)]}'
{"id":"openstack%2Fcookbook-openstack-common~697862","triplet_id":"openstack%2Fcookbook-openstack-common~master~Icb9147036a01f92ec48a24c692dd022258e294c0","project":"openstack/cookbook-openstack-common","branch":"master","topic":"faster-chefspec","hashtags":[],"change_id":"Icb9147036a01f92ec48a24c692dd022258e294c0","subject":"Improve ChefSpec test speed by enabling caching","status":"MERGED","created":"2019-12-08 00:44:38.000000000","updated":"2020-01-07 10:03:11.000000000","submitted":"2020-01-07 10:03:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697862-1578391391886-0e1c537b","meta_rev_id":"916dbdb8d3037ef53cacbfb1a8bc1e9ac667b2e0","_number":697862,"virtual_id_number":697862,"owner":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-07 10:03:11.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2020-01-07 09:09:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":1,"date":"2020-01-07 09:09:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-07 09:09:44.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2020-01-07 10:03:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bc76c537b6a3ede83b6bfaad8b0c8d07b53a5e9c","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2019-12-08 00:44:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a2dd7b6086da2589669e77406d774c4fde21614c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-08 01:33:13.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/7ef508657ecc424aa17c81ae9b3a2417 : FAILURE in 2m 37s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/2a1405316ad8414ab604035584571cf9 : SUCCESS in 43m 39s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/728c2f6853d74a73a9cc0cd1ced6ae74 : SUCCESS in 48m 06s","accounts_in_message":[],"_revision_number":1},{"id":"6f7867e17dea430190ec29cd66d680c8b027f5d2","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2019-12-08 05:21:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f7d59299eae764ac66688366d0b6d52c75076226","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-08 06:09:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/2bcc2c7246a7432c9c3c927aabf0eef9 : SUCCESS in 3m 19s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/f66d8f9a91f049709b9434c130759ac2 : SUCCESS in 43m 18s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/07b84433d8f046fca5983d912889086d : SUCCESS in 46m 40s","accounts_in_message":[],"_revision_number":2},{"id":"a1af097642d716262742a0b17041248d1873b6cb","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-01-06 11:01:01.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3f357489b5d79cd99121fe5565bf8fcb809dfcc4","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-01-06 19:11:53.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"28e5bb955aa59f540ed8de18663154adbdb9d905","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-01-06 19:35:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"52b9a5114709b5d827a46288e725533d87bbbff0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-06 20:30:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/03292004a24a4c6fa67a6f9f62e5c947 : SUCCESS in 4m 58s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/7e35824463064e71873267dd91599d84 : SUCCESS in 47m 57s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/0faff246adb649f08ac76086c4d87ed3 : SUCCESS in 52m 17s","accounts_in_message":[],"_revision_number":3},{"id":"1f81fa3e84fa387ad49d6072fe871bbdaf551576","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-01-07 09:09:44.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"2e1301dfa430db517b48fc6447c0a2d7bd892e2a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-07 09:09:55.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"ad23bcd09434e0d292b90bae514410de5a8958fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-07 10:03:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"ce8efe4b518183b6028b052d657048a39e2247d1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-07 10:03:11.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/494d56bfbd6e45f2a8a477d49035c4b6 : SUCCESS in 3m 50s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/eba2e8e432984e908acc1313fa276526 : SUCCESS in 38m 03s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/720c7924a0a74ec0bbaba1c7db0b1b37 : SUCCESS in 46m 19s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4000e8aa96b0fdae553a0eb5b5e9e4a6d51d8dbe","revisions":{"3bb95800cb8fa93ccb28d8f9bc468966b9543e35":{"kind":"REWORK","_number":1,"created":"2019-12-08 00:44:38.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/62/697862/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-common","ref":"refs/changes/62/697862/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/1"}}},"commit":{"parents":[{"commit":"d5e2d175cd08ceb2985d8311887f7901847d9bd8","subject":"Fix README.rst formatting","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/d5e2d175cd08ceb2985d8311887f7901847d9bd8"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-08 00:29:45.000000000","tz":-480},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-08 00:43:20.000000000","tz":-480},"subject":"Improve ChefSpec test speed by enabling caching","message":"Improve ChefSpec test speed by enabling caching\n\nThis updates all references of let(:chef_run) to cached(:chef_run) to speed up\ntests. By doing this, we have to create a new cached(:chef_run) block whenever\nwe need to adjust node attributes for testing.\n\nSome additional fixes include:\n- Add default[\u0027openstack\u0027][\u0027common\u0027][\u0027search_sleep\u0027] attribute to allow speed\n  ups during testing.\n- Improved a few tests\n- Adjusted some formatting\n- Remove deprecated ChefSpec::Coverage.start function\n- Show warnings\n- Use major version for redhat platform\n\nSpeed was improved from 4 minutes 16 seconds to 35.45 seconds.\n\nChange-Id: Icb9147036a01f92ec48a24c692dd022258e294c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/3bb95800cb8fa93ccb28d8f9bc468966b9543e35"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/3bb95800cb8fa93ccb28d8f9bc468966b9543e35"}]},"branch":"refs/heads/master"},"7d6a2ec578f88da561f2369d557ab993cac8b1c9":{"kind":"REWORK","_number":2,"created":"2019-12-08 05:21:43.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/62/697862/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-common","ref":"refs/changes/62/697862/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/2"}}},"commit":{"parents":[{"commit":"d5e2d175cd08ceb2985d8311887f7901847d9bd8","subject":"Fix README.rst formatting","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/d5e2d175cd08ceb2985d8311887f7901847d9bd8"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-08 00:29:45.000000000","tz":-480},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-08 05:21:37.000000000","tz":-480},"subject":"Improve ChefSpec test speed by enabling caching","message":"Improve ChefSpec test speed by enabling caching\n\nThis updates all references of let(:chef_run) to cached(:chef_run) to speed up\ntests. By doing this, we have to create a new cached(:chef_run) block whenever\nwe need to adjust node attributes for testing.\n\nSome additional fixes include:\n- Add default[\u0027openstack\u0027][\u0027common\u0027][\u0027search_sleep\u0027] attribute to allow speed\n  ups during testing.\n- Improved a few tests\n- Adjusted some formatting\n- Remove deprecated ChefSpec::Coverage.start function\n- Show warnings\n- Use major version for redhat platform\n\nSpeed was improved from 4 minutes 16 seconds to 35.45 seconds.\n\nChange-Id: Icb9147036a01f92ec48a24c692dd022258e294c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/7d6a2ec578f88da561f2369d557ab993cac8b1c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/7d6a2ec578f88da561f2369d557ab993cac8b1c9"}]},"branch":"refs/heads/master"},"4000e8aa96b0fdae553a0eb5b5e9e4a6d51d8dbe":{"kind":"REWORK","_number":3,"created":"2020-01-06 19:35:20.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/62/697862/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-common","ref":"refs/changes/62/697862/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-common refs/changes/62/697862/3"}}},"commit":{"parents":[{"commit":"d5e2d175cd08ceb2985d8311887f7901847d9bd8","subject":"Fix README.rst formatting","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/d5e2d175cd08ceb2985d8311887f7901847d9bd8"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-12-08 00:29:45.000000000","tz":-480},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2020-01-06 19:34:18.000000000","tz":-480},"subject":"Improve ChefSpec test speed by enabling caching","message":"Improve ChefSpec test speed by enabling caching\n\nThis updates all references of let(:chef_run) to cached(:chef_run) to speed up\ntests. By doing this, we have to create a new cached(:chef_run) block whenever\nwe need to adjust node attributes for testing.\n\nSome additional fixes include:\n- Add default[\u0027openstack\u0027][\u0027common\u0027][\u0027search_count_max\u0027] attribute to allow speed\n  ups during testing.\n- Improved a few tests\n- Adjusted some formatting\n- Remove deprecated ChefSpec::Coverage.start function\n- Show warnings\n- Use major version for redhat platform\n- Update to Ubuntu 18.04\n\nSpeed was improved from 4 minutes 16 seconds to 41.98 seconds.\n\nChange-Id: Icb9147036a01f92ec48a24c692dd022258e294c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/4000e8aa96b0fdae553a0eb5b5e9e4a6d51d8dbe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-common/commit/4000e8aa96b0fdae553a0eb5b5e9e4a6d51d8dbe"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}