)]}'
{"libraries/cli.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1359fc93946a48b0fa4c533fa6677c4fa5c88068","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  # @return [Hash] environment"},{"line_number":33,"context_line":"  def openstack_command_env(name, project, user_domain, project_domain)"},{"line_number":34,"context_line":"    identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":35,"context_line":"    auth_url \u003d ::URI.decode_www_form_component identity_endpoint.to_s"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    pass \u003d get_password \u0027user\u0027, name"},{"line_number":38,"context_line":"    {"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9f560f44_de613aab","line":35,"updated":"2020-08-26 09:38:25.000000000","message":"I\u0027m wondering what this is actually supposed to do. What would be the difference if we simple use\n\nauth_url \u003d identity_endpoint.to_s","commit_id":"aa64d7b68d898d246cd0acc0d3466f3c26eba57b"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"5bea2cbc260e69ea31146a0ae91a0bf4f5240016","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  # @return [Hash] environment"},{"line_number":33,"context_line":"  def openstack_command_env(name, project, user_domain, project_domain)"},{"line_number":34,"context_line":"    identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":35,"context_line":"    auth_url \u003d ::URI.decode_www_form_component identity_endpoint.to_s"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    pass \u003d get_password \u0027user\u0027, name"},{"line_number":38,"context_line":"    {"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9f560f44_25401ea5","line":35,"in_reply_to":"9f560f44_de613aab","updated":"2020-08-26 15:58:26.000000000","message":"That\u0027s an excellent question. Looking through the git history this seems to be included in the some of the early code so perhaps this isn\u0027t needed anymore. I\u0027ll give it a try and see what happens.","commit_id":"aa64d7b68d898d246cd0acc0d3466f3c26eba57b"}],"libraries/uri.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1359fc93946a48b0fa4c533fa6677c4fa5c88068","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  # keys are used directly from the hash."},{"line_number":31,"context_line":"  def uri_from_hash(hash)"},{"line_number":32,"context_line":"    if hash[\u0027uri\u0027]"},{"line_number":33,"context_line":"      ::URI.parse Addressable::URI.encode(hash[\u0027uri\u0027])"},{"line_number":34,"context_line":"    else"},{"line_number":35,"context_line":"      host \u003d hash[\u0027host\u0027]"},{"line_number":36,"context_line":"      scheme \u003d hash[\u0027scheme\u0027] ? hash[\u0027scheme\u0027] : \u0027http\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9f560f44_1e829200","line":33,"updated":"2020-08-26 09:38:25.000000000","message":"Again I wonder why we need this. Can\u0027t we just require hash[\u0027uri\u0027] to be an encoded URI already?","commit_id":"aa64d7b68d898d246cd0acc0d3466f3c26eba57b"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"93a0502c3f1c2f14febb96631ac87e716fe5f633","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  # keys are used directly from the hash."},{"line_number":31,"context_line":"  def uri_from_hash(hash)"},{"line_number":32,"context_line":"    if hash[\u0027uri\u0027]"},{"line_number":33,"context_line":"      ::URI.parse Addressable::URI.encode(hash[\u0027uri\u0027])"},{"line_number":34,"context_line":"    else"},{"line_number":35,"context_line":"      host \u003d hash[\u0027host\u0027]"},{"line_number":36,"context_line":"      scheme \u003d hash[\u0027scheme\u0027] ? hash[\u0027scheme\u0027] : \u0027http\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9f560f44_fd47bf4b","line":33,"in_reply_to":"9f560f44_1e829200","updated":"2020-08-27 23:51:35.000000000","message":"This actually is required otherwise the spec test fails with the following:\n\nURI::InvalidURIError:\n  bad URI(is not URI?): \"http://localhost:8080/v2/%(tenant_id)s\"","commit_id":"aa64d7b68d898d246cd0acc0d3466f3c26eba57b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6387fd4bcf2dafd0af24c60187619bdef5561c96","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  # keys are used directly from the hash."},{"line_number":31,"context_line":"  def uri_from_hash(hash)"},{"line_number":32,"context_line":"    if hash[\u0027uri\u0027]"},{"line_number":33,"context_line":"      ::URI.parse Addressable::URI.encode(hash[\u0027uri\u0027])"},{"line_number":34,"context_line":"    else"},{"line_number":35,"context_line":"      host \u003d hash[\u0027host\u0027]"},{"line_number":36,"context_line":"      scheme \u003d hash[\u0027scheme\u0027] ? hash[\u0027scheme\u0027] : \u0027http\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9f560f44_0b1e6873","line":33,"in_reply_to":"9f560f44_fd47bf4b","updated":"2020-09-02 08:48:44.000000000","message":"Hmm, o.k., so that\u0027s fine for now, then.","commit_id":"aa64d7b68d898d246cd0acc0d3466f3c26eba57b"}]}