)]}'
{"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"e6ceed804880739540c137f3ac8a975c84768e64","unresolved":false,"context_lines":[{"line_number":112,"context_line":"# Certificate file to use when starting the server securely"},{"line_number":113,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] \u003d nil"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Private key file to use when starting the server securely"},{"line_number":116,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] \u003d nil"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Neutron options"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9aa7fdbe_879dff5b","line":115,"updated":"2014-10-22 09:59:28.000000000","message":"should be api server.","commit_id":"83463b1d96c440ed9d58002f888be7159e67c896"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"2c57adee81b5a5de8a21e498b31d973717a933dd","unresolved":false,"context_lines":[{"line_number":112,"context_line":"# Certificate file to use when starting the server securely"},{"line_number":113,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] \u003d nil"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Private key file to use when starting the server securely"},{"line_number":116,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] \u003d nil"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Neutron options"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9aa7fdbe_e777ab00","line":115,"in_reply_to":"9aa7fdbe_879dff5b","updated":"2014-10-22 10:04:06.000000000","message":"this comment is just copied from the nova code\nhttps://github.com/openstack/nova/blob/master/nova/openstack/common/sslutils.py","commit_id":"83463b1d96c440ed9d58002f888be7159e67c896"}],"spec/nova-common_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"73d9295d3188d8f4564b459b5182e5f786117212","unresolved":false,"context_lines":[{"line_number":245,"context_line":"          /^memcache_secret_key \u003d/)"},{"line_number":246,"context_line":"        expect(chef_run).not_to render_file(file.name).with_content("},{"line_number":247,"context_line":"          /^cafile \u003d/)"},{"line_number":248,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^ca_file\u003d/)"},{"line_number":249,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^cert_file\u003d/)"},{"line_number":250,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^key_file\u003d/)"},{"line_number":251,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^cinder_ca_certificates_file\u003d/)"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aa7fdbe_21ced5b4","line":248,"updated":"2014-10-23 15:06:37.000000000","message":"Since there is no if check in template for these, when default is nil or not, this will always be true.   Need to add the $ at end to make sure empty.   for next 2 as well.","commit_id":"3b11f03c10007e6a71ae7e8e1742e9e82111fe5d"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"aa396ea2865a859a620b9343bea65dac1bff1dbe","unresolved":false,"context_lines":[{"line_number":245,"context_line":"          /^memcache_secret_key \u003d/)"},{"line_number":246,"context_line":"        expect(chef_run).not_to render_file(file.name).with_content("},{"line_number":247,"context_line":"          /^cafile \u003d/)"},{"line_number":248,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^ca_file\u003d/)"},{"line_number":249,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^cert_file\u003d/)"},{"line_number":250,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^key_file\u003d/)"},{"line_number":251,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^cinder_ca_certificates_file\u003d/)"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aa7fdbe_0159d18d","line":248,"in_reply_to":"9aa7fdbe_21ced5b4","updated":"2014-10-23 15:17:00.000000000","message":"Done","commit_id":"3b11f03c10007e6a71ae7e8e1742e9e82111fe5d"}],"templates/default/nova.conf.erb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"e6ceed804880739540c137f3ac8a975c84768e64","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"# CA certificate file to use to verify connecting clients"},{"line_number":347,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] -%\u003e"},{"line_number":348,"context_line":"ca_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] %\u003e"},{"line_number":349,"context_line":"\u003c% else -%\u003e"},{"line_number":350,"context_line":"# ca_file \u003d"},{"line_number":351,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":3,"id":"9aa7fdbe_67273b65","line":348,"updated":"2014-10-22 09:59:28.000000000","message":"if base on this logic , only change to ca_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] %\u003e , no need to use the if check.\n\nsame as the others.","commit_id":"83463b1d96c440ed9d58002f888be7159e67c896"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"2c57adee81b5a5de8a21e498b31d973717a933dd","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"# CA certificate file to use to verify connecting clients"},{"line_number":347,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] -%\u003e"},{"line_number":348,"context_line":"ca_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] %\u003e"},{"line_number":349,"context_line":"\u003c% else -%\u003e"},{"line_number":350,"context_line":"# ca_file \u003d"},{"line_number":351,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":3,"id":"9aa7fdbe_a73f6324","line":348,"in_reply_to":"9aa7fdbe_67273b65","updated":"2014-10-22 10:04:06.000000000","message":"i dont want a line like \"ca_file \u003d \" in the file, the \"if\" here avoids that case","commit_id":"83463b1d96c440ed9d58002f888be7159e67c896"}]}