)]}'
{"attributes/default.rb":[{"author":{"_account_id":9978,"name":"Pierre Rambaud","email":"pierre.rambaud@numergy.com","username":"GoT"},"change_message_id":"57de728e28c707f4f2d219e4c0d82a9540dd3c2d","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    \u0027common_packages\u0027 \u003d\u003e [\u0027nova-common\u0027],"},{"line_number":496,"context_line":"    \u0027iscsi_helper\u0027 \u003d\u003e \u0027tgtadm\u0027,"},{"line_number":497,"context_line":"    \u0027nfs_packages\u0027 \u003d\u003e [\u0027nfs-common\u0027],"},{"line_number":498,"context_line":"    \u0027docker_packages\u0027 \u003d\u003e [\u0027docker.io\u0027],"},{"line_number":499,"context_line":"    \u0027package_overrides\u0027 \u003d\u003e \"-o Dpkg::Options::\u003d\u0027--force-confold\u0027 -o Dpkg::Options::\u003d\u0027--force-confdef\u0027\""},{"line_number":500,"context_line":"  }"},{"line_number":501,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a890539_dab486d3","line":498,"updated":"2014-11-19 09:19:45.000000000","message":"Not sure it\u0027s a good idea to use docker.io package it use version is 1.0.1 in ubuntu 14.04. Use docker cookbook instead, it use docker 1.3+.","commit_id":"e407b6ec3f89d9239a431733095ce7354a22e979"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"7a64ce90f62a1496bf42d6d8529b21ead8cf35e3","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    \u0027common_packages\u0027 \u003d\u003e [\u0027nova-common\u0027],"},{"line_number":496,"context_line":"    \u0027iscsi_helper\u0027 \u003d\u003e \u0027tgtadm\u0027,"},{"line_number":497,"context_line":"    \u0027nfs_packages\u0027 \u003d\u003e [\u0027nfs-common\u0027],"},{"line_number":498,"context_line":"    \u0027docker_packages\u0027 \u003d\u003e [\u0027docker.io\u0027],"},{"line_number":499,"context_line":"    \u0027package_overrides\u0027 \u003d\u003e \"-o Dpkg::Options::\u003d\u0027--force-confold\u0027 -o Dpkg::Options::\u003d\u0027--force-confdef\u0027\""},{"line_number":500,"context_line":"  }"},{"line_number":501,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a890539_dad0d9f9","line":498,"in_reply_to":"5a890539_2901b439","updated":"2014-11-20 10:52:43.000000000","message":"Thanks for your comments, I will add a todo to the nova-docker recipe that using docker cookbook to install docker.","commit_id":"e407b6ec3f89d9239a431733095ce7354a22e979"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"b42e8bad8161912b5a6a9555a9be5e4acaae1d49","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    \u0027common_packages\u0027 \u003d\u003e [\u0027nova-common\u0027],"},{"line_number":496,"context_line":"    \u0027iscsi_helper\u0027 \u003d\u003e \u0027tgtadm\u0027,"},{"line_number":497,"context_line":"    \u0027nfs_packages\u0027 \u003d\u003e [\u0027nfs-common\u0027],"},{"line_number":498,"context_line":"    \u0027docker_packages\u0027 \u003d\u003e [\u0027docker.io\u0027],"},{"line_number":499,"context_line":"    \u0027package_overrides\u0027 \u003d\u003e \"-o Dpkg::Options::\u003d\u0027--force-confold\u0027 -o Dpkg::Options::\u003d\u0027--force-confdef\u0027\""},{"line_number":500,"context_line":"  }"},{"line_number":501,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a890539_2901b439","line":498,"in_reply_to":"5a890539_9d3bd89b","updated":"2014-11-19 17:48:56.000000000","message":"I would agree, using the docker cookbook is the way to go here.","commit_id":"e407b6ec3f89d9239a431733095ce7354a22e979"},{"author":{"_account_id":9978,"name":"Pierre Rambaud","email":"pierre.rambaud@numergy.com","username":"GoT"},"change_message_id":"085491ee29c93c2c0659bdd5748727f351715044","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    \u0027common_packages\u0027 \u003d\u003e [\u0027nova-common\u0027],"},{"line_number":496,"context_line":"    \u0027iscsi_helper\u0027 \u003d\u003e \u0027tgtadm\u0027,"},{"line_number":497,"context_line":"    \u0027nfs_packages\u0027 \u003d\u003e [\u0027nfs-common\u0027],"},{"line_number":498,"context_line":"    \u0027docker_packages\u0027 \u003d\u003e [\u0027docker.io\u0027],"},{"line_number":499,"context_line":"    \u0027package_overrides\u0027 \u003d\u003e \"-o Dpkg::Options::\u003d\u0027--force-confold\u0027 -o Dpkg::Options::\u003d\u0027--force-confdef\u0027\""},{"line_number":500,"context_line":"  }"},{"line_number":501,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a890539_9d3bd89b","line":498,"in_reply_to":"5a890539_bd7b347a","updated":"2014-11-19 09:41:15.000000000","message":"Right but it can be better if whatever the operating system the same version of the package is installed. So when test kitchen will be implemented there will be no surprises.","commit_id":"e407b6ec3f89d9239a431733095ce7354a22e979"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"04f65d4e80af394c062bb82a3e0ff3a0499f3315","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    \u0027common_packages\u0027 \u003d\u003e [\u0027nova-common\u0027],"},{"line_number":496,"context_line":"    \u0027iscsi_helper\u0027 \u003d\u003e \u0027tgtadm\u0027,"},{"line_number":497,"context_line":"    \u0027nfs_packages\u0027 \u003d\u003e [\u0027nfs-common\u0027],"},{"line_number":498,"context_line":"    \u0027docker_packages\u0027 \u003d\u003e [\u0027docker.io\u0027],"},{"line_number":499,"context_line":"    \u0027package_overrides\u0027 \u003d\u003e \"-o Dpkg::Options::\u003d\u0027--force-confold\u0027 -o Dpkg::Options::\u003d\u0027--force-confdef\u0027\""},{"line_number":500,"context_line":"  }"},{"line_number":501,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a890539_bd7b347a","line":498,"in_reply_to":"5a890539_dab486d3","updated":"2014-11-19 09:37:53.000000000","message":"Thanks for your comments. In this case we only need to install docker package, so I don\u0027t think we need the docker cookbook to install it. And it\u0027s the Ubuntu community issue.","commit_id":"e407b6ec3f89d9239a431733095ce7354a22e979"}],"recipes/nova-docker.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"029af1f4da03321b7644c6822375500955796a9d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"platform_options \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027platform\u0027]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# TODO(zhiwei): Install docker package using docker cookbook"},{"line_number":22,"context_line":"platform_options[\u0027docker_packages\u0027].each do |pkg|"},{"line_number":23,"context_line":"  package pkg do"},{"line_number":24,"context_line":"    options platform_options[\u0027package_overrides\u0027]"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5a890539_b66c009f","line":21,"updated":"2014-11-20 15:10:56.000000000","message":"Humm, I guess Im still in favor of just using the docker cookbook now instead of duplicating this effort here.   \nJust a simple   include_recipe docker::package  \nshould do the trick.","commit_id":"0163baa7c315a575d144161370e873c08eab9562"}],"spec/nova-common_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"b42e8bad8161912b5a6a9555a9be5e4acaae1d49","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      end"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"      context \u0027docker\u0027 do"},{"line_number":221,"context_line":"        # TODO(zhiwei): Need to find a way to check the same option"},{"line_number":222,"context_line":"        # with different value in different section, like below:"},{"line_number":223,"context_line":"        #"},{"line_number":224,"context_line":"        # [DEFAULT]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a890539_a9492490","line":221,"updated":"2014-11-19 17:48:56.000000000","message":"Checkout the work done in the common cookbook for sections like this. https://github.com/stackforge/cookbook-openstack-common/blob/master/spec/logging_spec.rb\n\nDepending upon how the template is done, something like that might work.  This is a hole in chef spec, instead of using .with_content(), we should add a .with_section_content(\u0027section\u0027, \u0027content\u0027)  .   should be easy addition to the chefspec, but I have not had time to look into it.","commit_id":"e407b6ec3f89d9239a431733095ce7354a22e979"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"7a64ce90f62a1496bf42d6d8529b21ead8cf35e3","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      end"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"      context \u0027docker\u0027 do"},{"line_number":221,"context_line":"        # TODO(zhiwei): Need to find a way to check the same option"},{"line_number":222,"context_line":"        # with different value in different section, like below:"},{"line_number":223,"context_line":"        #"},{"line_number":224,"context_line":"        # [DEFAULT]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5a890539_3aed5db8","line":221,"in_reply_to":"5a890539_a9492490","updated":"2014-11-20 10:52:43.000000000","message":"Thanks Mark, I updated this TODO message, and also upload a patch to chefspec project to add a with_section_content method to render_file. https://github.com/sethvargo/chefspec/pull/529","commit_id":"e407b6ec3f89d9239a431733095ce7354a22e979"}],"spec/support/matcher.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"b62f8b80a65b3d62afe2fd1beb45a4c5381a80d4","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    unless @actual_content.nil?"},{"line_number":38,"context_line":"      unless @section.nil?"},{"line_number":39,"context_line":"        @actual_content \u003d @actual_content[/^\\[#{@section}\\]\\n([^\\[]*)/ms, 1]"},{"line_number":40,"context_line":"      end"},{"line_number":41,"context_line":"    end"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5a890539_a5bd77d9","line":39,"updated":"2014-11-21 15:49:12.000000000","message":"Trying to understand your regex here.  Maybe ouy can explain it a bit better.\n\nWould it handle the case of:\n\n[section]\n\u003cblank line(s)\u003e\nkey \u003d value\noption1 \u003d value1 # what your trying to look for in this section.\n\n\nAnd with that hardcoded \\n in there, this will only work on linux boxes, no windows. \nI added this to after your line 37 to allow your regex to do something for me.  @actual_content \u003d @actual_content.gsub(/\\r/,\u0027\u0027)     \n\nAnd maybe we consider putting this matcher in Common as once it gets flushed out, would be useful in many of the other cookbooks.","commit_id":"fcff0e0b75330346ab1a027d59ce281d8fef3e09"}]}