)]}'
{"spec/network_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a2c5db2da659755394ffa2e235a0d4ab0d4eef71","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      it \u0027includes neutron section defaults\u0027 do"},{"line_number":42,"context_line":"        ["},{"line_number":43,"context_line":"          /^\\[neutron\\]$/,"},{"line_number":44,"context_line":"          %r{^url\u003dhttp://127.0.0.1:9696$},"},{"line_number":45,"context_line":"          /^network_api_class\u003dnova.network.neutronv2.api.API$/,"},{"line_number":46,"context_line":"          /^auth_strategy\u003dkeystone$/,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a961159_d2bc8409","line":43,"updated":"2014-12-15 17:33:26.000000000","message":"Since this does not really test this correctly, I would like to see this refactor to use the new support in https://review.openstack.org/#/c/140215/\n\nand that means helping push that review along...hint hint","commit_id":"c54f7ba0735616357f359865a4da77b228a7fe23"}],"spec/nova-common_spec.rb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"bf5f5e1e9b0dbdd96056da57e4cbc2202ff757f7","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^cert_file\u003d$/)"},{"line_number":250,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^key_file\u003d$/)"},{"line_number":251,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^cinder_ca_certificates_file\u003d$/)"},{"line_number":252,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^cinder_api_insecure\u003dfalse/)"},{"line_number":253,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^cinder_catalog_info\u003dvolumev2:cinderv2:publicURL$/)"},{"line_number":254,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^hash_algorithms \u003d md5$/)"},{"line_number":255,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^insecure \u003d false$/)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a961159_22e9c180","line":252,"updated":"2014-12-09 08:21:03.000000000","message":"Better to use a loop condition.","commit_id":"b857a4da22dca9baa0d7f4d5e1f08b4dd7598bab"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"bf5f5e1e9b0dbdd96056da57e4cbc2202ff757f7","unresolved":false,"context_lines":[{"line_number":261,"context_line":"      it \u0027sets service_type to neutron\u0027 do"},{"line_number":262,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027service_type\u0027] \u003d \u0027neutron\u0027"},{"line_number":263,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^\\[neutron\\]$/)"},{"line_number":264,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^api_insecure\u003dfalse$/)"},{"line_number":265,"context_line":"        expect(chef_run).to render_file(file.name).with_content(%r{^url\u003dhttp://127.0.0.1:9696$})"},{"line_number":266,"context_line":"      end"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a961159_42d7adc1","line":264,"updated":"2014-12-09 08:21:03.000000000","message":"what if set api_insecure to true under glance and set api_insecure to false under neutron? I had submitted a patch to test ini file section content, so I think you can set this patch WIP, and uses the new custom matcher for this case. https://review.openstack.org/#/c/140215/","commit_id":"b857a4da22dca9baa0d7f4d5e1f08b4dd7598bab"},{"author":{"_account_id":9492,"name":"Yi Ming Yin","email":"yinym@cn.ibm.com","username":"yym"},"change_message_id":"675bdaf738de8def8bcdd556d7ceb8b6a7cc921c","unresolved":false,"context_lines":[{"line_number":261,"context_line":"      it \u0027sets service_type to neutron\u0027 do"},{"line_number":262,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027service_type\u0027] \u003d \u0027neutron\u0027"},{"line_number":263,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^\\[neutron\\]$/)"},{"line_number":264,"context_line":"        expect(chef_run).to render_file(file.name).with_content(/^api_insecure\u003dfalse$/)"},{"line_number":265,"context_line":"        expect(chef_run).to render_file(file.name).with_content(%r{^url\u003dhttp://127.0.0.1:9696$})"},{"line_number":266,"context_line":"      end"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a961159_fda67ac0","line":264,"in_reply_to":"3a961159_42d7adc1","updated":"2014-12-09 08:49:33.000000000","message":"I had the same concern on the current render_file().with_content(). This is based on single line, but we cannot check options with the same name under different sections. It is nice to have such function proposed by you.\n\nThe side effect of the old way here is such spec cannot detect \"errors\" sometimes.\n\nFor example, if we expect api_insecure for neutron to be \"true\", but the template set it to \"false\". The spec will still pass if api_insecure for cinder has been set to \"true\". But we are fine here when everything is correct. The case you mentioned above can still be matched, because the matcher will finally find a line with api_insecure\u003dtrue.","commit_id":"b857a4da22dca9baa0d7f4d5e1f08b4dd7598bab"}]}