)]}'
{"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"08af0d93e65c095845cc6a53ed1de32d5be49622","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"# To disable the EC2 API endpoint, simply remove \u0027ec2,\u0027 from the list"},{"line_number":513,"context_line":"# of enabled API services."},{"line_number":514,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027enabled_apis\u0027] \u003d \u0027ec2,osapi_compute\u0027"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"# Metadata host and port"},{"line_number":517,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027metadata_listen\u0027] \u003d \u00270.0.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a961159_798d5e2a","line":514,"updated":"2014-12-27 16:47:15.000000000","message":"Humm, are you just changing the default or removing the metadata from the allowed values?\n\nIf removing, then compute recipe needs to change or be cleaned up: \nif node[\u0027openstack\u0027][\u0027compute\u0027][\u0027enabled_apis\u0027].include?(\u0027metadata\u0027)\n\nAnd if we still support the metadata value, are there other changes that need to happen to avoid the timing conflict?","commit_id":"f538737a8c6d80ea5fafc12076abc4892ebe8d49"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"08af0d93e65c095845cc6a53ed1de32d5be49622","unresolved":false,"context_lines":[{"line_number":512,"context_line":"# To disable the EC2 API endpoint, simply remove \u0027ec2,\u0027 from the list"},{"line_number":513,"context_line":"# of enabled API services."},{"line_number":514,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027enabled_apis\u0027] \u003d \u0027ec2,osapi_compute\u0027"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"# Metadata host and port"},{"line_number":517,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027metadata_listen\u0027] \u003d \u00270.0.0.0\u0027"},{"line_number":518,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027metadata_listen_port\u0027] \u003d 8775"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a961159_99920a4a","line":515,"updated":"2014-12-27 16:47:15.000000000","message":"And should update the comments here about what values are valid and where to now look to enable the metadata api? I assume that means adding that recipe to the run list?  or do we need a new metadata api role?","commit_id":"f538737a8c6d80ea5fafc12076abc4892ebe8d49"}],"spec/compute_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"08af0d93e65c095845cc6a53ed1de32d5be49622","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    include_examples \u0027expect_creates_nova_instances_dir\u0027"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    it \u0027includes api-metadata recipe\u0027 do"},{"line_number":18,"context_line":"      expect(chef_run).to include_recipe \u0027openstack-compute::api-metadata\u0027"},{"line_number":19,"context_line":"    end"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    it \u0027does not include api-metadata recipe\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a961159_f9922e57","side":"PARENT","line":18,"updated":"2014-12-27 16:47:15.000000000","message":"Why not just switch this to the negitive,   not include recipe metadata...","commit_id":"b4d15bf70167dcc311bc71b5b7b3fd8e81351180"}],"spec/nova-common_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"08af0d93e65c095845cc6a53ed1de32d5be49622","unresolved":false,"context_lines":[{"line_number":187,"context_line":"      end"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"      it \u0027has default metadata ip and port options set\u0027 do"},{"line_number":190,"context_line":"        [/^metadata_listen\u003d0.0.0.0$/,"},{"line_number":191,"context_line":"         /^metadata_listen_port\u003d8775$/].each do |line|"},{"line_number":192,"context_line":"          expect(chef_run).to render_file(file.name).with_content(line)"},{"line_number":193,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a961159_399d9667","side":"PARENT","line":190,"updated":"2014-12-27 16:47:15.000000000","message":"Please explain where this values are now defined and tested?\nthe attributes are still available, so move to api-metadata-spec?","commit_id":"b4d15bf70167dcc311bc71b5b7b3fd8e81351180"}]}