)]}'
{".kitchen.yml":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9352086bc1572bb04700bde8088e92b64badc6a6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: vagrant"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a961159_ff838bc8","line":1,"updated":"2015-01-14 14:25:20.000000000","message":"Maybe some comments in here or in the TESTING.rb to explain what  this is trying to do and how to basically use it?","commit_id":"a038f43456fef5bfc03a4f980e56f9eecc44a9d7"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"9cf8092126fbe7594f25ad9a276f172b9c4f41e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: vagrant"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a961159_f8270cc5","line":1,"in_reply_to":"3a961159_ff838bc8","updated":"2015-01-15 02:12:32.000000000","message":"This file was added prematurely.  I will remove it","commit_id":"a038f43456fef5bfc03a4f980e56f9eecc44a9d7"}],"Berksfile":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"04dd4c25f157c114820d3f7b1ed34935da8d72aa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cookbook \"openstack-network\","},{"line_number":12,"context_line":"  github: \"stackforge/cookbook-openstack-network\""},{"line_number":13,"context_line":"cookbook \"ceph\","},{"line_number":14,"context_line":"  github: \"ceph/ceph-cookbook\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a961159_69835003","line":14,"updated":"2015-01-15 03:50:34.000000000","message":"stackforge/cookbook-ceph or ceph/ceph-cookbook,  which is right ?","commit_id":"9f751a618b7bf3f0fb7730fc1fdadde6adcb5736"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"9579e1404608bf597545e898d37f94d49c7386c9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cookbook \"openstack-network\","},{"line_number":12,"context_line":"  github: \"stackforge/cookbook-openstack-network\""},{"line_number":13,"context_line":"cookbook \"ceph\","},{"line_number":14,"context_line":"  github: \"ceph/ceph-cookbook\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a961159_a06e26c6","line":14,"in_reply_to":"3a961159_69835003","updated":"2015-01-15 06:53:11.000000000","message":"Zhiwei is correct.  The stackforge Ceph module is deprecated.","commit_id":"9f751a618b7bf3f0fb7730fc1fdadde6adcb5736"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"c3ac1388d57174ab0bcb25c797a6b753d862950f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cookbook \"openstack-network\","},{"line_number":12,"context_line":"  github: \"stackforge/cookbook-openstack-network\""},{"line_number":13,"context_line":"cookbook \"ceph\","},{"line_number":14,"context_line":"  github: \"ceph/ceph-cookbook\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a961159_09bc8c6b","line":14,"in_reply_to":"3a961159_69835003","updated":"2015-01-15 04:17:25.000000000","message":"stackforge ceph cookbook was deprecated: https://review.openstack.org/#/c/142837/","commit_id":"9f751a618b7bf3f0fb7730fc1fdadde6adcb5736"}],"Gemfile":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9352086bc1572bb04700bde8088e92b64badc6a6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"gem \u0027foodcritic\u0027, \u0027~\u003e 3.0.3\u0027"},{"line_number":10,"context_line":"gem \u0027rubocop\u0027, \u0027~\u003e 0.18.1\u0027"},{"line_number":11,"context_line":"gem \u0027fauxhai\u0027, \u0027\u003e\u003d 2.1.0\u0027"},{"line_number":12,"context_line":"gem \u0027test-kitchen\u0027"},{"line_number":13,"context_line":"gem \u0027kitchen-vagrant\u0027"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a961159_7f46bba8","line":12,"updated":"2015-01-14 14:25:20.000000000","message":"Probably good to have basic version constraints here.\n\n\u0027~\u003e x.x\u0027","commit_id":"a038f43456fef5bfc03a4f980e56f9eecc44a9d7"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"9cf8092126fbe7594f25ad9a276f172b9c4f41e5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"gem \u0027foodcritic\u0027, \u0027~\u003e 3.0.3\u0027"},{"line_number":10,"context_line":"gem \u0027rubocop\u0027, \u0027~\u003e 0.18.1\u0027"},{"line_number":11,"context_line":"gem \u0027fauxhai\u0027, \u0027\u003e\u003d 2.1.0\u0027"},{"line_number":12,"context_line":"gem \u0027test-kitchen\u0027"},{"line_number":13,"context_line":"gem \u0027kitchen-vagrant\u0027"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a961159_78131c65","line":12,"in_reply_to":"3a961159_7f46bba8","updated":"2015-01-15 02:12:32.000000000","message":"This was added prematurely.  I will remove it.","commit_id":"a038f43456fef5bfc03a4f980e56f9eecc44a9d7"}],"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9352086bc1572bb04700bde8088e92b64badc6a6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  supports os"},{"line_number":26,"context_line":"end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"depends \u0027ceph\u0027"},{"line_number":29,"context_line":"depends \u0027openstack-common\u0027, \u0027~\u003e 10.2\u0027"},{"line_number":30,"context_line":"depends \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":31,"context_line":"depends \u0027openstack-image\u0027, \u0027~\u003e 10.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a961159_bff2e36c","line":28,"updated":"2015-01-14 14:25:20.000000000","message":"would be good to have basic version constraint like selinix below.","commit_id":"a038f43456fef5bfc03a4f980e56f9eecc44a9d7"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"9cf8092126fbe7594f25ad9a276f172b9c4f41e5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  supports os"},{"line_number":26,"context_line":"end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"depends \u0027ceph\u0027"},{"line_number":29,"context_line":"depends \u0027openstack-common\u0027, \u0027~\u003e 10.2\u0027"},{"line_number":30,"context_line":"depends \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":31,"context_line":"depends \u0027openstack-image\u0027, \u0027~\u003e 10.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a961159_583740fe","line":28,"in_reply_to":"3a961159_bff2e36c","updated":"2015-01-15 02:12:32.000000000","message":"Done","commit_id":"a038f43456fef5bfc03a4f980e56f9eecc44a9d7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5dc4c50b78ce82fa01df738e63ed82848c0cae94","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  supports os"},{"line_number":26,"context_line":"end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"depends \u0027ceph\u0027, \u0027~\u003e 0.2.1\u0027"},{"line_number":29,"context_line":"depends \u0027openstack-common\u0027, \u0027~\u003e 10.2\u0027"},{"line_number":30,"context_line":"depends \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":31,"context_line":"depends \u0027openstack-image\u0027, \u0027~\u003e 10.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a961159_f43c6cc1","line":28,"updated":"2015-01-15 09:18:48.000000000","message":"Fuzzy matching an exact version number looks strange to me. IMO either use \u00270.2.1\u0027 to pin the exact version or \u0027~\u003e 0.2\u0027. Given that the version is pretty low, one can expect incompatible changes, so indeed doing the exact match might be the better solution.","commit_id":"c095eca670364ae6b38241eda2fb11130d58fba4"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"ba258597d37fa56508b5d5bf88c5c9ed5733654c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  supports os"},{"line_number":26,"context_line":"end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"depends \u0027ceph\u0027, \u0027~\u003e 0.2.1\u0027"},{"line_number":29,"context_line":"depends \u0027openstack-common\u0027, \u0027~\u003e 10.2\u0027"},{"line_number":30,"context_line":"depends \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":31,"context_line":"depends \u0027openstack-image\u0027, \u0027~\u003e 10.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a961159_711b236f","line":28,"in_reply_to":"3a961159_f43c6cc1","updated":"2015-01-15 13:27:52.000000000","message":"I left this as a fuzzy match per markvans comments earlier.  However, it does make for sense to have an exact version match.  Done","commit_id":"c095eca670364ae6b38241eda2fb11130d58fba4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d6b17aba58d6fd568ae00d8a9d51bfc49caab3d8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"recipe \u0027openstack-compute::api-os-compute\u0027, \u0027Installs OS API\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-compute::client\u0027, \u0027Install nova client packages\u0027"},{"line_number":13,"context_line":"recipe \u0027openstack-compute::compute\u0027, \u0027nova-compute service\u0027"},{"line_number":14,"context_line":"recipe \u0027openstack-compute::conductor\u0027, \u0027Installs nova conductor service\u0027"},{"line_number":15,"context_line":"recipe \u0027openstack-compute::libvirt\u0027, \u0027Installs libvirt, used by nova compute for management of the virtual machine environment\u0027"},{"line_number":16,"context_line":"recipe \u0027openstack-compute::identity_registration\u0027, \u0027Registers the API and EC2 endpoints with Keystone\u0027"},{"line_number":17,"context_line":"recipe \u0027openstack-compute::network\u0027, \u0027Installs nova network service\u0027"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"1a930d6b_7bb43dd1","line":14,"updated":"2015-01-22 18:34:44.000000000","message":"I notice that libvirt_rbd is not listed here, I think it should, right?\n\nIt\u0027s also not in any of the openstack-chef-repo roles, it should probably be in there as well?    \n\nOr how exactly is this specific recipe used?   Maybe example in readme is needed?","commit_id":"2fb0f58b5e3af3008a5b4813c774d062e296033a"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"756d94e0534d6bdcb7a2fa367264ce91f796b97e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"recipe \u0027openstack-compute::api-os-compute\u0027, \u0027Installs OS API\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-compute::client\u0027, \u0027Install nova client packages\u0027"},{"line_number":13,"context_line":"recipe \u0027openstack-compute::compute\u0027, \u0027nova-compute service\u0027"},{"line_number":14,"context_line":"recipe \u0027openstack-compute::conductor\u0027, \u0027Installs nova conductor service\u0027"},{"line_number":15,"context_line":"recipe \u0027openstack-compute::libvirt\u0027, \u0027Installs libvirt, used by nova compute for management of the virtual machine environment\u0027"},{"line_number":16,"context_line":"recipe \u0027openstack-compute::identity_registration\u0027, \u0027Registers the API and EC2 endpoints with Keystone\u0027"},{"line_number":17,"context_line":"recipe \u0027openstack-compute::network\u0027, \u0027Installs nova network service\u0027"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"da86d52c_35bae9de","line":14,"in_reply_to":"1a930d6b_7bb43dd1","updated":"2015-02-02 16:38:48.000000000","message":"the libvirt_rbd recipe is invoked from nova-common based on the volume backend attribute.\n\nhttps://github.com/stackforge/cookbook-openstack-compute/blob/c7ecebdb1fe2d3fc1ba022c5d99747c349cd70f1/recipes/libvirt.rb#L219","commit_id":"2fb0f58b5e3af3008a5b4813c774d062e296033a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a77f6a1c580bb28206e974b48a70e81a40ae85fa","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  supports os"},{"line_number":26,"context_line":"end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"depends \u0027ceph\u0027, \u0027\u003d 0.2.1\u0027"},{"line_number":29,"context_line":"depends \u0027openstack-common\u0027, \u0027~\u003e 10.2\u0027"},{"line_number":30,"context_line":"depends \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":31,"context_line":"depends \u0027openstack-image\u0027, \u0027~\u003e 10.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"1a930d6b_31f7a4d4","line":28,"updated":"2015-01-27 16:26:13.000000000","message":"I think we should switch to use the scheme we discussed at the meeting:\n\ndepends \u0027ceph\u0027, \u0027\u003d\u003e 0.2.1\u0027 \n\ndepends \u0027ceph\u0027, \u0027\u003c 3.0.0\u0027","commit_id":"2fb0f58b5e3af3008a5b4813c774d062e296033a"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"756d94e0534d6bdcb7a2fa367264ce91f796b97e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  supports os"},{"line_number":26,"context_line":"end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"depends \u0027ceph\u0027, \u0027\u003d 0.2.1\u0027"},{"line_number":29,"context_line":"depends \u0027openstack-common\u0027, \u0027~\u003e 10.2\u0027"},{"line_number":30,"context_line":"depends \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":31,"context_line":"depends \u0027openstack-image\u0027, \u0027~\u003e 10.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"da86d52c_756aa11b","line":28,"in_reply_to":"1a930d6b_31f7a4d4","updated":"2015-02-02 16:38:48.000000000","message":"So both of those depends should be required?","commit_id":"2fb0f58b5e3af3008a5b4813c774d062e296033a"}],"recipes/libvirt_rbd.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9352086bc1572bb04700bde8088e92b64badc6a6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"include_recipe \u0027ceph::_common\u0027"},{"line_number":26,"context_line":"include_recipe \u0027ceph::install\u0027"},{"line_number":27,"context_line":"include_recipe \u0027ceph::conf\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ceph_user \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027rbd\u0027][\u0027cinder\u0027][\u0027user\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a961159_bf990321","line":26,"updated":"2015-01-14 14:25:20.000000000","message":"Is install recipe really required here?  seems odd that compute would need to worry about that part.","commit_id":"a038f43456fef5bfc03a4f980e56f9eecc44a9d7"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"9cf8092126fbe7594f25ad9a276f172b9c4f41e5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"include_recipe \u0027ceph::_common\u0027"},{"line_number":26,"context_line":"include_recipe \u0027ceph::install\u0027"},{"line_number":27,"context_line":"include_recipe \u0027ceph::conf\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ceph_user \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027rbd\u0027][\u0027cinder\u0027][\u0027user\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a961159_2b04e013","line":26,"in_reply_to":"3a961159_bf990321","updated":"2015-01-15 02:12:32.000000000","message":"It is actually needed. Ceph is needed on anything that nova runs on for the ceph client to correctly talk to libvirt.","commit_id":"a038f43456fef5bfc03a4f980e56f9eecc44a9d7"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"04dd4c25f157c114820d3f7b1ed34935da8d72aa","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# which one should be used for each single volume mount request"},{"line_number":54,"context_line":"Chef::Log.info(\"rbd_secret_name: #{secret_uuid}\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"template \u0027/tmp/secret.xml\u0027 do"},{"line_number":57,"context_line":"  source \u0027secret.xml.erb\u0027"},{"line_number":58,"context_line":"  user \u0027root\u0027"},{"line_number":59,"context_line":"  group \u0027root\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a961159_c91524e7","line":56,"updated":"2015-01-15 03:50:34.000000000","message":"should not pull out to an attribute ?","commit_id":"9f751a618b7bf3f0fb7730fc1fdadde6adcb5736"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"9579e1404608bf597545e898d37f94d49c7386c9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# which one should be used for each single volume mount request"},{"line_number":54,"context_line":"Chef::Log.info(\"rbd_secret_name: #{secret_uuid}\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"template \u0027/tmp/secret.xml\u0027 do"},{"line_number":57,"context_line":"  source \u0027secret.xml.erb\u0027"},{"line_number":58,"context_line":"  user \u0027root\u0027"},{"line_number":59,"context_line":"  group \u0027root\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a961159_c03fb2b3","line":56,"in_reply_to":"3a961159_c91524e7","updated":"2015-01-15 06:53:11.000000000","message":"I don\u0027t think this should be an attribute since it is just a tmp file that is immediately deleted.  The only reason I named it statically here instead of keeping it as a random string was to avoid the import of the securerandom module.","commit_id":"9f751a618b7bf3f0fb7730fc1fdadde6adcb5736"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5dc4c50b78ce82fa01df738e63ed82848c0cae94","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  source \u0027secret.xml.erb\u0027"},{"line_number":47,"context_line":"  user \u0027root\u0027"},{"line_number":48,"context_line":"  group \u0027root\u0027"},{"line_number":49,"context_line":"  mode \u0027700\u0027"},{"line_number":50,"context_line":"  variables("},{"line_number":51,"context_line":"    uuid: secret_uuid,"},{"line_number":52,"context_line":"    client_name: node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027rbd\u0027][\u0027rbd_user\u0027]"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a961159_540460c5","side":"PARENT","line":49,"updated":"2015-01-15 09:18:48.000000000","message":"While you are touching this part anyway: This file certainly does not need to be executable, so mode \u0027600\u0027 would be better.","commit_id":"f3952ed4e4c9f17f8e2d1c327de0e228f463b555"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"ba258597d37fa56508b5d5bf88c5c9ed5733654c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  source \u0027secret.xml.erb\u0027"},{"line_number":47,"context_line":"  user \u0027root\u0027"},{"line_number":48,"context_line":"  group \u0027root\u0027"},{"line_number":49,"context_line":"  mode \u0027700\u0027"},{"line_number":50,"context_line":"  variables("},{"line_number":51,"context_line":"    uuid: secret_uuid,"},{"line_number":52,"context_line":"    client_name: node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027rbd\u0027][\u0027rbd_user\u0027]"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a961159_5103870c","side":"PARENT","line":49,"in_reply_to":"3a961159_540460c5","updated":"2015-01-15 13:27:52.000000000","message":"Done","commit_id":"f3952ed4e4c9f17f8e2d1c327de0e228f463b555"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5dc4c50b78ce82fa01df738e63ed82848c0cae94","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  include ::Openstack"},{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"include_recipe \u0027ceph::_common\u0027"},{"line_number":26,"context_line":"include_recipe \u0027ceph::install\u0027"},{"line_number":27,"context_line":"include_recipe \u0027ceph::conf\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a961159_34b6f425","line":25,"updated":"2015-01-15 09:18:48.000000000","message":"Including a private recipe from a different cookbook should be avoided. If this is really necessary in the current setup, I would consider this a bug in the ceph cookbook, so at least add a note about it and file an issue over there?","commit_id":"c095eca670364ae6b38241eda2fb11130d58fba4"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"ba258597d37fa56508b5d5bf88c5c9ed5733654c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  include ::Openstack"},{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"include_recipe \u0027ceph::_common\u0027"},{"line_number":26,"context_line":"include_recipe \u0027ceph::install\u0027"},{"line_number":27,"context_line":"include_recipe \u0027ceph::conf\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a961159_16fe5506","line":25,"in_reply_to":"3a961159_34b6f425","updated":"2015-01-15 13:27:52.000000000","message":"I was also not very keen on adding this.  After digging around in their cookbook I couldn\u0027t find a sane way to get the ceph repository added without including it.","commit_id":"c095eca670364ae6b38241eda2fb11130d58fba4"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"6364b0833ae53bbde0e48f2537ef72ee0a47ef6d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  source \u0027secret.xml.erb\u0027"},{"line_number":58,"context_line":"  user \u0027root\u0027"},{"line_number":59,"context_line":"  group \u0027root\u0027"},{"line_number":60,"context_line":"  mode \u0027600\u0027"},{"line_number":61,"context_line":"  variables("},{"line_number":62,"context_line":"    uuid: secret_uuid,"},{"line_number":63,"context_line":"    client_name: node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027rbd\u0027][\u0027cinder\u0027][\u0027user\u0027]"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a961159_b1e58b0b","line":60,"updated":"2015-01-15 13:39:18.000000000","message":"I saw in your previous patch, you did not touch this attribute. You should use 00600 instead of \u0027600\u0027, please take a look at other cookbooks.","commit_id":"8127d240c777819ad22b52e3fdcacfe130bd4fa1"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"02ac6f6dff81cef073264d8778076ecab0e93603","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  source \u0027secret.xml.erb\u0027"},{"line_number":58,"context_line":"  user \u0027root\u0027"},{"line_number":59,"context_line":"  group \u0027root\u0027"},{"line_number":60,"context_line":"  mode \u0027600\u0027"},{"line_number":61,"context_line":"  variables("},{"line_number":62,"context_line":"    uuid: secret_uuid,"},{"line_number":63,"context_line":"    client_name: node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027rbd\u0027][\u0027cinder\u0027][\u0027user\u0027]"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a961159_512f07f6","line":60,"in_reply_to":"3a961159_b1e58b0b","updated":"2015-01-15 13:43:20.000000000","message":"this actually seems like it\u0027s all over the place:\n$ grep -r \"0700\" .\n./recipes/api-os-compute.rb:  mode 00700\n./spec/api-os-compute_spec.rb:        mode: 0700\n\nI will still update it.","commit_id":"8127d240c777819ad22b52e3fdcacfe130bd4fa1"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d6b17aba58d6fd568ae00d8a9d51bfc49caab3d8","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ::Chef::Recipe # rubocop:disable Documentation"},{"line_number":22,"context_line":"  include ::Openstack"},{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"include_recipe \u0027ceph::_common\u0027"},{"line_number":26,"context_line":"include_recipe \u0027ceph::install\u0027"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"1a930d6b_db49b1d1","line":23,"updated":"2015-01-22 18:34:44.000000000","message":"Where does this recipe ever get called/used?  not in roles or included anywhere?\n\nmaybe need a if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027images_type\u0027] \u003d\u003d \u0027rbd\u0027   to include in to nova-common?","commit_id":"2fb0f58b5e3af3008a5b4813c774d062e296033a"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"756d94e0534d6bdcb7a2fa367264ce91f796b97e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ::Chef::Recipe # rubocop:disable Documentation"},{"line_number":22,"context_line":"  include ::Openstack"},{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"include_recipe \u0027ceph::_common\u0027"},{"line_number":26,"context_line":"include_recipe \u0027ceph::install\u0027"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"da86d52c_95db951a","line":23,"in_reply_to":"1a930d6b_db49b1d1","updated":"2015-02-02 16:38:48.000000000","message":"https://github.com/stackforge/cookbook-openstack-compute/blob/c7ecebdb1fe2d3fc1ba022c5d99747c349cd70f1/recipes/libvirt.rb#L219","commit_id":"2fb0f58b5e3af3008a5b4813c774d062e296033a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d6b17aba58d6fd568ae00d8a9d51bfc49caab3d8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  action :add"},{"line_number":50,"context_line":"end"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# TODO(srenatus) there might be multiple secrets, cinder will tell nova-compute"},{"line_number":53,"context_line":"# which one should be used for each single volume mount request"},{"line_number":54,"context_line":"Chef::Log.info(\"rbd_secret_name: #{secret_uuid}\")"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"1a930d6b_fbd66df0","line":52,"updated":"2015-01-22 18:34:44.000000000","message":"Is this todo still valid with new upsteam cookbook?","commit_id":"2fb0f58b5e3af3008a5b4813c774d062e296033a"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"756d94e0534d6bdcb7a2fa367264ce91f796b97e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  action :add"},{"line_number":50,"context_line":"end"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# TODO(srenatus) there might be multiple secrets, cinder will tell nova-compute"},{"line_number":53,"context_line":"# which one should be used for each single volume mount request"},{"line_number":54,"context_line":"Chef::Log.info(\"rbd_secret_name: #{secret_uuid}\")"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"da86d52c_3504a97a","line":52,"in_reply_to":"1a930d6b_fbd66df0","updated":"2015-02-02 16:38:48.000000000","message":"No it\u0027s not. I\u0027ll remove it.","commit_id":"2fb0f58b5e3af3008a5b4813c774d062e296033a"}]}