)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1f3abb5fc67c0311649fa26dd7dcb4e8f6369688","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Wei Hu \u003chwhu@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-09 13:39:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix can not set metadata options in nova.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The exist logic in nova.conf about set up \"metadata_listen\" and \""},{"line_number":10,"context_line":"metadata_listen_port\"  options for nova metadata api is only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_cde3c731","line":7,"updated":"2015-02-09 14:32:05.000000000","message":"cannot understand the message","commit_id":"5fe3a47db6c4222a8ae0c5120961666299f632d6"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"97300653e79219a338e20f6589f85f5979a7d69d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Wei Hu \u003chwhu@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-09 13:39:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix can not set metadata options in nova.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The exist logic in nova.conf about set up \"metadata_listen\" and \""},{"line_number":10,"context_line":"metadata_listen_port\"  options for nova metadata api is only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_1c827200","line":7,"in_reply_to":"da86d52c_cde3c731","updated":"2015-02-09 15:04:04.000000000","message":"Done","commit_id":"5fe3a47db6c4222a8ae0c5120961666299f632d6"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1f3abb5fc67c0311649fa26dd7dcb4e8f6369688","unresolved":false,"context_lines":[{"line_number":12,"context_line":"metadata-api\" to provide nova metadata service no need to include"},{"line_number":13,"context_line":"\"metadata\" in \"enabled_apis\". This code change will let those options"},{"line_number":14,"context_line":"can be changed when the run_list include \"openstack-compute::api-"},{"line_number":15,"context_line":"metadata\" recipe."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ibb9cc65bfcc491eb7ed924138ecac5d7c9c983d7"},{"line_number":18,"context_line":"Closes-bug: #1418797"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_ad9e9361","line":15,"updated":"2015-02-09 14:32:05.000000000","message":"I think the commit message is not clear","commit_id":"5fe3a47db6c4222a8ae0c5120961666299f632d6"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"97300653e79219a338e20f6589f85f5979a7d69d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"metadata-api\" to provide nova metadata service no need to include"},{"line_number":13,"context_line":"\"metadata\" in \"enabled_apis\". This code change will let those options"},{"line_number":14,"context_line":"can be changed when the run_list include \"openstack-compute::api-"},{"line_number":15,"context_line":"metadata\" recipe."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ibb9cc65bfcc491eb7ed924138ecac5d7c9c983d7"},{"line_number":18,"context_line":"Closes-bug: #1418797"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_3c873611","line":15,"in_reply_to":"da86d52c_ad9e9361","updated":"2015-02-09 15:04:04.000000000","message":"Will do in next patch.","commit_id":"5fe3a47db6c4222a8ae0c5120961666299f632d6"}],"templates/default/nova.conf.erb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1f3abb5fc67c0311649fa26dd7dcb4e8f6369688","unresolved":false,"context_lines":[{"line_number":167,"context_line":"osapi_compute_listen_port\u003d\u003c%\u003d @compute_api_bind_port %\u003e"},{"line_number":168,"context_line":"\u003c% end -%\u003e"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"enabled_apis\"].include?(\"metadata\") || node.run_list.expand(node.chef_environment).recipes.include?(\"openstack-compute::api-metadata\") %\u003e"},{"line_number":171,"context_line":"# The IP address on which the metadata will listen. (string value)"},{"line_number":172,"context_line":"metadata_listen\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027metadata_listen\u0027] %\u003e"},{"line_number":173,"context_line":"# The port on which the metadata will listen. (integer value)"}],"source_content_type":"application/x-erb","patch_set":2,"id":"da86d52c_4db517cc","line":170,"updated":"2015-02-09 14:32:05.000000000","message":"If user doesn\u0027t want to enable metadata api, but the run_list includes the recipe, how to address it ?","commit_id":"5fe3a47db6c4222a8ae0c5120961666299f632d6"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"97300653e79219a338e20f6589f85f5979a7d69d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"osapi_compute_listen_port\u003d\u003c%\u003d @compute_api_bind_port %\u003e"},{"line_number":168,"context_line":"\u003c% end -%\u003e"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"enabled_apis\"].include?(\"metadata\") || node.run_list.expand(node.chef_environment).recipes.include?(\"openstack-compute::api-metadata\") %\u003e"},{"line_number":171,"context_line":"# The IP address on which the metadata will listen. (string value)"},{"line_number":172,"context_line":"metadata_listen\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027metadata_listen\u0027] %\u003e"},{"line_number":173,"context_line":"# The port on which the metadata will listen. (integer value)"}],"source_content_type":"application/x-erb","patch_set":2,"id":"da86d52c_bc9b2671","line":170,"in_reply_to":"da86d52c_4db517cc","updated":"2015-02-09 15:04:04.000000000","message":"Why run_list include this recipe but not enable nova-metadata-api? I did not see any if condition in https://github.com/stackforge/cookbook-openstack-compute/blob/master/recipes/api-metadata.rb","commit_id":"5fe3a47db6c4222a8ae0c5120961666299f632d6"}]}
