)]}'
{"README.md":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"Docker configuration Attributes"},{"line_number":365,"context_line":"-------------------------------"},{"line_number":366,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker_type\u0027]` - Mark this as true to make compute docker type"},{"line_number":367,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027nova_docker_driver\u0027]` - The nova docker driver that will be configured in a docker type compute"},{"line_number":368,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027pkgs\u0027]` - Additional packages required for nova docker driver installation using git source"},{"line_number":369,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027filedownload_type\u0027]` - Default option is \u0027git\u0027. Local file download is also supported for which this has to be configured as \u0027local\u0027"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1a6ced46_28a5dfa1","line":366,"updated":"2015-03-25 14:24:45.000000000","message":"Since this is really not a type, but a boolean, I think something like [compute][docker][enable]  would be better","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":365,"context_line":"-------------------------------"},{"line_number":366,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker_type\u0027]` - Mark this as true to make compute docker type"},{"line_number":367,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027nova_docker_driver\u0027]` - The nova docker driver that will be configured in a docker type compute"},{"line_number":368,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027pkgs\u0027]` - Additional packages required for nova docker driver installation using git source"},{"line_number":369,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027filedownload_type\u0027]` - Default option is \u0027git\u0027. Local file download is also supported for which this has to be configured as \u0027local\u0027"},{"line_number":370,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027repository\u0027]` - github repository from which nova-docker source will be downloaded if the filedownload_type is git"},{"line_number":371,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027branch\u0027]` - github branch from which nova-docker source will be downloaded if the filedownload_type is git. Default is master"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1a6ced46_88edf3b9","line":368,"updated":"2015-03-25 14:24:45.000000000","message":"Is this where the rpm would go someday, or maybe keep that separate, and call this  \"build_pkgs\"","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":369,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027filedownload_type\u0027]` - Default option is \u0027git\u0027. Local file download is also supported for which this has to be configured as \u0027local\u0027"},{"line_number":370,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027repository\u0027]` - github repository from which nova-docker source will be downloaded if the filedownload_type is git"},{"line_number":371,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027branch\u0027]` - github branch from which nova-docker source will be downloaded if the filedownload_type is git. Default is master"},{"line_number":372,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027local_clone\u0027]` - A local directory in compute node where the git clone of nova-docker driver should be kept if the filedownload_type is local"},{"line_number":373,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_filter_source_path\u0027]` - Relative path to docker filter files in nova-docker source which will be cloned from git repo"},{"line_number":374,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_sock\u0027]` - Path to docker service sock file"},{"line_number":375,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_permission_level\u0027]` - Permission level to be assigned to docker sock file"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1a6ced46_486cdb35","line":372,"updated":"2015-03-25 14:24:45.000000000","message":"Is this really needed?  Seems like a development only option.   And I think this can be covered by the existing [github][repo] value.\n\nWe can use the git clone --local   option to handle this if it\u0027s needed.  Then no need for separate option, just detect local based upon how repo is specified (  file:/// )","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"}],"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":591,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker_type\u0027] \u003d false"},{"line_number":592,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027nova_docker_driver\u0027] \u003d \u0027novadocker.virt.docker.driver.DockerDriver\u0027"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"# Below are nova-docker installation related configurations"},{"line_number":595,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027pkgs\u0027]  \u003d value_for_platform("},{"line_number":596,"context_line":"  %w(ubuntu) \u003d\u003e {"},{"line_number":597,"context_line":"    \u0027default\u0027 \u003d\u003e [\u0027git\u0027, \u0027python-dev\u0027, \u0027gcc\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a6ced46_48885bc5","line":594,"updated":"2015-03-25 14:24:45.000000000","message":"I would prefer that these move up to the platform_family package section above, easier to find and track there.","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"}],"recipes/compute.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    action [:create, :manage]"},{"line_number":109,"context_line":"  end"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  # copy docker filters"},{"line_number":112,"context_line":"  bash \u0027copy filters\u0027 do"},{"line_number":113,"context_line":"    cwd install_directory"},{"line_number":114,"context_line":"    code \u003c\u003c-EOH"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a6ced46_9c2ff487","line":111,"updated":"2015-03-25 14:24:45.000000000","message":"I don\u0027t like using bash for something like this, try these suggestions instead: http://stackoverflow.com/questions/19221252/how-to-move-copy-files-locally-with-chef   (i like option \"First Way\")","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"}],"recipes/docker-setup.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Cookbook Name:: openstack-compute"},{"line_number":3,"context_line":"# Recipe:: docker-compute"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2015 IBM Corp."},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a6ced46_fc246861","line":3,"updated":"2015-03-25 14:24:45.000000000","message":"Does not match.   I think \"compute-docker\"  would fit better with existing cookbook recipe namespace.","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# upgrade the required packages (some packages will be removed once RPM based nova-docker installation is introduced)"},{"line_number":27,"context_line":"installation_packages.each do |pkg|"},{"line_number":28,"context_line":"  package pkg do"},{"line_number":29,"context_line":"    action :upgrade"},{"line_number":30,"context_line":"  end"},{"line_number":31,"context_line":"end"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a6ced46_dc896c76","line":29,"updated":"2015-03-25 14:24:45.000000000","message":"Need to add\noptions platform_options[\u0027package_overrides\u0027]\n\nand then above this add\nplatform_options \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027platform\u0027]","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# This will be removed once RPM based installation of nova-docker driver is available"},{"line_number":34,"context_line":"python_pip \u0027setuptools\u0027 do"},{"line_number":35,"context_line":"  action :upgrade"},{"line_number":36,"context_line":"end"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a6ced46_9c5d3418","line":34,"updated":"2015-03-25 14:24:45.000000000","message":"DRY, Combine these pip installs into a list driven approach\n\nAnd should these be define in a attr list or would never need change?","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# default download mechanims is to download from nova-docker git repo"},{"line_number":44,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027filedownload_type\u0027] \u003d\u003d \u0027git\u0027"},{"line_number":45,"context_line":"  # In case you want to download latest docker driver from public git repo change filedownload_type to git"},{"line_number":46,"context_line":"  github_repository \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027repository\u0027]"},{"line_number":47,"context_line":"  github_branch \u003d   node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027branch\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a6ced46_5cdc9c73","line":44,"updated":"2015-03-25 14:24:45.000000000","message":"instead of if/elsif,  use a case, it cleaner.","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"56979335ced062d26c7366dab0d72720665ed8d5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      python ./setup.py install"},{"line_number":63,"context_line":"    EOH"},{"line_number":64,"context_line":"  end"},{"line_number":65,"context_line":"elsif node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027filedownload_type\u0027]  \u003d\u003d \u0027local\u0027"},{"line_number":66,"context_line":"  # Make sure a local git clone of https://github.com/stackforge/nova-docker is available as a local directory in compute"},{"line_number":67,"context_line":"  git_clone_directory  \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027local_clone\u0027]"},{"line_number":68,"context_line":"  # Configure nova docker driver"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a6ced46_3c4d203f","line":65,"updated":"2015-03-25 14:24:45.000000000","message":"I would rather keep the local option simpler, and just be a tar ball/zip file, I believe that\u0027s what we do in other places.","commit_id":"4d1e16739a0b9efe3818b97099494e3ac7aab798"}]}