)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"337fe3566009af5ed1c3f1b8e3e702565c93c185","unresolved":false,"context_lines":[{"line_number":11,"context_line":"nova-docker driver as a compute driver and allow user to configure a"},{"line_number":12,"context_line":"compute as docker compute"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: bluerprint docker-driver-configuration"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6fa7e93a4050419fb0531e17b56da4c32205bce3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_bece7c58","line":14,"updated":"2015-04-02 06:57:13.000000000","message":"correct it to blueprint , so it can be linked","commit_id":"60dfd00ac791dd9a6cdffff157229c9eb87fd089"},{"author":{"_account_id":14655,"name":"Sudheesh","email":"skairali@in.ibm.com","username":"skairali"},"change_message_id":"c657ddb612c09a7236ca791f53c7ab70aa341a57","unresolved":false,"context_lines":[{"line_number":11,"context_line":"nova-docker driver as a compute driver and allow user to configure a"},{"line_number":12,"context_line":"compute as docker compute"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: bluerprint docker-driver-configuration"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6fa7e93a4050419fb0531e17b56da4c32205bce3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_9f2cd34b","line":14,"in_reply_to":"baa041b7_bece7c58","updated":"2015-04-02 08:05:26.000000000","message":"Done","commit_id":"60dfd00ac791dd9a6cdffff157229c9eb87fd089"}],"README.md":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"337fe3566009af5ed1c3f1b8e3e702565c93c185","unresolved":false,"context_lines":[{"line_number":364,"context_line":"Docker configuration Attributes"},{"line_number":365,"context_line":"-------------------------------"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027]` - Mark this as true to make compute docker type and use nova docker driver as compute driver. Docker computes are supported only in Ubuntu and Rhel"},{"line_number":368,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027driver\u0027]` - The nova docker driver that will be configured in a docker type compute"},{"line_number":369,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027platform\u0027][\u0027docker_build_pkgs\u0027]` - Additoinal packages required for nova docker driver build and installation from git source"},{"line_number":370,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027pip_build_pkgs\u0027]` - Additional python packages required for nova docker driver build and installation from git source"}],"source_content_type":"text/x-gfm","patch_set":8,"id":"baa041b7_fe8764d5","line":367,"updated":"2015-04-02 06:57:13.000000000","message":"I think your meaning should be redhat, rhel platform_family includes redhat platform.","commit_id":"60dfd00ac791dd9a6cdffff157229c9eb87fd089"},{"author":{"_account_id":14655,"name":"Sudheesh","email":"skairali@in.ibm.com","username":"skairali"},"change_message_id":"c657ddb612c09a7236ca791f53c7ab70aa341a57","unresolved":false,"context_lines":[{"line_number":364,"context_line":"Docker configuration Attributes"},{"line_number":365,"context_line":"-------------------------------"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027]` - Mark this as true to make compute docker type and use nova docker driver as compute driver. Docker computes are supported only in Ubuntu and Rhel"},{"line_number":368,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027driver\u0027]` - The nova docker driver that will be configured in a docker type compute"},{"line_number":369,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027platform\u0027][\u0027docker_build_pkgs\u0027]` - Additoinal packages required for nova docker driver build and installation from git source"},{"line_number":370,"context_line":"* `[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027pip_build_pkgs\u0027]` - Additional python packages required for nova docker driver build and installation from git source"}],"source_content_type":"text/x-gfm","patch_set":8,"id":"baa041b7_1ffa03be","line":367,"in_reply_to":"baa041b7_fe8764d5","updated":"2015-04-02 08:05:26.000000000","message":"Yes, do you want me to patch it as \"Docker computes are supported only in Ubuntu and redhat\" ?","commit_id":"60dfd00ac791dd9a6cdffff157229c9eb87fd089"}],"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":589,"context_line":"# choose the needed ones to set"},{"line_number":590,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027upgrade_levels\u0027] \u003d nil"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"# Docker configurations"},{"line_number":593,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027]  \u003d false"},{"line_number":594,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027nova_docker_driver\u0027] \u003d \u0027novadocker.virt.docker.driver.DockerDriver\u0027"},{"line_number":595,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027pip_build_pkgs\u0027] \u003d [\u0027setuptools\u0027, \u0027pbr\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_bf042515","line":592,"updated":"2015-03-30 18:26:19.000000000","message":"A nit, but since we are moving in the direction of attribute doc being in here, I would like to see each attr with it\u0027s own description comment  (just copied from readme for now).\nThe goal of the future readme is to be more of a quick start manual that describes how to use attr defined in here, and maybe someday to even have a automated task to build the readme attr doc from this file directly.","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"# Docker configurations"},{"line_number":593,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027]  \u003d false"},{"line_number":594,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027nova_docker_driver\u0027] \u003d \u0027novadocker.virt.docker.driver.DockerDriver\u0027"},{"line_number":595,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027pip_build_pkgs\u0027] \u003d [\u0027setuptools\u0027, \u0027pbr\u0027]"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"# By defalt nova-docker will be downloaded from git repository([\u0027docker\u0027][\u0027github\u0027][\u0027repository\u0027]) and installed"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_9a096f2f","line":594,"updated":"2015-03-30 18:26:19.000000000","message":"redundant \"docker\" in key name","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":597,"context_line":"# By defalt nova-docker will be downloaded from git repository([\u0027docker\u0027][\u0027github\u0027][\u0027repository\u0027]) and installed"},{"line_number":598,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027repository\u0027] \u003d \u0027https://github.com/stackforge/nova-docker\u0027"},{"line_number":599,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027branch\u0027] \u003d \u0027master\u0027"},{"line_number":600,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_filter_source_path\u0027] \u003d \u0027/etc/nova/rootwrap.d\u0027"},{"line_number":601,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_sock\u0027] \u003d \u0027/var/run/docker.sock\u0027"},{"line_number":602,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_permission_level\u0027] \u003d 666"},{"line_number":603,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027group\u0027] \u003d \u0027docker\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_9f5841fc","line":600,"updated":"2015-03-30 18:26:19.000000000","message":"redundant to have docker in the key name here and next 2.","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":598,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027repository\u0027] \u003d \u0027https://github.com/stackforge/nova-docker\u0027"},{"line_number":599,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027branch\u0027] \u003d \u0027master\u0027"},{"line_number":600,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_filter_source_path\u0027] \u003d \u0027/etc/nova/rootwrap.d\u0027"},{"line_number":601,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_sock\u0027] \u003d \u0027/var/run/docker.sock\u0027"},{"line_number":602,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_permission_level\u0027] \u003d 666"},{"line_number":603,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027group\u0027] \u003d \u0027docker\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_1f6d5198","line":601,"updated":"2015-03-30 18:26:19.000000000","message":"Could this path vary between ubuntu and rhel?","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":599,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027github\u0027][\u0027branch\u0027] \u003d \u0027master\u0027"},{"line_number":600,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_filter_source_path\u0027] \u003d \u0027/etc/nova/rootwrap.d\u0027"},{"line_number":601,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_sock\u0027] \u003d \u0027/var/run/docker.sock\u0027"},{"line_number":602,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_permission_level\u0027] \u003d 666"},{"line_number":603,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027group\u0027] \u003d \u0027docker\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_5f6999bd","line":602,"updated":"2015-03-30 18:26:19.000000000","message":"And should this be more specific?   since this only applies to the socket file?\n\nservice_sock\nservice_sock_mode","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"}],"recipes/compute.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  action [:enable, :start]"},{"line_number":98,"context_line":"end"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027]"},{"line_number":101,"context_line":"  docker_filter_source_path \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_filter_source_path\u0027]"},{"line_number":102,"context_line":"  install_directory  \u003d \"#{Chef::Config[\u0027file_cache_path\u0027]}/nova-docker\""},{"line_number":103,"context_line":"  docker_group \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_9fb4c1f2","line":100,"updated":"2015-03-30 18:26:19.000000000","message":"could this be pushed to just above the line 92 nova compute service resource?   Then would not need the extra restart immediate, just add a subscribes like is done for the nova.conf, that\u0027s much cleaner then a forced restart (we\u0027re trying to avoid those)\n\nThen also, instead of a big if check here, just use gated resources, so add:\n\nonly_if {node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027]}","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"}],"recipes/docker-setup.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#   Make sure that docker runtime is installed as a prerequsite"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"include_recipe \u0027python::pip\u0027"},{"line_number":22,"context_line":"docker_service_sock \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_sock\u0027]"},{"line_number":23,"context_line":"docker_service_permission_level \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027docker_service_permission_level\u0027]"},{"line_number":24,"context_line":"platform_options \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027platform\u0027]"},{"line_number":25,"context_line":"pip_build_pkgs \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027pip_build_pkgs\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_7f257da9","line":22,"updated":"2015-03-30 18:26:19.000000000","message":"Normally there is a blank after include_recipe stuff.","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"}],"spec/compute_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    include_examples \u0027expect_creates_nova_lock_dir\u0027"},{"line_number":15,"context_line":"    include_examples \u0027expect_creates_nova_instances_dir\u0027"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    context \u0027docker setup steps when compute is docker type\u0027 do"},{"line_number":18,"context_line":"      before do"},{"line_number":19,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027] \u003d true"},{"line_number":20,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da9b358b_3f75b5ca","line":17,"updated":"2015-03-30 18:26:19.000000000","message":"I don\u0027t see a reason for separate contexts here, please combine these together into one for docker enabled.","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"836d961c8ef6eec7060ca9bbf95bd74d79a08608","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        expect(chef_run).to create_file(\u0027/etc/nova/rootwrap.d/docker.filters\u0027).with("},{"line_number":130,"context_line":"          user:   \u0027root\u0027,"},{"line_number":131,"context_line":"          group:  \u0027root\u0027"},{"line_number":132,"context_line":"        )"},{"line_number":133,"context_line":"      end"},{"line_number":134,"context_line":"    end"},{"line_number":135,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"da9b358b_d5d44021","line":132,"updated":"2015-03-31 16:26:10.000000000","message":"Please add mode and path\n\n mode: 0644,\n path: \u0027/etc/nova/rootwrap.d/docker.filters\u0027","commit_id":"87950255defbf81df466dd55182acbaa95caf836"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"836d961c8ef6eec7060ca9bbf95bd74d79a08608","unresolved":false,"context_lines":[{"line_number":131,"context_line":"          group:  \u0027root\u0027"},{"line_number":132,"context_line":"        )"},{"line_number":133,"context_line":"      end"},{"line_number":134,"context_line":"    end"},{"line_number":135,"context_line":"  end"},{"line_number":136,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"da9b358b_15c0687a","line":134,"updated":"2015-03-31 16:26:10.000000000","message":"Need to add spec test for the subscribes:\n\n   expect(chef_run.service(\u0027nova-compute\u0027)).to subscribe_to(\u0027file[/etc/nova/rootwrap.d/docker.filters]\u0027)","commit_id":"87950255defbf81df466dd55182acbaa95caf836"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"337fe3566009af5ed1c3f1b8e3e702565c93c185","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      before do"},{"line_number":113,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027] \u003d true"},{"line_number":114,"context_line":"      end"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"      it \u0027includes docker-setup recipe\u0027 do"},{"line_number":117,"context_line":"        expect(chef_run).to include_recipe \u0027openstack-compute::docker-setup\u0027"},{"line_number":118,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"baa041b7_3c25d5aa","line":115,"updated":"2015-04-02 06:57:13.000000000","message":"shouldn\u0027t this cover the default case: not include recipe \u0027openstack-compute::docker-setup\u0027 ?","commit_id":"60dfd00ac791dd9a6cdffff157229c9eb87fd089"},{"author":{"_account_id":14655,"name":"Sudheesh","email":"skairali@in.ibm.com","username":"skairali"},"change_message_id":"c657ddb612c09a7236ca791f53c7ab70aa341a57","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      before do"},{"line_number":113,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027] \u003d true"},{"line_number":114,"context_line":"      end"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"      it \u0027includes docker-setup recipe\u0027 do"},{"line_number":117,"context_line":"        expect(chef_run).to include_recipe \u0027openstack-compute::docker-setup\u0027"},{"line_number":118,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"baa041b7_5fabeb89","line":115,"in_reply_to":"baa041b7_3c25d5aa","updated":"2015-04-02 08:05:26.000000000","message":"As you can see by defaut docker is not enabled and none of  docker related test cases are required. Thats why we have added a new context called \u0027when docker is enabled\u0027 and in this context we have to test for inclusion of recipe.  Outside this context there is nothing to be tested for docker","commit_id":"60dfd00ac791dd9a6cdffff157229c9eb87fd089"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ba06a3e868d0a4d96a18610ddaf76327f69b182a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      before do"},{"line_number":113,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027docker\u0027][\u0027enable\u0027] \u003d true"},{"line_number":114,"context_line":"      end"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"      it \u0027includes docker-setup recipe\u0027 do"},{"line_number":117,"context_line":"        expect(chef_run).to include_recipe \u0027openstack-compute::docker-setup\u0027"},{"line_number":118,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"baa041b7_85d5a444","line":115,"in_reply_to":"baa041b7_5fabeb89","updated":"2015-04-02 09:06:36.000000000","message":"got your meaning, my point is that: by default, we can cover,\n\nexpect(chef_run).not_to include_recipe \u0027openstack-compute::docker-setup\u0027","commit_id":"60dfd00ac791dd9a6cdffff157229c9eb87fd089"}],"templates/default/nova.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"927ece65a49c906494c6bdf04cb15cd32f0a31ac","unresolved":false,"context_lines":[{"line_number":122,"context_line":"image_service\u003dnova.image.glance.GlanceImageService"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"##### COMPUTE #####"},{"line_number":125,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"docker\"][\"enable\"] %\u003e"},{"line_number":126,"context_line":"compute_driver\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"docker\"][\"nova_docker_driver\"] %\u003e"},{"line_number":127,"context_line":"\u003c% else %\u003e"},{"line_number":128,"context_line":"compute_driver\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"driver\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"da9b358b_3a3f03b6","line":125,"updated":"2015-03-30 18:26:19.000000000","message":"I don\u0027t think this logic is good here.\n\nI would instead add a simple node.set[\"openstack\"][\"compute\"][\"driver\"] \u003d node[\"openstack\"][\"compute\"][\"docker\"][\"nova_docker_driver\"]  to your setup recipe.","commit_id":"df12261f1cc9357d1ce42047f39acad9380b03cb"}]}