)]}'
{"README.md":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e0ce03f80a2d450402f85f59de272c6f5ba0f893","unresolved":false,"context_lines":[{"line_number":284,"context_line":"Scheduler Configuration Attributes"},{"line_number":285,"context_line":"----------------------------------"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"* `openstack[\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027]` Boolean that decides whether to use baremetal_scheduler_default_filters or not."},{"line_number":288,"context_line":"* `openstack[\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027]` A list of filters enabled for baremetal schedulers that support them."},{"line_number":289,"context_line":"* `openstack[\"compute\"][\"scheduler\"][\"scheduler_manager\"]` - the scheduler manager to use"},{"line_number":290,"context_line":"* `openstack[\"compute\"][\"scheduler\"][\"scheduler_driver\"]` - the scheduler driver to use"}],"source_content_type":"text/x-gfm","patch_set":5,"id":"7a016987_0a43026e","line":287,"updated":"2015-05-26 14:40:35.000000000","message":"Would be good to a brief ironic enablement section to describe that when this is set to true, the other values will be overwritten.","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ac3453e7ef03b7c9897093d21e94b75344d3b127","unresolved":false,"context_lines":[{"line_number":284,"context_line":"Scheduler Configuration Attributes"},{"line_number":285,"context_line":"----------------------------------"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"* `openstack[\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027]` Boolean that decides whether to use baremetal_scheduler_default_filters or not."},{"line_number":288,"context_line":"* `openstack[\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027]` A list of filters enabled for baremetal schedulers that support them."},{"line_number":289,"context_line":"* `openstack[\"compute\"][\"scheduler\"][\"scheduler_manager\"]` - the scheduler manager to use"},{"line_number":290,"context_line":"* `openstack[\"compute\"][\"scheduler\"][\"scheduler_driver\"]` - the scheduler driver to use"}],"source_content_type":"text/x-gfm","patch_set":5,"id":"7a016987_2a8f2c76","line":287,"in_reply_to":"7a016987_0a43026e","updated":"2015-06-01 07:15:06.000000000","message":"Done","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"}],"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a31fb67c65bfed3c796727ab044eba0777b6a773","unresolved":false,"context_lines":[{"line_number":227,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_single_default_gateway\u0027] \u003d false"},{"line_number":228,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_ipv6\u0027] \u003d false"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d \u0027False\u0027"},{"line_number":231,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_manager\u0027] \u003d \u0027nova.scheduler.manager.SchedulerManager\u0027"},{"line_number":232,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_driver\u0027] \u003d \u0027nova.scheduler.filter_scheduler.FilterScheduler\u0027"},{"line_number":233,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_host_manager\u0027] \u003d \u0027nova.scheduler.host_manager.HostManager\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_2a12d709","line":230,"updated":"2015-05-19 06:57:59.000000000","message":"why not just boolean false instead of string?","commit_id":"5a3804a9f26413069e052c1b838b03e72108d801"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1d0128bc66929b33d1cd5264b4935f80aaa2d21e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_single_default_gateway\u0027] \u003d false"},{"line_number":228,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_ipv6\u0027] \u003d false"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d \u0027False\u0027"},{"line_number":231,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_manager\u0027] \u003d \u0027nova.scheduler.manager.SchedulerManager\u0027"},{"line_number":232,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_driver\u0027] \u003d \u0027nova.scheduler.filter_scheduler.FilterScheduler\u0027"},{"line_number":233,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_host_manager\u0027] \u003d \u0027nova.scheduler.host_manager.HostManager\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_8a066b84","line":230,"in_reply_to":"7a016987_2a12d709","updated":"2015-05-19 07:47:00.000000000","message":"in face, either boolean or string is ok like others.","commit_id":"5a3804a9f26413069e052c1b838b03e72108d801"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9e0745b70eec79de8cc4ad19f4ce38a600c5ace6","unresolved":false,"context_lines":[{"line_number":228,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_ipv6\u0027] \u003d false"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":231,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":232,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":233,"context_line":"  RetryFilter"},{"line_number":234,"context_line":"  AvailabilityZoneFilter"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7a016987_991fd96b","line":231,"updated":"2015-05-19 22:44:19.000000000","message":"Just a question, when this is set to True, does the scheduler_driver need to be changed to the ironic one?   or when should that happen.","commit_id":"05588a9cd152ffb34fc29ef0e2d35b38b8b678a9"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"5c274b4ea532497b563cbf38b59cd4fc1cf9466f","unresolved":false,"context_lines":[{"line_number":228,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_ipv6\u0027] \u003d false"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":231,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":232,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":233,"context_line":"  RetryFilter"},{"line_number":234,"context_line":"  AvailabilityZoneFilter"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7a016987_2a1a8c17","line":231,"in_reply_to":"7a016987_129f1460","updated":"2015-05-22 02:52:33.000000000","message":"I think we can add a section \"Configure Compute Service to use the Bare Metal Service\" in REAME.md file, how is it going ?","commit_id":"05588a9cd152ffb34fc29ef0e2d35b38b8b678a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"f41d0b19ae4669c24e8e35d783319d0a33fcde81","unresolved":false,"context_lines":[{"line_number":228,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_ipv6\u0027] \u003d false"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":231,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":232,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":233,"context_line":"  RetryFilter"},{"line_number":234,"context_line":"  AvailabilityZoneFilter"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7a016987_4fe6f7e8","line":231,"in_reply_to":"7a016987_2a1a8c17","updated":"2015-05-22 06:49:21.000000000","message":"If there are valid defaults for he set to True case, why not just  set the attributes appropriately to those defaults?  In most cases we are trying to allow the cookbooks to handle basic enablement like this, is there a reason we can\u0027t to that in this ironic nova case?   Just trying to better understand....","commit_id":"05588a9cd152ffb34fc29ef0e2d35b38b8b678a9"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"be0d1ce09158a0ca5e8f026902cf7b0e7aea9f8c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_ipv6\u0027] \u003d false"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":231,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":232,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":233,"context_line":"  RetryFilter"},{"line_number":234,"context_line":"  AvailabilityZoneFilter"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7a016987_04d9e056","line":231,"in_reply_to":"7a016987_4fe6f7e8","updated":"2015-05-25 03:25:13.000000000","message":"yes, better to set the ironic-related attributes for True case.","commit_id":"05588a9cd152ffb34fc29ef0e2d35b38b8b678a9"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1188cca355fee16b66ccc97c16b1b5a081a5db43","unresolved":false,"context_lines":[{"line_number":228,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_ipv6\u0027] \u003d false"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":231,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":232,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":233,"context_line":"  RetryFilter"},{"line_number":234,"context_line":"  AvailabilityZoneFilter"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7a016987_da4c1ca0","line":231,"in_reply_to":"7a016987_991fd96b","updated":"2015-05-20 07:02:15.000000000","message":"I think if you want to config Compute service to use Bare Metal Service, this attribute should be set to True, and the corresponding attributes should also be set to the ironic-related values, like scheduler_driver, compute_driver, etc.","commit_id":"05588a9cd152ffb34fc29ef0e2d35b38b8b678a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"7444029b9b8bf5f4056d93ec00575cbc48626318","unresolved":false,"context_lines":[{"line_number":228,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027use_ipv6\u0027] \u003d false"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":231,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":232,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":233,"context_line":"  RetryFilter"},{"line_number":234,"context_line":"  AvailabilityZoneFilter"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7a016987_129f1460","line":231,"in_reply_to":"7a016987_da4c1ca0","updated":"2015-05-21 17:33:09.000000000","message":"I guess than I\u0027m asking if that set to True, should the cookbook automatically setup the ironic-related attributes?  That can certainly go in another patch, but I\u0027m trying to get some clarification on where this \"true\" enablement should go (code or docs)?","commit_id":"05588a9cd152ffb34fc29ef0e2d35b38b8b678a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e0ce03f80a2d450402f85f59de272c6f5ba0f893","unresolved":false,"context_lines":[{"line_number":586,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":587,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027]"},{"line_number":590,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":591,"context_line":"    RetryFilter"},{"line_number":592,"context_line":"    AvailabilityZoneFilter"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7a016987_05089327","line":589,"updated":"2015-05-26 14:40:35.000000000","message":"Would like to see a comment here describing why this logic is here.","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ac3453e7ef03b7c9897093d21e94b75344d3b127","unresolved":false,"context_lines":[{"line_number":586,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":587,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027]"},{"line_number":590,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":591,"context_line":"    RetryFilter"},{"line_number":592,"context_line":"    AvailabilityZoneFilter"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7a016987_ea1a347c","line":589,"in_reply_to":"7a016987_05089327","updated":"2015-06-01 07:15:06.000000000","message":"Done","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e0ce03f80a2d450402f85f59de272c6f5ba0f893","unresolved":false,"context_lines":[{"line_number":587,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027]"},{"line_number":590,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":591,"context_line":"    RetryFilter"},{"line_number":592,"context_line":"    AvailabilityZoneFilter"},{"line_number":593,"context_line":"    ComputeFilter"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7a016987_aa218eb6","line":590,"updated":"2015-05-26 14:40:35.000000000","message":"This attribute is specific to baremetal, so no need to have within this if logic, it should be pushed above with the enablement flag.  Then can also remove the logic for it in the nova template.","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ac3453e7ef03b7c9897093d21e94b75344d3b127","unresolved":false,"context_lines":[{"line_number":587,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027]"},{"line_number":590,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":591,"context_line":"    RetryFilter"},{"line_number":592,"context_line":"    AvailabilityZoneFilter"},{"line_number":593,"context_line":"    ComputeFilter"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7a016987_8a42a00d","line":590,"in_reply_to":"7a016987_aa218eb6","updated":"2015-06-01 07:15:06.000000000","message":"Done","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e0ce03f80a2d450402f85f59de272c6f5ba0f893","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    ExactRamFilter"},{"line_number":597,"context_line":"    ExactDiskFilter"},{"line_number":598,"context_line":"    ExactCoreFilter)"},{"line_number":599,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027driver\u0027] \u003d \u0027nova.virt.ironic.IronicDriver\u0027"},{"line_number":600,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027manager\u0027] \u003d \u0027ironic.nova.compute.manager.ClusteredComputeManager\u0027"},{"line_number":601,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_host_manager\u0027] \u003d \u0027nova.scheduler.ironic_host_manager.IronicHostManager\u0027"},{"line_number":602,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027ram_allocation_ratio\u0027] \u003d 1.0"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7a016987_25514f0f","line":599,"updated":"2015-05-26 14:40:35.000000000","message":"While i agree this approach will work, would be good to have a test case that verifies that these can still be overridden.","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ac3453e7ef03b7c9897093d21e94b75344d3b127","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    ExactRamFilter"},{"line_number":597,"context_line":"    ExactDiskFilter"},{"line_number":598,"context_line":"    ExactCoreFilter)"},{"line_number":599,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027driver\u0027] \u003d \u0027nova.virt.ironic.IronicDriver\u0027"},{"line_number":600,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027manager\u0027] \u003d \u0027ironic.nova.compute.manager.ClusteredComputeManager\u0027"},{"line_number":601,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_host_manager\u0027] \u003d \u0027nova.scheduler.ironic_host_manager.IronicHostManager\u0027"},{"line_number":602,"context_line":"  default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027ram_allocation_ratio\u0027] \u003d 1.0"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7a016987_0ab8f00f","line":599,"in_reply_to":"7a016987_25514f0f","updated":"2015-06-01 07:15:06.000000000","message":"Done","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"f7eb3460bb515941e94d55890adaabff659cd095","unresolved":false,"context_lines":[{"line_number":588,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027bare-metal\u0027][\u0027admin_tenant_name\u0027] \u003d \u0027service\u0027"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":591,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":594,"context_line":"  RetryFilter"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"7a016987_42f35e73","line":591,"updated":"2015-06-01 15:26:25.000000000","message":"Is the use of scheduler here redundant?  maybe just \"use_baremetal_filters\" ?","commit_id":"706109cbda9774c94c0343072851ad83879f85b9"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"5a5acf873ecb4e12fbe5410afddc1589967f9198","unresolved":false,"context_lines":[{"line_number":588,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027bare-metal\u0027][\u0027admin_tenant_name\u0027] \u003d \u0027service\u0027"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":591,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":594,"context_line":"  RetryFilter"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"5afe65bd_2d4dbf72","line":591,"in_reply_to":"7a016987_42f35e73","updated":"2015-06-02 03:21:53.000000000","message":"Done","commit_id":"706109cbda9774c94c0343072851ad83879f85b9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"f7eb3460bb515941e94d55890adaabff659cd095","unresolved":false,"context_lines":[{"line_number":590,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":591,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":594,"context_line":"  RetryFilter"},{"line_number":595,"context_line":"  AvailabilityZoneFilter"},{"line_number":596,"context_line":"  ComputeFilter"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"7a016987_22e622b0","line":593,"updated":"2015-06-01 15:26:25.000000000","message":"Is the use of scheduler here redundant? maybe just \"baremetal_default_filters\" ?","commit_id":"706109cbda9774c94c0343072851ad83879f85b9"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"5a5acf873ecb4e12fbe5410afddc1589967f9198","unresolved":false,"context_lines":[{"line_number":590,"context_line":"# Boolean to decide whether to use baremetal_scheduler_default_filters or not."},{"line_number":591,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d false"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027] \u003d %W("},{"line_number":594,"context_line":"  RetryFilter"},{"line_number":595,"context_line":"  AvailabilityZoneFilter"},{"line_number":596,"context_line":"  ComputeFilter"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"5afe65bd_cdb86be8","line":593,"in_reply_to":"7a016987_22e622b0","updated":"2015-06-02 03:21:53.000000000","message":"Done","commit_id":"706109cbda9774c94c0343072851ad83879f85b9"}],"spec/nova-common_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a31fb67c65bfed3c796727ab044eba0777b6a773","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        end"},{"line_number":725,"context_line":"      end"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"      it \u0027has scheduler options\u0027 do"},{"line_number":728,"context_line":"        [/^scheduler_use_baremetal_filters\u003dFalse$/,"},{"line_number":729,"context_line":"         /^scheduler_manager\u003dnova.scheduler.manager.SchedulerManager$/,"},{"line_number":730,"context_line":"         /^scheduler_driver\u003dnova.scheduler.filter_scheduler.FilterScheduler$/,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_aac36756","line":727,"updated":"2015-05-19 06:57:59.000000000","message":"What about True case, if true, also need to scheduler_driver to ironic?","commit_id":"5a3804a9f26413069e052c1b838b03e72108d801"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1d0128bc66929b33d1cd5264b4935f80aaa2d21e","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        end"},{"line_number":725,"context_line":"      end"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"      it \u0027has scheduler options\u0027 do"},{"line_number":728,"context_line":"        [/^scheduler_use_baremetal_filters\u003dFalse$/,"},{"line_number":729,"context_line":"         /^scheduler_manager\u003dnova.scheduler.manager.SchedulerManager$/,"},{"line_number":730,"context_line":"         /^scheduler_driver\u003dnova.scheduler.filter_scheduler.FilterScheduler$/,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_0a427bae","line":727,"in_reply_to":"7a016987_aac36756","updated":"2015-05-19 07:47:00.000000000","message":"will cover","commit_id":"5a3804a9f26413069e052c1b838b03e72108d801"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a31fb67c65bfed3c796727ab044eba0777b6a773","unresolved":false,"context_lines":[{"line_number":732,"context_line":"         /^scheduler_available_filters\u003dnova.scheduler.filters.all_filters$/,"},{"line_number":733,"context_line":"         /^scheduler_default_filters\u003dRetryFilter,AvailabilityZoneFilter,RamFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter$/"},{"line_number":734,"context_line":"        ].each do |line|"},{"line_number":735,"context_line":"          expect(chef_run).to render_file(file.name).with_content(line)"},{"line_number":736,"context_line":"        end"},{"line_number":737,"context_line":"      end"},{"line_number":738,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_6aa8cf8d","line":735,"updated":"2015-05-19 06:57:59.000000000","message":"Make this section specific?","commit_id":"5a3804a9f26413069e052c1b838b03e72108d801"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1d0128bc66929b33d1cd5264b4935f80aaa2d21e","unresolved":false,"context_lines":[{"line_number":732,"context_line":"         /^scheduler_available_filters\u003dnova.scheduler.filters.all_filters$/,"},{"line_number":733,"context_line":"         /^scheduler_default_filters\u003dRetryFilter,AvailabilityZoneFilter,RamFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter$/"},{"line_number":734,"context_line":"        ].each do |line|"},{"line_number":735,"context_line":"          expect(chef_run).to render_file(file.name).with_content(line)"},{"line_number":736,"context_line":"        end"},{"line_number":737,"context_line":"      end"},{"line_number":738,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_ea3eff26","line":735,"in_reply_to":"7a016987_6aa8cf8d","updated":"2015-05-19 07:47:00.000000000","message":"Done","commit_id":"5a3804a9f26413069e052c1b838b03e72108d801"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e0ce03f80a2d450402f85f59de272c6f5ba0f893","unresolved":false,"context_lines":[{"line_number":737,"context_line":"      end"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"      it \u0027sets to use baremetal default attributes\u0027 do"},{"line_number":740,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d true"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        ["},{"line_number":743,"context_line":"          /^scheduler_use_baremetal_filters\u003dtrue$/,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7a016987_c595db88","line":740,"updated":"2015-05-26 14:40:35.000000000","message":"As stated before, would like to see an additional test that sets scheduler_use_baremetal_filters \u003d true AND overrides the other values like the ram_allocation_ratio and the reserved_host_memory_mb and the others.","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ac3453e7ef03b7c9897093d21e94b75344d3b127","unresolved":false,"context_lines":[{"line_number":737,"context_line":"      end"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"      it \u0027sets to use baremetal default attributes\u0027 do"},{"line_number":740,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027scheduler_use_baremetal_filters\u0027] \u003d true"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        ["},{"line_number":743,"context_line":"          /^scheduler_use_baremetal_filters\u003dtrue$/,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7a016987_2abdec01","line":740,"in_reply_to":"7a016987_c595db88","updated":"2015-06-01 07:15:06.000000000","message":"Done","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"}],"templates/default/nova.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a31fb67c65bfed3c796727ab044eba0777b6a773","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"##### SCHEDULER #####"},{"line_number":41,"context_line":"# Flag to decide whether to use baremetal_scheduler_default_filters or not (boolean value)."},{"line_number":42,"context_line":"scheduler_use_baremetal_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":"scheduler_manager\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_manager\"] %\u003e"},{"line_number":44,"context_line":"scheduler_driver\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_driver\"] %\u003e"},{"line_number":45,"context_line":"scheduler_available_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"available_filters\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"7a016987_aaec87f3","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":31},"updated":"2015-05-19 06:57:59.000000000","message":"What about also adding baremetal_scheduler_default_filters to be complete.\n\nAnd what about baremetal_scheduler_default_filters  or a default setting for scheduler_driver?","commit_id":"5a3804a9f26413069e052c1b838b03e72108d801"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1d0128bc66929b33d1cd5264b4935f80aaa2d21e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"##### SCHEDULER #####"},{"line_number":41,"context_line":"# Flag to decide whether to use baremetal_scheduler_default_filters or not (boolean value)."},{"line_number":42,"context_line":"scheduler_use_baremetal_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":"scheduler_manager\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_manager\"] %\u003e"},{"line_number":44,"context_line":"scheduler_driver\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_driver\"] %\u003e"},{"line_number":45,"context_line":"scheduler_available_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"available_filters\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"7a016987_8a142ba0","line":42,"in_reply_to":"7a016987_aaec87f3","updated":"2015-05-19 07:47:00.000000000","message":"Done","commit_id":"5a3804a9f26413069e052c1b838b03e72108d801"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9e0745b70eec79de8cc4ad19f4ce38a600c5ace6","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"##### SCHEDULER #####"},{"line_number":41,"context_line":"# Flag to decide whether to use baremetal_scheduler_default_filters or not (boolean value)."},{"line_number":42,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":"scheduler_use_baremetal_filters\u003dTrue"},{"line_number":44,"context_line":"# Which filter class names to use for filtering baremetal hosts when not specified in the request."},{"line_number":45,"context_line":"baremetal_scheduler_default_filters\u003d\u003c%\u003d @baremetal_scheduler_default_filters %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"7a016987_4b13c45b","line":42,"updated":"2015-05-19 22:44:19.000000000","message":"Is the if/else needed here?  why not just:\n\n\nscheduler_use_baremetal_filters\u003dnode[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"]\n\n\n\u003c% if node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e\n  baremetal_scheduler_default_filters\u003d\u003c%\u003d @baremetal_scheduler_default_filters %\u003e\n\u003c% end %\u003e","commit_id":"05588a9cd152ffb34fc29ef0e2d35b38b8b678a9"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1188cca355fee16b66ccc97c16b1b5a081a5db43","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"##### SCHEDULER #####"},{"line_number":41,"context_line":"# Flag to decide whether to use baremetal_scheduler_default_filters or not (boolean value)."},{"line_number":42,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":"scheduler_use_baremetal_filters\u003dTrue"},{"line_number":44,"context_line":"# Which filter class names to use for filtering baremetal hosts when not specified in the request."},{"line_number":45,"context_line":"baremetal_scheduler_default_filters\u003d\u003c%\u003d @baremetal_scheduler_default_filters %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"7a016987_1a575427","line":42,"in_reply_to":"7a016987_4b13c45b","updated":"2015-05-20 07:02:15.000000000","message":"yes, looks better, thanks.","commit_id":"05588a9cd152ffb34fc29ef0e2d35b38b8b678a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e0ce03f80a2d450402f85f59de272c6f5ba0f893","unresolved":false,"context_lines":[{"line_number":40,"context_line":"##### SCHEDULER #####"},{"line_number":41,"context_line":"# Flag to decide whether to use baremetal_scheduler_default_filters or not (boolean value)."},{"line_number":42,"context_line":"scheduler_use_baremetal_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":44,"context_line":"# Which filter class names to use for filtering baremetal hosts when not specified in the request."},{"line_number":45,"context_line":"baremetal_scheduler_default_filters\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027].join(\u0027,\u0027) %\u003e"},{"line_number":46,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":5,"id":"7a016987_c5c39b89","line":43,"updated":"2015-05-26 14:40:35.000000000","message":"No need for this logic, just like this baremetal value flow thru.  Less logic in the template is good.","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"ac3453e7ef03b7c9897093d21e94b75344d3b127","unresolved":false,"context_lines":[{"line_number":40,"context_line":"##### SCHEDULER #####"},{"line_number":41,"context_line":"# Flag to decide whether to use baremetal_scheduler_default_filters or not (boolean value)."},{"line_number":42,"context_line":"scheduler_use_baremetal_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":44,"context_line":"# Which filter class names to use for filtering baremetal hosts when not specified in the request."},{"line_number":45,"context_line":"baremetal_scheduler_default_filters\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027].join(\u0027,\u0027) %\u003e"},{"line_number":46,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":5,"id":"7a016987_cc8e7578","line":43,"in_reply_to":"7a016987_c5c39b89","updated":"2015-06-01 07:15:06.000000000","message":"this attribute is ironic-only, not like other attributes, so I think this logic is Ok.","commit_id":"ab418627e4546d5e9cd98bde184f80a2344153d7"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"f7eb3460bb515941e94d55890adaabff659cd095","unresolved":false,"context_lines":[{"line_number":40,"context_line":"##### SCHEDULER #####"},{"line_number":41,"context_line":"# Flag to decide whether to use baremetal_scheduler_default_filters or not (boolean value)."},{"line_number":42,"context_line":"scheduler_use_baremetal_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":44,"context_line":"# Which filter class names to use for filtering baremetal hosts when not specified in the request."},{"line_number":45,"context_line":"baremetal_scheduler_default_filters\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027].join(\u0027,\u0027) %\u003e"},{"line_number":46,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"7a016987_a2a8d220","line":43,"updated":"2015-06-01 15:26:25.000000000","message":"I guess the question I was trying to ask before was that if this logic was removed, and baremetal_default_filters are in the conf all the time, that would not be an issue, right?   If, yes, remove this unnecessary logic from template to keep it clean.","commit_id":"706109cbda9774c94c0343072851ad83879f85b9"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"5a5acf873ecb4e12fbe5410afddc1589967f9198","unresolved":false,"context_lines":[{"line_number":40,"context_line":"##### SCHEDULER #####"},{"line_number":41,"context_line":"# Flag to decide whether to use baremetal_scheduler_default_filters or not (boolean value)."},{"line_number":42,"context_line":"scheduler_use_baremetal_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_use_baremetal_filters\"] %\u003e"},{"line_number":44,"context_line":"# Which filter class names to use for filtering baremetal hosts when not specified in the request."},{"line_number":45,"context_line":"baremetal_scheduler_default_filters\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_scheduler_default_filters\u0027].join(\u0027,\u0027) %\u003e"},{"line_number":46,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"5afe65bd_e8567505","line":43,"in_reply_to":"7a016987_a2a8d220","updated":"2015-06-02 03:21:53.000000000","message":"got it, there is a bool attribute to control the baremetal filters . Thanks!","commit_id":"706109cbda9774c94c0343072851ad83879f85b9"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"181ccfdb49e6aaa550b12e3e37fbe4f9e35465c1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"scheduler_use_baremetal_filters\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"use_baremetal_filters\"] %\u003e"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Which filter class names to use for filtering baremetal hosts when not specified in the request."},{"line_number":45,"context_line":"baremetal_scheduler_default_filters\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027baremetal_default_filters\u0027].join(\u0027,\u0027) %\u003e"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"scheduler_manager\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_manager\"] %\u003e"},{"line_number":48,"context_line":"scheduler_driver\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"scheduler\"][\"scheduler_driver\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":11,"id":"5afe65bd_3f63a4b3","line":45,"updated":"2015-06-02 05:16:21.000000000","message":"You added two options, but the value one is use single quote, the other use double quote.","commit_id":"7025549aab50b564ee7b6830b04deb6a3154c5cb"}]}