)]}'
{"attributes/default.rb":[{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"7f85b0718a70578ea7c50511d9f788de200c91a4","unresolved":false,"context_lines":[{"line_number":347,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027cpu_mode\u0027] \u003d nil"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"# Sync virtual and real mouse cursors in Windows VMs (boolean value)"},{"line_number":350,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027use_usb_tablet\u0027] \u003d \u0027true\u0027"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027availability_zone\u0027] \u003d \u0027nova\u0027"},{"line_number":353,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027default_schedule_zone\u0027] \u003d \u0027nova\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa32b979_fe19e1d1","line":350,"updated":"2015-06-24 16:18:29.000000000","message":"Being that the default of this is commented out, i think this being false and defaulted false is a better.\n\nOtherwise we\u0027re adding something that isnt normally there.","commit_id":"90d90bf5c63aea60792ddf312484232157fa4c08"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"92ff498a96516a5c12c3d6b596873a222a4d6e50","unresolved":false,"context_lines":[{"line_number":347,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027cpu_mode\u0027] \u003d nil"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"# Sync virtual and real mouse cursors in Windows VMs (boolean value)"},{"line_number":350,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027use_usb_tablet\u0027] \u003d \u0027true\u0027"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027availability_zone\u0027] \u003d \u0027nova\u0027"},{"line_number":353,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027default_schedule_zone\u0027] \u003d \u0027nova\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa32b979_8d041718","line":350,"in_reply_to":"fa32b979_fe19e1d1","updated":"2015-06-25 01:26:30.000000000","message":"But the default value in nova is true. I think we should not change the upstream default behavior.","commit_id":"90d90bf5c63aea60792ddf312484232157fa4c08"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5690825ec99c0f5c8bd26cdfc1df8e30bfecd021","unresolved":false,"context_lines":[{"line_number":344,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027live_migration_flag\u0027] \u003d \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE,VIR_MIGRATE_PERSIST_DEST\u0027"},{"line_number":345,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027block_migration_flag\u0027] \u003d \u0027VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_NON_SHARED_INC\u0027"},{"line_number":346,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027live_migration_uri\u0027] \u003d \u0027qemu+tcp://%s/system\u0027"},{"line_number":347,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027cpu_mode\u0027] \u003d nil"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"# Sync virtual and real mouse cursors in Windows VMs (boolean value)"},{"line_number":350,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027use_usb_tablet\u0027] \u003d \u0027true\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa32b979_5bfd1807","line":347,"updated":"2015-06-26 14:53:48.000000000","message":"Please add a good description about what this is and what the valid values are.","commit_id":"95ff9e8bc67e6ceeb68f1b89fbd67bf6f7720e23"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"28ba4c927cc43a8427d505167173ffac149d2e0b","unresolved":false,"context_lines":[{"line_number":344,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027live_migration_flag\u0027] \u003d \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE,VIR_MIGRATE_PERSIST_DEST\u0027"},{"line_number":345,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027block_migration_flag\u0027] \u003d \u0027VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_NON_SHARED_INC\u0027"},{"line_number":346,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027live_migration_uri\u0027] \u003d \u0027qemu+tcp://%s/system\u0027"},{"line_number":347,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027cpu_mode\u0027] \u003d nil"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"# Sync virtual and real mouse cursors in Windows VMs (boolean value)"},{"line_number":350,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027use_usb_tablet\u0027] \u003d \u0027true\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba3cc151_5a55351b","line":347,"in_reply_to":"fa32b979_5bfd1807","updated":"2015-06-29 05:13:20.000000000","message":"Thanks Mark, I added more description of this attribute.","commit_id":"95ff9e8bc67e6ceeb68f1b89fbd67bf6f7720e23"}],"nova.conf.sample":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5690825ec99c0f5c8bd26cdfc1df8e30bfecd021","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa32b979_7b77bc9f","line":1,"updated":"2015-06-26 14:53:48.000000000","message":"I don\u0027t think we need this file included in the cookbooks","commit_id":"95ff9e8bc67e6ceeb68f1b89fbd67bf6f7720e23"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"28ba4c927cc43a8427d505167173ffac149d2e0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba3cc151_da48658a","line":1,"in_reply_to":"fa32b979_7b77bc9f","updated":"2015-06-29 05:13:20.000000000","message":"Sorry, I removed this file in the new patchset.","commit_id":"95ff9e8bc67e6ceeb68f1b89fbd67bf6f7720e23"}],"templates/default/nova.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5690825ec99c0f5c8bd26cdfc1df8e30bfecd021","unresolved":false,"context_lines":[{"line_number":628,"context_line":"# Deprecated group/name - [DEFAULT]/libvirt_cpu_mode"},{"line_number":629,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"libvirt\"][\"cpu_mode\"] -%\u003e"},{"line_number":630,"context_line":"cpu_mode\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"libvirt\"][\"cpu_mode\"] %\u003e"},{"line_number":631,"context_line":"\u003c% elsif node[\"openstack\"][\"compute\"][\"libvirt\"][\"virt_type\"] \u003d\u003d \"qemu\" -%\u003e"},{"line_number":632,"context_line":"cpu_mode\u003dnone"},{"line_number":633,"context_line":"\u003c% end -%\u003e"},{"line_number":634,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"fa32b979_5b80b849","line":631,"updated":"2015-06-26 14:53:48.000000000","message":"this logic should be clearly doc in the attributes file around the virt_type and the cpu_mode","commit_id":"95ff9e8bc67e6ceeb68f1b89fbd67bf6f7720e23"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"28ba4c927cc43a8427d505167173ffac149d2e0b","unresolved":false,"context_lines":[{"line_number":628,"context_line":"# Deprecated group/name - [DEFAULT]/libvirt_cpu_mode"},{"line_number":629,"context_line":"\u003c% if node[\"openstack\"][\"compute\"][\"libvirt\"][\"cpu_mode\"] -%\u003e"},{"line_number":630,"context_line":"cpu_mode\u003d\u003c%\u003d node[\"openstack\"][\"compute\"][\"libvirt\"][\"cpu_mode\"] %\u003e"},{"line_number":631,"context_line":"\u003c% elsif node[\"openstack\"][\"compute\"][\"libvirt\"][\"virt_type\"] \u003d\u003d \"qemu\" -%\u003e"},{"line_number":632,"context_line":"cpu_mode\u003dnone"},{"line_number":633,"context_line":"\u003c% end -%\u003e"},{"line_number":634,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"ba3cc151_9a22ddb8","line":631,"in_reply_to":"fa32b979_5b80b849","updated":"2015-06-29 05:13:20.000000000","message":"Thanks. I added the description in attribute file.","commit_id":"95ff9e8bc67e6ceeb68f1b89fbd67bf6f7720e23"}]}