)]}'
{"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"b6084a357423541acc50315ca7ecbb1b73d4f3f2","unresolved":false,"context_lines":[{"line_number":589,"context_line":"    \u0027nfs_packages\u0027 \u003d\u003e [\u0027nfs-common\u0027],"},{"line_number":590,"context_line":"    \u0027volume_packages\u0027 \u003d\u003e [\u0027sysfsutils\u0027, \u0027sg3-utils\u0027, \u0027multipath-tools\u0027],"},{"line_number":591,"context_line":"    \u0027docker_build_pkgs\u0027 \u003d\u003e [\u0027git\u0027, \u0027python-dev\u0027, \u0027gcc\u0027],"},{"line_number":592,"context_line":"    \u0027nova_powervm_packages\u0027 \u003d\u003e [\u0027git\u0027, \u0027python-dev\u0027, \u0027libxslt-dev\u0027],"},{"line_number":593,"context_line":"    \u0027package_overrides\u0027 \u003d\u003e \"-o Dpkg::Options::\u003d\u0027--force-confold\u0027 -o Dpkg::Options::\u003d\u0027--force-confdef\u0027\""},{"line_number":594,"context_line":"  }"},{"line_number":595,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da20952f_52e835b3","line":592,"updated":"2015-09-11 02:39:57.000000000","message":"can change to compute_powervm_packages to be consistent with the above.","commit_id":"550d9b9043b37b5dc973ec7eaa5ddc293f3572b4"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"09ddcb70fcb4e73448b4321877e0e9b6891b8ebe","unresolved":false,"context_lines":[{"line_number":589,"context_line":"    \u0027nfs_packages\u0027 \u003d\u003e [\u0027nfs-common\u0027],"},{"line_number":590,"context_line":"    \u0027volume_packages\u0027 \u003d\u003e [\u0027sysfsutils\u0027, \u0027sg3-utils\u0027, \u0027multipath-tools\u0027],"},{"line_number":591,"context_line":"    \u0027docker_build_pkgs\u0027 \u003d\u003e [\u0027git\u0027, \u0027python-dev\u0027, \u0027gcc\u0027],"},{"line_number":592,"context_line":"    \u0027nova_powervm_packages\u0027 \u003d\u003e [\u0027git\u0027, \u0027python-dev\u0027, \u0027libxslt-dev\u0027],"},{"line_number":593,"context_line":"    \u0027package_overrides\u0027 \u003d\u003e \"-o Dpkg::Options::\u003d\u0027--force-confold\u0027 -o Dpkg::Options::\u003d\u0027--force-confdef\u0027\""},{"line_number":594,"context_line":"  }"},{"line_number":595,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a1a9d01_15825ac8","line":592,"in_reply_to":"da20952f_52e835b3","updated":"2015-09-30 14:27:08.000000000","message":"Done","commit_id":"550d9b9043b37b5dc973ec7eaa5ddc293f3572b4"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"0563737889194b00acb021ea437abcdd40e95554","unresolved":false,"context_lines":[{"line_number":731,"context_line":"# Setting this attribute to false will require use of the apt repository attribute"},{"line_number":732,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027download_from_source\u0027] \u003d true"},{"line_number":733,"context_line":"# github repository from which nova-powervm source will be downloaded"},{"line_number":734,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027nova-powervm\u0027][\u0027git_repository\u0027] \u003d \u0027https://github.com/stackforge/nova-powervm\u0027"},{"line_number":735,"context_line":"# github repository from which pypowervm source will be downloaded"},{"line_number":736,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027pypowervm\u0027][\u0027git_repository\u0027] \u003d \u0027https://github.com/pypowervm/pypowervm\u0027"},{"line_number":737,"context_line":"# apt repository from which nova-powervm packages will be downloaded"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba15a1d1_135eb476","line":734,"updated":"2015-09-20 13:40:49.000000000","message":"Should this point to github or instead the openstack git?  git://git.openstack.org/stackforge/nova-powervm.git","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"db753143663f77c95d9c834acb44af5440f27613","unresolved":false,"context_lines":[{"line_number":731,"context_line":"# Setting this attribute to false will require use of the apt repository attribute"},{"line_number":732,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027download_from_source\u0027] \u003d true"},{"line_number":733,"context_line":"# github repository from which nova-powervm source will be downloaded"},{"line_number":734,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027nova-powervm\u0027][\u0027git_repository\u0027] \u003d \u0027https://github.com/stackforge/nova-powervm\u0027"},{"line_number":735,"context_line":"# github repository from which pypowervm source will be downloaded"},{"line_number":736,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027pypowervm\u0027][\u0027git_repository\u0027] \u003d \u0027https://github.com/pypowervm/pypowervm\u0027"},{"line_number":737,"context_line":"# apt repository from which nova-powervm packages will be downloaded"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a1a9d01_f5000636","line":734,"in_reply_to":"ba15a1d1_135eb476","updated":"2015-09-30 14:26:55.000000000","message":"Done","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5a725847fadce33d9454e7c8672e5a46a2f0897a","unresolved":false,"context_lines":[{"line_number":741,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027distribution\u0027] \u003d nil"},{"line_number":742,"context_line":"# uri to gpg key"},{"line_number":743,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027key\u0027] \u003d nil"},{"line_number":744,"context_line":"# defaut packages for the PowerVM Nova compute"},{"line_number":745,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027packages\u0027] \u003d [\u0027pypowervm\u0027, \u0027nova-powervm\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba15a1d1_16af3082","line":744,"updated":"2015-09-15 19:03:28.000000000","message":"this comment should be more clear, this are the default packages from the apt repo defined directly above, not generic platform packages.","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"db753143663f77c95d9c834acb44af5440f27613","unresolved":false,"context_lines":[{"line_number":741,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027distribution\u0027] \u003d nil"},{"line_number":742,"context_line":"# uri to gpg key"},{"line_number":743,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027key\u0027] \u003d nil"},{"line_number":744,"context_line":"# defaut packages for the PowerVM Nova compute"},{"line_number":745,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027packages\u0027] \u003d [\u0027pypowervm\u0027, \u0027nova-powervm\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a1a9d01_b5f60e5b","line":744,"in_reply_to":"ba15a1d1_16af3082","updated":"2015-09-30 14:26:55.000000000","message":"Done","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5a725847fadce33d9454e7c8672e5a46a2f0897a","unresolved":false,"context_lines":[{"line_number":742,"context_line":"# uri to gpg key"},{"line_number":743,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027key\u0027] \u003d nil"},{"line_number":744,"context_line":"# defaut packages for the PowerVM Nova compute"},{"line_number":745,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027packages\u0027] \u003d [\u0027pypowervm\u0027, \u0027nova-powervm\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba15a1d1_7679cc2e","line":745,"updated":"2015-09-15 19:03:28.000000000","message":"Maybe for clarification, this should be: openstack  powervm apt packages since this is directly tied to the apt keys above and NOT to the more generic platform packages above (#592).","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"db753143663f77c95d9c834acb44af5440f27613","unresolved":false,"context_lines":[{"line_number":742,"context_line":"# uri to gpg key"},{"line_number":743,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027key\u0027] \u003d nil"},{"line_number":744,"context_line":"# defaut packages for the PowerVM Nova compute"},{"line_number":745,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027packages\u0027] \u003d [\u0027pypowervm\u0027, \u0027nova-powervm\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a1a9d01_759b9618","line":745,"in_reply_to":"ba15a1d1_7679cc2e","updated":"2015-09-30 14:26:55.000000000","message":"Done","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"}],"recipes/compute.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"b6084a357423541acc50315ca7ecbb1b73d4f3f2","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027enable\u0027]"},{"line_number":31,"context_line":"  include_recipe \u0027openstack-compute::powervm-setup\u0027"},{"line_number":32,"context_line":"end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"include_recipe \u0027openstack-compute::nova-common\u0027"},{"line_number":35,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027enabled_apis\u0027].include?(\u0027metadata\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da20952f_759be3c9","line":32,"updated":"2015-09-11 02:39:57.000000000","message":"please add spec for this changein compute_spec.rb","commit_id":"550d9b9043b37b5dc973ec7eaa5ddc293f3572b4"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"09ddcb70fcb4e73448b4321877e0e9b6891b8ebe","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027enable\u0027]"},{"line_number":31,"context_line":"  include_recipe \u0027openstack-compute::powervm-setup\u0027"},{"line_number":32,"context_line":"end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"include_recipe \u0027openstack-compute::nova-common\u0027"},{"line_number":35,"context_line":"if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027enabled_apis\u0027].include?(\u0027metadata\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a1a9d01_75663652","line":32,"in_reply_to":"da20952f_759be3c9","updated":"2015-09-30 14:27:08.000000000","message":"Done","commit_id":"550d9b9043b37b5dc973ec7eaa5ddc293f3572b4"}],"recipes/powervm-setup.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"b6084a357423541acc50315ca7ecbb1b73d4f3f2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    package \u0027pypowervm, nova-powervm\u0027 do"},{"line_number":78,"context_line":"      action :upgrade"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"  when \u0027redhat\u0027"},{"line_number":81,"context_line":"    Chef::Log.warn(\u0027Other distribution currently not supported\u0027)"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da20952f_f541333a","line":80,"updated":"2015-09-11 02:39:57.000000000","message":"I think there should be \"rhel \" platform_family.","commit_id":"550d9b9043b37b5dc973ec7eaa5ddc293f3572b4"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"09ddcb70fcb4e73448b4321877e0e9b6891b8ebe","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    package \u0027pypowervm, nova-powervm\u0027 do"},{"line_number":78,"context_line":"      action :upgrade"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"  when \u0027redhat\u0027"},{"line_number":81,"context_line":"    Chef::Log.warn(\u0027Other distribution currently not supported\u0027)"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a1a9d01_d5de22dc","line":80,"in_reply_to":"da20952f_f541333a","updated":"2015-09-30 14:27:08.000000000","message":"Done","commit_id":"550d9b9043b37b5dc973ec7eaa5ddc293f3572b4"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"b6084a357423541acc50315ca7ecbb1b73d4f3f2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      action :upgrade"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"  when \u0027redhat\u0027"},{"line_number":81,"context_line":"    Chef::Log.warn(\u0027Other distribution currently not supported\u0027)"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"da20952f_f56853bc","line":81,"updated":"2015-09-11 02:39:57.000000000","message":"the log message is not right about other distr,  how about fedora, suse...","commit_id":"550d9b9043b37b5dc973ec7eaa5ddc293f3572b4"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"09ddcb70fcb4e73448b4321877e0e9b6891b8ebe","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      action :upgrade"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"  when \u0027redhat\u0027"},{"line_number":81,"context_line":"    Chef::Log.warn(\u0027Other distribution currently not supported\u0027)"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a1a9d01_95e42aac","line":81,"in_reply_to":"da20952f_f56853bc","updated":"2015-09-30 14:27:08.000000000","message":"Done","commit_id":"550d9b9043b37b5dc973ec7eaa5ddc293f3572b4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"6de355531ced9dd0937405e700f8b87740cf3796","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   License for the specific language governing permissions and limitations"},{"line_number":18,"context_line":"#   under the License."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"include_recipe \u0027python::pip\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# set nova PowerVM driver as the compute driver"},{"line_number":23,"context_line":"node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027driver\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027driver\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da20952f_3116bf49","line":20,"updated":"2015-09-11 18:56:36.000000000","message":"Isn\u0027t this only needed in the \u0027download_from_source\u0027 case below?  and therefore should be moved to around line 53?","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"3da7fb28beb29b9486b8f6da507c548c1e02a051","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   License for the specific language governing permissions and limitations"},{"line_number":18,"context_line":"#   under the License."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"include_recipe \u0027python::pip\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# set nova PowerVM driver as the compute driver"},{"line_number":23,"context_line":"node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027driver\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027driver\u0027]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a1a9d01_75e396d9","line":20,"in_reply_to":"da20952f_3116bf49","updated":"2015-09-30 14:27:03.000000000","message":"Done","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"6de355531ced9dd0937405e700f8b87740cf3796","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    execute \u0027apt-get-update\u0027 do"},{"line_number":73,"context_line":"      command \u0027apt-get update\u0027"},{"line_number":74,"context_line":"      ignore_failure true"},{"line_number":75,"context_line":"      action :nothing"},{"line_number":76,"context_line":"    end"},{"line_number":77,"context_line":"    package \u0027pypowervm, nova-powervm\u0027 do"},{"line_number":78,"context_line":"      action :upgrade"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da20952f_b1572f00","line":75,"updated":"2015-09-11 18:56:36.000000000","message":"action is nothing, I dont see a notify to run this action anywhere, is this really needed?","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"3da7fb28beb29b9486b8f6da507c548c1e02a051","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    execute \u0027apt-get-update\u0027 do"},{"line_number":73,"context_line":"      command \u0027apt-get update\u0027"},{"line_number":74,"context_line":"      ignore_failure true"},{"line_number":75,"context_line":"      action :nothing"},{"line_number":76,"context_line":"    end"},{"line_number":77,"context_line":"    package \u0027pypowervm, nova-powervm\u0027 do"},{"line_number":78,"context_line":"      action :upgrade"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a1a9d01_35e99eb7","line":75,"in_reply_to":"da20952f_b1572f00","updated":"2015-09-30 14:27:03.000000000","message":"Done","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"6de355531ced9dd0937405e700f8b87740cf3796","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      ignore_failure true"},{"line_number":75,"context_line":"      action :nothing"},{"line_number":76,"context_line":"    end"},{"line_number":77,"context_line":"    package \u0027pypowervm, nova-powervm\u0027 do"},{"line_number":78,"context_line":"      action :upgrade"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"  when \u0027rhel\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da20952f_9169cbc2","line":77,"updated":"2015-09-11 18:56:36.000000000","message":"Shouldn\u0027t this package list come from attributes like other platform packages?\n\nAnd for ubuntu should have the package options specified","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"3da7fb28beb29b9486b8f6da507c548c1e02a051","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      ignore_failure true"},{"line_number":75,"context_line":"      action :nothing"},{"line_number":76,"context_line":"    end"},{"line_number":77,"context_line":"    package \u0027pypowervm, nova-powervm\u0027 do"},{"line_number":78,"context_line":"      action :upgrade"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"  when \u0027rhel\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a1a9d01_d5d4e2ec","line":77,"in_reply_to":"da20952f_9169cbc2","updated":"2015-09-30 14:27:03.000000000","message":"Done","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"45f1779932e87f8ff1d46374137e03d4cf6a51ab","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    package \u0027pypowervm, nova-powervm\u0027 do"},{"line_number":78,"context_line":"      action :upgrade"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"  when \u0027rhel\u0027"},{"line_number":81,"context_line":"    Chef::Log.warn(\u0027Rhel distribution is currently not supported\u0027)"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba15a1d1_99542555","line":80,"updated":"2015-09-14 08:28:31.000000000","message":"I also think there should be \u0027fedora\u0027, \u0027rhel\u0027, \u0027suse\u0027 , since keep same with the attributes file.","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"3da7fb28beb29b9486b8f6da507c548c1e02a051","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    package \u0027pypowervm, nova-powervm\u0027 do"},{"line_number":78,"context_line":"      action :upgrade"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"  when \u0027rhel\u0027"},{"line_number":81,"context_line":"    Chef::Log.warn(\u0027Rhel distribution is currently not supported\u0027)"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a1a9d01_3500be65","line":80,"in_reply_to":"ba15a1d1_99542555","updated":"2015-09-30 14:27:03.000000000","message":"Done","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5a725847fadce33d9454e7c8672e5a46a2f0897a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":"  else"},{"line_number":63,"context_line":"    Chef::Log.info(\u0027Install nova-powervm from apt repo\u0027)"},{"line_number":64,"context_line":"    apt_repository \u0027powervm\u0027 do"},{"line_number":65,"context_line":"      uri node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027uri\u0027]"},{"line_number":66,"context_line":"      distribution node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027distribution\u0027]"},{"line_number":67,"context_line":"      components [\u0027main\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba15a1d1_d6645823","line":64,"updated":"2015-09-15 19:03:28.000000000","message":"This is a new dependency for the compute cookbook, need to add \"depends \u0027apt\u0027, \u0027~\u003e 2.8\u0027     (2.8 or higher is the newer version we are just now moving up to, see the other patches in the queue.","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"db753143663f77c95d9c834acb44af5440f27613","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":"  else"},{"line_number":63,"context_line":"    Chef::Log.info(\u0027Install nova-powervm from apt repo\u0027)"},{"line_number":64,"context_line":"    apt_repository \u0027powervm\u0027 do"},{"line_number":65,"context_line":"      uri node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027uri\u0027]"},{"line_number":66,"context_line":"      distribution node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027distribution\u0027]"},{"line_number":67,"context_line":"      components [\u0027main\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a1a9d01_159eda06","line":64,"in_reply_to":"ba15a1d1_d6645823","updated":"2015-09-30 14:26:55.000000000","message":"Done","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5a725847fadce33d9454e7c8672e5a46a2f0897a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      key node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027key\u0027]"},{"line_number":69,"context_line":"      action :add"},{"line_number":70,"context_line":"    end"},{"line_number":71,"context_line":"    execute \u0027apt-get-update\u0027 do"},{"line_number":72,"context_line":"      command \u0027apt-get update\u0027"},{"line_number":73,"context_line":"      ignore_failure true"},{"line_number":74,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba15a1d1_96e90083","line":71,"updated":"2015-09-15 19:03:28.000000000","message":"This does not look right, should not need to use the execute/shell command for this when there is a apt-repo added, see https://github.com/chef-cookbooks/apt#apt_repository","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"db753143663f77c95d9c834acb44af5440f27613","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      key node[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027apt\u0027][\u0027key\u0027]"},{"line_number":69,"context_line":"      action :add"},{"line_number":70,"context_line":"    end"},{"line_number":71,"context_line":"    execute \u0027apt-get-update\u0027 do"},{"line_number":72,"context_line":"      command \u0027apt-get update\u0027"},{"line_number":73,"context_line":"      ignore_failure true"},{"line_number":74,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a1a9d01_35a19e46","line":71,"in_reply_to":"ba15a1d1_96e90083","updated":"2015-09-30 14:26:55.000000000","message":"Done","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5a725847fadce33d9454e7c8672e5a46a2f0897a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    end"},{"line_number":81,"context_line":"  end"},{"line_number":82,"context_line":"when \u0027rhel\u0027, \u0027fedora\u0027, \u0027suse\u0027"},{"line_number":83,"context_line":"  log \"\u0027#{node[\u0027platform_family\u0027]}\u0027 is not supported!\" do"},{"line_number":84,"context_line":"    level :error"},{"line_number":85,"context_line":"  end"},{"line_number":86,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba15a1d1_36efd4b1","line":83,"updated":"2015-09-15 19:03:28.000000000","message":"Maybe a bit more verbose, \"PowerVM compute driver is not support on platform: \u0027#{node[\u0027platform_family\u0027]}\u0027","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"db753143663f77c95d9c834acb44af5440f27613","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    end"},{"line_number":81,"context_line":"  end"},{"line_number":82,"context_line":"when \u0027rhel\u0027, \u0027fedora\u0027, \u0027suse\u0027"},{"line_number":83,"context_line":"  log \"\u0027#{node[\u0027platform_family\u0027]}\u0027 is not supported!\" do"},{"line_number":84,"context_line":"    level :error"},{"line_number":85,"context_line":"  end"},{"line_number":86,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a1a9d01_d58ce2db","line":83,"in_reply_to":"ba15a1d1_36efd4b1","updated":"2015-09-30 14:26:55.000000000","message":"Done","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"}],"spec/powervm-setup_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"6de355531ced9dd0937405e700f8b87740cf3796","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      expect(chef_run.node[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027force_config_drive\u0027]).to eq(\u0027True\u0027)"},{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    context \u0027download from source\u0027 do"},{"line_number":33,"context_line":"      before do"},{"line_number":34,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027download_from_source\u0027] \u003d true"},{"line_number":35,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"da20952f_b17c0f72","line":32,"updated":"2015-09-11 18:56:36.000000000","message":"Need tests for apt package install\nand need separate test for rhel to show unsupported case.","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"3da7fb28beb29b9486b8f6da507c548c1e02a051","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      expect(chef_run.node[\u0027openstack\u0027][\u0027compute\u0027][\u0027config\u0027][\u0027force_config_drive\u0027]).to eq(\u0027True\u0027)"},{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    context \u0027download from source\u0027 do"},{"line_number":33,"context_line":"      before do"},{"line_number":34,"context_line":"        node.set[\u0027openstack\u0027][\u0027compute\u0027][\u0027powervm\u0027][\u0027download_from_source\u0027] \u003d true"},{"line_number":35,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a1a9d01_95f18a97","line":32,"in_reply_to":"da20952f_b17c0f72","updated":"2015-09-30 14:27:03.000000000","message":"Done","commit_id":"33a20106a2505dc4e2cfc0b651575d1ec04a7f58"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"0563737889194b00acb021ea437abcdd40e95554","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      end"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"      it \u0027syncs a git with pypowervm git repo\u0027 do"},{"line_number":46,"context_line":"        expect(chef_run).to sync_git(git_nova_local_dir).with(repository: \u0027https://github.com/stackforge/nova-powervm\u0027)"},{"line_number":47,"context_line":"      end"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"      it \u0027installs pypowervm package\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba15a1d1_b353486c","line":46,"updated":"2015-09-20 13:40:49.000000000","message":"See note earlier.  Shoudl this be the openstack git URI instead?","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"},{"author":{"_account_id":14221,"name":"Dominique Clain","email":"dclain@us.ibm.com","username":"dclain"},"change_message_id":"db753143663f77c95d9c834acb44af5440f27613","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      end"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"      it \u0027syncs a git with pypowervm git repo\u0027 do"},{"line_number":46,"context_line":"        expect(chef_run).to sync_git(git_nova_local_dir).with(repository: \u0027https://github.com/stackforge/nova-powervm\u0027)"},{"line_number":47,"context_line":"      end"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"      it \u0027installs pypowervm package\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a1a9d01_f587a6b2","line":46,"in_reply_to":"ba15a1d1_b353486c","updated":"2015-09-30 14:26:55.000000000","message":"Done","commit_id":"c3ae13432b89e16c1d97d5ea2291cd140c7afabe"}]}