)]}'
{"Berksfile":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"b1a535383255412b73727116ca0b48f22b9c277f","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"metadata"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"cookbook \"openstack-bare-metal\","},{"line_number":6,"context_line":"  github: \"openstack/cookbook-openstack-bare-metal\""},{"line_number":7,"context_line":"cookbook \"openstack-image\","},{"line_number":8,"context_line":"  github: \"openstack/cookbook-openstack-image\""}],"source_content_type":"application/octet-stream","patch_set":18,"id":"5a5ae5dd_ed3db9dd","side":"PARENT","line":5,"updated":"2016-02-05 17:20:30.000000000","message":"This is on the TODO list to patch back in?","commit_id":"a7ce50ea7a1a81f4204d5ca39eafe1f125560a89"}],"attributes/nova_conf.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":2,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf_secrets\u0027] \u003d {}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":5,"context_line":"  ###### comments after attributes are defaults from openstack docs"},{"line_number":6,"context_line":"  # [DEFAULT] section"},{"line_number":7,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027verbose\u0027] \u003d false # true"},{"line_number":8,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027log_dir\u0027] \u003d \u0027/var/log/nova\u0027 # none"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_29b1c28f","line":5,"updated":"2016-01-08 16:30:29.000000000","message":"Should be we ref\u0027ing the doc\u0027s here or just going straight to the code?","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # [DEFAULT] section"},{"line_number":7,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027verbose\u0027] \u003d false # true"},{"line_number":8,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027log_dir\u0027] \u003d \u0027/var/log/nova\u0027 # none"},{"line_number":9,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027remove_unused_original_minimum_age_seconds\u0027] \u003d 3600 # 86400"},{"line_number":10,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027default_schedule_zone\u0027] \u003d \u0027nova\u0027 # none"},{"line_number":11,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027vlan_interface\u0027] \u003d \u0027eth0\u0027 # none"},{"line_number":12,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027force_raw_images\u0027] \u003d false # true"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_69449a73","line":9,"updated":"2016-01-08 16:30:29.000000000","message":"why not use default here?","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027state_path\u0027] \u003d \u0027/var/lib/nova\u0027"},{"line_number":17,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027admin_user\u0027] \u003d \u0027nova\u0027 # none"},{"line_number":18,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027admin_tenant_name\u0027] \u003d \u0027service\u0027 # none"},{"line_number":19,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027admin_username\u0027] \u003d \u0027ironic\u0027 # none"},{"line_number":20,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027admin_tenant_name\u0027] \u003d \u0027service\u0027 # none"},{"line_number":21,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027compute_driver\u0027] \u003d \u0027libvirt.LibvirtDriver\u0027 # none"},{"line_number":22,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027connection_type\u0027] \u003d \u0027libvirt\u0027 # static! not listed"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_8970eedd","line":19,"updated":"2016-01-08 16:30:29.000000000","message":"this seems wrong?","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027auth_version\u0027] \u003d node[\u0027openstack\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027] # none"},{"line_number":24,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027rpc_backend\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027rpc_backend\u0027]"},{"line_number":25,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027instances_path\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027][\u0027DEFAULT\u0027][\u0027state_path\u0027]}/instances\""},{"line_number":26,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027enabled_apis\u0027] \u003d \u0027ec2,osapi_compute\u0027"},{"line_number":27,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027default_availability_zone\u0027] \u003d \u0027nova\u0027"},{"line_number":28,"context_line":"  if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027use\u0027] #\u003d false"},{"line_number":29,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027log_config\u0027] \u003d \u0027/etc/openstack/logging.conf\u0027"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_092b9e95","line":26,"updated":"2016-01-08 16:30:29.000000000","message":"I would vote that ec2 should not be part of our defaults, it\u0027s slowly being pushed out of core openstack.","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027dns_server\u0027] \u003d \u00278.8.8.8\u0027 # [] in docs"},{"line_number":45,"context_line":"  when \u0027nova\u0027"},{"line_number":46,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027multi_host\u0027] \u003d false"},{"line_number":47,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027network_manager\u0027] \u003d \u0027nova.network.manager.FlatDHCPManager\u0027 # nova.network.manager.VlanManager"},{"line_number":48,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027public_interface\u0027] \u003d \u0027eth0\u0027"},{"line_number":49,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027dmz_cidr\u0027] \u003d \u002710.128.0.0/24\u0027 # nil"},{"line_number":50,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027force_dhcp_release\u0027] \u003d true"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_c4d32b5e","line":47,"updated":"2016-01-08 16:30:29.000000000","message":"should be switch to vlan now?","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027dmz_cidr\u0027] \u003d \u002710.128.0.0/24\u0027 # nil"},{"line_number":50,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027force_dhcp_release\u0027] \u003d true"},{"line_number":51,"context_line":"    if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027dhcp_domain\u0027] # novalocal"},{"line_number":52,"context_line":"      conf[\u0027DEFAULT\u0027][\u0027dhcp_domain\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027dhcp_domain\u0027]"},{"line_number":53,"context_line":"    end"},{"line_number":54,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027send_arp_for_ha\u0027] \u003d true # false"},{"line_number":55,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027use_single_default_gateway\u0027] \u003d false"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_64a59f02","line":52,"updated":"2016-01-08 16:30:29.000000000","message":"Why a separate key needed for this?","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027admin_user\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027service_user\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  # [libvirt] section"},{"line_number":67,"context_line":"  conf[\u0027libvirt\u0027][\u0027virt_type\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027virt_type\u0027]"},{"line_number":68,"context_line":"  conf[\u0027libvirt\u0027][\u0027images_type\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027images_type\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027images_type\u0027] \u003d\u003d \u0027lvm\u0027"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_64583ffb","line":67,"updated":"2016-01-08 16:30:29.000000000","message":"separate keys still needed for these two?","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"}],"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"b1a535383255412b73727116ca0b48f22b9c277f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"recipe \u0027openstack-compute::vncproxy\u0027, \u0027Installs and configures the vncproxy service for console access to VMs\u0027"},{"line_number":24,"context_line":"recipe \u0027openstack-compute::serialproxy\u0027, \u0027Installs and configures the serialproxy service for serial console access to VMs\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"%w(ubuntu fedora redhat centos).each do |os|"},{"line_number":27,"context_line":"  supports os"},{"line_number":28,"context_line":"end"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_c806ab1b","line":26,"updated":"2016-02-05 17:20:30.000000000","message":"be consistent with Common, remove fedora","commit_id":"f826afefd60f86dcc8941c387d337e555826e293"},{"author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"change_message_id":"b8f67f1316e3fe17626a39c0583611320db18619","unresolved":false,"context_lines":[{"line_number":23,"context_line":"recipe \u0027openstack-compute::vncproxy\u0027, \u0027Installs and configures the vncproxy service for console access to VMs\u0027"},{"line_number":24,"context_line":"recipe \u0027openstack-compute::serialproxy\u0027, \u0027Installs and configures the serialproxy service for serial console access to VMs\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"%w(ubuntu fedora redhat centos).each do |os|"},{"line_number":27,"context_line":"  supports os"},{"line_number":28,"context_line":"end"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_4a34bc48","line":26,"in_reply_to":"5a5ae5dd_c806ab1b","updated":"2016-02-08 14:06:46.000000000","message":"Done","commit_id":"f826afefd60f86dcc8941c387d337e555826e293"}],"recipes/nova-common.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1d2bae25fd3b719b7cee90c016c4f56fce370bfa","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# delete all secrets saved in the attribute"},{"line_number":251,"context_line":"# node[\u0027openstack\u0027][\u0027network\u0027][\u0027conf\u0027][\u0027secrets\u0027] after creating the neutron.conf"},{"line_number":252,"context_line":"ruby_block \"delete all attributes in node[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027][\u0027secrets\u0027]\" do"},{"line_number":253,"context_line":"  block do"},{"line_number":254,"context_line":"    node.rm(:openstack, :compute, :conf_secrets)"},{"line_number":255,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"fa69d971_ad9b6c71","line":252,"updated":"2016-01-04 21:03:54.000000000","message":"Just a thought, would it be possible to move this logic into the template itself as a \"cleanup\" set at the end?\n\nMaybe we also need to consider if a wrapper cookbook might need these values, so would need to do this at the \"end\" of the compile or converge.","commit_id":"e4d8cf93152d301ff6dd61173da7e653e25b1a86"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# limitations under the License."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# activesupport currently needs to be upgraded, since the one used in"},{"line_number":24,"context_line":"# chef 12 is too old (3.2.19) and does not include the needed deep_merge"},{"line_number":25,"context_line":"chef_gem \u0027activesupport\u0027 do"},{"line_number":26,"context_line":"  action :upgrade"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_2421e74d","line":23,"updated":"2016-01-08 16:30:29.000000000","message":"As stated in other patches, would like to see this tracked as a bug, and doc that fact here so this can be removed once the bug is fixed (newer chef version and/or push this in the Common library included below).","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"efc0e8d14ce086933fef628aad0b49ad36293623","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"mq_service_type \u003d node[\u0027openstack\u0027][\u0027mq\u0027][\u0027compute\u0027][\u0027service_type\u0027]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"if mq_service_type \u003d\u003d \u0027rabbitmq\u0027 || mq_service_type \u003d\u003d \u0027rabbit\u0027"},{"line_number":95,"context_line":"  mq_service_type \u003d \u0027rabbit\u0027 # needs to be set for nova_secret logic"},{"line_number":96,"context_line":"  node[\u0027openstack\u0027][\u0027mq\u0027][\u0027compute\u0027][\u0027rabbit\u0027][\u0027ha\u0027] \u0026\u0026 (rabbit_hosts \u003d rabbit_servers)"},{"line_number":97,"context_line":"  mq_password \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027mq\u0027][\u0027compute\u0027][\u0027rabbit\u0027][\u0027userid\u0027]"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_c4d6cb26","line":94,"updated":"2016-01-08 16:30:29.000000000","message":"use .include?(\u0027rabbit\u0027) for these cases?","commit_id":"d117aeeba508feb0bcd9ff1e2c38f3720f3c0305"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"b1a535383255412b73727116ca0b48f22b9c277f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# limitations under the License."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# activesupport currently needs to be upgraded, since the one used in"},{"line_number":24,"context_line":"# chef 12 is too old (3.2.19) and does not include the needed deep_merge"},{"line_number":25,"context_line":"require \u0027uri\u0027"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_48607bcf","line":23,"updated":"2016-02-05 17:20:30.000000000","message":"can be removed now?  or just leave on todo list?","commit_id":"f826afefd60f86dcc8941c387d337e555826e293"},{"author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"change_message_id":"b8f67f1316e3fe17626a39c0583611320db18619","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# limitations under the License."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# activesupport currently needs to be upgraded, since the one used in"},{"line_number":24,"context_line":"# chef 12 is too old (3.2.19) and does not include the needed deep_merge"},{"line_number":25,"context_line":"require \u0027uri\u0027"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":18,"id":"5a5ae5dd_4afd9c6c","line":23,"in_reply_to":"5a5ae5dd_48607bcf","updated":"2016-02-08 14:06:46.000000000","message":"Done","commit_id":"f826afefd60f86dcc8941c387d337e555826e293"}],"templates/default/nova.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1d2bae25fd3b719b7cee90c016c4f56fce370bfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c%\u003d node[\"openstack\"][\"compute\"][\"custom_template_banner\"] %\u003e"},{"line_number":2,"context_line":"\u003c% @service_config.each do |section, values| -%\u003e"},{"line_number":3,"context_line":"[\u003c%\u003d section %\u003e]"},{"line_number":4,"context_line":"  \u003c% values.each do |key, value| -%\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"fa69d971_ad4a8caa","line":1,"updated":"2016-01-04 21:03:54.000000000","message":"If all these templates are going to be the same, why not just have one copy in Common and pull that in with the Template resource cookbook property?   This would be done in the recipe and this file is no longer needed then.\n\nOr do it here, use partial templates:\n\n\u003c%\u003d render \"partial_name.txt.erb\", :option \u003d\u003e {cookbook\u003dcommon} %\u003e","commit_id":"e4d8cf93152d301ff6dd61173da7e653e25b1a86"}]}