)]}'
{"templates/default/wsgi-template.conf.erb":[{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"e5e138e91ff84add28d239835d0b9c1b42ee9da3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c%\u003d node[\"openstack\"][\"compute\"][\"custom_template_banner\"] %\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Listen \u003c%\u003d @params[:server_host] %\u003e:\u003c%\u003d @params[:server_port] %\u003e"},{"line_number":4,"context_line":""}],"source_content_type":"application/x-erb","patch_set":2,"id":"da36d5c6_1ae320da","line":1,"updated":"2017-02-26 15:30:47.000000000","message":"I think node attribute callouts like this should be single quotes, so as to not force Ruby to evaluate for performance reasons","commit_id":"6e13b20ffc6223ce1b80f206c46f7638bff615b2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9bcf15dc9ba32a889fd5eac782d565a674e46edf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c%\u003d node[\"openstack\"][\"compute\"][\"custom_template_banner\"] %\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Listen \u003c%\u003d @params[:server_host] %\u003e:\u003c%\u003d @params[:server_port] %\u003e"},{"line_number":4,"context_line":""}],"source_content_type":"application/x-erb","patch_set":2,"id":"da36d5c6_fa148ca0","line":1,"in_reply_to":"da36d5c6_1ae320da","updated":"2017-02-26 15:40:07.000000000","message":"Well, this is copied 1:1 from https://review.openstack.org/402743 which you approved. ;)\n\nI don\u0027t mind changing it, but I think usage should also be consistent across the cookbooks.","commit_id":"6e13b20ffc6223ce1b80f206c46f7638bff615b2"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"6ac080f560f11a2f921407ac97da59b4f636ca6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c%\u003d node[\"openstack\"][\"compute\"][\"custom_template_banner\"] %\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Listen \u003c%\u003d @params[:server_host] %\u003e:\u003c%\u003d @params[:server_port] %\u003e"},{"line_number":4,"context_line":""}],"source_content_type":"application/x-erb","patch_set":2,"id":"da36d5c6_da48a8b5","line":1,"in_reply_to":"da36d5c6_fa148ca0","updated":"2017-02-26 15:52:01.000000000","message":"Fair enough. :D\n\nNot worth changing here and now, but eventually. I\u0027ll distill some thoughts into a spec/bp.","commit_id":"6e13b20ffc6223ce1b80f206c46f7638bff615b2"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"a825ec06a796a5cdb598a855f31de33b8c694662","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c%\u003d node[\"openstack\"][\"compute\"][\"custom_template_banner\"] %\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Listen \u003c%\u003d @params[:server_host] %\u003e:\u003c%\u003d @params[:server_port] %\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cVirtualHost \u003c%\u003d @params[:server_host] %\u003e:\u003c%\u003d @params[:server_port] %\u003e\u003e"},{"line_number":6,"context_line":"  WSGIDaemonProcess \u003c%\u003d @params[:daemon_process] %\u003e processes\u003d2 threads\u003d10 user\u003d\u003c%\u003d @params[:user] %\u003e group\u003d\u003c%\u003d @params[:group] %\u003e display-name\u003d%{GROUP}"}],"source_content_type":"application/x-erb","patch_set":3,"id":"ba2be162_0eaf4f2c","line":3,"updated":"2017-03-06 16:57:22.000000000","message":"This Listen directive conflicts with ports.conf declarations, causing a strange-looking Apache crash on systemd-inclined deploys","commit_id":"dc339a859d377f040858f452ef7b824d226555fe"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"409243d520512a842ce5c94fd319f0b1af49ac6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c%\u003d node[\"openstack\"][\"compute\"][\"custom_template_banner\"] %\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Listen \u003c%\u003d @params[:server_host] %\u003e:\u003c%\u003d @params[:server_port] %\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cVirtualHost \u003c%\u003d @params[:server_host] %\u003e:\u003c%\u003d @params[:server_port] %\u003e\u003e"},{"line_number":6,"context_line":"  WSGIDaemonProcess \u003c%\u003d @params[:daemon_process] %\u003e processes\u003d2 threads\u003d10 user\u003d\u003c%\u003d @params[:user] %\u003e group\u003d\u003c%\u003d @params[:group] %\u003e display-name\u003d%{GROUP}"}],"source_content_type":"application/x-erb","patch_set":3,"id":"9a30ddce_104b6f88","line":3,"in_reply_to":"ba2be162_0eaf4f2c","updated":"2017-03-09 11:08:58.000000000","message":"Well, it does work for my Ubuntu deployment and in the CI test[1]. There are duplications in the Keystone and Ceilometer deployments, but that is a different issue.\n\n[1] http://ci.cloudbau.de/ci-logs/refs-changes-71-436971-3","commit_id":"dc339a859d377f040858f452ef7b824d226555fe"}]}