)]}'
{"attributes/libvirtd_conf.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"55db9ab5c1929cdfc52dd32b581c7ba73a22f7c2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027libvirtd_opts\u0027] \u003d \u0027-l\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027auth_tcp\u0027] \u003d \u0027none\u0027"},{"line_number":5,"context_line":"# libvirt.max_clients (default: 20)"},{"line_number":6,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027max_clients\u0027] \u003d 20"},{"line_number":7,"context_line":"# libvirt.max_workers (default: 20)"},{"line_number":8,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027max_workers\u0027] \u003d 20"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f6a8fd7_f2e5bc39","line":5,"updated":"2018-04-16 14:16:24.000000000","message":"I don\u0027t think that these comments add much value, remove them?","commit_id":"ad88dc2a782b648cac1ace2806222d781c0bce85"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"38e6551548628abf0f1443ee4c529fcc2aaaa5dc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027libvirtd_opts\u0027] \u003d \u0027-l\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027auth_tcp\u0027] \u003d \u0027none\u0027"},{"line_number":5,"context_line":"# libvirt.max_clients (default: 20)"},{"line_number":6,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027max_clients\u0027] \u003d 20"},{"line_number":7,"context_line":"# libvirt.max_workers (default: 20)"},{"line_number":8,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027libvirt\u0027][\u0027max_workers\u0027] \u003d 20"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f6a8fd7_55247bc6","line":5,"in_reply_to":"9f6a8fd7_f2e5bc39","updated":"2018-04-17 09:12:12.000000000","message":"In this step i just moved all the attributes (including the comments). In the next step we need to check if we actually need them (if these are the defaults anyway, we should not set them IMHO) and what can be removed without changing the functionality.","commit_id":"ad88dc2a782b648cac1ace2806222d781c0bce85"}]}
