)]}'
{"recipes/nova-common.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"26e7843890bfeccad9d9fc426b3dd4a1688f7a14","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027iscsi_helper\u0027] \u003d platform_options[\u0027iscsi_helper\u0027]"},{"line_number":156,"context_line":"  # conf[\u0027DEFAULT\u0027][\u0027scheduler_default_filters\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027default_filters\u0027].join(\u0027,\u0027)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  # if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027][\u0027DEFAULT\u0027][\u0027enabled_apis\u0027].include?(\u0027osapi_compute\u0027)"},{"line_number":159,"context_line":"  #  conf[\u0027DEFAULT\u0027][\u0027osapi_compute_listen\u0027] \u003d compute_api_bind_address"},{"line_number":160,"context_line":"  #  conf[\u0027DEFAULT\u0027][\u0027osapi_compute_listen_port\u0027] \u003d compute_api_bind[\u0027port\u0027]"},{"line_number":161,"context_line":"  # end"},{"line_number":162,"context_line":"  # if node[\u0027openstack\u0027][\u0027mq\u0027][\u0027compute\u0027][\u0027rabbit\u0027][\u0027ha\u0027]"},{"line_number":163,"context_line":"  #   conf[\u0027DEFAULT\u0027][\u0027rabbit_hosts\u0027] \u003d rabbit_hosts"},{"line_number":164,"context_line":"  # end"},{"line_number":165,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027metadata_listen\u0027] \u003d compute_metadata_api_bind_address"},{"line_number":166,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027metadata_listen_port\u0027] \u003d compute_metadata_api_bind[\u0027port\u0027]"},{"line_number":167,"context_line":"  conf[\u0027vnc\u0027][\u0027novncproxy_base_url\u0027] \u003d novnc_endpoint.to_s"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5f7c97a3_f7f87c4a","line":164,"range":{"start_line":158,"start_character":1,"end_line":164,"end_character":7},"updated":"2018-06-26 13:40:25.000000000","message":"is there a reason for keeping this?","commit_id":"7496c13ceb1cc483bb86a525e4208d6fbe1c2165"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"3ea9a1435efe4135d76e402863ad79a1e302520c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027iscsi_helper\u0027] \u003d platform_options[\u0027iscsi_helper\u0027]"},{"line_number":156,"context_line":"  # conf[\u0027DEFAULT\u0027][\u0027scheduler_default_filters\u0027] \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027scheduler\u0027][\u0027default_filters\u0027].join(\u0027,\u0027)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  # if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027][\u0027DEFAULT\u0027][\u0027enabled_apis\u0027].include?(\u0027osapi_compute\u0027)"},{"line_number":159,"context_line":"  #  conf[\u0027DEFAULT\u0027][\u0027osapi_compute_listen\u0027] \u003d compute_api_bind_address"},{"line_number":160,"context_line":"  #  conf[\u0027DEFAULT\u0027][\u0027osapi_compute_listen_port\u0027] \u003d compute_api_bind[\u0027port\u0027]"},{"line_number":161,"context_line":"  # end"},{"line_number":162,"context_line":"  # if node[\u0027openstack\u0027][\u0027mq\u0027][\u0027compute\u0027][\u0027rabbit\u0027][\u0027ha\u0027]"},{"line_number":163,"context_line":"  #   conf[\u0027DEFAULT\u0027][\u0027rabbit_hosts\u0027] \u003d rabbit_hosts"},{"line_number":164,"context_line":"  # end"},{"line_number":165,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027metadata_listen\u0027] \u003d compute_metadata_api_bind_address"},{"line_number":166,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027metadata_listen_port\u0027] \u003d compute_metadata_api_bind[\u0027port\u0027]"},{"line_number":167,"context_line":"  conf[\u0027vnc\u0027][\u0027novncproxy_base_url\u0027] \u003d novnc_endpoint.to_s"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5f7c97a3_fafdc1b1","line":164,"range":{"start_line":158,"start_character":1,"end_line":164,"end_character":7},"in_reply_to":"5f7c97a3_f7f87c4a","updated":"2018-06-26 13:59:11.000000000","message":"I could not see a reason for keeping it, and I was on the fence about removing it anyway. If it turns out that it\u0027s needed, it can be re-implemented properly in a followup.","commit_id":"7496c13ceb1cc483bb86a525e4208d6fbe1c2165"}]}