)]}'
{"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# ****************** OpenStack Compute Endpoints ******************************"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# The OpenStack Compute (Nova) vnc endpoint"},{"line_number":120,"context_line":"%w("},{"line_number":121,"context_line":"  compute-api"},{"line_number":122,"context_line":"  compute-metadata-api"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_92be5bd2","line":119,"updated":"2020-06-09 08:10:07.000000000","message":"I don\u0027t understand why this comment only mentions the vnc endpoint. Maybe just drop it?","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"62cc1c054d5418766e470e0a5ec11dfb978e2cba","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# ****************** OpenStack Compute Endpoints ******************************"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# The OpenStack Compute (Nova) vnc endpoint"},{"line_number":120,"context_line":"%w("},{"line_number":121,"context_line":"  compute-api"},{"line_number":122,"context_line":"  compute-metadata-api"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_30a3fc02","line":119,"in_reply_to":"ff570b3c_92be5bd2","updated":"2020-06-09 15:54:41.000000000","message":"Ah true, I was just clearing out any mention of XPvnc. I\u0027ll clean this up.","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"162de580e195ba93aa0975d46d5927623423bd05","unresolved":false,"context_lines":[{"line_number":19,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027group\u0027] \u003d \u0027nova\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Logging stuff"},{"line_number":22,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027use\u0027] \u003d false"},{"line_number":23,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027facility\u0027] \u003d \u0027LOG_LOCAL1\u0027"},{"line_number":24,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027config_facility\u0027] \u003d \u0027local1\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ff570b3c_875a824d","line":22,"updated":"2020-06-10 08:15:03.000000000","message":"Seems weird that this wasn\u0027t actually defined before. I\u0027m also wondering whether the whole syslog thing does still work, I\u0027d be thinking that that\u0027s mainly a pre-systemd thing. But that\u0027s a topic for a followup I guess.","commit_id":"6c69ce58b1a34e189cceefc1ad24d81637c58f39"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"468ab20a56ecf821883188f693c9e520d98da001","unresolved":false,"context_lines":[{"line_number":19,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027group\u0027] \u003d \u0027nova\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Logging stuff"},{"line_number":22,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027use\u0027] \u003d false"},{"line_number":23,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027facility\u0027] \u003d \u0027LOG_LOCAL1\u0027"},{"line_number":24,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027config_facility\u0027] \u003d \u0027local1\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ff570b3c_ff981ecd","line":22,"in_reply_to":"ff570b3c_875a824d","updated":"2020-06-10 16:43:54.000000000","message":"I think before it was assuming that if the attribute wasn\u0027t defined, it would return false.\n\nI agree I\u0027m not sure whether the whole syslog thing is working as expected but lets deal with that in another patch set.","commit_id":"6c69ce58b1a34e189cceefc1ad24d81637c58f39"}],"attributes/placement.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"default[\u0027openstack\u0027][\u0027placement\u0027][\u0027ssl\u0027][\u0027protocol\u0027] \u003d \u0027\u0027"},{"line_number":22,"context_line":"default[\u0027openstack\u0027][\u0027placement\u0027][\u0027ssl\u0027][\u0027ciphers\u0027] \u003d \u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Work around upstream issue with running the api service under wsgi"},{"line_number":25,"context_line":"# https://docs.openstack.org/releasenotes/nova/stein.html#known-issues"},{"line_number":26,"context_line":"default[\u0027openstack\u0027][\u0027placement\u0027][\u0027threads\u0027] \u003d 10"},{"line_number":27,"context_line":"default[\u0027openstack\u0027][\u0027placement\u0027][\u0027processes\u0027] \u003d 2"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_12ca4b6d","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":70},"updated":"2020-06-09 08:10:07.000000000","message":"This comment doesn\u0027t apply here, the issue only affects placement within nova.","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"case node[\u0027platform_family\u0027]"},{"line_number":31,"context_line":"when \u0027rhel\u0027 # :pragma-foodcritic: ~FC024 - won\u0027t fix this"},{"line_number":32,"context_line":"  default[\u0027openstack\u0027][\u0027placement\u0027][\u0027platform\u0027] \u003d {"},{"line_number":33,"context_line":"    \u0027api_placement_packages\u0027 \u003d\u003e [\u0027openstack-placement-api\u0027],"},{"line_number":34,"context_line":"    \u0027api_placement_service\u0027 \u003d\u003e \u0027openstack-placement-api\u0027,"},{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":"when \u0027debian\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_d28573d1","line":33,"updated":"2020-06-09 08:10:07.000000000","message":"Do we need to keep the \"api_placement_\" prefix for these vars? I\u0027d say we could drop it, placement only has its API, no other components.","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"62cc1c054d5418766e470e0a5ec11dfb978e2cba","unresolved":false,"context_lines":[{"line_number":30,"context_line":"case node[\u0027platform_family\u0027]"},{"line_number":31,"context_line":"when \u0027rhel\u0027 # :pragma-foodcritic: ~FC024 - won\u0027t fix this"},{"line_number":32,"context_line":"  default[\u0027openstack\u0027][\u0027placement\u0027][\u0027platform\u0027] \u003d {"},{"line_number":33,"context_line":"    \u0027api_placement_packages\u0027 \u003d\u003e [\u0027openstack-placement-api\u0027],"},{"line_number":34,"context_line":"    \u0027api_placement_service\u0027 \u003d\u003e \u0027openstack-placement-api\u0027,"},{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":"when \u0027debian\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_70957488","line":33,"in_reply_to":"ff570b3c_d28573d1","updated":"2020-06-09 15:54:41.000000000","message":"Sure thing. I\u0027ll do that.","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":"when \u0027debian\u0027"},{"line_number":37,"context_line":"  default[\u0027openstack\u0027][\u0027placement\u0027][\u0027platform\u0027] \u003d {"},{"line_number":38,"context_line":"    \u0027api_placement_packages\u0027 \u003d\u003e %w(python3-nova python3-placement libapache2-mod-wsgi-py3),"},{"line_number":39,"context_line":"    \u0027api_placement_service\u0027 \u003d\u003e \u0027placement-api\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_050de334","line":38,"updated":"2020-06-09 08:10:07.000000000","message":"Do we really need to explicitly install python3-nova here?","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"62cc1c054d5418766e470e0a5ec11dfb978e2cba","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":"when \u0027debian\u0027"},{"line_number":37,"context_line":"  default[\u0027openstack\u0027][\u0027placement\u0027][\u0027platform\u0027] \u003d {"},{"line_number":38,"context_line":"    \u0027api_placement_packages\u0027 \u003d\u003e %w(python3-nova python3-placement libapache2-mod-wsgi-py3),"},{"line_number":39,"context_line":"    \u0027api_placement_service\u0027 \u003d\u003e \u0027placement-api\u0027,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_908c8880","line":38,"in_reply_to":"ff570b3c_050de334","updated":"2020-06-09 15:54:41.000000000","message":"Hmm, good point. I don\u0027t think so but I\u0027ll verify.","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"162de580e195ba93aa0975d46d5927623423bd05","unresolved":false,"context_lines":[{"line_number":32,"context_line":"case node[\u0027platform_family\u0027]"},{"line_number":33,"context_line":"when \u0027rhel\u0027 # :pragma-foodcritic: ~FC024 - won\u0027t fix this"},{"line_number":34,"context_line":"  default[\u0027openstack\u0027][\u0027placement\u0027][\u0027platform\u0027] \u003d {"},{"line_number":35,"context_line":"    \u0027placement_packages\u0027 \u003d\u003e [\u0027openstack-placement-api\u0027],"},{"line_number":36,"context_line":"    \u0027placement_service\u0027 \u003d\u003e \u0027openstack-placement-api\u0027,"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":"when \u0027debian\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ff570b3c_071dd272","line":35,"updated":"2020-06-10 08:15:03.000000000","message":"I was actually thinking to also drop the \"placement_\" part, since we are within openstack.placement.platform anyway, but if you prefer this, I\u0027m fine with it.","commit_id":"6c69ce58b1a34e189cceefc1ad24d81637c58f39"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"468ab20a56ecf821883188f693c9e520d98da001","unresolved":false,"context_lines":[{"line_number":32,"context_line":"case node[\u0027platform_family\u0027]"},{"line_number":33,"context_line":"when \u0027rhel\u0027 # :pragma-foodcritic: ~FC024 - won\u0027t fix this"},{"line_number":34,"context_line":"  default[\u0027openstack\u0027][\u0027placement\u0027][\u0027platform\u0027] \u003d {"},{"line_number":35,"context_line":"    \u0027placement_packages\u0027 \u003d\u003e [\u0027openstack-placement-api\u0027],"},{"line_number":36,"context_line":"    \u0027placement_service\u0027 \u003d\u003e \u0027openstack-placement-api\u0027,"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":"when \u0027debian\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ff570b3c_1f81924b","line":35,"in_reply_to":"ff570b3c_071dd272","updated":"2020-06-10 16:43:54.000000000","message":"Based on how we\u0027ve been doing this in other cookbooks, this follows the same convention. We\u0027ve been prepending the service names.","commit_id":"6c69ce58b1a34e189cceefc1ad24d81637c58f39"}],"attributes/placement_conf.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  # [DEFAULT] section"},{"line_number":5,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027log_dir\u0027] \u003d \u0027/var/log/placement\u0027"},{"line_number":6,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027state_path\u0027] \u003d \u0027/var/lib/placement\u0027"},{"line_number":7,"context_line":"  if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027use\u0027] #\u003d false"},{"line_number":8,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027log_config\u0027] \u003d \u0027/etc/openstack/logging.conf\u0027"},{"line_number":9,"context_line":"  end"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_b2871f13","line":7,"range":{"start_line":7,"start_character":51,"end_line":7,"end_character":53},"updated":"2020-06-09 08:10:07.000000000","message":"Is this some rubyism I don\u0027t know or should it be \"!\u003d\"?\n\nI\u0027m also not sure we want to use the setting from compute, rather make this a dedicated var for placement?","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"62cc1c054d5418766e470e0a5ec11dfb978e2cba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  # [DEFAULT] section"},{"line_number":5,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027log_dir\u0027] \u003d \u0027/var/log/placement\u0027"},{"line_number":6,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027state_path\u0027] \u003d \u0027/var/lib/placement\u0027"},{"line_number":7,"context_line":"  if node[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027use\u0027] #\u003d false"},{"line_number":8,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027log_config\u0027] \u003d \u0027/etc/openstack/logging.conf\u0027"},{"line_number":9,"context_line":"  end"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_90e1282e","line":7,"range":{"start_line":7,"start_character":51,"end_line":7,"end_character":53},"in_reply_to":"ff570b3c_b2871f13","updated":"2020-06-09 15:54:41.000000000","message":"Hmm, I think I copied this from the other config. This probably should use unless instead. And I agree, we should make a dedicated var for placement.","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"}],"recipes/placement_api.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"include_recipe \u0027openstack-compute::nova-common\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Create valid apache site configuration file before installing package"},{"line_number":30,"context_line":"bind_service \u003d node[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027all\u0027][\u0027placement-api\u0027]"},{"line_number":31,"context_line":"placement_user \u003d node[\u0027openstack\u0027][\u0027placement\u0027][\u0027user\u0027]"},{"line_number":32,"context_line":"placement_group \u003d node[\u0027openstack\u0027][\u0027placement\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_323caf2f","line":29,"updated":"2020-06-09 08:10:07.000000000","message":"This comment no longer seems valid.","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"memcache_servers \u003d memcached_servers.join \u0027,\u0027"},{"line_number":67,"context_line":"placement_api_endpoint \u003d internal_endpoint \u0027placement-api\u0027"},{"line_number":68,"context_line":"Chef::Log.debug(\"openstack-compute::nova-common:placement_api_endpoint|#{::URI.decode placement_api_endpoint.to_s}\")"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"node.default[\u0027openstack\u0027][\u0027placement\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":71,"context_line":"  unless memcache_servers.empty?"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_52dfa3d5","line":68,"range":{"start_line":68,"start_character":36,"end_line":68,"end_character":47},"updated":"2020-06-09 08:10:07.000000000","message":"Change this?","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"end"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# delete all secrets saved in the attribute"},{"line_number":99,"context_line":"# node[\u0027openstack\u0027][\u0027placement\u0027][\u0027conf_secrets\u0027] after creating the neutron.conf"},{"line_number":100,"context_line":"ruby_block \"delete all attributes in node[\u0027openstack\u0027][\u0027placement\u0027][\u0027conf_secrets\u0027]\" do"},{"line_number":101,"context_line":"  block do"},{"line_number":102,"context_line":"    node.rm(:openstack, :placement, :conf_secrets)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_325dcf48","line":99,"range":{"start_line":99,"start_character":68,"end_line":99,"end_character":75},"updated":"2020-06-09 08:10:07.000000000","message":"placement","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"}],"spec/spec_helper.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a45697f9d1f66117fc8f0c4744486f32155109f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      .with(\u0027token\u0027, \u0027openstack_vmware_secret_name\u0027)"},{"line_number":50,"context_line":"      .and_return \u0027vmware_secret_name\u0027"},{"line_number":51,"context_line":"    allow_any_instance_of(Chef::Recipe).to receive(:get_password)"},{"line_number":52,"context_line":"      .with(\u0027db\u0027, \u0027placement\u0027)"},{"line_number":53,"context_line":"      .and_return(\u0027placement_db_pass\u0027)"},{"line_number":54,"context_line":"    allow_any_instance_of(Chef::Recipe).to receive(:get_password)"},{"line_number":55,"context_line":"      .with(\u0027db\u0027, \u0027nova\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"ff570b3c_a5fcf70c","line":52,"updated":"2020-06-09 08:10:07.000000000","message":"Nit: Put this after the nova* entries for ordering?","commit_id":"d2cd496a4535bf2ffe83f6256d17ab125cebef98"}]}