)]}'
{"recipes/libvirt.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b4f5509b28de959edc3239557e7600e43293bcd5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# limitations under the License."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"require \u0027mixlib/shellout\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"platform_options \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027platform\u0027]"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f560f44_1e445273","line":23,"updated":"2020-08-26 10:21:22.000000000","message":"This seems unneeded now?","commit_id":"d259b4edd1df8611898a02948599fa7220898161"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"9ac92ffd3dd9668a8b4c17aa0cd410df833a5dd3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# limitations under the License."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"require \u0027mixlib/shellout\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"platform_options \u003d node[\u0027openstack\u0027][\u0027compute\u0027][\u0027platform\u0027]"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f560f44_6574d6fe","line":23,"in_reply_to":"9f560f44_1e445273","updated":"2020-08-26 16:01:25.000000000","message":"Yup, this should be removed.","commit_id":"d259b4edd1df8611898a02948599fa7220898161"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b4f5509b28de959edc3239557e7600e43293bcd5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  action :upgrade"},{"line_number":30,"context_line":"end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# TODO: (jklare) methods do not belong in recipes, this has to be moved!"},{"line_number":33,"context_line":"def update_grub_default_kernel(flavor \u003d \u0027default\u0027)"},{"line_number":34,"context_line":"  default_boot \u003d 0"},{"line_number":35,"context_line":"  current_default \u003d nil"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f560f44_f92258a2","line":32,"updated":"2020-08-26 10:21:22.000000000","message":"I\u0027ve never noticed this before, where is this actually called? Is this needed by any real world deployment? I seriously think this cookbook should neither reboot the host nor fiddle with grub config, can we just drop all of this?","commit_id":"d259b4edd1df8611898a02948599fa7220898161"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"9ac92ffd3dd9668a8b4c17aa0cd410df833a5dd3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  action :upgrade"},{"line_number":30,"context_line":"end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# TODO: (jklare) methods do not belong in recipes, this has to be moved!"},{"line_number":33,"context_line":"def update_grub_default_kernel(flavor \u003d \u0027default\u0027)"},{"line_number":34,"context_line":"  default_boot \u003d 0"},{"line_number":35,"context_line":"  current_default \u003d nil"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f560f44_c50e828a","line":32,"in_reply_to":"9f560f44_f92258a2","updated":"2020-08-26 16:01:25.000000000","message":"Yes I agree, however should this be done in a separate patch so it provides some context?","commit_id":"d259b4edd1df8611898a02948599fa7220898161"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b4f5509b28de959edc3239557e7600e43293bcd5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  end"},{"line_number":60,"context_line":"end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# def update_grub2_default_kernel(flavor \u003d \u0027default\u0027)"},{"line_number":63,"context_line":"#   boot_entry \u003d \"\u0027openSUSE GNU/Linux, with Xen hypervisor\u0027\""},{"line_number":64,"context_line":"#   begin"},{"line_number":65,"context_line":"#     Mixlib::ShellOut.new(\"grub2-set-default #{boot_entry}\").run_command.error!"},{"line_number":66,"context_line":"#     ::Chef::Log.info(\"Changed grub2 default to #{boot_entry}\")"},{"line_number":67,"context_line":"#   rescue Mixlib::ShellOut::ShellCommandFailed \u003d\u003e e"},{"line_number":68,"context_line":"#     ::Chef::Application.fatal!("},{"line_number":69,"context_line":"#       \"Unable to change grub2 default to #{boot_entry}"},{"line_number":70,"context_line":"# #{e.message}\")"},{"line_number":71,"context_line":"#   end"},{"line_number":72,"context_line":"# end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def update_boot_kernel_and_trigger_reboot(flavor \u003d \u0027default\u0027)"},{"line_number":75,"context_line":"  # only default and xen flavor is supported by this helper right now"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f560f44_3e2156b5","line":72,"range":{"start_line":62,"start_character":0,"end_line":72,"end_character":5},"updated":"2020-08-26 10:21:22.000000000","message":"Drop this for sure","commit_id":"d259b4edd1df8611898a02948599fa7220898161"}],"recipes/nova-common.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b4f5509b28de959edc3239557e7600e43293bcd5","unresolved":false,"context_lines":[{"line_number":133,"context_line":".[](\u0027neutron\u0027)[\u0027metadata_proxy_shared_secret\u0027] \u003d"},{"line_number":134,"context_line":"  get_password \u0027token\u0027, \u0027neutron_metadata_secret\u0027"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"auth_url \u003d ::URI.decode_www_form_component identity_endpoint.to_s"},{"line_number":137,"context_line":"node.default[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf_secrets\u0027]"},{"line_number":138,"context_line":"  .[](\u0027keystone_authtoken\u0027)[\u0027password\u0027] \u003d"},{"line_number":139,"context_line":"  get_password \u0027service\u0027, \u0027openstack-compute\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f560f44_393df0ba","line":136,"updated":"2020-08-26 10:21:22.000000000","message":"Same as in other reviews: Drop the decode completely?","commit_id":"d259b4edd1df8611898a02948599fa7220898161"}],"recipes/placement_api.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b4f5509b28de959edc3239557e7600e43293bcd5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"db_user \u003d node[\u0027openstack\u0027][\u0027db\u0027][\u0027placement\u0027][\u0027username\u0027]"},{"line_number":45,"context_line":"db_pass \u003d get_password \u0027db\u0027, \u0027placement\u0027"},{"line_number":46,"context_line":"identity_endpoint \u003d internal_endpoint \u0027identity\u0027"},{"line_number":47,"context_line":"auth_url \u003d ::URI.decode_www_form_component identity_endpoint.to_s"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"node.default[\u0027openstack\u0027][\u0027placement\u0027][\u0027conf_secrets\u0027]"},{"line_number":50,"context_line":"  .[](\u0027placement_database\u0027)[\u0027connection\u0027] \u003d"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f560f44_59e8a4e0","line":47,"updated":"2020-08-26 10:21:22.000000000","message":"same","commit_id":"d259b4edd1df8611898a02948599fa7220898161"}]}