)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"82818fa3eb2c0a8e2ea7b685bd9fa59f0776fea7","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Furthermore, nova.conf is now populated with required enpoint information"},{"line_number":13,"context_line":"- with hopefully sane default values of relevant attributes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"What could still be done is one-setting switch controlling whether to"},{"line_number":16,"context_line":"use VNC or SPICE consoles - at present it is necessary to manually set"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"node[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027][\u0027vnc\u0027][\u0027enabled\u0027] \u003d false"},{"line_number":19,"context_line":"node[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027][\u0027spice\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"somewhere in order to switch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Signed-off-by: Marek Szuba \u003cm.szuba@gsi.de\u003e"},{"line_number":24,"context_line":"Change-Id: I0996daddda6d21633930ba73e174f99775a9e0c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f9a1d7bc_4093564b","line":22,"range":{"start_line":15,"start_character":0,"end_line":22,"end_character":0},"updated":"2021-07-20 23:58:03.000000000","message":"Perhaps it might make nodes to use node[\u0027openstack\u0027][\u0027compute\u0027][\u0027console_type\u0027] \u003d \u0027vnc\u0027 by default and allow it to also be \u0027spice\u0027 and use that to flip which one to be enabled.","commit_id":"34ba171fd48c9b4dd32356df6f417533fe431f2b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"78560cf824499f1858d148c50bac983bca6af6d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f30a4fbc_386881dc","updated":"2021-10-14 22:47:10.000000000","message":"recheck","commit_id":"30c5bdd64dc7c3e21229572d939933cf57d23c48"}],"attributes/default.rb":[{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"82818fa3eb2c0a8e2ea7b685bd9fa59f0776fea7","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    \u0027compute_conductor_service\u0027 \u003d\u003e \u0027openstack-nova-conductor\u0027,"},{"line_number":67,"context_line":"    \u0027compute_vncproxy_packages\u0027 \u003d\u003e [\u0027openstack-nova-novncproxy\u0027],"},{"line_number":68,"context_line":"    \u0027compute_vncproxy_service\u0027 \u003d\u003e \u0027openstack-nova-novncproxy\u0027,"},{"line_number":69,"context_line":"    \u0027compute_spiceproxy_packages\u0027 \u003d\u003e [\u0027openstack-nova-spicehtml5proxy\u0027],"},{"line_number":70,"context_line":"    \u0027compute_spiceproxy_service\u0027 \u003d\u003e \u0027openstack-nova-spicehtml5proxy\u0027,"},{"line_number":71,"context_line":"    \u0027compute_serialproxy_packages\u0027 \u003d\u003e [\u0027openstack-nova-serialproxy\u0027],"},{"line_number":72,"context_line":"    \u0027compute_serialproxy_service\u0027 \u003d\u003e \u0027openstack-nova-serialproxy\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"272fb187_099486f4","line":69,"updated":"2021-07-20 23:58:03.000000000","message":"You need to add the spice-html5 package here for RHEL.","commit_id":"34ba171fd48c9b4dd32356df6f417533fe431f2b"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"82818fa3eb2c0a8e2ea7b685bd9fa59f0776fea7","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    # Websockify is needed due to https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1076442"},{"line_number":100,"context_line":"    \u0027compute_vncproxy_packages\u0027 \u003d\u003e %w(novnc websockify python3-nova nova-novncproxy),"},{"line_number":101,"context_line":"    \u0027compute_vncproxy_service\u0027 \u003d\u003e \u0027nova-novncproxy\u0027,"},{"line_number":102,"context_line":"    \u0027compute_spiceproxy_packages\u0027 \u003d\u003e %w(nova-spicehtml5proxy spice-html5),"},{"line_number":103,"context_line":"    \u0027compute_spiceproxy_service\u0027 \u003d\u003e \u0027nova-spicehtml5proxy\u0027,"},{"line_number":104,"context_line":"    \u0027compute_serialproxy_packages\u0027 \u003d\u003e %w(python3-nova nova-serialproxy),"},{"line_number":105,"context_line":"    \u0027compute_serialproxy_service\u0027 \u003d\u003e \u0027nova-serialproxy\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"65760856_144ec105","line":102,"updated":"2021-07-20 23:58:03.000000000","message":"This needs to be nova-spiceproxy on Ubuntu (same for the service name)","commit_id":"34ba171fd48c9b4dd32356df6f417533fe431f2b"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"a6635b0d1b75db9d92c7a269468862461cd7079e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027user\u0027] \u003d \u0027nova\u0027"},{"line_number":17,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027group\u0027] \u003d \u0027nova\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# If set to \u0027spice\u0027 or \u0027vnc\u0027 the cookbook will attempt to automatically"},{"line_number":20,"context_line":"# enable the right type; any other type will require appropriate attributes"},{"line_number":21,"context_line":"# to be set by the user."},{"line_number":22,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027console_type\u0027] \u003d \u0027vnc\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Logging stuff"},{"line_number":25,"context_line":"default[\u0027openstack\u0027][\u0027compute\u0027][\u0027syslog\u0027][\u0027use\u0027] \u003d false"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba94a664_242d1ca6","line":22,"range":{"start_line":19,"start_character":0,"end_line":22,"end_character":55},"updated":"2021-07-22 17:59:11.000000000","message":"So something I forgot to mention before is that I believe you can have both vnc _and_ SPICE (among other) console types enabled at the same time. I\u0027m wondering if we want to account for that somehow. What do you think?","commit_id":"db65b6a9cd041647438a1766fa0e37e2a980b2e1"}],"recipes/nova-common.rb":[{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"8d1ad2d0674a0ebc78b3b601a4b8beb72e6361e6","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027metadata_listen\u0027] \u003d compute_metadata_api_bind_address"},{"line_number":158,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027metadata_listen_port\u0027] \u003d compute_metadata_api_bind[\u0027port\u0027]"},{"line_number":159,"context_line":"  conf[\u0027vnc\u0027][\u0027novncproxy_base_url\u0027] \u003d novnc_endpoint.to_s"},{"line_number":160,"context_line":"  conf[\u0027vnc\u0027][\u0027novncproxy_host\u0027] \u003d novnc_bind_address"},{"line_number":161,"context_line":"  conf[\u0027vnc\u0027][\u0027novncproxy_port\u0027] \u003d novnc_bind[\u0027port\u0027]"},{"line_number":162,"context_line":"  conf[\u0027vnc\u0027][\u0027server_listen\u0027] \u003d vnc_bind_address"},{"line_number":163,"context_line":"  conf[\u0027vnc\u0027][\u0027server_proxyclient_address\u0027] \u003d vnc_proxy_bind_address"},{"line_number":164,"context_line":"  conf[\u0027spice\u0027][\u0027html5proxy_base_url\u0027] \u003d spicehtml5_endpoint.to_s"},{"line_number":165,"context_line":"  conf[\u0027spice\u0027][\u0027html5proxy_host\u0027] \u003d spicehtml5_bind_address"},{"line_number":166,"context_line":"  conf[\u0027spice\u0027][\u0027html5proxy_port\u0027] \u003d spicehtml5_bind[\u0027port\u0027]"},{"line_number":167,"context_line":"  conf[\u0027spice\u0027][\u0027server_listen\u0027] \u003d spice_bind_address"},{"line_number":168,"context_line":"  conf[\u0027spice\u0027][\u0027server_proxyclient_address\u0027] \u003d spice_proxy_bind_address"},{"line_number":169,"context_line":"  unless memcache_servers.empty?"},{"line_number":170,"context_line":"    # Need to set the backend explicitly, see LP bug #1572062"},{"line_number":171,"context_line":"    conf[\u0027cache\u0027][\u0027backend\u0027] \u003d \u0027oslo_cache.memcache_pool\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"be815a33_ae7c4dcc","line":168,"range":{"start_line":159,"start_character":3,"end_line":168,"end_character":69},"updated":"2021-07-21 23:06:53.000000000","message":"Can you move these into the case statement below so the vnc config only gets added when it\u0027s set?","commit_id":"ae9923b20127ddc9ff109eca54448812e43f2243"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"8d1ad2d0674a0ebc78b3b601a4b8beb72e6361e6","unresolved":true,"context_lines":[{"line_number":199,"context_line":"  # Non-serial consoles"},{"line_number":200,"context_line":"  case node[\u0027openstack\u0027][\u0027compute\u0027][\u0027console_type\u0027]"},{"line_number":201,"context_line":"  when \u0027spice\u0027"},{"line_number":202,"context_line":"    conf[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027][\u0027vnc\u0027][\u0027enabled\u0027] \u003d false"},{"line_number":203,"context_line":"    conf[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027][\u0027spice\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":204,"context_line":"  when \u0027vnc\u0027"},{"line_number":205,"context_line":"    # No need to explicitly disable other types, according to Nova documentation"},{"line_number":206,"context_line":"    # VNC takes precedence if enabled."}],"source_content_type":"text/x-ruby","patch_set":3,"id":"47c47dc8_33d7ac36","line":203,"range":{"start_line":202,"start_character":4,"end_line":203,"end_character":67},"updated":"2021-07-21 23:06:53.000000000","message":"You need to remove `[\u0027openstack\u0027][\u0027compute\u0027][\u0027conf\u0027]` here and below as that\u0027s already included with `conf.\n\nAlso please add `conf[\u0027spice\u0027][\u0027agent_enabled\u0027] \u003d true` here as well.","commit_id":"ae9923b20127ddc9ff109eca54448812e43f2243"}],"recipes/spiceproxy.rb":[{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"82818fa3eb2c0a8e2ea7b685bd9fa59f0776fea7","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# Cookbook:: openstack-compute"},{"line_number":3,"context_line":"# Recipe:: spiceproxy"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright:: 2012, Rackspace US, Inc."},{"line_number":6,"context_line":"# Copyright:: 2013, Craig Tracey \u003ccraigtracey@gmail.com\u003e"},{"line_number":7,"context_line":"# Copyright:: 2020, Oregon State University"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":10,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fcdd1375_cec85bd6","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":43},"updated":"2021-07-20 23:58:03.000000000","message":"This should be updated to whoever has the copyright to this new recipe.","commit_id":"34ba171fd48c9b4dd32356df6f417533fe431f2b"}],"spec/nova-common_spec.rb":[{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"a6635b0d1b75db9d92c7a269468862461cd7079e","unresolved":true,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"      it \u0027[vnc]\u0027 do"},{"line_number":244,"context_line":"        ["},{"line_number":245,"context_line":"          /^enabled \u003d true$/,"},{"line_number":246,"context_line":"          %r{^novncproxy_base_url \u003d http://127.0.0.1:6080/vnc_auto.html$},"},{"line_number":247,"context_line":"          /^novncproxy_host \u003d 127.0.0.1$/,"},{"line_number":248,"context_line":"          /^novncproxy_port \u003d 6080$/,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"888e2d3e_38f0d849","line":245,"updated":"2021-07-22 17:59:11.000000000","message":"Can you also ensure that the SPICE options are _not_ being set when using defaults?","commit_id":"db65b6a9cd041647438a1766fa0e37e2a980b2e1"}]}