)]}'
{"CHANGELOG.md":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a77dcd8661a1c1dc9de5d7c64e44641c1def9893","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":"This file is used to list changes made in each version of the openstack-dashboard cookbook."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"## 9.1.1"},{"line_number":6,"context_line":"* allow override of the temporary directory used for file uploads"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"## 9.1"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"baada198_ff9bb7c6","line":5,"updated":"2014-07-10 15:08:27.000000000","message":"From discussions, we\u0027re pulling back on having version bumps for small cookbook changes like adding an local attribute.   Just a Change log entry in the existing version entry is enough.","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"},{"author":{"_account_id":26,"name":"Matt Ray","email":"matthewhray@gmail.com","username":"mattray"},"change_message_id":"db2f46cb9e9108758a7eb8d2ea4e71eafc8bce23","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":"This file is used to list changes made in each version of the openstack-dashboard cookbook."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"## 9.1.1"},{"line_number":6,"context_line":"* allow override of the temporary directory used for file uploads"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"## 9.1"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"baada198_83f25298","line":5,"in_reply_to":"baada198_c649c7b8","updated":"2014-07-11 00:35:16.000000000","message":"I could see not uploading a cookbook if the version hasn\u0027t changed, especially if it\u0027s --frozen when you upload it. Does the policy need to be that for \"master\" we don\u0027t bump versions for non-changing functionality? For example, if you add a new attribute with the same default value, you wouldn\u0027t have to bump the version (and this sort of deployment doesn\u0027t care about your change)?","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"f1f063c601f75fda70e40e477ac436c0cf109fa8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":"This file is used to list changes made in each version of the openstack-dashboard cookbook."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"## 9.1.1"},{"line_number":6,"context_line":"* allow override of the temporary directory used for file uploads"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"## 9.1"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"baada198_8d460a20","line":5,"in_reply_to":"baada198_c649c7b8","updated":"2014-07-10 20:07:25.000000000","message":"had not seen those issues before with chef, we usually using the new commit level to trigger the chef server updates and don\u0027t really bother with the versions for that stage.   Are there bugs opened against Chef for this?","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"8a0c46089dba0116a59fc2f196e531d87683f321","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":"This file is used to list changes made in each version of the openstack-dashboard cookbook."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"## 9.1.1"},{"line_number":6,"context_line":"* allow override of the temporary directory used for file uploads"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"## 9.1"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"baada198_c649c7b8","line":5,"in_reply_to":"baada198_ff9bb7c6","updated":"2014-07-10 18:05:10.000000000","message":"In our environment, the cookbook will not get deployed if the version is not incremented.  There are issues with chef/caching when the cookbook changes but the version remains the same.\n\nI\u0027m going to guess a lot of others are also in the same situation.","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"}],"attributes/default.rb":[{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"96c82f2263f7ee89d8ee9307e9b8c70334f173e1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl_offload\u0027] \u003d false"},{"line_number":130,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027plugins\u0027] \u003d nil"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027file_upload_temp_dir\u0027] \u003d nil"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027error_log\u0027] \u003d \u0027openstack-dashboard-error.log\u0027"},{"line_number":135,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027access_log\u0027] \u003d \u0027openstack-dashboard-access.log\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baada198_675bb922","line":132,"updated":"2014-07-23 08:40:55.000000000","message":"Maybe it would be good to document this here and say that the upstream default (currently \"/tmp\") will be used here when this is nil.","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"}],"metadata.rb":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c23a67021b000a6cdb88940484e849b6ce2fa979","unresolved":false,"context_lines":[{"line_number":4,"context_line":"license          \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description      \u0027Installs/Configures the OpenStack Dasboard (Horizon)\u0027"},{"line_number":6,"context_line":"long_description IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":7,"context_line":"version          \u00279.2\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"recipe           \u0027openstack-dashboard::server\u0027, \u0027Sets up the Horizon dashboard within an Apache `mod_wsgi` container.\u0027"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"baada198_2a960495","line":7,"updated":"2014-07-01 14:20:40.000000000","message":"I think this should be 9.1.1 version since this patch set is for a new attribute and doesn\u0027t change behavior.","commit_id":"43dec35a5613eb238891ffacf3cde6f369b5cea4"}],"spec/server_spec.rb":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8a0ab362217129e8ed79923efc5c3e599fcdf5cd","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            end"},{"line_number":155,"context_line":"            it \u0027does override temp dir when it is not nil\u0027 do"},{"line_number":156,"context_line":"              node.set[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027file_upload_temp_dir\u0027] \u003d \u0027/foobar\u0027"},{"line_number":157,"context_line":"              expect(chef_run).to render_file(file.name).with_content(\u0027FILE_UPLOAD_TEMP_DIR \u003d \"/foobar\"\u0027)"},{"line_number":158,"context_line":"            end"},{"line_number":159,"context_line":"          end"},{"line_number":160,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"baada198_3532c010","line":157,"updated":"2014-07-02 11:03:50.000000000","message":"This should verify that nothing else is on the line in the file like is done for other tests.","commit_id":"47dd742a150bee6f4c15623a1947a31b8cca875a"}],"templates/default/local_settings.py.erb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"5945efe8cae59e648f5435bf85677db825b6612c","unresolved":false,"context_lines":[{"line_number":513,"context_line":""},{"line_number":514,"context_line":"# define a custom tmp upload directory (override /tmp)"},{"line_number":515,"context_line":"\u003c% if node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] %\u003e"},{"line_number":516,"context_line":"FILE_UPLOAD_TEMP_DIR \u003d \"\u003c%\u003d node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] %\u003e\""},{"line_number":517,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":4,"id":"baada198_197535fa","line":516,"updated":"2014-07-16 04:20:25.000000000","message":"Do we really need the if condition? If the attribute FILE_UPLOAD_TEMP_DIR is default to \u0027/tmp\u0027, I think you should set node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] in attribute file to \u0027/tmp\u0027, so that you can omit the if condition.","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a77dcd8661a1c1dc9de5d7c64e44641c1def9893","unresolved":false,"context_lines":[{"line_number":513,"context_line":""},{"line_number":514,"context_line":"# define a custom tmp upload directory (override /tmp)"},{"line_number":515,"context_line":"\u003c% if node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] %\u003e"},{"line_number":516,"context_line":"FILE_UPLOAD_TEMP_DIR \u003d \"\u003c%\u003d node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] %\u003e\""},{"line_number":517,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":4,"id":"baada198_5fe103fd","line":516,"updated":"2014-07-10 15:08:27.000000000","message":"humm, I see a mix of single and double quotes around  values, I guess I would favor using just single quotes for new items.","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"96c82f2263f7ee89d8ee9307e9b8c70334f173e1","unresolved":false,"context_lines":[{"line_number":513,"context_line":""},{"line_number":514,"context_line":"# define a custom tmp upload directory (override /tmp)"},{"line_number":515,"context_line":"\u003c% if node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] %\u003e"},{"line_number":516,"context_line":"FILE_UPLOAD_TEMP_DIR \u003d \"\u003c%\u003d node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] %\u003e\""},{"line_number":517,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":4,"id":"baada198_4749555f","line":516,"in_reply_to":"baada198_197535fa","updated":"2014-07-23 08:40:55.000000000","message":"I think the if condition is fine. That way we are immune to changes in the default upstream.","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"8a0c46089dba0116a59fc2f196e531d87683f321","unresolved":false,"context_lines":[{"line_number":513,"context_line":""},{"line_number":514,"context_line":"# define a custom tmp upload directory (override /tmp)"},{"line_number":515,"context_line":"\u003c% if node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] %\u003e"},{"line_number":516,"context_line":"FILE_UPLOAD_TEMP_DIR \u003d \"\u003c%\u003d node[\"openstack\"][\"dashboard\"][\"file_upload_temp_dir\"] %\u003e\""},{"line_number":517,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":4,"id":"baada198_666d5b32","line":516,"in_reply_to":"baada198_5fe103fd","updated":"2014-07-10 18:05:10.000000000","message":"In general I would agree, however I am following the convention already in the template","commit_id":"da2a76f987ad02c57d8204779cadbb4550d011ed"}]}