)]}'
{"attributes/default.rb":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"93feb332783e06363bb1ac2364d51261efe17502","unresolved":false,"context_lines":[{"line_number":39,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027server_hostname\u0027] \u003d nil"},{"line_number":40,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027use_ssl\u0027] \u003d true"},{"line_number":41,"context_line":"# Don\u0027t cache ssl html pages"},{"line_number":42,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027cache_ssl\u0027] \u003d false"},{"line_number":43,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027cert_url\u0027] \u003d nil"},{"line_number":44,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027key_url\u0027] \u003d nil"},{"line_number":45,"context_line":"# When using a remote certificate and key, the names of the actual installed certificate"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dac4157f_c2235da6","line":42,"updated":"2015-04-21 18:33:01.000000000","message":"because of how the VirtualHosts are set up this makes all html have the Cache-Control no-cache;no-store headers. It\u0027s not tied to use_ssl, and I\u0027m not sure it should be. I think maybe it would be clearer to call the variable [\"openstack\"][\"dashboard\"][\"cache_html\"] instead of [\"openstack\"][\"dashboard\"][\"cache_ssl\"]. IMO it\u0027s important to note that this setting will be useless unless apache 2.4 or greater is used. Maybe that could be added in a code comment here?","commit_id":"f8e0f3dd63759d6be7439d73d25c8558a497fc94"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"775be4429b84203d3481831a76aaace46e8c6961","unresolved":false,"context_lines":[{"line_number":39,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027server_hostname\u0027] \u003d nil"},{"line_number":40,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027use_ssl\u0027] \u003d true"},{"line_number":41,"context_line":"# Don\u0027t cache ssl html pages"},{"line_number":42,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027cache_ssl\u0027] \u003d false"},{"line_number":43,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027cert_url\u0027] \u003d nil"},{"line_number":44,"context_line":"default[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027key_url\u0027] \u003d nil"},{"line_number":45,"context_line":"# When using a remote certificate and key, the names of the actual installed certificate"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dac4157f_60d36805","line":42,"in_reply_to":"dac4157f_c2235da6","updated":"2015-04-21 20:30:34.000000000","message":"Done","commit_id":"f8e0f3dd63759d6be7439d73d25c8558a497fc94"}],"spec/apache2-server_spec.rb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"2cf56d2ed2b404894d0d346f7d51afd6c595b807","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        it_should_behave_like \u0027virtualhost port configurator\u0027, \u0027dashboard-http-bind\u0027, 8080"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        context \u0027cache_html\u0027 do"},{"line_number":152,"context_line":"          it \u0027prevent html page caching\u0027 do"},{"line_number":153,"context_line":"            expect(chef_run).to render_file(file.name).with_content(%r(^\\s*SetEnvIfExpr \"req\\(\u0027accept\u0027\\) \u003d~/html/\" NO_CACHE$))"},{"line_number":154,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^\\s*Header merge Cache-Control no-cache env\u003dNO_CACHE$/)"},{"line_number":155,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^\\s*Header merge Cache-Control no-store env\u003dNO_CACHE$/)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_2922f4b9","line":152,"updated":"2015-04-22 00:44:59.000000000","message":"prevents","commit_id":"839866f5ff7b23d6c76f1e74ffeddba384d642d5"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"830ab4c2ef1ca77e8799ce404d20cb932478e2d4","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        it_should_behave_like \u0027virtualhost port configurator\u0027, \u0027dashboard-http-bind\u0027, 8080"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        context \u0027cache_html\u0027 do"},{"line_number":152,"context_line":"          it \u0027prevent html page caching\u0027 do"},{"line_number":153,"context_line":"            expect(chef_run).to render_file(file.name).with_content(%r(^\\s*SetEnvIfExpr \"req\\(\u0027accept\u0027\\) \u003d~/html/\" NO_CACHE$))"},{"line_number":154,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^\\s*Header merge Cache-Control no-cache env\u003dNO_CACHE$/)"},{"line_number":155,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^\\s*Header merge Cache-Control no-store env\u003dNO_CACHE$/)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_03ea52db","line":152,"in_reply_to":"dac4157f_2922f4b9","updated":"2015-04-22 15:30:58.000000000","message":"Done","commit_id":"839866f5ff7b23d6c76f1e74ffeddba384d642d5"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"2cf56d2ed2b404894d0d346f7d51afd6c595b807","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^\\s*Header merge Cache-Control no-store env\u003dNO_CACHE$/)"},{"line_number":156,"context_line":"          end"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"          it \u0027allow html page caching\u0027 do"},{"line_number":159,"context_line":"            node.set[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027cache_html\u0027] \u003d true"},{"line_number":160,"context_line":"            expect(chef_run).not_to render_file(file.name).with_content(%r(^\\s*SetEnvIfExpr \"req\\(\u0027accept\u0027\\) \u003d~/html/\" NO_CACHE$))"},{"line_number":161,"context_line":"            expect(chef_run).not_to render_file(file.name).with_content(/^\\s*Header merge Cache-Control no-cache env\u003dNO_CACHE$/)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_bc008402","line":158,"updated":"2015-04-22 00:44:59.000000000","message":"allows","commit_id":"839866f5ff7b23d6c76f1e74ffeddba384d642d5"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"830ab4c2ef1ca77e8799ce404d20cb932478e2d4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^\\s*Header merge Cache-Control no-store env\u003dNO_CACHE$/)"},{"line_number":156,"context_line":"          end"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"          it \u0027allow html page caching\u0027 do"},{"line_number":159,"context_line":"            node.set[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027cache_html\u0027] \u003d true"},{"line_number":160,"context_line":"            expect(chef_run).not_to render_file(file.name).with_content(%r(^\\s*SetEnvIfExpr \"req\\(\u0027accept\u0027\\) \u003d~/html/\" NO_CACHE$))"},{"line_number":161,"context_line":"            expect(chef_run).not_to render_file(file.name).with_content(/^\\s*Header merge Cache-Control no-cache env\u003dNO_CACHE$/)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dac4157f_e3e63e14","line":158,"in_reply_to":"dac4157f_bc008402","updated":"2015-04-22 15:30:58.000000000","message":"Done","commit_id":"839866f5ff7b23d6c76f1e74ffeddba384d642d5"}],"templates/default/dash-site.erb":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"93feb332783e06363bb1ac2364d51261efe17502","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  CustomLog \u003c%\u003d node[\"apache\"][\"log_dir\"] %\u003e/\u003c%\u003d node[\"openstack\"][\"dashboard\"][\"access_log\"] %\u003e combined"},{"line_number":81,"context_line":"  TraceEnable \u003c%\u003d node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027traceenable\u0027] %\u003e"},{"line_number":82,"context_line":"  \u003c% if !node[\"openstack\"][\"dashboard\"][\"cache_ssl\"] %\u003e"},{"line_number":83,"context_line":"  \u003c% if node[\u0027apache\u0027][\u0027version\u0027] \u003d\u003d \u00272.4\u0027 -%\u003e"},{"line_number":84,"context_line":"  SetEnvIfExpr \"req(\u0027accept\u0027) \u003d~/html/\" NO_CACHE"},{"line_number":85,"context_line":"  \u003c% end -%\u003e"},{"line_number":86,"context_line":"  Header merge Cache-Control no-cache env\u003dNO_CACHE"}],"source_content_type":"application/x-erb","patch_set":1,"id":"dac4157f_27322b11","line":83,"updated":"2015-04-21 18:33:01.000000000","message":"this should work on newer versions of apache too (I see it in the 2.5 doc). What do you think about using \u003e here?","commit_id":"f8e0f3dd63759d6be7439d73d25c8558a497fc94"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"775be4429b84203d3481831a76aaace46e8c6961","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  CustomLog \u003c%\u003d node[\"apache\"][\"log_dir\"] %\u003e/\u003c%\u003d node[\"openstack\"][\"dashboard\"][\"access_log\"] %\u003e combined"},{"line_number":81,"context_line":"  TraceEnable \u003c%\u003d node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027traceenable\u0027] %\u003e"},{"line_number":82,"context_line":"  \u003c% if !node[\"openstack\"][\"dashboard\"][\"cache_ssl\"] %\u003e"},{"line_number":83,"context_line":"  \u003c% if node[\u0027apache\u0027][\u0027version\u0027] \u003d\u003d \u00272.4\u0027 -%\u003e"},{"line_number":84,"context_line":"  SetEnvIfExpr \"req(\u0027accept\u0027) \u003d~/html/\" NO_CACHE"},{"line_number":85,"context_line":"  \u003c% end -%\u003e"},{"line_number":86,"context_line":"  Header merge Cache-Control no-cache env\u003dNO_CACHE"}],"source_content_type":"application/x-erb","patch_set":1,"id":"dac4157f_8002fc6d","line":83,"in_reply_to":"dac4157f_27322b11","updated":"2015-04-21 20:30:34.000000000","message":"Done","commit_id":"f8e0f3dd63759d6be7439d73d25c8558a497fc94"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"2cf56d2ed2b404894d0d346f7d51afd6c595b807","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  LogLevel warn"},{"line_number":80,"context_line":"  CustomLog \u003c%\u003d node[\"apache\"][\"log_dir\"] %\u003e/\u003c%\u003d node[\"openstack\"][\"dashboard\"][\"access_log\"] %\u003e combined"},{"line_number":81,"context_line":"  TraceEnable \u003c%\u003d node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027traceenable\u0027] %\u003e"},{"line_number":82,"context_line":"  \u003c% if !node[\"openstack\"][\"dashboard\"][\"cache_html\"] %\u003e"},{"line_number":83,"context_line":"  \u003c% if node[\u0027apache\u0027][\u0027version\u0027] \u003e\u003d \u00272.4\u0027 -%\u003e"},{"line_number":84,"context_line":"  SetEnvIfExpr \"req(\u0027accept\u0027) \u003d~/html/\" NO_CACHE"},{"line_number":85,"context_line":"  \u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"dac4157f_5c0de835","line":82,"updated":"2015-04-22 00:44:59.000000000","message":"It\u0027s better to unless node[\"openstack\"][\"dashboard\"][\"cache_html\"]","commit_id":"839866f5ff7b23d6c76f1e74ffeddba384d642d5"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"830ab4c2ef1ca77e8799ce404d20cb932478e2d4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  LogLevel warn"},{"line_number":80,"context_line":"  CustomLog \u003c%\u003d node[\"apache\"][\"log_dir\"] %\u003e/\u003c%\u003d node[\"openstack\"][\"dashboard\"][\"access_log\"] %\u003e combined"},{"line_number":81,"context_line":"  TraceEnable \u003c%\u003d node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027traceenable\u0027] %\u003e"},{"line_number":82,"context_line":"  \u003c% if !node[\"openstack\"][\"dashboard\"][\"cache_html\"] %\u003e"},{"line_number":83,"context_line":"  \u003c% if node[\u0027apache\u0027][\u0027version\u0027] \u003e\u003d \u00272.4\u0027 -%\u003e"},{"line_number":84,"context_line":"  SetEnvIfExpr \"req(\u0027accept\u0027) \u003d~/html/\" NO_CACHE"},{"line_number":85,"context_line":"  \u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"dac4157f_83bc22dd","line":82,"in_reply_to":"dac4157f_5c0de835","updated":"2015-04-22 15:30:58.000000000","message":"Done","commit_id":"839866f5ff7b23d6c76f1e74ffeddba384d642d5"}]}