)]}'
{"recipes/apache2-server.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"68554e212514cd8a26828b279ccffbd0d8cde4b3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"ssl_key_file \u003d File.join(node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027key_dir\u0027], node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027key\u0027])"},{"line_number":84,"context_line":"ssl_chain_file \u003d unless node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027chain\u0027].nil?"},{"line_number":85,"context_line":"                   File.join(node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027cert_dir\u0027], node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027chain\u0027])"},{"line_number":86,"context_line":"                 end"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"if node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027use_ssl\u0027]"},{"line_number":89,"context_line":"  unless ssl_cert_file \u003d\u003d ssl_key_file"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dada55a8_44aa281a","line":86,"updated":"2016-07-21 07:15:37.000000000","message":"Would like to see both conditional assignments in one block and a positive check instead of double negative. To avoid errors because of an unassigned variable below, you can set \"ssl_chain_file \u003d nil\" in an else statement.","commit_id":"e814a2b8de8b40aa17c6f2d55c7a387606401773"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"68554e212514cd8a26828b279ccffbd0d8cde4b3","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    end"},{"line_number":101,"context_line":"  end"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  unless node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027chain\u0027].nil?"},{"line_number":104,"context_line":"    cert_mode \u003d 00644"},{"line_number":105,"context_line":"    cert_owner \u003d \u0027root\u0027"},{"line_number":106,"context_line":"    cert_group \u003d \u0027root\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dada55a8_247c54b4","line":103,"updated":"2016-07-21 07:15:37.000000000","message":"This should check the ssl_chain_file variable to be aligned with \"ssl_cert_file\" above and use a positive context instead of double negative (if ssl_chain_file)","commit_id":"e814a2b8de8b40aa17c6f2d55c7a387606401773"}],"templates/default/dash-site.erb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"68554e212514cd8a26828b279ccffbd0d8cde4b3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  SSLEngine on"},{"line_number":68,"context_line":"  SSLCertificateFile \u003c%\u003d @ssl_cert_file %\u003e"},{"line_number":69,"context_line":"  SSLCertificateKeyFile \u003c%\u003d @ssl_key_file %\u003e"},{"line_number":70,"context_line":"    \u003c% unless node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027ssl\u0027][\u0027chain\u0027].nil? -%\u003e"},{"line_number":71,"context_line":"  SSLCertificateChainFile \u003c%\u003d @ssl_chain_file %\u003e"},{"line_number":72,"context_line":"    \u003c% end -%\u003e"},{"line_number":73,"context_line":"  SSLProtocol \u003c%\u003d node[\"openstack\"][\"dashboard\"][\"ssl\"][\"protocol\"] %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"dada55a8_0776726f","line":70,"updated":"2016-07-21 07:15:37.000000000","message":"This should be positive too.","commit_id":"e814a2b8de8b40aa17c6f2d55c7a387606401773"}]}