)]}'
{"recipes/horizon.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"93dd1fb247ac47eebaf898d7efa70f1ce6ff25e8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"https_bind_address \u003d bind_address https_bind"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"horizon_host \u003d if node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027use_ssl\u0027]"},{"line_number":44,"context_line":"                 http_bind_address"},{"line_number":45,"context_line":"               else"},{"line_number":46,"context_line":"                 https_bind_address"},{"line_number":47,"context_line":"               end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_075ad7f1","side":"PARENT","line":44,"updated":"2017-02-16 05:52:14.000000000","message":"Btw., the logic here looks wrong, if use_ssl is True, https_bind_address should be used.","commit_id":"7742a929dc10450d915a04f58ded60298990c634"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"6ee218a529543824c865525dbd03470b3eab2fb2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"https_bind_address \u003d bind_address https_bind"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"horizon_host \u003d if node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027use_ssl\u0027]"},{"line_number":44,"context_line":"                 http_bind_address"},{"line_number":45,"context_line":"               else"},{"line_number":46,"context_line":"                 https_bind_address"},{"line_number":47,"context_line":"               end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_77cf90b3","side":"PARENT","line":44,"in_reply_to":"fa31d9ce_075ad7f1","updated":"2017-02-17 08:05:44.000000000","message":"Done","commit_id":"7742a929dc10450d915a04f58ded60298990c634"},{"author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"change_message_id":"2a3cdb8eec944b1b436b0a7085e27becd9f1c1b8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"https_bind \u003d node[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027dashboard_https\u0027]"},{"line_number":41,"context_line":"https_bind_address \u003d bind_address https_bind"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"horizon_host \u003d if node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027use_ssl\u0027]"},{"line_number":44,"context_line":"                 http_bind_address"},{"line_number":45,"context_line":"               else"},{"line_number":46,"context_line":"                 https_bind_address"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_ee61fe12","line":43,"updated":"2017-02-16 19:19:31.000000000","message":"Perhaps a more elegant option could be: \n\n  horizon_host \u003d node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027use_ssl\u0027] ? https_bind_address : http_bind_address","commit_id":"1390f44ae33b46ef04fa5d0519f94465a350ce0f"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"6ee218a529543824c865525dbd03470b3eab2fb2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"https_bind \u003d node[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027dashboard_https\u0027]"},{"line_number":41,"context_line":"https_bind_address \u003d bind_address https_bind"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"horizon_host \u003d if node[\u0027openstack\u0027][\u0027dashboard\u0027][\u0027use_ssl\u0027]"},{"line_number":44,"context_line":"                 http_bind_address"},{"line_number":45,"context_line":"               else"},{"line_number":46,"context_line":"                 https_bind_address"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_57e44c3a","line":43,"in_reply_to":"fa31d9ce_ee61fe12","updated":"2017-02-17 08:05:44.000000000","message":"this line is too long and would be rejected by rubocop","commit_id":"1390f44ae33b46ef04fa5d0519f94465a350ce0f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"93dd1fb247ac47eebaf898d7efa70f1ce6ff25e8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                 http_bind_address"},{"line_number":56,"context_line":"               else"},{"line_number":57,"context_line":"                 https_bind_address"},{"line_number":58,"context_line":"               end"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"db_pass \u003d get_password \u0027db\u0027, \u0027horizon\u0027"},{"line_number":61,"context_line":"db_info \u003d db \u0027dashboard\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_274efb3a","line":58,"updated":"2017-02-16 05:52:14.000000000","message":"This whole block seems duplicated. Error from rebase?","commit_id":"1390f44ae33b46ef04fa5d0519f94465a350ce0f"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"6ee218a529543824c865525dbd03470b3eab2fb2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                 http_bind_address"},{"line_number":56,"context_line":"               else"},{"line_number":57,"context_line":"                 https_bind_address"},{"line_number":58,"context_line":"               end"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"db_pass \u003d get_password \u0027db\u0027, \u0027horizon\u0027"},{"line_number":61,"context_line":"db_info \u003d db \u0027dashboard\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_97ede427","line":58,"in_reply_to":"fa31d9ce_274efb3a","updated":"2017-02-17 08:05:44.000000000","message":"Done","commit_id":"1390f44ae33b46ef04fa5d0519f94465a350ce0f"}],"recipes/neutron-lbaas-dashboard.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"93dd1fb247ac47eebaf898d7efa70f1ce6ff25e8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  notifies :run, \u0027execute[openstack-dashboard collectstatic]\u0027"},{"line_number":32,"context_line":"end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"execute \u0027openstack-dashboard collectstatic\u0027 do"},{"line_number":35,"context_line":"  cwd django_path"},{"line_number":36,"context_line":"  environment \u0027PYTHONPATH\u0027 \u003d\u003e \"/etc/openstack-dashboard:#{django_path}:$PYTHONPATH\""},{"line_number":37,"context_line":"  command \u0027python manage.py collectstatic --noinput\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_47f76fd2","line":34,"updated":"2017-02-16 05:52:14.000000000","message":"This resource might well be used be other dashboard plugins in the future, so I\u0027d rather place it into the main cookbook.","commit_id":"1390f44ae33b46ef04fa5d0519f94465a350ce0f"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"6ee218a529543824c865525dbd03470b3eab2fb2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  notifies :run, \u0027execute[openstack-dashboard collectstatic]\u0027"},{"line_number":32,"context_line":"end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"execute \u0027openstack-dashboard collectstatic\u0027 do"},{"line_number":35,"context_line":"  cwd django_path"},{"line_number":36,"context_line":"  environment \u0027PYTHONPATH\u0027 \u003d\u003e \"/etc/openstack-dashboard:#{django_path}:$PYTHONPATH\""},{"line_number":37,"context_line":"  command \u0027python manage.py collectstatic --noinput\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_1748142d","line":34,"in_reply_to":"fa31d9ce_47f76fd2","updated":"2017-02-17 08:05:44.000000000","message":"Done","commit_id":"1390f44ae33b46ef04fa5d0519f94465a350ce0f"}],"spec/neutron-lbaas-dashboard_spec.rb":[{"author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"change_message_id":"2a3cdb8eec944b1b436b0a7085e27becd9f1c1b8","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"describe \u0027openstack-dashboard::neutron-lbaas-dashboard\u0027 do"},{"line_number":5,"context_line":"  describe \u0027ubuntu\u0027 do"},{"line_number":6,"context_line":"    let(:runner) { ChefSpec::SoloRunner.new(UBUNTU_OPTS) }"},{"line_number":7,"context_line":"    let(:node) { runner.node }"},{"line_number":8,"context_line":"    let(:chef_run) do"},{"line_number":9,"context_line":"      runner.converge(described_recipe)"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_6e0b4e2c","line":6,"updated":"2017-02-16 19:19:31.000000000","message":"Could we add tests for REDHAT_OPTS as well?","commit_id":"1390f44ae33b46ef04fa5d0519f94465a350ce0f"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"6ee218a529543824c865525dbd03470b3eab2fb2","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"describe \u0027openstack-dashboard::neutron-lbaas-dashboard\u0027 do"},{"line_number":5,"context_line":"  describe \u0027ubuntu\u0027 do"},{"line_number":6,"context_line":"    let(:runner) { ChefSpec::SoloRunner.new(UBUNTU_OPTS) }"},{"line_number":7,"context_line":"    let(:node) { runner.node }"},{"line_number":8,"context_line":"    let(:chef_run) do"},{"line_number":9,"context_line":"      runner.converge(described_recipe)"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa31d9ce_d75cbcef","line":6,"in_reply_to":"fa31d9ce_6e0b4e2c","updated":"2017-02-17 08:05:44.000000000","message":"Currently this recipe has no specific options for redhat to test for","commit_id":"1390f44ae33b46ef04fa5d0519f94465a350ce0f"}]}