)]}'
{"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a855056aa9963520f64adb85906f5479f018e559","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  default[\u0027openstack\u0027][\u0027endpoints\u0027][ep_type][\u0027dns-api\u0027][\u0027host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":25,"context_line":"  default[\u0027openstack\u0027][\u0027endpoints\u0027][ep_type][\u0027dns-api\u0027][\u0027scheme\u0027] \u003d \u0027http\u0027"},{"line_number":26,"context_line":"  default[\u0027openstack\u0027][\u0027endpoints\u0027][ep_type][\u0027dns-api\u0027][\u0027port\u0027] \u003d 9001"},{"line_number":27,"context_line":"  default[\u0027openstack\u0027][\u0027endpoints\u0027][ep_type][\u0027dns-api\u0027][\u0027path\u0027] \u003d \u0027/v2\u0027"},{"line_number":28,"context_line":"end"},{"line_number":29,"context_line":"default[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027all\u0027][\u0027dns-api\u0027][\u0027host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":30,"context_line":"default[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027all\u0027][\u0027dns-api\u0027][\u0027port\u0027] \u003d 9001"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_6aa191a8","line":27,"updated":"2018-07-12 14:14:16.000000000","message":"I think this is wrong, the plain endpoint should not need to contain the version information.","commit_id":"d9fffcbd1740cc207b29edde29fceba3299fe493"}],"recipes/common.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a855056aa9963520f64adb85906f5479f018e559","unresolved":false,"context_lines":[{"line_number":79,"context_line":"node.default[\u0027openstack\u0027][\u0027dns\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":80,"context_line":"  conf[\u0027service:api\u0027][\u0027api_host\u0027] \u003d bind_address api_bind"},{"line_number":81,"context_line":"  conf[\u0027service:api\u0027][\u0027api_port\u0027] \u003d api_bind[\u0027port\u0027]"},{"line_number":82,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027auth_uri\u0027] \u003d public_identity_endpoint"},{"line_number":83,"context_line":"  conf[\u0027keystone_authtoken\u0027][\u0027auth_url\u0027] \u003d auth_url"},{"line_number":84,"context_line":"end"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_4a485561","side":"PARENT","line":82,"updated":"2018-07-12 14:14:16.000000000","message":"This config option is deprecated, but instead of dropping it, we should set \u0027www_authenticate_uri\u0027 instead. And for this option the public endpoint is indeed the one that is correct, because it will be presented to the non-authenticated user.","commit_id":"59112747e865faeeb84b92e189bfd84b7fb0bc04"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a855056aa9963520f64adb85906f5479f018e559","unresolved":false,"context_lines":[{"line_number":70,"context_line":"bind_services \u003d node[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027all\u0027]"},{"line_number":71,"context_line":"api_bind \u003d bind_services[\u0027dns-api\u0027]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":74,"context_line":"auth_url \u003d auth_uri_transform identity_endpoint.to_s, node[\u0027openstack\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# define attributes that are needed in designate.conf"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_2a22b9a4","line":73,"updated":"2018-07-12 14:14:16.000000000","message":"Actually it is a bit debatable whether internal services (from a user pov) should be using the public or the internal endpoint. Instead of hardcoding the public endpoint, which to me seems like a step into the wrong direction, we should stick to the internal one in my opinionated view.\n\nAn alternative would be to make this choice configurable for the deployer, but I\u0027m not sure that that added complexity is useful.","commit_id":"d9fffcbd1740cc207b29edde29fceba3299fe493"}],"recipes/identity_registration.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a855056aa9963520f64adb85906f5479f018e559","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  include ::Openstack"},{"line_number":25,"context_line":"end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":28,"context_line":"auth_url \u003d auth_uri_transform identity_endpoint.to_s, node[\u0027openstack\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"internal_designate_endpoint \u003d internal_endpoint \u0027dns-api\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_0a3c9d90","line":27,"updated":"2018-07-12 14:14:16.000000000","message":"Same thing here, I\u0027d rather use the internal endpoint.","commit_id":"d9fffcbd1740cc207b29edde29fceba3299fe493"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a855056aa9963520f64adb85906f5479f018e559","unresolved":false,"context_lines":[{"line_number":25,"context_line":"end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":28,"context_line":"auth_url \u003d auth_uri_transform identity_endpoint.to_s, node[\u0027openstack\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"internal_designate_endpoint \u003d internal_endpoint \u0027dns-api\u0027"},{"line_number":31,"context_line":"public_designate_endpoint \u003d public_endpoint \u0027dns-api\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_6a0511c1","line":28,"updated":"2018-07-12 14:14:16.000000000","message":"I think we should drop these transformations everywhere, just use the version we have in the endpoint. But that may be better done in a separate patch series that fixes this consistently for all cookbooks.","commit_id":"d9fffcbd1740cc207b29edde29fceba3299fe493"}],"recipes/neutron_int.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a855056aa9963520f64adb85906f5479f018e559","unresolved":false,"context_lines":[{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"dns_endpoint \u003d internal_endpoint \u0027dns-api\u0027"},{"line_number":26,"context_line":"dns_url \u003d dns_endpoint.to_s + node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027internal\u0027][\u0027dns-api\u0027][\u0027path\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":29,"context_line":"auth_url \u003d auth_uri_transform identity_endpoint.to_s, node[\u0027openstack\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_cae1c5ff","line":26,"updated":"2018-07-12 14:14:16.000000000","message":"I\u0027m thinking that this may add the version path twice. It is really only needed because neutron lacks the ability to do version discovery properly. I\u0027d rather leave this the original version.","commit_id":"d9fffcbd1740cc207b29edde29fceba3299fe493"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a855056aa9963520f64adb85906f5479f018e559","unresolved":false,"context_lines":[{"line_number":25,"context_line":"dns_endpoint \u003d internal_endpoint \u0027dns-api\u0027"},{"line_number":26,"context_line":"dns_url \u003d dns_endpoint.to_s + node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027internal\u0027][\u0027dns-api\u0027][\u0027path\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"identity_endpoint \u003d public_endpoint \u0027identity\u0027"},{"line_number":29,"context_line":"auth_url \u003d auth_uri_transform identity_endpoint.to_s, node[\u0027openstack\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"node.default[\u0027openstack\u0027][\u0027network\u0027][\u0027conf\u0027].tap do |conf|"},{"line_number":32,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027external_dns_driver\u0027] \u003d \u0027designate\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_caca256e","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":97},"updated":"2018-07-12 14:14:16.000000000","message":"Same comments as for other recipes apply.","commit_id":"d9fffcbd1740cc207b29edde29fceba3299fe493"}]}