)]}'
{"id":"openstack%2Fcookbook-openstack-dns~676372","triplet_id":"openstack%2Fcookbook-openstack-dns~master~I5ccb4fa5d8f3a003c4dd1b07e1c9ab2a99246dd6","project":"openstack/cookbook-openstack-dns","branch":"master","topic":"fix-config","hashtags":[],"change_id":"I5ccb4fa5d8f3a003c4dd1b07e1c9ab2a99246dd6","subject":"Fix designate config","status":"MERGED","created":"2019-08-14 09:01:01.000000000","updated":"2019-08-14 14:12:27.000000000","submitted":"2019-08-14 14:12:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676372-1565791947031-3f7c88c0","meta_rev_id":"660afccfcbc97d0597621427740cc62923494047","_number":676372,"virtual_id_number":676372,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-14 14:12:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"recommended":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-14 12:56:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":2,"date":"2019-08-14 10:57:22.000000000","_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":1,"date":"2019-08-14 12:50:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2019-08-14 12:36:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":1,"date":"2019-08-14 13:12:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 10:57:22.000000000","updated_by":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"reviewer":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"state":"REVIEWER"},{"updated":"2019-08-14 12:36:26.000000000","updated_by":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"reviewer":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"state":"REVIEWER"},{"updated":"2019-08-14 12:50:24.000000000","updated_by":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"reviewer":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"state":"REVIEWER"},{"updated":"2019-08-14 12:56:18.000000000","updated_by":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"reviewer":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"state":"REVIEWER"},{"updated":"2019-08-14 14:12:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b10fb967ccd1273187eee1c1fa2830194356ad8b","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-14 09:01:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ae59088c5c7c74c69e8da74792a2d88ec2db27f0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 09:46:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/6d18c7dbd0dc43f48bab0b2af81bc594 : SUCCESS in 2m 22s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/5606d3c27af14097af97b6aebd9f5702 : SUCCESS in 44m 12s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/86f260bae518456e899ef43e57fb8b06 : SUCCESS in 44m 26s","accounts_in_message":[],"_revision_number":1},{"id":"d8f8845b500257fc98585ae914e62612b32baa3b","author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"date":"2019-08-14 10:57:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d2f5e0c88d67148d821f2f4be417781668f0cae0","author":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"date":"2019-08-14 12:36:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"337427a58f30905f41404ca61b8f43918bb8bbf2","author":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"date":"2019-08-14 12:50:24.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a455957fbef64e49be1c5c4ae84abb49913c7f7f","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2019-08-14 12:56:18.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0ec61018f56ace44e0a860bddd5fa37b117ae64f","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-14 13:12:41.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c084c5424e2660831c06a12e26e264555ecc4efe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 13:12:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f2e724450969fd9b2bafe96b508361d82a2c45d4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 14:12:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/14f0189eebc14fd7bdf546a877066ed9 : SUCCESS in 2m 19s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/ab94e00c9f3440eeb37855a1b743473b : SUCCESS in 50m 21s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/01639b981c2d4cbda4e03a8dc31ce934 : SUCCESS in 54m 08s","accounts_in_message":[],"_revision_number":1},{"id":"779b165b1f9a965cbc22c58ccb57b6c0f3b939f6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 14:12:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"be2fd380fa50bd1701fe416e6874142749d424fa","revisions":{"be2fd380fa50bd1701fe416e6874142749d424fa":{"kind":"REWORK","_number":1,"created":"2019-08-14 09:01:01.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/72/676372/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-dns","ref":"refs/changes/72/676372/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-dns refs/changes/72/676372/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-dns refs/changes/72/676372/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-dns refs/changes/72/676372/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-dns refs/changes/72/676372/1"}}},"commit":{"parents":[{"commit":"a6ec2075616b8f880a2199490b31f23b5b59345b","subject":"Fixes to support fog-openstack-1.x","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-dns/commit/a6ec2075616b8f880a2199490b31f23b5b59345b"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-08-13 12:06:26.000000000","tz":0},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-08-14 09:00:59.000000000","tz":0},"subject":"Fix designate config","message":"Fix designate config\n\nThe changes in [0] sadly were almost, but not quite, completely broken.\nThey introduced config options that do not exist in designate and also\nmade secrets being saved into the node config.\n\nFix all this, also clean up the remainder of a workaround that is no\nlonger needed.\n\nThis was partially fixed for stable/queens in [1].\n\nbackport: stable/queens\n\n[0] If4e185eb58a525e22971c7a8b876274c353db847\n[1] https://review.opendev.org/606094\n\nChange-Id: I5ccb4fa5d8f3a003c4dd1b07e1c9ab2a99246dd6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-dns/commit/be2fd380fa50bd1701fe416e6874142749d424fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-dns/commit/be2fd380fa50bd1701fe416e6874142749d424fa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}