)]}'
{"id":"openstack%2Fcookbook-openstack-dns~677464","triplet_id":"openstack%2Fcookbook-openstack-dns~stable%2Fqueens~I5ccb4fa5d8f3a003c4dd1b07e1c9ab2a99246dd6","project":"openstack/cookbook-openstack-dns","branch":"stable/queens","hashtags":[],"change_id":"I5ccb4fa5d8f3a003c4dd1b07e1c9ab2a99246dd6","subject":"Fix designate config","status":"MERGED","created":"2019-08-20 12:56:41.000000000","updated":"2019-09-09 14:02:40.000000000","submitted":"2019-09-09 14:02:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677464-1568037760513-82917982","meta_rev_id":"a96e8f776579a2f622b60a6f59f61291e6b255f5","_number":677464,"virtual_id_number":677464,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":2,"date":"2019-09-09 14:02:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2019-09-09 13:54:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2019-08-21 14:04:32.000000000","_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":1,"date":"2019-09-09 13:54:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-21 14:04:32.000000000","updated_by":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"reviewer":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"state":"REVIEWER"},{"updated":"2019-09-09 14:02:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"646b41ddde794db2f3c48e1ba6b30530cf35c8c9","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-20 12:56:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"04e666c5c848806fb0eda2db9deb71e14a91a74b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 13:47:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/c41542519673429abf84b8d484f503be : SUCCESS in 2m 59s\n- openstack-chef-integration-bionic https://zuul.opendev.org/t/openstack/build/85fc8d7676e4407f99cc3d0c646b9534 : SUCCESS in 40m 42s (non-voting)\n- openstack-chef-integration-xenial https://zuul.opendev.org/t/openstack/build/7efc6698e07b4f33ad92ded186a56971 : SUCCESS in 46m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5037a11dbee29767214d5c147db5031cca461086","author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"date":"2019-08-21 14:04:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"95284d1bb6e8d3f904d5d6ca0ffb5bb96a2e720d","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-09 13:54:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"dabbbc40de165b86f8fbd67a6ecbdb02b5c14670","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-09 13:55:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6f0cef950f8fc6fb879aef136d627f83560a77cb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-09 14:02:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a96e8f776579a2f622b60a6f59f61291e6b255f5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-09 14:02:40.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/ea37802814d84379a1102b176ab0972a : SUCCESS in 3m 18s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"949c2e2038a2677affbc1a8f57510cb1cda8e71d","revisions":{"949c2e2038a2677affbc1a8f57510cb1cda8e71d":{"kind":"REWORK","_number":1,"created":"2019-08-20 12:56:41.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/64/677464/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-dns","ref":"refs/changes/64/677464/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-dns refs/changes/64/677464/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-dns refs/changes/64/677464/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-dns refs/changes/64/677464/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-dns refs/changes/64/677464/1"}}},"commit":{"parents":[{"commit":"d128c82b683047c47f7c849098ef9de73c0cc28d","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-dns/commit/d128c82b683047c47f7c849098ef9de73c0cc28d"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-08-13 12:06:26.000000000","tz":0},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-08-20 12:55:31.000000000","tz":0},"subject":"Fix designate config","message":"Fix designate config\n\nThe changes in [0] sadly were almost, but not quite, completely broken.\nThey introduced config options that do not exist in designate and also\nmade secrets being saved into the node config.\n\nFix all this, also clean up the remainder of a workaround that is no\nlonger needed.\n\nThis was partially fixed for stable/queens in [1], amended the\ncherry-pick accordingly.\n\nConflicts:\n\trecipes/common.rb\n\n[0] If4e185eb58a525e22971c7a8b876274c353db847\n[1] https://review.opendev.org/606094\n\nChange-Id: I5ccb4fa5d8f3a003c4dd1b07e1c9ab2a99246dd6\n(cherry picked from commit be2fd380fa50bd1701fe416e6874142749d424fa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-dns/commit/949c2e2038a2677affbc1a8f57510cb1cda8e71d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-dns/commit/949c2e2038a2677affbc1a8f57510cb1cda8e71d"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}