)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9c596d01126aa16d7658272afcfc93579a8e29f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add named recipe and other various fixes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This cookbook wasn\u0027t completely functional unfortunately and this"},{"line_number":10,"context_line":"provides various fixes to get it there. One primary issue was that there"},{"line_number":11,"context_line":"was no named server running so this patch adds a recipe for setting up"},{"line_number":12,"context_line":"named. This recipe is useful as an example but might not be ideal for"},{"line_number":13,"context_line":"production setups."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We probably should move the dashboard recipe to the openstack-dashboad"},{"line_number":16,"context_line":"cookbook in another patch since we have fwaas and lbaas there as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_20b31e37","line":13,"range":{"start_line":10,"start_character":40,"end_line":13,"end_character":18},"updated":"2020-01-28 10:56:17.000000000","message":"The setup of DNS servers was intentionally not in the scope of this cookbook. In our production environment we deploy these as service VMs. So I\u0027m not sure that this should really be added here. IIUC it is needed for testing, but then it might rather be set up by some testing cookbook.","commit_id":"a3a2f30069f14f386f15c29c20f112aad6a1ab48"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"374274b30f4058de87af084a67a6a980d7a46336","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add named recipe and other various fixes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This cookbook wasn\u0027t completely functional unfortunately and this"},{"line_number":10,"context_line":"provides various fixes to get it there. One primary issue was that there"},{"line_number":11,"context_line":"was no named server running so this patch adds a recipe for setting up"},{"line_number":12,"context_line":"named. This recipe is useful as an example but might not be ideal for"},{"line_number":13,"context_line":"production setups."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We probably should move the dashboard recipe to the openstack-dashboad"},{"line_number":16,"context_line":"cookbook in another patch since we have fwaas and lbaas there as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_d59d226c","line":13,"range":{"start_line":10,"start_character":40,"end_line":13,"end_character":18},"in_reply_to":"3fa7e38b_20b31e37","updated":"2020-01-28 16:29:51.000000000","message":"If you prefer, I can move this to the integration-testing cookbook.","commit_id":"a3a2f30069f14f386f15c29c20f112aad6a1ab48"}],"README.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9c596d01126aa16d7658272afcfc93579a8e29f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Cookbooks"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The following cookbooks are dependencies:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"-  \u0027bind\u0027, \u0027~\u003e 2.3.1\u0027"},{"line_number":40,"context_line":"-  \u0027openstackclient\u0027"},{"line_number":41,"context_line":"-  \u0027openstack-common\u0027, \u0027\u003e\u003d 18.0.0\u0027"},{"line_number":42,"context_line":"-  \u0027openstack-identity\u0027, \u0027\u003e\u003d 18.0.0\u0027"},{"line_number":43,"context_line":"-  \u0027openstack-network\u0027, \u0027\u003e\u003d 18.0.0\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Attributes"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_608fd675","line":43,"range":{"start_line":37,"start_character":0,"end_line":43,"end_character":35},"updated":"2020-01-28 10:56:17.000000000","message":"I\u0027m not sure whether we should continue to try to keep this up to date, or rather drop it and assume people will know where to look for the metadata.","commit_id":"a3a2f30069f14f386f15c29c20f112aad6a1ab48"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"374274b30f4058de87af084a67a6a980d7a46336","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Cookbooks"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The following cookbooks are dependencies:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"-  \u0027bind\u0027, \u0027~\u003e 2.3.1\u0027"},{"line_number":40,"context_line":"-  \u0027openstackclient\u0027"},{"line_number":41,"context_line":"-  \u0027openstack-common\u0027, \u0027\u003e\u003d 18.0.0\u0027"},{"line_number":42,"context_line":"-  \u0027openstack-identity\u0027, \u0027\u003e\u003d 18.0.0\u0027"},{"line_number":43,"context_line":"-  \u0027openstack-network\u0027, \u0027\u003e\u003d 18.0.0\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Attributes"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_b5a666be","line":43,"range":{"start_line":37,"start_character":0,"end_line":43,"end_character":35},"in_reply_to":"3fa7e38b_608fd675","updated":"2020-01-28 16:29:51.000000000","message":"I think it\u0027s useful to see it quickly without having to look there.","commit_id":"a3a2f30069f14f386f15c29c20f112aad6a1ab48"}],"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9c596d01126aa16d7658272afcfc93579a8e29f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"default[\u0027openstack\u0027][\u0027dns\u0027][\u0027group\u0027] \u003d \u0027designate\u0027"},{"line_number":50,"context_line":"case node[\u0027platform_family\u0027]"},{"line_number":51,"context_line":"when \u0027rhel\u0027"},{"line_number":52,"context_line":"  # Note(jh): TBC"},{"line_number":53,"context_line":"  default[\u0027openstack\u0027][\u0027dns\u0027][\u0027platform\u0027] \u003d {"},{"line_number":54,"context_line":"    \u0027designate_packages\u0027 \u003d\u003e [\u0027openstack-designate-api\u0027, \u0027openstack-designate-central\u0027,"},{"line_number":55,"context_line":"                             \u0027openstack-designate-mdns\u0027, \u0027openstack-designate-producer\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3fa7e38b_20855e53","line":52,"range":{"start_line":52,"start_character":2,"end_line":52,"end_character":17},"updated":"2020-01-28 10:56:17.000000000","message":"If you tested this and it works on rhel now, you could remove this note.","commit_id":"a3a2f30069f14f386f15c29c20f112aad6a1ab48"}],"recipes/common.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9c596d01126aa16d7658272afcfc93579a8e29f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  end"},{"line_number":100,"context_line":"end"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"rndc_secret \u003d get_password \u0027token\u0027, \u0027designate_rndc\u0027"},{"line_number":103,"context_line":"template \u0027/etc/designate/rndc.key\u0027 do"},{"line_number":104,"context_line":"  source \u0027rndc.key.erb\u0027"},{"line_number":105,"context_line":"  owner node[\u0027openstack\u0027][\u0027dns\u0027][\u0027user\u0027]"},{"line_number":106,"context_line":"  group node[\u0027openstack\u0027][\u0027dns\u0027][\u0027group\u0027]"},{"line_number":107,"context_line":"  mode 00440"},{"line_number":108,"context_line":"  variables("},{"line_number":109,"context_line":"    secret: rndc_secret"},{"line_number":110,"context_line":"  )"},{"line_number":111,"context_line":"end"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"pool_config \u003d node[\u0027openstack\u0027][\u0027dns\u0027][\u0027pool\u0027]"},{"line_number":114,"context_line":"template \u0027/etc/designate/pools.yaml\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3fa7e38b_c001eab6","side":"PARENT","line":111,"range":{"start_line":102,"start_character":0,"end_line":111,"end_character":3},"updated":"2020-01-28 10:56:17.000000000","message":"I would like to keep the designate deployment separated from the bind deployment, there may be a bind instance running on the controller in a different configuration. So let\u0027s keep this file in place, even if it will be a copy of the identical bind configuration file in the testing scenario.\n\nWe need to be able to create a working designate deployment without running the named recipe.","commit_id":"cc4ec952670d771be4c8a790259c9444636ae84f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"edc80c4f3664a017616e9ef0fbffc8ee8898b8cd","unresolved":false,"context_lines":[{"line_number":102,"context_line":"end"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"rndc_secret \u003d get_password \u0027token\u0027, \u0027designate_rndc\u0027"},{"line_number":105,"context_line":"template \u0027/etc/designate/rndc.key\u0027 do"},{"line_number":106,"context_line":"  source \u0027rndc.key.erb\u0027"},{"line_number":107,"context_line":"  owner node[\u0027openstack\u0027][\u0027dns\u0027][\u0027user\u0027]"},{"line_number":108,"context_line":"  group node[\u0027openstack\u0027][\u0027dns\u0027][\u0027group\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3fa7e38b_66ccbc32","line":105,"updated":"2020-01-29 11:31:39.000000000","message":"Wouldn\u0027t you want to use \"pool_config[\u0027rndc_key\u0027]\" for the path here now, too, in order to stay consistent with the change below?","commit_id":"fbbc6413ada014a9f9968af6f9503e6d4e111c06"}]}