)]}'
{"templates/default/keystone.conf.erb":[{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":614,"context_line":"# Catalog backend driver. (string value)"},{"line_number":615,"context_line":"#driver\u003dkeystone.catalog.backends.sql.Catalog"},{"line_number":616,"context_line":"\u003c% if node[\"openstack\"][\"identity\"][\"catalog\"][\"backend\"] \u003d\u003d \"templated\" -%\u003e"},{"line_number":617,"context_line":"# templated driver uses different class name :("},{"line_number":618,"context_line":"driver \u003d keystone.catalog.backends.templated.TemplatedCatalog"},{"line_number":619,"context_line":"\u003c% else -%\u003e"},{"line_number":620,"context_line":"driver \u003d keystone.catalog.backends.\u003c%\u003d node[\"openstack\"][\"identity\"][\"catalog\"][\"backend\"] %\u003e.Catalog"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_597ee6e3","line":617,"updated":"2014-08-05 07:25:26.000000000","message":"I think this would be confusing to leave in the final output. You probably meant to put it inside \u003c%# %\u003e, but even then I\u0027m not sure it\u0027s useful as the code is already pretty clear.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":614,"context_line":"# Catalog backend driver. (string value)"},{"line_number":615,"context_line":"#driver\u003dkeystone.catalog.backends.sql.Catalog"},{"line_number":616,"context_line":"\u003c% if node[\"openstack\"][\"identity\"][\"catalog\"][\"backend\"] \u003d\u003d \"templated\" -%\u003e"},{"line_number":617,"context_line":"# templated driver uses different class name :("},{"line_number":618,"context_line":"driver \u003d keystone.catalog.backends.templated.TemplatedCatalog"},{"line_number":619,"context_line":"\u003c% else -%\u003e"},{"line_number":620,"context_line":"driver \u003d keystone.catalog.backends.\u003c%\u003d node[\"openstack\"][\"identity\"][\"catalog\"][\"backend\"] %\u003e.Catalog"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_13499bb8","line":617,"in_reply_to":"baada198_597ee6e3","updated":"2014-08-05 15:14:41.000000000","message":"yup, will pull that out.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":912,"context_line":"#password\u003d\u003cNone\u003e"},{"line_number":913,"context_line":"\u003c% if @ldap[\"password\"] -%\u003e"},{"line_number":914,"context_line":"password \u003d \u003c%\u003d @ldap[\"password\"] %\u003e"},{"line_number":915,"context_line":"\u003c% else -%\u003e"},{"line_number":916,"context_line":"# password \u003d None"},{"line_number":917,"context_line":"\u003c% end -%\u003e"},{"line_number":918,"context_line":""}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_59e3469f","line":915,"updated":"2014-08-05 07:25:26.000000000","message":"I think the else branch isn\u0027t needed here. The output line is very similar to the one before the block.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":912,"context_line":"#password\u003d\u003cNone\u003e"},{"line_number":913,"context_line":"\u003c% if @ldap[\"password\"] -%\u003e"},{"line_number":914,"context_line":"password \u003d \u003c%\u003d @ldap[\"password\"] %\u003e"},{"line_number":915,"context_line":"\u003c% else -%\u003e"},{"line_number":916,"context_line":"# password \u003d None"},{"line_number":917,"context_line":"\u003c% end -%\u003e"},{"line_number":918,"context_line":""}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_b3d1cfce","line":915,"in_reply_to":"baada198_59e3469f","updated":"2014-08-05 15:14:41.000000000","message":"Done","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"# API attribute. (list value)"},{"line_number":1067,"context_line":"#user_additional_attribute_mapping\u003d"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"# TODO: Is this used anymore?"},{"line_number":1070,"context_line":"user_domain_id_attribute \u003d \u003c%\u003d @ldap[\"user_domain_id_attribute\"] %\u003e"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"# Search base for projects (string value)"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_f9889ac4","line":1069,"updated":"2014-08-05 07:25:26.000000000","message":"I just grepped the master source for user_domain_id_attribute and didn\u0027t get anything, so I suppose it\u0027s not used anymore.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"# API attribute. (list value)"},{"line_number":1067,"context_line":"#user_additional_attribute_mapping\u003d"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"# TODO: Is this used anymore?"},{"line_number":1070,"context_line":"user_domain_id_attribute \u003d \u003c%\u003d @ldap[\"user_domain_id_attribute\"] %\u003e"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"# Search base for projects (string value)"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_d3064322","line":1069,"in_reply_to":"baada198_f9889ac4","updated":"2014-08-05 15:14:41.000000000","message":"I confirmed that with https://bugs.launchpad.net/keystone/+bug/1209440\nI\u0027ll remove this.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"project_attribute_ignore \u003d \u003c%\u003d @ldap[\"project_attribute_ignore\"] %\u003e"},{"line_number":1127,"context_line":"\u003c% end -%\u003e"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"# TODO: Is this used anymore?"},{"line_number":1130,"context_line":"project_objectclass \u003d \u003c%\u003d @ldap[\"project_objectclass\"] %\u003e\r"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"# Allow project creation in LDAP backend. (boolean value)"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_3965b21c","line":1129,"updated":"2014-08-05 07:25:26.000000000","message":"Yes, this is used and it\u0027s included in this file on line 1088.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"project_attribute_ignore \u003d \u003c%\u003d @ldap[\"project_attribute_ignore\"] %\u003e"},{"line_number":1127,"context_line":"\u003c% end -%\u003e"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"# TODO: Is this used anymore?"},{"line_number":1130,"context_line":"project_objectclass \u003d \u003c%\u003d @ldap[\"project_objectclass\"] %\u003e\r"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"# Allow project creation in LDAP backend. (boolean value)"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_4ece0c91","line":1129,"in_reply_to":"baada198_3965b21c","updated":"2014-08-05 15:14:41.000000000","message":"Updated accordingly.  a cut/paste error on my part.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"# API attribute. (list value)"},{"line_number":1278,"context_line":"#group_additional_attribute_mapping\u003d"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"# TODO: Is this used anymore?"},{"line_number":1281,"context_line":"group_domain_id_attribute \u003d \u003c%\u003d @ldap[\"group_domain_id_attribute\"] %\u003e"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"# Enable TLS for communicating with LDAP servers. (boolean"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_d97bd6bc","line":1280,"updated":"2014-08-05 07:25:26.000000000","message":"Nope,  couldn\u0027t find it in the source.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"# API attribute. (list value)"},{"line_number":1278,"context_line":"#group_additional_attribute_mapping\u003d"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"# TODO: Is this used anymore?"},{"line_number":1281,"context_line":"group_domain_id_attribute \u003d \u003c%\u003d @ldap[\"group_domain_id_attribute\"] %\u003e"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"# Enable TLS for communicating with LDAP servers. (boolean"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_ce34dce2","line":1280,"in_reply_to":"baada198_d97bd6bc","updated":"2014-08-05 15:14:41.000000000","message":"I confirmed that with https://bugs.launchpad.net/keystone/+bug/1209440 I\u0027ll remove this.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"# servers. (string value)"},{"line_number":1292,"context_line":"#tls_cacertfile\u003d\u003cNone\u003e"},{"line_number":1293,"context_line":"tls_cacertfile \u003d \u003c%\u003d @ldap[\"tls_cacertfile\"] %\u003e"},{"line_number":1294,"context_line":"\u003c%   elsif @ldap[\"tls_cacertdir\"] -%\u003e"},{"line_number":1295,"context_line":"# CA certificate directory path for communicating with LDAP"},{"line_number":1296,"context_line":"# servers. (string value)"},{"line_number":1297,"context_line":"#tls_cacertdir\u003d\u003cNone\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_34013704","line":1294,"updated":"2014-08-05 07:25:26.000000000","message":"What if both tls_cacertfile and tls_cacertdir are set? Then the cacertfile takes precedence and tls_cacertdir is not output to the config file. That could be unexpected.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"# servers. (string value)"},{"line_number":1292,"context_line":"#tls_cacertfile\u003d\u003cNone\u003e"},{"line_number":1293,"context_line":"tls_cacertfile \u003d \u003c%\u003d @ldap[\"tls_cacertfile\"] %\u003e"},{"line_number":1294,"context_line":"\u003c%   elsif @ldap[\"tls_cacertdir\"] -%\u003e"},{"line_number":1295,"context_line":"# CA certificate directory path for communicating with LDAP"},{"line_number":1296,"context_line":"# servers. (string value)"},{"line_number":1297,"context_line":"#tls_cacertdir\u003d\u003cNone\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_ce205cfc","line":1294,"in_reply_to":"baada198_34013704","updated":"2014-08-05 15:14:41.000000000","message":"I\u0027ll add a comment in the attribute/default to explain that.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"# CA certificate file path for communicating with LDAP"},{"line_number":1301,"context_line":"# servers. (string value)"},{"line_number":1302,"context_line":"#tls_cacertfile\u003d\u003cNone\u003e"},{"line_number":1303,"context_line":"# tls_cacertfile \u003d"},{"line_number":1304,"context_line":"# CA certificate directory path for communicating with LDAP"},{"line_number":1305,"context_line":"# servers. (string value)"},{"line_number":1306,"context_line":"#tls_cacertdir\u003d\u003cNone\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_593fc6de","line":1303,"updated":"2014-08-05 07:25:26.000000000","message":"duplicate line","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"# CA certificate file path for communicating with LDAP"},{"line_number":1301,"context_line":"# servers. (string value)"},{"line_number":1302,"context_line":"#tls_cacertfile\u003d\u003cNone\u003e"},{"line_number":1303,"context_line":"# tls_cacertfile \u003d"},{"line_number":1304,"context_line":"# CA certificate directory path for communicating with LDAP"},{"line_number":1305,"context_line":"# servers. (string value)"},{"line_number":1306,"context_line":"#tls_cacertdir\u003d\u003cNone\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_2ebc78b5","line":1303,"in_reply_to":"baada198_593fc6de","updated":"2014-08-05 15:14:41.000000000","message":"Done","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"# CA certificate directory path for communicating with LDAP"},{"line_number":1305,"context_line":"# servers. (string value)"},{"line_number":1306,"context_line":"#tls_cacertdir\u003d\u003cNone\u003e"},{"line_number":1307,"context_line":"# tls_cacertdir \u003d"},{"line_number":1308,"context_line":"\u003c%   end -%\u003e"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"\u003c%   if @ldap[\"tls_req_cert\"] -%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_995cfe4d","line":1307,"updated":"2014-08-05 07:25:26.000000000","message":"duplicate line","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"# CA certificate directory path for communicating with LDAP"},{"line_number":1305,"context_line":"# servers. (string value)"},{"line_number":1306,"context_line":"#tls_cacertdir\u003d\u003cNone\u003e"},{"line_number":1307,"context_line":"# tls_cacertdir \u003d"},{"line_number":1308,"context_line":"\u003c%   end -%\u003e"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"\u003c%   if @ldap[\"tls_req_cert\"] -%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_4ed8cc24","line":1307,"in_reply_to":"baada198_995cfe4d","updated":"2014-08-05 15:14:41.000000000","message":"Done","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"36de8477725bf3c8f1e3272506f71945fa41f934","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"# (string value)"},{"line_number":1318,"context_line":"#tls_req_cert\u003ddemand"},{"line_number":1319,"context_line":"\u003c%   end -%\u003e"},{"line_number":1320,"context_line":"\u003c% else -%\u003e"},{"line_number":1321,"context_line":"\u003c% end -%\u003e"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"# Enable LDAP connection pooling. (boolean value)"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_541b0b6e","line":1320,"updated":"2014-08-05 07:25:26.000000000","message":"I think the else line is not needed here.","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"cab372b917cbafe6bd1c8df9b662d3cef6b14de3","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"# (string value)"},{"line_number":1318,"context_line":"#tls_req_cert\u003ddemand"},{"line_number":1319,"context_line":"\u003c%   end -%\u003e"},{"line_number":1320,"context_line":"\u003c% else -%\u003e"},{"line_number":1321,"context_line":"\u003c% end -%\u003e"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"# Enable LDAP connection pooling. (boolean value)"}],"source_content_type":"application/x-erb","patch_set":1,"id":"baada198_0e1b34cc","line":1320,"in_reply_to":"baada198_541b0b6e","updated":"2014-08-05 15:14:41.000000000","message":"Done","commit_id":"ff9a7f6e98f1c28d667bbef6c364f9e6e7f25516"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"f6b9961b97aa0db4627ab1dd653f45d8d576dfaa","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"project_filter \u003d \u003c%\u003d @ldap[\"project_filter\"] %\u003e"},{"line_number":1078,"context_line":"\u003c% end -%\u003e"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"# LDAP objectclass for projects. (string value)"},{"line_number":1081,"context_line":"# Deprecated group/name - [ldap]/tenant_objectclass"},{"line_number":1082,"context_line":"#project_objectclass\u003dgroupOfNames"},{"line_number":1083,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"1abeadc6_74f2b470","line":1080,"updated":"2014-08-25 13:51:45.000000000","message":"This block is still listed twice. Once more bellow where the actual value is set.","commit_id":"7d7d3cc411febf8faaec53c39d9a028dfc8e2323"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"473de9cffd30029356d9fa93017ac1923a7e3671","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"project_filter \u003d \u003c%\u003d @ldap[\"project_filter\"] %\u003e"},{"line_number":1078,"context_line":"\u003c% end -%\u003e"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"# LDAP objectclass for projects. (string value)"},{"line_number":1081,"context_line":"# Deprecated group/name - [ldap]/tenant_objectclass"},{"line_number":1082,"context_line":"#project_objectclass\u003dgroupOfNames"},{"line_number":1083,"context_line":""}],"source_content_type":"application/x-erb","patch_set":3,"id":"1abeadc6_f1eb31ae","line":1080,"in_reply_to":"1abeadc6_74f2b470","updated":"2014-08-25 15:14:12.000000000","message":"removed this dup, thx.","commit_id":"7d7d3cc411febf8faaec53c39d9a028dfc8e2323"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"f6b9961b97aa0db4627ab1dd653f45d8d576dfaa","unresolved":false,"context_lines":[{"line_number":1303,"context_line":"# (string value)"},{"line_number":1304,"context_line":"#tls_req_cert\u003ddemand"},{"line_number":1305,"context_line":"tls_req_cert \u003d \u003c%\u003d @ldap[\"tls_req_cert\"] %\u003e"},{"line_number":1306,"context_line":"\u003c%   else -%\u003e"},{"line_number":1307,"context_line":"# Valid options for tls_req_cert are demand, never, and allow."},{"line_number":1308,"context_line":"# (string value)"},{"line_number":1309,"context_line":"#tls_req_cert\u003ddemand"}],"source_content_type":"application/x-erb","patch_set":3,"id":"1abeadc6_5494d8e7","line":1306,"updated":"2014-08-25 13:51:45.000000000","message":"Why not just simplify this and leave only the actual assignment in the if block. That way we can get rid of 5 lines including the else branch.","commit_id":"7d7d3cc411febf8faaec53c39d9a028dfc8e2323"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"473de9cffd30029356d9fa93017ac1923a7e3671","unresolved":false,"context_lines":[{"line_number":1303,"context_line":"# (string value)"},{"line_number":1304,"context_line":"#tls_req_cert\u003ddemand"},{"line_number":1305,"context_line":"tls_req_cert \u003d \u003c%\u003d @ldap[\"tls_req_cert\"] %\u003e"},{"line_number":1306,"context_line":"\u003c%   else -%\u003e"},{"line_number":1307,"context_line":"# Valid options for tls_req_cert are demand, never, and allow."},{"line_number":1308,"context_line":"# (string value)"},{"line_number":1309,"context_line":"#tls_req_cert\u003ddemand"}],"source_content_type":"application/x-erb","patch_set":3,"id":"1abeadc6_71ee41b6","line":1306,"in_reply_to":"1abeadc6_5494d8e7","updated":"2014-08-25 15:14:12.000000000","message":"good suggestion, cleaned it up.","commit_id":"7d7d3cc411febf8faaec53c39d9a028dfc8e2323"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"3eb8cad3be13b9cb2d05fbc91c2501bb3ecf0421","unresolved":false,"context_lines":[{"line_number":1292,"context_line":"# (string value)"},{"line_number":1293,"context_line":"#tls_req_cert\u003ddemand"},{"line_number":1294,"context_line":"tls_req_cert \u003d \u003c%\u003d @ldap[\"tls_req_cert\"] %\u003e"},{"line_number":1295,"context_line":"\u003c%   else -%\u003e"},{"line_number":1296,"context_line":"# Valid options for tls_req_cert are demand, never, and allow."},{"line_number":1297,"context_line":"# (string value)"},{"line_number":1298,"context_line":"#tls_req_cert\u003ddemand"}],"source_content_type":"application/x-erb","patch_set":4,"id":"1abeadc6_1176edd8","line":1295,"updated":"2014-08-25 15:19:42.000000000","message":"This look unchanged from the previous commit.","commit_id":"00467e93ddb9ec014b9ac2fdd270a092b4b4b98a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"ccf248015a3060d02eba4f8ff7eff7736476882b","unresolved":false,"context_lines":[{"line_number":1292,"context_line":"# (string value)"},{"line_number":1293,"context_line":"#tls_req_cert\u003ddemand"},{"line_number":1294,"context_line":"tls_req_cert \u003d \u003c%\u003d @ldap[\"tls_req_cert\"] %\u003e"},{"line_number":1295,"context_line":"\u003c%   else -%\u003e"},{"line_number":1296,"context_line":"# Valid options for tls_req_cert are demand, never, and allow."},{"line_number":1297,"context_line":"# (string value)"},{"line_number":1298,"context_line":"#tls_req_cert\u003ddemand"}],"source_content_type":"application/x-erb","patch_set":4,"id":"1abeadc6_845d5def","line":1295,"in_reply_to":"1abeadc6_1176edd8","updated":"2014-08-25 15:28:56.000000000","message":"Done","commit_id":"00467e93ddb9ec014b9ac2fdd270a092b4b4b98a"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"75491f3eb1dee16cc2b761378243ac1acc587b3e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# service to listen on. (string value)"},{"line_number":19,"context_line":"# Deprecated group/name - [DEFAULT]/bind_host"},{"line_number":20,"context_line":"#public_bind_host\u003d0.0.0.0"},{"line_number":21,"context_line":"bind_host \u003d \u003c%\u003d @bind_address %\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# The IP address of the network interface for the admin"},{"line_number":24,"context_line":"# service to listen on. (string value)"}],"source_content_type":"application/x-erb","patch_set":5,"id":"1abeadc6_a4a5f9b6","line":21,"updated":"2014-08-25 15:33:03.000000000","message":"should we switch to actually using public_bind_host here instead? since the other one is deprecated.","commit_id":"120513d2c68932b8a51e8c11be40278d1e976c92"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e8fbc724ba76a5a5c10f9dc910b7235e7fe8e9a7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# service to listen on. (string value)"},{"line_number":19,"context_line":"# Deprecated group/name - [DEFAULT]/bind_host"},{"line_number":20,"context_line":"#public_bind_host\u003d0.0.0.0"},{"line_number":21,"context_line":"bind_host \u003d \u003c%\u003d @bind_address %\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# The IP address of the network interface for the admin"},{"line_number":24,"context_line":"# service to listen on. (string value)"}],"source_content_type":"application/x-erb","patch_set":5,"id":"1abeadc6_04af8d2c","line":21,"in_reply_to":"1abeadc6_a4a5f9b6","updated":"2014-08-25 16:02:45.000000000","message":"good suggestion. done.","commit_id":"120513d2c68932b8a51e8c11be40278d1e976c92"},{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"25ffba26c8490facb894a55b21671215a4293ab0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# with explicit role grants. After migration, the"},{"line_number":93,"context_line":"# member_role_id will be used in the API add_user_to_project."},{"line_number":94,"context_line":"# (string value)"},{"line_number":95,"context_line":"#member_role_id\u003d9fe2ff9ee4384b1894a90878d3e92bab"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# During a SQL upgrade member_role_name will be used to create"},{"line_number":98,"context_line":"# a new role that will replace records in the assignment table"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1abeadc6_261484f4","line":95,"updated":"2014-08-25 20:18:40.000000000","message":"Should this be a hard coded?","commit_id":"9fae99a77308b6d01bfa432fd6c6c445f006abef"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"96e9241449c16d75d21f4d4657b88f93134315c1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# with explicit role grants. After migration, the"},{"line_number":93,"context_line":"# member_role_id will be used in the API add_user_to_project."},{"line_number":94,"context_line":"# (string value)"},{"line_number":95,"context_line":"#member_role_id\u003d9fe2ff9ee4384b1894a90878d3e92bab"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# During a SQL upgrade member_role_name will be used to create"},{"line_number":98,"context_line":"# a new role that will replace records in the assignment table"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1abeadc6_c6bbd073","line":95,"in_reply_to":"1abeadc6_261484f4","updated":"2014-08-25 20:33:00.000000000","message":"Just copied default comment from the example: https://github.com/openstack/keystone/blob/master/etc/keystone.conf.sample#L87","commit_id":"9fae99a77308b6d01bfa432fd6c6c445f006abef"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"8878407c2949b0655d0e1a9f140f7a028e5f148f","unresolved":false,"context_lines":[{"line_number":473,"context_line":"# (Optional) Name of log file to output to. If no default is"},{"line_number":474,"context_line":"# set, logging will go to stdout. (string value)"},{"line_number":475,"context_line":"# Deprecated group/name - [DEFAULT]/logfile"},{"line_number":476,"context_line":"#log_file\u003d\u003cNone\u003e"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"# (Optional) The base directory used for relative --log-file"},{"line_number":479,"context_line":"# paths. (string value)"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1abeadc6_027bfd29","line":476,"updated":"2014-08-26 11:50:53.000000000","message":"Maybe this shouldn\u0027t be separate from the log_file setting above.","commit_id":"9fae99a77308b6d01bfa432fd6c6c445f006abef"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"499fa50beebdf5639023c8c79872a6128ae2674a","unresolved":false,"context_lines":[{"line_number":473,"context_line":"# (Optional) Name of log file to output to. If no default is"},{"line_number":474,"context_line":"# set, logging will go to stdout. (string value)"},{"line_number":475,"context_line":"# Deprecated group/name - [DEFAULT]/logfile"},{"line_number":476,"context_line":"#log_file\u003d\u003cNone\u003e"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"# (Optional) The base directory used for relative --log-file"},{"line_number":479,"context_line":"# paths. (string value)"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1abeadc6_b07c2674","line":476,"in_reply_to":"1abeadc6_027bfd29","updated":"2014-08-26 14:45:05.000000000","message":"yup, good point, will push up and group them","commit_id":"9fae99a77308b6d01bfa432fd6c6c445f006abef"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"8878407c2949b0655d0e1a9f140f7a028e5f148f","unresolved":false,"context_lines":[{"line_number":478,"context_line":"# (Optional) The base directory used for relative --log-file"},{"line_number":479,"context_line":"# paths. (string value)"},{"line_number":480,"context_line":"# Deprecated group/name - [DEFAULT]/logdir"},{"line_number":481,"context_line":"#log_dir\u003d\u003cNone\u003e"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"# Use syslog for logging. Existing syslog format is DEPRECATED"},{"line_number":484,"context_line":"# during I, and will change in J to honor RFC5424. (boolean"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1abeadc6_4275f530","line":481,"updated":"2014-08-26 11:50:53.000000000","message":"Same here for the other branch of the syslog conditional","commit_id":"9fae99a77308b6d01bfa432fd6c6c445f006abef"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"499fa50beebdf5639023c8c79872a6128ae2674a","unresolved":false,"context_lines":[{"line_number":478,"context_line":"# (Optional) The base directory used for relative --log-file"},{"line_number":479,"context_line":"# paths. (string value)"},{"line_number":480,"context_line":"# Deprecated group/name - [DEFAULT]/logdir"},{"line_number":481,"context_line":"#log_dir\u003d\u003cNone\u003e"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"# Use syslog for logging. Existing syslog format is DEPRECATED"},{"line_number":484,"context_line":"# during I, and will change in J to honor RFC5424. (boolean"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1abeadc6_d07fe264","line":481,"in_reply_to":"1abeadc6_4275f530","updated":"2014-08-26 14:45:05.000000000","message":"Done","commit_id":"9fae99a77308b6d01bfa432fd6c6c445f006abef"}]}