)]}'
{"CHANGELOG.md":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"435ec7befdec2855da22e9902fa000ad4f325bb2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"* Sync conf files with Juno"},{"line_number":9,"context_line":"* Allow admin and public workers to be configured"},{"line_number":10,"context_line":"* Bump openstack-common requirement to 10.0.3 which adds InternalURL endpoint variables"},{"line_number":11,"context_line":"* Cleanup a node.set in test as it is no longer required."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"## 9.3.1"},{"line_number":14,"context_line":"* Add support for a templated keystone-paste.ini"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fa98f980_a15661d0","line":11,"updated":"2014-09-02 14:25:05.000000000","message":"This comment is no longer valid since specs were changed, right?  \nNo need to mention adding basic tests in change log, so maybe just remove this line?","commit_id":"d5b0ff2f84cf6eb1192afac70ed3001ceed1fa72"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"a00c2037d5895b53da1ff9c65cb508ab200c0fe7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"* Sync conf files with Juno"},{"line_number":9,"context_line":"* Allow admin and public workers to be configured"},{"line_number":10,"context_line":"* Bump openstack-common requirement to 10.0.3 which adds InternalURL endpoint variables"},{"line_number":11,"context_line":"* Cleanup a node.set in test as it is no longer required."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"## 9.3.1"},{"line_number":14,"context_line":"* Add support for a templated keystone-paste.ini"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fa98f980_ac155ce6","line":11,"in_reply_to":"fa98f980_a15661d0","updated":"2014-09-04 04:56:49.000000000","message":"Done","commit_id":"d5b0ff2f84cf6eb1192afac70ed3001ceed1fa72"}],"metadata.rb":[{"author":{"_account_id":1032,"name":"Justin Shepherd","email":"jshepher@rackspace.com","username":"jshepher"},"change_message_id":"7f9285b8c753bde8677033caac3b8283da5e9344","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  supports os"},{"line_number":15,"context_line":"end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"depends          \u0027openstack-common\u0027, \u0027~\u003e 10.0.3\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa98f980_72869fba","line":17,"updated":"2014-09-15 04:33:50.000000000","message":"The optimistic versioning should already be allowing this. ~\u003e 10.0 should grab the latest 10.0.X version","commit_id":"e609042d0afc2ccc2abb8979ff4cc8f4f88d71a0"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"0a89b582b1a6edfaf85b263c1af7a4c77b0fb7c9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  supports os"},{"line_number":15,"context_line":"end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"depends          \u0027openstack-common\u0027, \u0027~\u003e 10.0.3\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa98f980_dc2f00a6","line":17,"in_reply_to":"fa98f980_33e08b25","updated":"2014-09-18 05:33:08.000000000","message":"I can see how this could be considered a feature.\n\nhttps://review.openstack.org/#/c/122319/","commit_id":"e609042d0afc2ccc2abb8979ff4cc8f4f88d71a0"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"c4ec0451ea18dce67979ff9c6a477214df9dc5c8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  supports os"},{"line_number":15,"context_line":"end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"depends          \u0027openstack-common\u0027, \u0027~\u003e 10.0.3\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa98f980_4a7557f8","line":17,"in_reply_to":"fa98f980_3fabf775","updated":"2014-09-15 13:27:30.000000000","message":"Agreed, the version change in -common should have been to 10.1 as it added new \"features\" (the new attributes). Then we can also change it here and ~\u003e 10.1 (i.e. \u003e\u003d 10.1, \u003c 11) would make more sense than ~\u003e 10.0.3 (\u003e\u003d 10.0.3, \u003c 10.1)\n\nBTW I think \"~\u003e\" is actually the \"pessimistic\" operator. \"\u003e\u003d\" is the optimistic one.\n\nhttp://guides.rubygems.org/patterns/#declaring-dependencies","commit_id":"e609042d0afc2ccc2abb8979ff4cc8f4f88d71a0"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"075de2e163bf49c4ec2403164006de54a6b81526","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  supports os"},{"line_number":15,"context_line":"end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"depends          \u0027openstack-common\u0027, \u0027~\u003e 10.0.3\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa98f980_33e08b25","line":17,"in_reply_to":"fa98f980_4a7557f8","updated":"2014-09-15 16:07:06.000000000","message":"yup, I agree, probably need to go back and update the common cookbook changes with the appropriate version bump, then refresh this patch accordingly.","commit_id":"e609042d0afc2ccc2abb8979ff4cc8f4f88d71a0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"130d894ceca9dbae6f6002ab01f161b90bcc3f2e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  supports os"},{"line_number":15,"context_line":"end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"depends          \u0027openstack-common\u0027, \u0027~\u003e 10.0.3\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa98f980_3fabf775","line":17,"in_reply_to":"fa98f980_72869fba","updated":"2014-09-15 12:45:18.000000000","message":"Justin has a good point.  I think that the proper way to set the version dependency would be to bump openstack-common to 10.1 and make this ~\u003e 10.1.","commit_id":"e609042d0afc2ccc2abb8979ff4cc8f4f88d71a0"}],"spec/registration_spec.rb":[{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"8404e049ce0456c58af35b150492d70c9e217d91","unresolved":false,"context_lines":[{"line_number":204,"context_line":"          node.set[\u0027openstack\u0027][\u0027identity\u0027][\u0027catalog\u0027][\u0027backend\u0027] \u003d \u0027sql\u0027"},{"line_number":205,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027host\u0027] \u003d \u0027127.0.0.2\u0027"},{"line_number":206,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027port\u0027] \u003d \u00275001\u0027"},{"line_number":207,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027path\u0027] \u003d \u0027/v2.0\u0027"},{"line_number":208,"context_line":"        end"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        it \u0027registers identity endpoint\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1abeadc6_cb2ab48f","side":"PARENT","line":207,"updated":"2014-08-27 08:13:56.000000000","message":"so is this being tested elsewhere then?","commit_id":"ca7a24b695baa64bda745a49a9ff0a9e2a41cd37"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"2576eeb78a93bd86839a2774bd8602def0a1b90f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"          node.set[\u0027openstack\u0027][\u0027identity\u0027][\u0027catalog\u0027][\u0027backend\u0027] \u003d \u0027sql\u0027"},{"line_number":205,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027host\u0027] \u003d \u0027127.0.0.2\u0027"},{"line_number":206,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027port\u0027] \u003d \u00275001\u0027"},{"line_number":207,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027path\u0027] \u003d \u0027/v2.0\u0027"},{"line_number":208,"context_line":"        end"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        it \u0027registers identity endpoint\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1abeadc6_11eaf7ab","side":"PARENT","line":207,"in_reply_to":"1abeadc6_cb2ab48f","updated":"2014-08-28 01:55:09.000000000","message":"I was removing it as it\u0027s being pulled from the openstack-common cookbook.  But as we will be adding two checks, one to ensure they are all unique, and another to ensure the settings from openstack-common are correct I\u0027ll add this back in.","commit_id":"ca7a24b695baa64bda745a49a9ff0a9e2a41cd37"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"c8b22b6a85edbc19dec70b8f7152622334d9d736","unresolved":false,"context_lines":[{"line_number":202,"context_line":"      context \u0027with sql catalog backend\u0027 do"},{"line_number":203,"context_line":"        before do"},{"line_number":204,"context_line":"          node.set[\u0027openstack\u0027][\u0027identity\u0027][\u0027catalog\u0027][\u0027backend\u0027] \u003d \u0027sql\u0027"},{"line_number":205,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027host\u0027] \u003d \u0027127.0.0.2\u0027"},{"line_number":206,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027port\u0027] \u003d \u00275001\u0027"},{"line_number":207,"context_line":"        end"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1abeadc6_bd312c0d","line":205,"updated":"2014-08-27 14:45:58.000000000","message":"humm, probably need to make two tests here, first should be without node.set to make sure the Common attribute defaults are being set and used properly.   Second should be with node.set to make sure the logic can pickup those types of attribute changes.","commit_id":"4ed7ba7733edf03d10bd11f592654b661843b7ef"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"2576eeb78a93bd86839a2774bd8602def0a1b90f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"      context \u0027with sql catalog backend\u0027 do"},{"line_number":203,"context_line":"        before do"},{"line_number":204,"context_line":"          node.set[\u0027openstack\u0027][\u0027identity\u0027][\u0027catalog\u0027][\u0027backend\u0027] \u003d \u0027sql\u0027"},{"line_number":205,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027host\u0027] \u003d \u0027127.0.0.2\u0027"},{"line_number":206,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027port\u0027] \u003d \u00275001\u0027"},{"line_number":207,"context_line":"        end"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1abeadc6_51a1cf92","line":205,"in_reply_to":"1abeadc6_bd312c0d","updated":"2014-08-28 01:55:09.000000000","message":"I agree, this is a good idea.  It will be updated shortly.","commit_id":"4ed7ba7733edf03d10bd11f592654b661843b7ef"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"c4ec0451ea18dce67979ff9c6a477214df9dc5c8","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        end"},{"line_number":200,"context_line":"      end"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"      context \u0027with sql catalog backend verify individuality\u0027 do"},{"line_number":203,"context_line":"        before do"},{"line_number":204,"context_line":"          node.set[\u0027openstack\u0027][\u0027identity\u0027][\u0027catalog\u0027][\u0027backend\u0027] \u003d \u0027sql\u0027"},{"line_number":205,"context_line":"          node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-internal\u0027][\u0027host\u0027] \u003d \u0027127.0.0.2\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa98f980_8af01f68","line":202,"updated":"2014-09-15 13:27:30.000000000","message":"1. I think this should make it more obvious that we\u0027re testing that the attributes are settable/customizable. I don\u0027t really understand what you mean by \"individuality\"\n\n2. Isn\u0027t this the same context \"sql catalog backend\" with two sub-contexts? \"default values\" and \"custom values\". I think we should nest these.","commit_id":"e609042d0afc2ccc2abb8979ff4cc8f4f88d71a0"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"c4ec0451ea18dce67979ff9c6a477214df9dc5c8","unresolved":false,"context_lines":[{"line_number":228,"context_line":"          ).with(endpoint_region: \u0027identityRegion\u0027)"},{"line_number":229,"context_line":"        end"},{"line_number":230,"context_line":"      end"},{"line_number":231,"context_line":"      context \u0027with sql catalog backend\u0027 do"},{"line_number":232,"context_line":"        before do"},{"line_number":233,"context_line":"          node.set[\u0027openstack\u0027][\u0027identity\u0027][\u0027catalog\u0027][\u0027backend\u0027] \u003d \u0027sql\u0027"},{"line_number":234,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa98f980_cae6a7af","line":231,"updated":"2014-09-15 13:27:30.000000000","message":"This should maybe say \"default attribute values\" somewhere.","commit_id":"e609042d0afc2ccc2abb8979ff4cc8f4f88d71a0"}]}