)]}'
{"providers/register.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"77a2127007fb0413dfbd8b7746755825af1944b4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"      endpoint_uuid \u003d identity_uuid new_resource, \u0027endpoint\u0027, \u0027service_id\u0027, service_uuid"},{"line_number":121,"context_line":"      if endpoint_uuid"},{"line_number":122,"context_line":"        Chef::Log.info(\"Endpoint already exists for Service Type \u0027#{new_resource.service_type}\u0027 already exists.. delete it first.\")"},{"line_number":123,"context_line":"        identity_command(new_resource, \u0027endpoint-delete\u0027,"},{"line_number":124,"context_line":"                         \u0027\u0027 \u003d\u003e endpoint_uuid)"},{"line_number":125,"context_line":"      end"},{"line_number":126,"context_line":"      identity_command(new_resource, \u0027endpoint-create\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"baa201ad_f0f3ca07","line":123,"updated":"2014-10-14 14:30:05.000000000","message":"this seems like a poor man\u0027s idempotent solution.   How much harder would it be to do this better, such that we don\u0027t have delete/create churn for every converge.    I think this is related to bug: 1306501\n\nSo, we would need to query the endpoint, and compare for any differences, then and only then, we can delete/create as needed.","commit_id":"0ec52ec805c0113ad4ba26820be06cc7cf86603f"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"63f212f893fae5efbe5b7237a44132bd9248092a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"      endpoint_uuid \u003d identity_uuid new_resource, \u0027endpoint\u0027, \u0027service_id\u0027, service_uuid"},{"line_number":121,"context_line":"      if endpoint_uuid"},{"line_number":122,"context_line":"        Chef::Log.info(\"Endpoint already exists for Service Type \u0027#{new_resource.service_type}\u0027 already exists.. delete it first.\")"},{"line_number":123,"context_line":"        identity_command(new_resource, \u0027endpoint-delete\u0027,"},{"line_number":124,"context_line":"                         \u0027\u0027 \u003d\u003e endpoint_uuid)"},{"line_number":125,"context_line":"      end"},{"line_number":126,"context_line":"      identity_command(new_resource, \u0027endpoint-create\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"baa201ad_11103b58","line":123,"in_reply_to":"baa201ad_f0f3ca07","updated":"2014-10-15 08:27:30.000000000","message":"I had added one check, thanks","commit_id":"0ec52ec805c0113ad4ba26820be06cc7cf86603f"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"bf3ab8a4e1a8e31432724e928bc55d44225e371f","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"private"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def endpoint_need_updated?(resource, key, value, args \u003d {}, uuid_field \u003d \u0027id\u0027)"},{"line_number":89,"context_line":"  begin"},{"line_number":90,"context_line":"    output \u003d identity_command resource, \u0027endpoint-list\u0027, args"},{"line_number":91,"context_line":"    output \u003d prettytable_to_array(output)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"baa201ad_88031241","line":88,"updated":"2014-10-15 15:53:59.000000000","message":"A new spec test is need for this method.  stub out only what needed, I think that would be just the identity_command.  prettytable_to_array and search_uuid are fine to run thru a test with this.","commit_id":"cd5a439dc1987ff625559a1ef08b06f99f924cc8"}]}