)]}'
{"templates/default/keystone.conf.erb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"24ea1d5d27e25464bc2643ba7c8cfeec497dd97f","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Driver or drivers to handle sending notifications. (multi valued)"},{"line_number":87,"context_line":"#notification_driver \u003d"},{"line_number":88,"context_line":"notification_driver \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027identity\u0027][\u0027notification_driver\u0027] %\u003e"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# AMQP topic used for OpenStack notifications. (list value)"},{"line_number":91,"context_line":"# Deprecated group/name - [rpc_notifier2]/topics"}],"source_content_type":"application/x-erb","patch_set":4,"id":"3ab451fb_19d35c3a","line":88,"updated":"2015-04-17 02:29:14.000000000","message":"I think if you config notification_driver, you should add an \"if\" judgement like:\nhttps://github.com/stackforge/cookbook-openstack-image/blob/master/templates/default/glance-api.conf.erb#L225\n\n\u003c% if @notification_driver \u003d\u003d \"messaging\" %\u003e\nthen configure messaging attributes.","commit_id":"97ae31c8f1d8c598c562b795f43372c6bb4c50e3"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"ba0a6656a23742e72cd4ada25cd090b363b01ea6","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Driver or drivers to handle sending notifications. (multi valued)"},{"line_number":87,"context_line":"#notification_driver \u003d"},{"line_number":88,"context_line":"notification_driver \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027identity\u0027][\u0027notification_driver\u0027] %\u003e"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# AMQP topic used for OpenStack notifications. (list value)"},{"line_number":91,"context_line":"# Deprecated group/name - [rpc_notifier2]/topics"}],"source_content_type":"application/x-erb","patch_set":4,"id":"fabf19d9_7aca5951","line":88,"in_reply_to":"3ab451fb_19d35c3a","updated":"2015-04-18 03:36:33.000000000","message":"sounds reasonable to me","commit_id":"97ae31c8f1d8c598c562b795f43372c6bb4c50e3"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"2e39797f6debc37dfe0f34c6151e4abcf179aaa8","unresolved":false,"context_lines":[{"line_number":697,"context_line":"# From oslo.messaging"},{"line_number":698,"context_line":"#"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"\u003c% if @mq_service_type \u003d\u003d \"qpid\"  %\u003e"},{"line_number":701,"context_line":"[oslo_messaging_qpid]"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"#"}],"source_content_type":"application/x-erb","patch_set":6,"id":"dac4157f_6a9cb569","line":700,"updated":"2015-04-20 08:12:04.000000000","message":"should not judge the notification_driver here ?","commit_id":"34480278c17e5e76455d5178ead91cfdeea96180"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"080ce310982059b266525e84527b69fe6b6e9134","unresolved":false,"context_lines":[{"line_number":697,"context_line":"# From oslo.messaging"},{"line_number":698,"context_line":"#"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"\u003c% if @mq_service_type \u003d\u003d \"qpid\"  %\u003e"},{"line_number":701,"context_line":"[oslo_messaging_qpid]"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"#"}],"source_content_type":"application/x-erb","patch_set":6,"id":"dac4157f_b855791e","line":700,"in_reply_to":"dac4157f_6a9cb569","updated":"2015-04-20 14:50:26.000000000","message":"Since the current code in Common only creates the keys that are specific to the selected mq service type, we need to have these sections gated off such that we don\u0027t try to access a un initialized attributes.","commit_id":"34480278c17e5e76455d5178ead91cfdeea96180"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"531f0cd55032c04172cd75ebfe21618561b7b470","unresolved":false,"context_lines":[{"line_number":768,"context_line":"qpid_topology_version \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027mq\u0027][\u0027identity\u0027][\u0027qpid\u0027][\u0027topology_version\u0027] %\u003e"},{"line_number":769,"context_line":"\u003c% end -%\u003e"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"\u003c% if @mq_service_type \u003d\u003d \"rabbitmq\"  -%\u003e"},{"line_number":772,"context_line":"[oslo_messaging_rabbit]"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"#"}],"source_content_type":"application/x-erb","patch_set":6,"id":"dac4157f_eab8c5e7","line":771,"updated":"2015-04-20 08:11:26.000000000","message":"should not judge the notification_driver here ?","commit_id":"34480278c17e5e76455d5178ead91cfdeea96180"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"080ce310982059b266525e84527b69fe6b6e9134","unresolved":false,"context_lines":[{"line_number":768,"context_line":"qpid_topology_version \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027mq\u0027][\u0027identity\u0027][\u0027qpid\u0027][\u0027topology_version\u0027] %\u003e"},{"line_number":769,"context_line":"\u003c% end -%\u003e"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"\u003c% if @mq_service_type \u003d\u003d \"rabbitmq\"  -%\u003e"},{"line_number":772,"context_line":"[oslo_messaging_rabbit]"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"#"}],"source_content_type":"application/x-erb","patch_set":6,"id":"dac4157f_38404956","line":771,"in_reply_to":"dac4157f_eab8c5e7","updated":"2015-04-20 14:50:26.000000000","message":"Since the current code in Common only creates the keys that are specific to the selected mq service type, we need to have these sections gated off such that we don\u0027t try to access a un initialized attributes.","commit_id":"34480278c17e5e76455d5178ead91cfdeea96180"}]}