)]}'
{"providers/register.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5bb354e901f19069a15a9135674a5cd827016710","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def service_need_updated?(resource, args \u003d {}, uuid_field \u003d \u0027id\u0027)"},{"line_number":118,"context_line":"  begin"},{"line_number":119,"context_line":"    p \u0027service_need_updated\u0027"},{"line_number":120,"context_line":"    output \u003d identity_command resource, \u0027service-list\u0027, args"},{"line_number":121,"context_line":"    output \u003d prettytable_to_array(output)"},{"line_number":122,"context_line":"    return search_uuid(output, uuid_field, \u0027name\u0027 \u003d\u003e resource.service_name, \u0027type\u0027 \u003d\u003e resource.service_type).nil?"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a0c5dc1_e297838e","line":119,"updated":"2015-05-13 14:52:50.000000000","message":"Need to clean this up","commit_id":"355385f8199b2005ba032578734b8965dfec4084"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5bb354e901f19069a15a9135674a5cd827016710","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    output \u003d prettytable_to_array(output)"},{"line_number":122,"context_line":"    return search_uuid(output, uuid_field, \u0027name\u0027 \u003d\u003e resource.service_name, \u0027type\u0027 \u003d\u003e resource.service_type).nil?"},{"line_number":123,"context_line":"  rescue RuntimeError \u003d\u003e e"},{"line_number":124,"context_line":"    raise \"Could not check service attributes for service: type \u003d\u003e #{resource.service_type}. Error was #{e.message}\""},{"line_number":125,"context_line":"  end"},{"line_number":126,"context_line":"  false"},{"line_number":127,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a0c5dc1_22a6bb10","line":124,"updated":"2015-05-13 14:52:50.000000000","message":"maybe add in the service_name here?","commit_id":"355385f8199b2005ba032578734b8965dfec4084"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"5bb354e901f19069a15a9135674a5cd827016710","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    begin"},{"line_number":148,"context_line":"      service_uuid \u003d identity_uuid new_resource, \u0027service\u0027, \u0027type\u0027, new_resource.service_type"},{"line_number":149,"context_line":"      need_updated \u003d false"},{"line_number":150,"context_line":"      p \u0027service uuid check\u0027"},{"line_number":151,"context_line":"      if service_uuid"},{"line_number":152,"context_line":"        Chef::Log.info(\"Service Type \u0027#{new_resource.service_type}\u0027 already exists..\")"},{"line_number":153,"context_line":"        Chef::Log.info(\"Service UUID: #{service_uuid}\")"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a0c5dc1_828c4780","line":150,"updated":"2015-05-13 14:52:50.000000000","message":"Need to clean this up","commit_id":"355385f8199b2005ba032578734b8965dfec4084"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"4cf0918cbc2bc85e69f3d53acfdc44282c03bd79","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      if service_uuid"},{"line_number":150,"context_line":"        Chef::Log.info(\"Service Type \u0027#{new_resource.service_type}\u0027 already exists..\")"},{"line_number":151,"context_line":"        Chef::Log.info(\"Service UUID: #{service_uuid}\")"},{"line_number":152,"context_line":"        need_updated \u003d service_need_updated? new_resource"},{"line_number":153,"context_line":"        if need_updated"},{"line_number":154,"context_line":"          Chef::Log.info(\"Service Type \u0027#{new_resource.service_type}\u0027 needs to be updated, delete it first.\")"},{"line_number":155,"context_line":"          identity_command(new_resource, \u0027service-delete\u0027,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"7a016987_3d7a63f2","line":152,"updated":"2015-05-15 14:13:38.000000000","message":"Something seems off here.  for the existing endpoint code, it uses the UUID to see if it already exists, but I dont see that being passed to the service_need_updated?.\n\nI expected something like this:\n\nneed_updated \u003d service_need_updated? new_resource, \u0027service_id\u0027, service_uuid\n\nAnd then in the service_need_updated?  handle it much like the existing endpoint one.\n\ndef service_need_updated?(resource, key, value, args \u003d {}, uuid_field \u003d \u0027id\u0027)\n\n...\n\nreturn search_uuid(output, uuid_field, key \u003d\u003e value, \u0027name\u0027 \u003d\u003e resource.service_name, \u0027type\u0027 \u003d\u003e resource.service_type).nil?\n\nThat way we\u0027re checking the uuid which is unique and not the name which I don\u0027t believe is guaranteed to be unique.","commit_id":"f5a583b48106f65da53900613a26a0c3d1fe8b58"},{"author":{"_account_id":14888,"name":"Kasey Alusi","email":"kasey.alusi@gmail.com","username":"kasey.alusi"},"change_message_id":"8ab4d72e58a49fc632c232e700dbc552b17f259e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      if service_uuid"},{"line_number":150,"context_line":"        Chef::Log.info(\"Service Type \u0027#{new_resource.service_type}\u0027 already exists..\")"},{"line_number":151,"context_line":"        Chef::Log.info(\"Service UUID: #{service_uuid}\")"},{"line_number":152,"context_line":"        need_updated \u003d service_need_updated? new_resource"},{"line_number":153,"context_line":"        if need_updated"},{"line_number":154,"context_line":"          Chef::Log.info(\"Service Type \u0027#{new_resource.service_type}\u0027 needs to be updated, delete it first.\")"},{"line_number":155,"context_line":"          identity_command(new_resource, \u0027service-delete\u0027,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"7a016987_89c4725f","line":152,"in_reply_to":"7a016987_3d7a63f2","updated":"2015-05-15 16:31:32.000000000","message":"The endpoint check is passing in the service id because it associates an endpoint with a service, but when we want to see if we need to update values in a service entry with fields (id, name, type, description) we dont want to check the ID right?  The endpoint_need_update? does not check the endpoint id itself.","commit_id":"f5a583b48106f65da53900613a26a0c3d1fe8b58"}]}