)]}'
{"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"fc27b03afed3bfa173d7b3022916fdf7ec87aa72","unresolved":false,"context_lines":[{"line_number":7,"context_line":"version \u002713.0.0\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"recipe \u0027openstack-identity::client\u0027, \u0027Install packages required for keystone client\u0027"},{"line_number":10,"context_line":"recipe \u0027openstack-identity::server\u0027, \u0027Installs and Configures Keystone Service\u0027"},{"line_number":11,"context_line":"recipe \u0027openstack-identity::server-apache\u0027, \u0027Installs and Configures Keystone Service under Apache\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-identity::registration\u0027, \u0027Adds user, tenant, role and endpoint records to Keystone\u0027"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_fe017b6b","line":10,"updated":"2016-01-07 16:44:37.000000000","message":"time to remove this?","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d8d60eb83367305b5358ad5fc03a7b2354d9b75c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"version \u002713.0.0\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"recipe \u0027openstack-identity::client\u0027, \u0027Install packages required for keystone client\u0027"},{"line_number":10,"context_line":"recipe \u0027openstack-identity::server\u0027, \u0027Installs and Configures Keystone Service\u0027"},{"line_number":11,"context_line":"recipe \u0027openstack-identity::server-apache\u0027, \u0027Installs and Configures Keystone Service under Apache\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-identity::registration\u0027, \u0027Adds user, tenant, role and endpoint records to Keystone\u0027"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_ef43ce6a","line":10,"in_reply_to":"fa69d971_fe017b6b","updated":"2016-01-08 08:01:39.000000000","message":"Done","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"fc27b03afed3bfa173d7b3022916fdf7ec87aa72","unresolved":false,"context_lines":[{"line_number":10,"context_line":"recipe \u0027openstack-identity::server\u0027, \u0027Installs and Configures Keystone Service\u0027"},{"line_number":11,"context_line":"recipe \u0027openstack-identity::server-apache\u0027, \u0027Installs and Configures Keystone Service under Apache\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-identity::registration\u0027, \u0027Adds user, tenant, role and endpoint records to Keystone\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"%w(ubuntu fedora redhat centos suse).each do |os|"},{"line_number":15,"context_line":"  supports os"},{"line_number":16,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_5e5447c9","line":13,"updated":"2016-01-07 16:44:37.000000000","message":"new openrc recipe?","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"},{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"b93a05d99c78b7c2226f3d05b7f5d45da2a4e3ac","unresolved":false,"context_lines":[{"line_number":10,"context_line":"recipe \u0027openstack-identity::server\u0027, \u0027Installs and Configures Keystone Service\u0027"},{"line_number":11,"context_line":"recipe \u0027openstack-identity::server-apache\u0027, \u0027Installs and Configures Keystone Service under Apache\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-identity::registration\u0027, \u0027Adds user, tenant, role and endpoint records to Keystone\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"%w(ubuntu fedora redhat centos suse).each do |os|"},{"line_number":15,"context_line":"  supports os"},{"line_number":16,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_ed0f8b86","line":13,"in_reply_to":"fa69d971_5e5447c9","updated":"2016-01-07 18:32:08.000000000","message":"Agreed.","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d8d60eb83367305b5358ad5fc03a7b2354d9b75c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"recipe \u0027openstack-identity::server\u0027, \u0027Installs and Configures Keystone Service\u0027"},{"line_number":11,"context_line":"recipe \u0027openstack-identity::server-apache\u0027, \u0027Installs and Configures Keystone Service under Apache\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-identity::registration\u0027, \u0027Adds user, tenant, role and endpoint records to Keystone\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"%w(ubuntu fedora redhat centos suse).each do |os|"},{"line_number":15,"context_line":"  supports os"},{"line_number":16,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_0f474278","line":13,"in_reply_to":"fa69d971_ed0f8b86","updated":"2016-01-08 08:01:39.000000000","message":"Done","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"}],"recipes/server-apache.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"fc27b03afed3bfa173d7b3022916fdf7ec87aa72","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  # populate the templated catlog, if you\u0027re using the templated catalog backend"},{"line_number":263,"context_line":"  uris \u003d {"},{"line_number":264,"context_line":"    \u0027identity-admin\u0027 \u003d\u003e identity_admin_endpoint.to_s.gsub(\u0027%25\u0027, \u0027%\u0027),"},{"line_number":265,"context_line":"    \u0027identity\u0027 \u003d\u003e identity_public_endpoint.to_s.gsub(\u0027%25\u0027, \u0027%\u0027),"},{"line_number":266,"context_line":"    \u0027image\u0027 \u003d\u003e image_public_endpoint.to_s.gsub(\u0027%25\u0027, \u0027%\u0027),"},{"line_number":267,"context_line":"    \u0027compute\u0027 \u003d\u003e compute_public_endpoint.to_s.gsub(\u0027%25\u0027, \u0027%\u0027),"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_7ec02b2b","line":264,"updated":"2016-01-07 16:44:37.000000000","message":"DRY, ugly to use to_s.gsub(), why not either create small helper method to  handle this.   Isn\u0027t this already done in Common somewhere?","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d8d60eb83367305b5358ad5fc03a7b2354d9b75c","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  # populate the templated catlog, if you\u0027re using the templated catalog backend"},{"line_number":263,"context_line":"  uris \u003d {"},{"line_number":264,"context_line":"    \u0027identity-admin\u0027 \u003d\u003e identity_admin_endpoint.to_s.gsub(\u0027%25\u0027, \u0027%\u0027),"},{"line_number":265,"context_line":"    \u0027identity\u0027 \u003d\u003e identity_public_endpoint.to_s.gsub(\u0027%25\u0027, \u0027%\u0027),"},{"line_number":266,"context_line":"    \u0027image\u0027 \u003d\u003e image_public_endpoint.to_s.gsub(\u0027%25\u0027, \u0027%\u0027),"},{"line_number":267,"context_line":"    \u0027compute\u0027 \u003d\u003e compute_public_endpoint.to_s.gsub(\u0027%25\u0027, \u0027%\u0027),"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_efd0aecb","line":264,"in_reply_to":"fa69d971_7ec02b2b","updated":"2016-01-08 08:01:39.000000000","message":"I agree, but since i am not sure we want to keep this part at all (especially in that form), i do not want to refactor this right now (just moved this part into some guards since it was interfering with the refactored endpoint logic). I think this should probably be moved to another recipe in a next step and maybe not completely filled in the identity cookbook, but rather from the other service cookbooks, since it is possible that somebody wants to add or remove something here (still not sure if anybody is using this option at all).","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"}],"spec/server-apache_spec.rb":[{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"b93a05d99c78b7c2226f3d05b7f5d45da2a4e3ac","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        end"},{"line_number":304,"context_line":"      end"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"      # describe \u0027[saml] section\u0027 do"},{"line_number":307,"context_line":"      #   describe \u0027saml attributes\u0027 do"},{"line_number":308,"context_line":"      #     saml_default_attrs \u003d %w(assertion_expiration_time \u003d 3600"},{"line_number":309,"context_line":"      #                             xmlsec1_binary \u003d xmlsec1"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_8d884fc8","line":306,"updated":"2016-01-07 18:32:08.000000000","message":"Probably remove these also, if they are commented out no need for them.","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d8d60eb83367305b5358ad5fc03a7b2354d9b75c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        end"},{"line_number":304,"context_line":"      end"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"      # describe \u0027[saml] section\u0027 do"},{"line_number":307,"context_line":"      #   describe \u0027saml attributes\u0027 do"},{"line_number":308,"context_line":"      #     saml_default_attrs \u003d %w(assertion_expiration_time \u003d 3600"},{"line_number":309,"context_line":"      #                             xmlsec1_binary \u003d xmlsec1"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa69d971_6f811e8f","line":306,"in_reply_to":"fa69d971_8d884fc8","updated":"2016-01-08 08:01:39.000000000","message":"Good point, i think they were commented out in the big refactoring patch before and should also be removed there if not needed. I will talk to Christoph (calbers) and figure out if we can or should remove them.","commit_id":"ff85a8d27a611cb61cd56f7b0cc23c0f9b402095"}]}