)]}'
{"providers/service.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"63c1dfdc44649f6e76940a00eb7a910752ce5dbd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Copyright 2012, Rackspace US, Inc."},{"line_number":7,"context_line":"# Copyright 2012-2013, AT\u0026T Services, Inc."},{"line_number":8,"context_line":"# Copyright 2013, Opscode, Inc."},{"line_number":9,"context_line":"# Copyright 2013, Craig Tracey \u003ccraigtracey@gmail.com\u003e"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":12,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa7ab95a_13b60c3d","line":9,"updated":"2016-08-29 06:38:37.000000000","message":"This file looks rather new, so where do all these Copyrights originate from? Maybe just a copy/paste thing?","commit_id":"9c1b0be2392ffbeb2fa23bade9f1a77df25c20fc"},{"author":{"_account_id":23300,"name":"Brian Fletcher","email":"brian.jf.fletcher@gmail.com","username":"brian.fletcher"},"change_message_id":"cfad48a7eb18d363307c33704ff814d8f3c4dd13","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Copyright 2012, Rackspace US, Inc."},{"line_number":7,"context_line":"# Copyright 2012-2013, AT\u0026T Services, Inc."},{"line_number":8,"context_line":"# Copyright 2013, Opscode, Inc."},{"line_number":9,"context_line":"# Copyright 2013, Craig Tracey \u003ccraigtracey@gmail.com\u003e"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":12,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa7ab95a_5d49ba8d","line":9,"in_reply_to":"fa7ab95a_13b60c3d","updated":"2016-08-31 18:25:29.000000000","message":"Yes it was copy and paste. I will remove these lines in the next patchset.","commit_id":"9c1b0be2392ffbeb2fa23bade9f1a77df25c20fc"},{"author":{"_account_id":23300,"name":"Brian Fletcher","email":"brian.jf.fletcher@gmail.com","username":"brian.fletcher"},"change_message_id":"3470ca869aff6e7e61b5fb3dbf1290e31dedf53e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Copyright 2012, Rackspace US, Inc."},{"line_number":7,"context_line":"# Copyright 2012-2013, AT\u0026T Services, Inc."},{"line_number":8,"context_line":"# Copyright 2013, Opscode, Inc."},{"line_number":9,"context_line":"# Copyright 2013, Craig Tracey \u003ccraigtracey@gmail.com\u003e"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":12,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa7ab95a_2c4e3f6f","line":9,"in_reply_to":"fa7ab95a_5d49ba8d","updated":"2016-09-01 17:52:50.000000000","message":"Done","commit_id":"9c1b0be2392ffbeb2fa23bade9f1a77df25c20fc"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"e39eb4ee9501fe7b48eb10cc161487d514452e55","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    command \u0027uname\u0027"},{"line_number":28,"context_line":"    # We are restarting apache here because other recipes running in the chef-client run may be depending on"},{"line_number":29,"context_line":"    # keystone to be configured."},{"line_number":30,"context_line":"    notifies :reload, \u0027service[apache2]\u0027, :immediately"},{"line_number":31,"context_line":"    action :run"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa7ab95a_d0bee563","line":30,"updated":"2016-08-30 16:18:37.000000000","message":"Was it intended to use reload instead of restart? The current iteration uses restart because of the issue fixed in https://review.openstack.org/#/c/360124/. We probably want to keep that here I would think.","commit_id":"9c1b0be2392ffbeb2fa23bade9f1a77df25c20fc"},{"author":{"_account_id":23300,"name":"Brian Fletcher","email":"brian.jf.fletcher@gmail.com","username":"brian.fletcher"},"change_message_id":"cfad48a7eb18d363307c33704ff814d8f3c4dd13","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    command \u0027uname\u0027"},{"line_number":28,"context_line":"    # We are restarting apache here because other recipes running in the chef-client run may be depending on"},{"line_number":29,"context_line":"    # keystone to be configured."},{"line_number":30,"context_line":"    notifies :reload, \u0027service[apache2]\u0027, :immediately"},{"line_number":31,"context_line":"    action :run"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa7ab95a_dd5dca49","line":30,"in_reply_to":"fa7ab95a_d0bee563","updated":"2016-08-31 18:25:29.000000000","message":"It was intended to be a restart. I will fix this.","commit_id":"9c1b0be2392ffbeb2fa23bade9f1a77df25c20fc"},{"author":{"_account_id":23300,"name":"Brian Fletcher","email":"brian.jf.fletcher@gmail.com","username":"brian.fletcher"},"change_message_id":"3470ca869aff6e7e61b5fb3dbf1290e31dedf53e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    command \u0027uname\u0027"},{"line_number":28,"context_line":"    # We are restarting apache here because other recipes running in the chef-client run may be depending on"},{"line_number":29,"context_line":"    # keystone to be configured."},{"line_number":30,"context_line":"    notifies :reload, \u0027service[apache2]\u0027, :immediately"},{"line_number":31,"context_line":"    action :run"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa7ab95a_6c54c7fd","line":30,"in_reply_to":"fa7ab95a_dd5dca49","updated":"2016-09-01 17:52:50.000000000","message":"Done","commit_id":"9c1b0be2392ffbeb2fa23bade9f1a77df25c20fc"}],"recipes/server-apache.rb":[{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"99d84314b4483bcde37beff8f45eae983012cbb2","unresolved":false,"context_lines":[{"line_number":334,"context_line":"  end"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"  openstack_identity_service \u0027restart identity service\u0027 do"},{"line_number":337,"context_line":"    subscribes :restart, \"template[#{node[\u0027apache\u0027][\u0027dir\u0027]}/sites-available/keystone-#{app}.conf]\", :immediately"},{"line_number":338,"context_line":"    action :nothing"},{"line_number":339,"context_line":"  end"},{"line_number":340,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a89bdaa_d6f76ff3","line":337,"updated":"2016-09-09 16:35:12.000000000","message":"If you add:\n\nsubscribes :restart, \"template[#{node[\u0027apache\u0027][\u0027dir\u0027]}/sites-available/keystone-#{app}.conf]\", :immediately\n\nThis will also reload on config changes to the template. I\u0027ve confirmed this on my end as well.","commit_id":"4e08dc3c8d694f978aade0eebc381f8b24eff66d"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"d3799c84f53ab6eb5d1ffbb88228d94b0992fd5f","unresolved":false,"context_lines":[{"line_number":334,"context_line":"  end"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"  openstack_identity_service \u0027restart identity service\u0027 do"},{"line_number":337,"context_line":"    subscribes :restart, \"execute[a2ensite keystone-#{app}.conf]\", :immediately"},{"line_number":338,"context_line":"    action :nothing"},{"line_number":339,"context_line":"  end"},{"line_number":340,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a89bdaa_3655fbc5","line":337,"updated":"2016-09-09 16:36:37.000000000","message":"If you add the following here as well to this:\n\nsubscribes :restart, \"template[#{node[\u0027apache\u0027][\u0027dir\u0027]}/sites-available/keystone-#{app}.conf]\", :immediately\n\nIt will update on changes to the template. I\u0027ve tested it on my end as well.","commit_id":"da3dd293456fb6af19a2628dadbca4f024907e95"},{"author":{"_account_id":23300,"name":"Brian Fletcher","email":"brian.jf.fletcher@gmail.com","username":"brian.fletcher"},"change_message_id":"e2a6c355c40faef8e70caf677a296d3c50e0e333","unresolved":false,"context_lines":[{"line_number":334,"context_line":"  end"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"  openstack_identity_service \u0027restart identity service\u0027 do"},{"line_number":337,"context_line":"    subscribes :restart, \"execute[a2ensite keystone-#{app}.conf]\", :immediately"},{"line_number":338,"context_line":"    action :nothing"},{"line_number":339,"context_line":"  end"},{"line_number":340,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a89bdaa_a7b8a576","line":337,"in_reply_to":"9a89bdaa_3655fbc5","updated":"2016-09-12 17:57:15.000000000","message":"done. this may mean that apache will be restarted and a sleep four times on the first chef run.","commit_id":"da3dd293456fb6af19a2628dadbca4f024907e95"}]}