)]}'
{"recipes/server-apache.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"34f10cc9eba87a908c8235fbe7cc95d473b0ed27","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      package_name pkg"},{"line_number":58,"context_line":"      options platform_options[\u0027package_options\u0027]"},{"line_number":59,"context_line":"      action :upgrade"},{"line_number":60,"context_line":"      retries 10"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":"  end"},{"line_number":63,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a30ddce_19e8697c","line":60,"updated":"2017-03-07 07:26:44.000000000","message":"i don\u0027t like the retries here since imho a package not being installed on the first try seems like a bug to me (if the mirror sucks, we should change the mirror)","commit_id":"2cfa8d10c1a97e78d01394ee298530c55ca9fc61"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"0b04e08bb5bba57d9bc482803ece4ae9ce275089","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      package_name pkg"},{"line_number":58,"context_line":"      options platform_options[\u0027package_options\u0027]"},{"line_number":59,"context_line":"      action :upgrade"},{"line_number":60,"context_line":"      retries 10"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":"  end"},{"line_number":63,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a30ddce_f71aac16","line":60,"in_reply_to":"9a30ddce_19e8697c","updated":"2017-03-07 14:41:25.000000000","message":"agreed. this change doesn\u0027t make sense with the yum changes. away it goes","commit_id":"2cfa8d10c1a97e78d01394ee298530c55ca9fc61"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"34f10cc9eba87a908c8235fbe7cc95d473b0ed27","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    package_name pkg"},{"line_number":69,"context_line":"    options platform_options[\u0027package_options\u0027]"},{"line_number":70,"context_line":"    action :upgrade"},{"line_number":71,"context_line":"    retries 10"},{"line_number":72,"context_line":"  end"},{"line_number":73,"context_line":"end"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a30ddce_39ed2d8c","line":71,"updated":"2017-03-07 07:26:44.000000000","message":"same as above","commit_id":"2cfa8d10c1a97e78d01394ee298530c55ca9fc61"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"0b04e08bb5bba57d9bc482803ece4ae9ce275089","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    package_name pkg"},{"line_number":69,"context_line":"    options platform_options[\u0027package_options\u0027]"},{"line_number":70,"context_line":"    action :upgrade"},{"line_number":71,"context_line":"    retries 10"},{"line_number":72,"context_line":"  end"},{"line_number":73,"context_line":"end"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a30ddce_b7e75411","line":71,"in_reply_to":"9a30ddce_39ed2d8c","updated":"2017-03-07 14:41:25.000000000","message":"ditto","commit_id":"2cfa8d10c1a97e78d01394ee298530c55ca9fc61"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"34f10cc9eba87a908c8235fbe7cc95d473b0ed27","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    package_name pkg"},{"line_number":79,"context_line":"    options platform_options[\u0027package_options\u0027]"},{"line_number":80,"context_line":"    action :upgrade"},{"line_number":81,"context_line":"    retries 10"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":"end"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a30ddce_5902e13f","line":81,"updated":"2017-03-07 07:26:44.000000000","message":"same as above","commit_id":"2cfa8d10c1a97e78d01394ee298530c55ca9fc61"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"0b04e08bb5bba57d9bc482803ece4ae9ce275089","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    package_name pkg"},{"line_number":79,"context_line":"    options platform_options[\u0027package_options\u0027]"},{"line_number":80,"context_line":"    action :upgrade"},{"line_number":81,"context_line":"    retries 10"},{"line_number":82,"context_line":"  end"},{"line_number":83,"context_line":"end"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a30ddce_57bff8cf","line":81,"in_reply_to":"9a30ddce_5902e13f","updated":"2017-03-07 14:41:25.000000000","message":"ditto","commit_id":"2cfa8d10c1a97e78d01394ee298530c55ca9fc61"}],"spec/spec_helper.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"34f10cc9eba87a908c8235fbe7cc95d473b0ed27","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      .and_return(\u0027admin\u0027)"},{"line_number":67,"context_line":"    allow_any_instance_of(Chef::Recipe).to receive(:rabbit_transport_url)"},{"line_number":68,"context_line":"      .with(\u0027identity\u0027)"},{"line_number":69,"context_line":"      .and_return(\u0027rabbit://openstack:mypass@127.0.0.1:5672\u0027)"},{"line_number":70,"context_line":"    stub_command(\"[ ! -e /etc/httpd/conf/httpd.conf ] \u0026\u0026 [ -e /etc/redhat-release ] \u0026\u0026 [ $(/sbin/sestatus | grep -c \u0027^Current mode:.*enforcing\u0027) -eq 1 ]\").and_return(true)"},{"line_number":71,"context_line":"  end"},{"line_number":72,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a30ddce_59b0218c","line":69,"updated":"2017-03-07 07:26:44.000000000","message":"why do we need to change this stub?","commit_id":"2cfa8d10c1a97e78d01394ee298530c55ca9fc61"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"0b04e08bb5bba57d9bc482803ece4ae9ce275089","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      .and_return(\u0027admin\u0027)"},{"line_number":67,"context_line":"    allow_any_instance_of(Chef::Recipe).to receive(:rabbit_transport_url)"},{"line_number":68,"context_line":"      .with(\u0027identity\u0027)"},{"line_number":69,"context_line":"      .and_return(\u0027rabbit://openstack:mypass@127.0.0.1:5672\u0027)"},{"line_number":70,"context_line":"    stub_command(\"[ ! -e /etc/httpd/conf/httpd.conf ] \u0026\u0026 [ -e /etc/redhat-release ] \u0026\u0026 [ $(/sbin/sestatus | grep -c \u0027^Current mode:.*enforcing\u0027) -eq 1 ]\").and_return(true)"},{"line_number":71,"context_line":"  end"},{"line_number":72,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a30ddce_b7967492","line":69,"in_reply_to":"9a30ddce_59b0218c","updated":"2017-03-07 14:41:25.000000000","message":"the use of \u0027guest\u0027 is insecure and considered an anti-pattern, so the default needs to change. other CM projects explicitly delete \u0027guest\u0027","commit_id":"2cfa8d10c1a97e78d01394ee298530c55ca9fc61"}]}
