)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89c568512dfa9cd61acbbbf179eb18e38a699a82","unresolved":false,"context_lines":[{"line_number":9,"context_line":"instead of hard coded vault name the attribute"},{"line_number":10,"context_line":"[\u0027openstack\u0027][\u0027secret\u0027][\u0027secrets_data_bag\u0027] is used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I06dc597f0503f399ed1369214e92b2acbc36c774"},{"line_number":13,"context_line":"Change-Id: I286fbfe89395544d1f8d0139acca0d689e4737fa"},{"line_number":14,"context_line":"Closes-Bug: #1714523"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ff5d4b2f_4d664d54","line":12,"updated":"2017-09-19 04:54:12.000000000","message":"You need to remove this, since it causes a dependency cycle.","commit_id":"276f0a742acbb6c171f81de0adc4bc401001fc4d"}],"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2d605e933ea36bd106f244c453a929eee761656","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  \u0027/etc/keystone/fernet-tokens\u0027"},{"line_number":136,"context_line":"# Switch fernet token data bag. Default use \u0027keystone\u0027 data bag else use secrets data bag."},{"line_number":137,"context_line":"# So existing data bags don\u0027t have to be updated."},{"line_number":138,"context_line":"default[\u0027openstack\u0027][\u0027identity\u0027][\u0027fernet\u0027][\u0027use_secrets_data_bag\u0027] \u003d false"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# The external (REMOTE_USER) auth plugin module. (String value)"},{"line_number":141,"context_line":"default[\u0027openstack\u0027][\u0027identity\u0027][\u0027auth\u0027][\u0027external\u0027] \u003d \u0027keystone.auth.plugins.external.DefaultDomain\u0027"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5f2577a7_fe08d628","line":138,"updated":"2017-09-12 08:45:36.000000000","message":"IMO this adds unneccessary complexity. Let us just admit that adding the keystone databag was a mistake and switch to the default \u0027secrets_data_bag\u0027 instead.","commit_id":"370fe9b25778e05cad18a226baa344edf3e28ccf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c6e7f1d84007e6ba316d3028f69b1bb820131825","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  \u0027/etc/keystone/fernet-tokens\u0027"},{"line_number":136,"context_line":"# Switch fernet token data bag. Default use \u0027keystone\u0027 data bag else use secrets data bag."},{"line_number":137,"context_line":"# So existing data bags don\u0027t have to be updated."},{"line_number":138,"context_line":"default[\u0027openstack\u0027][\u0027identity\u0027][\u0027fernet\u0027][\u0027use_secrets_data_bag\u0027] \u003d false"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# The external (REMOTE_USER) auth plugin module. (String value)"},{"line_number":141,"context_line":"default[\u0027openstack\u0027][\u0027identity\u0027][\u0027auth\u0027][\u0027external\u0027] \u003d \u0027keystone.auth.plugins.external.DefaultDomain\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"5f2577a7_dec60d9b","line":138,"updated":"2017-09-13 15:39:15.000000000","message":"You no longer use this attribute, so it should be dropped from the patch","commit_id":"1c3e319c2ef1c83d3ddb74e3fe0fd2aecd17732e"}],"recipes/_fernet_tokens.rb":[{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"e19d5ade4c8c7c5db9da5c03aac51ce3cd206f06","unresolved":false,"context_lines":[{"line_number":33,"context_line":"end"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Switch fernet token data bag."},{"line_number":36,"context_line":"if node[\u0027openstack\u0027][\u0027identity\u0027][\u0027fernet\u0027][\u0027use_secrets_data_bag\u0027]"},{"line_number":37,"context_line":"  vault_name \u003d node[\u0027openstack\u0027][\u0027secret\u0027][\u0027secrets_data_bag\u0027]"},{"line_number":38,"context_line":"else"},{"line_number":39,"context_line":"  vault_name \u003d \u0027keystone\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f2577a7_9e7d7be9","line":36,"updated":"2017-09-09 13:22:40.000000000","message":"failing due to rubocop. see http://logs.openstack.org/74/501274/3/check/gate-cookbook-openstack-identity-chef-rake/f822409/","commit_id":"3fd05da8ce5862a26bd83421dbdee3caace7a3fd"}]}
