)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea7565cc884c9d9b440e557b63c04db4ed42e16","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rename keystone-main service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* rename keystone-main to keystone-public to better align with Keystone"},{"line_number":10,"context_line":"  conventions"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I98a5d41b4de3a3d7ef680d00ac898c93c5bc2a41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_4fc476f5","line":10,"updated":"2018-03-23 09:27:36.000000000","message":"I\u0027m not sure which conventions you are referring to. IIUC the keystone-main service has its name because it will serve both public and internal endpoints if the latter are configured. So renaming it would be misleading.","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"64929738d84a5f5c4acddc869cf61d6186d83e09","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rename keystone-main service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* rename keystone-main to keystone-public to better align with Keystone"},{"line_number":10,"context_line":"  conventions"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I98a5d41b4de3a3d7ef680d00ac898c93c5bc2a41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_8ed84b53","line":10,"in_reply_to":"df7087c5_4fc476f5","updated":"2018-03-23 13:04:20.000000000","message":"Looking further at other deployment projects, there is barely even a loose convention on this service naming: OpenStack-Ansible has a mixture of calling it both \"main\" and \"public\", Puppet OpenStack uses \"public\", and Chef uses \"main\". It\u0027s probably not worth the churn to rename the service at this stage, particularly with no cohesiveness on this particular service name between the projects.","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"}],"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea7565cc884c9d9b440e557b63c04db4ed42e16","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# to contain a custom banner at the top of the written file"},{"line_number":26,"context_line":"default[\u0027openstack\u0027][\u0027identity\u0027][\u0027custom_template_banner\u0027] \u003d \u0027"},{"line_number":27,"context_line":"# This file is automatically generated by Chef"},{"line_number":28,"context_line":"# Any hanges will be overwritten"},{"line_number":29,"context_line":"\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"%w(admin internal public).each do |ep_type|"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df7087c5_4ff6b665","line":28,"updated":"2018-03-23 09:27:36.000000000","message":"changes","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"}],"recipes/server-apache.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea7565cc884c9d9b440e557b63c04db4ed42e16","unresolved":false,"context_lines":[{"line_number":351,"context_line":"  end"},{"line_number":352,"context_line":"end"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"# disable keystone vhost from package since ubuntu autoenables this"},{"line_number":355,"context_line":"apache_site \u0027keystone\u0027 do"},{"line_number":356,"context_line":"  enable false"},{"line_number":357,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df7087c5_0fd3ded6","line":354,"updated":"2018-03-23 09:27:36.000000000","message":"This still sounds confusing to me. Maybe\n\ndisable keystone vhost that the ubuntu package automatically installed\n\nDo we need to wrap this resource for ubuntu only, then?","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"64929738d84a5f5c4acddc869cf61d6186d83e09","unresolved":false,"context_lines":[{"line_number":351,"context_line":"  end"},{"line_number":352,"context_line":"end"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"# disable keystone vhost from package since ubuntu autoenables this"},{"line_number":355,"context_line":"apache_site \u0027keystone\u0027 do"},{"line_number":356,"context_line":"  enable false"},{"line_number":357,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df7087c5_ee946746","line":354,"in_reply_to":"df7087c5_0fd3ded6","updated":"2018-03-23 13:04:20.000000000","message":"Since UCA is the only offender here, guarding it with not_if / only_if is something that can be done, even if the resource does nothing on RHEL. The comment wording needs to be rewritten, I agree.","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"}],"spec/server-apache_spec.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea7565cc884c9d9b440e557b63c04db4ed42e16","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# c encoding: UTF-8"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"require_relative \u0027spec_helper\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df7087c5_6fa85a1f","line":1,"updated":"2018-03-23 09:27:36.000000000","message":"Hmm?","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"64929738d84a5f5c4acddc869cf61d6186d83e09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# c encoding: UTF-8"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"require_relative \u0027spec_helper\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df7087c5_4eb313ea","line":1,"in_reply_to":"df7087c5_6fa85a1f","updated":"2018-03-23 13:04:20.000000000","message":"ENOCAFFEINE and/or fat-finger. Judging from the time of day the change was proposed, probably the former.","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cea7565cc884c9d9b440e557b63c04db4ed42e16","unresolved":false,"context_lines":[{"line_number":364,"context_line":"            )"},{"line_number":365,"context_line":"          end"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"          it \u0027configures  lines\u0027 do"},{"line_number":368,"context_line":"            node.set[\u0027openstack\u0027][\u0027identity\u0027][\u0027custom_template_banner\u0027] \u003d \u0027custom_template_banner_value\u0027"},{"line_number":369,"context_line":"            [/^custom_template_banner_value$/,"},{"line_number":370,"context_line":"             /user\u003dkeystone/,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df7087c5_0f48be84","line":367,"updated":"2018-03-23 09:27:36.000000000","message":"Did you want to insert \"keystone-admin.conf\" here similar to what you did below?","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"64929738d84a5f5c4acddc869cf61d6186d83e09","unresolved":false,"context_lines":[{"line_number":364,"context_line":"            )"},{"line_number":365,"context_line":"          end"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"          it \u0027configures  lines\u0027 do"},{"line_number":368,"context_line":"            node.set[\u0027openstack\u0027][\u0027identity\u0027][\u0027custom_template_banner\u0027] \u003d \u0027custom_template_banner_value\u0027"},{"line_number":369,"context_line":"            [/^custom_template_banner_value$/,"},{"line_number":370,"context_line":"             /user\u003dkeystone/,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"df7087c5_6eb857c7","line":367,"in_reply_to":"df7087c5_0f48be84","updated":"2018-03-23 13:04:20.000000000","message":"Probably so, but this is being reworked based on research into other deployment projects.","commit_id":"1ff48952b2f8be3fff58967e79a6cc6eb223ccec"}]}