)]}'
{"id":"openstack%2Fcookbook-openstack-identity~669583","triplet_id":"openstack%2Fcookbook-openstack-identity~master~I13de063d1e7ffd356d754eb0f2d8286a3c694836","project":"openstack/cookbook-openstack-identity","branch":"master","topic":"apache-restarts-notifications","hashtags":[],"change_id":"I13de063d1e7ffd356d754eb0f2d8286a3c694836","subject":"Properly notify apache restarts on keystone configuration updates","status":"MERGED","created":"2019-07-08 01:38:54.000000000","updated":"2019-08-20 13:36:40.000000000","submitted":"2019-08-20 13:36:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"669583-1566308200970-16970a7d","meta_rev_id":"de4dd47c166a6a6f7c38a7ee4dac7a2b3115b45d","_number":669583,"virtual_id_number":669583,"owner":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":2,"date":"2019-08-20 13:36:40.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2019-08-20 12:22:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2019-07-15 10:07:05.000000000","_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":1,"date":"2019-08-20 12:22:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-15 10:07:05.000000000","updated_by":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"reviewer":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"state":"REVIEWER"},{"updated":"2019-08-20 12:22:15.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-08-20 13:36:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"632288898d73aded62c830234b9e4074713cb27e","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2019-07-08 01:38:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"57fe4f71a87569b01494ad868ef99b547c27e818","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-08 01:54:40.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-chef-delivery http://logs.openstack.org/83/669583/1/check/openstack-chef-delivery/3f4f537/ : SUCCESS in 3m 48s\n- openstack-chef-integration http://logs.openstack.org/83/669583/1/check/openstack-chef-integration/bdb1686/ : FAILURE in 6m 48s","accounts_in_message":[],"_revision_number":1},{"id":"4a78272f48dd8edb2dc34a61d5f1a6b054072737","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2019-07-08 02:10:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"26f5ccf0eb6258c7f8e6b762b12699d97839521d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-08 02:58:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery http://logs.openstack.org/83/669583/2/check/openstack-chef-delivery/760ca89/ : SUCCESS in 4m 22s\n- openstack-chef-integration http://logs.openstack.org/83/669583/2/check/openstack-chef-integration/a082c4a/ : SUCCESS in 46m 23s","accounts_in_message":[],"_revision_number":2},{"id":"74a1950985e193887b2998f16c52e8d30c2bc9a2","author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"date":"2019-07-15 10:07:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"dac617958fa7e286cce4939f56fc07a98efcba81","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-06 10:11:41.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"da48283bc40270082bd5aaeac46576989862375f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 11:09:11.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://logs.opendev.org/83/669583/2/check/openstack-chef-delivery/dd95f31/ : SUCCESS in 4m 51s\n- openstack-chef-integration-ubuntu https://logs.opendev.org/83/669583/2/check/openstack-chef-integration-ubuntu/0846a18/ : SUCCESS in 40m 05s\n- openstack-chef-integration-centos https://logs.opendev.org/83/669583/2/check/openstack-chef-integration-centos/17ab353/ : SUCCESS in 51m 06s","accounts_in_message":[],"_revision_number":2},{"id":"895fa11d5a59dea11cd64cdebd6cb169a447f21b","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-20 12:22:15.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"babeac26e1a61fe1bf6b8d689f00ddc1bc36e88b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 12:22:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"07767e349a3d573434b81e0e416d52ec4d5280a3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 13:36:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"3cce3d6084994a20e2c752913fb59d04abaff1ec","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 13:36:40.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/38dc0f5e8aef4e92bbc34f7eb0b39957 : SUCCESS in 4m 12s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/34ae06c5c4c04d61acb6b69e8d4922d2 : SUCCESS in 46m 55s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/c8b1230c94724efa9821470fb762ac4b : SUCCESS in 50m 14s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5c2bfb4990b0c99a844624022b2ed4a57b37e4d3","revisions":{"ce56e151d6ce7522d5ab52a46863bbbf8181265a":{"kind":"REWORK","_number":1,"created":"2019-07-08 01:38:54.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/83/669583/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-identity","ref":"refs/changes/83/669583/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/83/669583/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/83/669583/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/83/669583/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/83/669583/1"}}},"commit":{"parents":[{"commit":"df72871ac839a7cea73ee427bc8ea7c456615a7a","subject":"Merge \"Fixes to support fog-openstack-1.x\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/df72871ac839a7cea73ee427bc8ea7c456615a7a"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-06-20 01:35:03.000000000","tz":-420},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-07-08 01:37:43.000000000","tz":-420},"subject":"Properly notify apache restarts on keystone configuration updates","message":"Properly notify apache restarts on keystone configuration updates\n\nThis uses edit_resource to add a notification in the identity apache\nconfiguration when it gets updated. This is a workaround due to the fact\nwe are using a version of the apache2 cookbook that is still using\ndefinitions and cannot add notifications with definitions.\n\nThis is intended to ensure we only restart apache when the configuration\nis updated. Otherwise, the old behaviour was to restart apache on every\nrun which is problematic in production environments. I have been using\nthis in our production wrapper cookbook for the past year or so without\nany issue.\n\nThis will be removed in the Stein release when we migrate to the newer\napache2 cookbook which uses proper resources.\n\nChange-Id: I13de063d1e7ffd356d754eb0f2d8286a3c694836\nSigned-off-by: Lance Albertson \u003clance@osuosl.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/ce56e151d6ce7522d5ab52a46863bbbf8181265a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/ce56e151d6ce7522d5ab52a46863bbbf8181265a"}]},"branch":"refs/heads/master"},"5c2bfb4990b0c99a844624022b2ed4a57b37e4d3":{"kind":"REWORK","_number":2,"created":"2019-07-08 02:10:58.000000000","uploader":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"ref":"refs/changes/83/669583/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-identity","ref":"refs/changes/83/669583/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/83/669583/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/83/669583/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/83/669583/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/83/669583/2"}}},"commit":{"parents":[{"commit":"df72871ac839a7cea73ee427bc8ea7c456615a7a","subject":"Merge \"Fixes to support fog-openstack-1.x\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/df72871ac839a7cea73ee427bc8ea7c456615a7a"}]}],"author":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-06-20 01:35:03.000000000","tz":-420},"committer":{"name":"Lance Albertson","email":"lance@osuosl.org","date":"2019-07-08 02:10:52.000000000","tz":-420},"subject":"Properly notify apache restarts on keystone configuration updates","message":"Properly notify apache restarts on keystone configuration updates\n\nThis uses edit_resource to add a notification in the identity apache\nconfiguration when it gets updated. This is a workaround due to the fact\nwe are using a version of the apache2 cookbook that is still using\ndefinitions and cannot add notifications with definitions.\n\nThis is intended to ensure we only restart apache when the configuration\nis updated. Otherwise, the old behaviour was to restart apache on every\nrun which is problematic in production environments. I have been using\nthis in our production wrapper cookbook for the past year or so without\nany issue.\n\nThis will be removed in the Stein release when we migrate to the newer\napache2 cookbook which uses proper resources.\n\nChange-Id: I13de063d1e7ffd356d754eb0f2d8286a3c694836\nSigned-off-by: Lance Albertson \u003clance@osuosl.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/5c2bfb4990b0c99a844624022b2ed4a57b37e4d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/5c2bfb4990b0c99a844624022b2ed4a57b37e4d3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}