)]}'
{"id":"openstack%2Fcookbook-openstack-identity~677937","triplet_id":"openstack%2Fcookbook-openstack-identity~master~I8574d9f4299be5b2a374140b461ef48e9e80ae6b","project":"openstack/cookbook-openstack-identity","branch":"master","topic":"add-cloud-config","hashtags":[],"change_id":"I8574d9f4299be5b2a374140b461ef48e9e80ae6b","subject":"Add a cloud_config recipe","status":"MERGED","created":"2019-08-22 08:45:57.000000000","updated":"2019-09-10 09:43:02.000000000","submitted":"2019-09-10 09:43:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677937-1568108582692-70508045","meta_rev_id":"973bf2f9207e83a8c7c20eafc9b8de5f0e3ed8c0","_number":677937,"virtual_id_number":677937,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"date":"2019-08-30 17:02:57.000000000","_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"value":2,"date":"2019-09-10 09:43:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":2,"date":"2019-09-10 08:39:46.000000000","_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":1,"date":"2019-09-10 08:45:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-26 09:35:00.000000000","updated_by":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"reviewer":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"state":"REVIEWER"},{"updated":"2019-08-30 17:02:57.000000000","updated_by":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"reviewer":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"state":"REVIEWER"},{"updated":"2019-09-10 08:39:46.000000000","updated_by":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"reviewer":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"state":"REVIEWER"},{"updated":"2019-09-10 09:43:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f38185f704096ba35f4cc027f7f44b1550ff8043","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-22 08:45:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f270a0b87c8d05319be27b1120654ffd0d7ee95f","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-22 08:49:52.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nA couple of questions for my fellow reviewers:\n\nDoes it make sense to have this as an additional recipe? Or would you rather see the existing recipe extended?","accounts_in_message":[],"_revision_number":1},{"id":"8aad7fbb11b1d4b5894b7365691ade9446b880d3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-22 09:47:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/25dc11c652b344278c67e7d480e11c31 : SUCCESS in 4m 48s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/8371ef40a04f47deae59003548c9ba56 : SUCCESS in 59m 28s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/8e434a6561504d2586f527b8d36d7c00 : SUCCESS in 59m 53s","accounts_in_message":[],"_revision_number":1},{"id":"e5098cda993ba7a070a5c57dfa516744b97733dc","author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"date":"2019-08-22 11:58:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"363ff5f1ac5fbb914022606cb64a1285e31428e7","author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"date":"2019-08-26 09:35:00.000000000","message":"Patch Set 1:\n\nThanks, looks good for a first implementation. The new template and recipe for the cloud config looks very static. Since the format it yaml, it might be possible to use a more flexible generation method for it which is directly based on the attributes. Also I do not fully understand why we remove the API version from both files. Will identity v3 be the last version ever? If not, we probably would need to reintroduce this variable at a later stage.","accounts_in_message":[],"_revision_number":1},{"id":"5edd288b846ecbe4a47d0831b46d7b8766a14d8e","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2019-08-27 15:54:26.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nAccording to the docs [1], it should be sourcing this file in the current directory without needing to source openrc. However when I do that, I get the following:\n\n  [root@minimal-centos-7 ~]# openstack user list\n  Missing value auth-url required for auth plugin password\n  [root@minimal-centos-7 ~]# pwd\n  /root\n\nIt looks like you need to specify --os-cloud for it to work properly:\n\n  [root@minimal-centos-7 ~]# openstack --os-cloud default user list\n  +----------------------------------+---------------+\n  | ID                               | Name          |\n  +----------------------------------+---------------+\n  | 0b4185fc05f04da5a428a83b459cab3f | admin         |\n  | 0bc44cf41a32459f9777009249bb1cba | ironic        |\n  | 1ac79c0d4a5f434a8c411de99793c1ab | placement     |\n  | 76838d69398c406a879fef9cdbf288f2 | neutron       |\n  | 7c05abb87546474699f426a8708759b3 | tempest_user1 |\n  | e24e180d26064fcb8c71ecd07a959a90 | nova          |\n  | e38615b90798496abd518d61f443877b | glance        |\n  | e56dd296cef84a7e8c8a2581e39bbce7 | tempest_user2 |\n  +----------------------------------+---------------+\n\nI couldn\u0027t find anything in documentation in what the default value for --os-cloud might be other than setting OS_CLOUD in the env var. I\u0027m not sure if this is an issue or a \"feature\" but I thought I might bring it up.\n\n[1] https://docs.openstack.org/python-openstackclient/rocky/configuration/index.html","accounts_in_message":[],"_revision_number":1},{"id":"03e7b7fc4fabd6187867b5d451ff7cd7297a2b60","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-30 14:30:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e6048ce80c55cb0fb195fb3f1fb49174081f3c60","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-30 14:36:52.000000000","message":"Patch Set 1:\n\nThanks for the reviews. \n\nI don\u0027t think that osc can use the cloud_config without any configuration. The easiest option similar to sourcing openrc would be to do \"export OS_CLOUD\u003ddefault\".\n\nRegarding Identity \u003e v3, there is no new version planned yet and it looked wrong to me to hardcode a version in the recipe to be passed into the template, so I moved that directly into the templates. If there ever is a new Identity API version, very likely we will have to touch much of this code anyway, so I don\u0027t see that as a drawback.\n\nFinally regarding generating more flexible yaml output, if you have a good solution for that, I\u0027ll be happy to see a patch. For now, I think this is simple enough and not likely to change much. Deployers with a more general setup can always generate their own recipe to create a more complex cloud config.","accounts_in_message":[],"_revision_number":1},{"id":"325461217bb875c25d15b8be62602f3a565ee0dd","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-30 14:37:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ee7b6ef68756bd12a14fecb1ce7bb378bf7eaa4b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-30 15:33:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/3ef7a6ee9191451eaaffedbbb102f5e1 : SUCCESS in 5m 34s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/053aaf927aed4102aa57e8072b292691 : SUCCESS in 48m 54s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/79947081dfd24cde9bbacea16bc6c892 : SUCCESS in 57m 05s","accounts_in_message":[],"_revision_number":2},{"id":"15e433980b8740899f624fca4c3a5235a031a08f","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2019-08-30 17:02:57.000000000","message":"Patch Set 2:\n\n\u003e Thanks for the reviews.\n \u003e \n \u003e I don\u0027t think that osc can use the cloud_config without any\n \u003e configuration. The easiest option similar to sourcing openrc would\n \u003e be to do \"export OS_CLOUD\u003ddefault\".\n \n+1 on doing that!\n\n \u003e Regarding Identity \u003e v3, there is no new version planned yet and it\n \u003e looked wrong to me to hardcode a version in the recipe to be passed\n \u003e into the template, so I moved that directly into the templates. If\n \u003e there ever is a new Identity API version, very likely we will have\n \u003e to touch much of this code anyway, so I don\u0027t see that as a\n \u003e drawback.\n \n1+ I agree we\u0027d have to go back and touch the go so this isn\u0027t an issue.\n\n \u003e Finally regarding generating more flexible yaml output, if you have\n \u003e a good solution for that, I\u0027ll be happy to see a patch. For now, I\n \u003e think this is simple enough and not likely to change much.\n \u003e Deployers with a more general setup can always generate their own\n \u003e recipe to create a more complex cloud config.\n\nI think let\u0027s leave it as-is. If someone in the community wants to provide a patch which allows more flexibility, we can consider it then. This is a good first crack at getting this added.","accounts_in_message":[],"_revision_number":2},{"id":"6792e0317a216cc4170f20cfde072998b7f67770","author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"date":"2019-09-10 08:39:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7a2ad4bcad7c39157bd43b886e9b8fbc9ccc5865","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-10 08:45:10.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"38f51441f331d6bf66db8a49689f0b42de986dd9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-10 08:45:22.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1f190beb8581a696524deb8ad8223cdddb0b78d6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-10 09:43:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"f3f35257977c543ab16c3772b20e3feda5aa9374","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-10 09:43:02.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://zuul.opendev.org/t/openstack/build/0ee257e85df243ca9c61124673ba4a0a : SUCCESS in 4m 16s\n- openstack-chef-integration-ubuntu https://zuul.opendev.org/t/openstack/build/c3aba00456514445aec85fa1e7e38166 : SUCCESS in 39m 57s\n- openstack-chef-integration-centos https://zuul.opendev.org/t/openstack/build/14737c7fad0644638c38a2e9854abc4c : SUCCESS in 51m 55s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f2902385efe0358cddae5f9619b1b2fe12a2531f","revisions":{"d44df974a99bd7636e76de1df6a314329de182b6":{"kind":"REWORK","_number":1,"created":"2019-08-22 08:45:57.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/37/677937/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-identity","ref":"refs/changes/37/677937/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/37/677937/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/37/677937/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/37/677937/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/37/677937/1"}}},"commit":{"parents":[{"commit":"df72871ac839a7cea73ee427bc8ea7c456615a7a","subject":"Merge \"Fixes to support fog-openstack-1.x\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/df72871ac839a7cea73ee427bc8ea7c456615a7a"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-08-22 08:10:43.000000000","tz":0},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-08-22 08:10:43.000000000","tz":0},"subject":"Add a cloud_config recipe","message":"Add a cloud_config recipe\n\nUsing a cloud config file when accessing a cloud is the modern variant\nof setting lots of environment variables, so we add a new recipe that\nproduces a cloud config matching what we are deploying.\n\nClean up the old openrc template a bit.\n\nChange-Id: I8574d9f4299be5b2a374140b461ef48e9e80ae6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/d44df974a99bd7636e76de1df6a314329de182b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/d44df974a99bd7636e76de1df6a314329de182b6"}]},"branch":"refs/heads/master"},"f2902385efe0358cddae5f9619b1b2fe12a2531f":{"kind":"REWORK","_number":2,"created":"2019-08-30 14:30:37.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/37/677937/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-identity","ref":"refs/changes/37/677937/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/37/677937/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/37/677937/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/37/677937/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-identity refs/changes/37/677937/2"}}},"commit":{"parents":[{"commit":"df72871ac839a7cea73ee427bc8ea7c456615a7a","subject":"Merge \"Fixes to support fog-openstack-1.x\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/df72871ac839a7cea73ee427bc8ea7c456615a7a"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-08-22 08:10:43.000000000","tz":0},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-08-30 14:29:33.000000000","tz":0},"subject":"Add a cloud_config recipe","message":"Add a cloud_config recipe\n\nUsing a cloud config file when accessing a cloud is the modern variant\nof setting lots of environment variables, so we add a new recipe that\nproduces a cloud config matching what we are deploying.\n\nClean up the old openrc template a bit.\n\nChange-Id: I8574d9f4299be5b2a374140b461ef48e9e80ae6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/f2902385efe0358cddae5f9619b1b2fe12a2531f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-identity/commit/f2902385efe0358cddae5f9619b1b2fe12a2531f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}