)]}'
{"CHANGELOG.md":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"68076d563bb00bef9bde63ff419b32ef3dad299c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"* Enable rabbit_use_ssl be configurable"},{"line_number":9,"context_line":"* Upgrading berkshelf from 2.0.18 to 3.1.5"},{"line_number":10,"context_line":"* Sync conf files with Juno"},{"line_number":11,"context_line":"* Enable authtoken configurations - including cafile, memcached_servers, memcache_security_strategy, memcache_secret_key and hash_algorithms"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"## 9.2.0"},{"line_number":14,"context_line":"* python_packages database client attributes have been migrated to the -common cookbook"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fa98f980_4df7d8d4","line":11,"updated":"2014-09-18 07:37:41.000000000","message":"should add increment to version, can refer to https://github.com/stackforge/openstack-chef-specs/blob/master/specs/juno/common/cookbook-versioning.rst","commit_id":"c1f93fff32805acfec4a7bef4c6f34bfa8bf7423"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"1d7b7661a25130f1cd075b143114461b33faf9be","unresolved":false,"context_lines":[{"line_number":8,"context_line":"* Enable rabbit_use_ssl be configurable"},{"line_number":9,"context_line":"* Upgrading berkshelf from 2.0.18 to 3.1.5"},{"line_number":10,"context_line":"* Sync conf files with Juno"},{"line_number":11,"context_line":"* Enable authtoken configurations - including cafile, memcached_servers, memcache_security_strategy, memcache_secret_key and hash_algorithms"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"## 9.2.0"},{"line_number":14,"context_line":"* python_packages database client attributes have been migrated to the -common cookbook"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fa98f980_48cfc657","line":11,"in_reply_to":"fa98f980_4df7d8d4","updated":"2014-09-18 08:20:20.000000000","message":"Hi, wen cheng, in master branch, in this case incrementing the Patch number is not necessary","commit_id":"c1f93fff32805acfec4a7bef4c6f34bfa8bf7423"}],"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"68076d563bb00bef9bde63ff419b32ef3dad299c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# XXX keystoneclient wants these dirs to exist even if it doesn\u0027t use them"},{"line_number":59,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027cache_dir\u0027] \u003d \u0027/var/cache/glance/api\u0027"},{"line_number":60,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027cache_dir\u0027] \u003d \u0027/var/cache/glance/registry\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# A list of memcached server(s) to use for caching."},{"line_number":63,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027memcached_servers\u0027] \u003d nil"},{"line_number":64,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027memcached_servers\u0027] \u003d nil"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa98f980_edbdecd8","line":61,"updated":"2014-09-18 07:37:41.000000000","message":"also need to add attributes doc to README","commit_id":"c1f93fff32805acfec4a7bef4c6f34bfa8bf7423"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"1d7b7661a25130f1cd075b143114461b33faf9be","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# XXX keystoneclient wants these dirs to exist even if it doesn\u0027t use them"},{"line_number":59,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027cache_dir\u0027] \u003d \u0027/var/cache/glance/api\u0027"},{"line_number":60,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027cache_dir\u0027] \u003d \u0027/var/cache/glance/registry\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# A list of memcached server(s) to use for caching."},{"line_number":63,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027memcached_servers\u0027] \u003d nil"},{"line_number":64,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027memcached_servers\u0027] \u003d nil"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa98f980_68900a4f","line":61,"in_reply_to":"fa98f980_edbdecd8","updated":"2014-09-18 08:20:20.000000000","message":"good, thanks","commit_id":"c1f93fff32805acfec4a7bef4c6f34bfa8bf7423"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"35ed68c075c8da4e47c1761f4982c947606ae25a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027cache_dir\u0027] \u003d \u0027/var/cache/glance/api\u0027"},{"line_number":60,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027cache_dir\u0027] \u003d \u0027/var/cache/glance/registry\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# A list of memcached server(s) to use for caching"},{"line_number":63,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027memcached_servers\u0027] \u003d nil"},{"line_number":64,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027memcached_servers\u0027] \u003d nil"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa98f980_74fb5647","line":62,"updated":"2014-09-19 18:57:36.000000000","message":"Just a nit, but since were considering a move to generating Readme attribute section from this file, need to have a description comment before each attribute.   Please dup these comments so each attribute has a description.","commit_id":"e4c25431cfa9ade90889d8a28067a0f594f0af03"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"35ed68c075c8da4e47c1761f4982c947606ae25a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027cafile\u0027] \u003d nil"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Verify HTTPS connections"},{"line_number":83,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027insecure\u0027] \u003d false"},{"line_number":84,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] \u003d false"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Whether to use any of the default caching pipelines from the paste configuration file"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa98f980_f43ae6e5","line":83,"updated":"2014-09-19 18:57:36.000000000","message":"if directly placed in template, should use \u0027False\u0027  string instead.","commit_id":"e4c25431cfa9ade90889d8a28067a0f594f0af03"}],"spec/api_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"35ed68c075c8da4e47c1761f4982c947606ae25a","unresolved":false,"context_lines":[{"line_number":351,"context_line":"          end"},{"line_number":352,"context_line":"        end"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        context \u0027keystone authtoken attributes\u0027 do"},{"line_number":355,"context_line":"          it \u0027sets memcached server(s)\u0027 do"},{"line_number":356,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027memcached_servers\u0027] \u003d \u0027localhost:11211\u0027"},{"line_number":357,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^memcached_servers \u003d localhost:11211$/)"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa98f980_948d1ad6","line":354,"updated":"2014-09-19 18:57:36.000000000","message":"I would also like to see a context to test just the defaults, do make sure those don\u0027t change without a spec update.","commit_id":"e4c25431cfa9ade90889d8a28067a0f594f0af03"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"8105081990a91009b0a7fa1b1267ce4db4531f57","unresolved":false,"context_lines":[{"line_number":404,"context_line":"          end"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"          it \u0027sets token hash algorithm\u0027 do"},{"line_number":407,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027hash_algorithm\u0027] \u003d \u0027sha2\u0027"},{"line_number":408,"context_line":"            expect(chef_run).to render_file(path).with_content(/^hash_algorithm \u003d sha2$/)"},{"line_number":409,"context_line":"          end"},{"line_number":410,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"da9df570_08c40491","line":407,"updated":"2014-09-22 08:45:37.000000000","message":"\u0027hash_algorithm\u0027 or \u0027hash_algorithms\u0027","commit_id":"32b82d0b068ac6c70eadb13b0f0f9bba1e5f8598"}],"spec/registry_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"35ed68c075c8da4e47c1761f4982c947606ae25a","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        it_behaves_like \u0027keystone attribute setter\u0027, \u0027registry\u0027"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        context \u0027keystone authtoken attributes\u0027 do"},{"line_number":129,"context_line":"          it \u0027sets memcached server(s)\u0027 do"},{"line_number":130,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027memcached_servers\u0027] \u003d \u0027localhost:11211\u0027"},{"line_number":131,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^memcached_servers \u003d localhost:11211$/)"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa98f980_f4b5867e","line":128,"updated":"2014-09-19 18:57:36.000000000","message":"I would also like to see a context to test just the defaults, do make sure those don\u0027t change without a spec update.","commit_id":"e4c25431cfa9ade90889d8a28067a0f594f0af03"}],"templates/default/glance-api.conf.erb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"68076d563bb00bef9bde63ff419b32ef3dad299c","unresolved":false,"context_lines":[{"line_number":745,"context_line":"\u003c% end %\u003e"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"# Hash algorithms to use for hashing PKI tokens."},{"line_number":748,"context_line":"hash_algorithms \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027hash_algorithms\u0027] %\u003e"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"# A PEM encoded Certificate Authority to use when verifying HTTPs connections."},{"line_number":751,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027cafile\u0027] %\u003e"}],"source_content_type":"application/x-erb","patch_set":3,"id":"fa98f980_cd8d882c","line":748,"updated":"2014-09-18 07:37:41.000000000","message":"whether nil checking is needed there ?","commit_id":"c1f93fff32805acfec4a7bef4c6f34bfa8bf7423"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"1d7b7661a25130f1cd075b143114461b33faf9be","unresolved":false,"context_lines":[{"line_number":745,"context_line":"\u003c% end %\u003e"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"# Hash algorithms to use for hashing PKI tokens."},{"line_number":748,"context_line":"hash_algorithms \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027hash_algorithms\u0027] %\u003e"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"# A PEM encoded Certificate Authority to use when verifying HTTPs connections."},{"line_number":751,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027cafile\u0027] %\u003e"}],"source_content_type":"application/x-erb","patch_set":3,"id":"fa98f980_4893465c","line":748,"in_reply_to":"fa98f980_cd8d882c","updated":"2014-09-18 08:20:20.000000000","message":"hash_algorithms has default value \u0027md5\u0027, so do not need checking here","commit_id":"c1f93fff32805acfec4a7bef4c6f34bfa8bf7423"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"35ed68c075c8da4e47c1761f4982c947606ae25a","unresolved":false,"context_lines":[{"line_number":753,"context_line":"\u003c% end %\u003e"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"# Verify HTTPS connections. (boolean value)"},{"line_number":756,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027insecure\u0027] %\u003e"},{"line_number":757,"context_line":"insecure \u003d true"},{"line_number":758,"context_line":"\u003c% end %\u003e"},{"line_number":759,"context_line":""}],"source_content_type":"application/x-erb","patch_set":6,"id":"fa98f980_34246ec5","line":756,"updated":"2014-09-19 18:57:36.000000000","message":"No need for check, just use string \u0027False\u0027 instead and avoid the logic for booleans","commit_id":"e4c25431cfa9ade90889d8a28067a0f594f0af03"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"2e208765e62e0d816c0fce7b531addf4bcf7ff74","unresolved":false,"context_lines":[{"line_number":754,"context_line":""},{"line_number":755,"context_line":"# Verify HTTPS connections. (boolean value)"},{"line_number":756,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027insecure\u0027] %\u003e"},{"line_number":757,"context_line":"insecure \u003d true"},{"line_number":758,"context_line":"\u003c% end %\u003e"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"[paste_deploy]"}],"source_content_type":"application/x-erb","patch_set":6,"id":"da9df570_6e52fd14","line":757,"updated":"2014-09-22 05:40:17.000000000","message":"you can set [\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] \u003d \u0027true\u0027,\n\nthen let insecure \u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027]","commit_id":"e4c25431cfa9ade90889d8a28067a0f594f0af03"}],"templates/default/glance-registry.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"35ed68c075c8da4e47c1761f4982c947606ae25a","unresolved":false,"context_lines":[{"line_number":244,"context_line":"\u003c% end %\u003e"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"# Verify HTTPS connections. (boolean value)"},{"line_number":247,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] %\u003e"},{"line_number":248,"context_line":"insecure \u003d true"},{"line_number":249,"context_line":"\u003c% end %\u003e"},{"line_number":250,"context_line":""}],"source_content_type":"application/x-erb","patch_set":6,"id":"fa98f980_94299a9d","line":247,"updated":"2014-09-19 18:57:36.000000000","message":"see other template comment, no if needed here","commit_id":"e4c25431cfa9ade90889d8a28067a0f594f0af03"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"2e208765e62e0d816c0fce7b531addf4bcf7ff74","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"# Verify HTTPS connections. (boolean value)"},{"line_number":247,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] %\u003e"},{"line_number":248,"context_line":"insecure \u003d true"},{"line_number":249,"context_line":"\u003c% end %\u003e"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"[paste_deploy]"}],"source_content_type":"application/x-erb","patch_set":6,"id":"da9df570_0e3411dd","line":248,"updated":"2014-09-22 05:40:17.000000000","message":"same as the previous","commit_id":"e4c25431cfa9ade90889d8a28067a0f594f0af03"}]}