)]}'
{"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b5c0fdf7e146d0bd99b2855afa0d6a967d180a24","unresolved":false,"context_lines":[{"line_number":162,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027upload_image\u0027][\u0027centos\u0027] \u003d \u0027http://c250663.r63.cf1.rackcdn.com/centos60_x86_64.qcow2\u0027"},{"line_number":163,"context_line":"# Image was created by `docker save busybox \u003e busybox.tar`, you can save any image on your system,"},{"line_number":164,"context_line":"# just make the tarball name to your image name(i.e., image name xxx, tarball name xxx.tar)."},{"line_number":165,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027upload_image\u0027][\u0027docker\u0027] \u003d \u0027http://127.0.0.1/docker/busybox.tar\u0027"},{"line_number":166,"context_line":"# To override image type"},{"line_number":167,"context_line":"# The following disk format types are supported: qcow vhd vmdk vdi iso raw"},{"line_number":168,"context_line":"# Bare container format will be used."}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a890539_9d4461b8","line":165,"updated":"2014-11-21 10:17:04.000000000","message":"I don\u0027t like the idea of referencing a URL that will by default not be available. If you only want to give an example of how uploading a docker image would work, I\u0027d suggest to at least leave it commented out. Also I would not call the image just \u0027docker\u0027, maybe better \u0027docker-busybox\u0027 or only \u0027busybox\u0027?\n\nEven better would be to find some external URL that can be considered stable enough to be included here.","commit_id":"75012550a5506e14f0ab9d7a1efc9968b093f7bc"}],"providers/image.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b5c0fdf7e146d0bd99b2855afa0d6a967d180a24","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  if name \u003d\u003d \u0027\u0027"},{"line_number":129,"context_line":"    name \u003d tail"},{"line_number":130,"context_line":"    Chef::Log.warn(\"Cannot get docker image name properly, the docker image(#{name}) may not work.\")"},{"line_number":131,"context_line":"  end"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  execute \"Uploading #{type} image #{name}\" do"},{"line_number":134,"context_line":"    cwd \u0027/tmp\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a890539_200d0238","line":131,"updated":"2014-11-21 10:17:04.000000000","message":"I don\u0027t like overriding the destination image name like that, as it doesn\u0027t match what the other providers do, IMHO also violates the principle of least surprise. Can you give a reason why you would want to do this?\n\nAlso, if you leave this part out, the difference to _upload_image_bare() becomes very small, maybe rather make that function more generic instead of mostly duplicating it?","commit_id":"75012550a5506e14f0ab9d7a1efc9968b093f7bc"}],"recipes/image_upload.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b5c0fdf7e146d0bd99b2855afa0d6a967d180a24","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    identity_tenant service_tenant_name"},{"line_number":58,"context_line":"    identity_uri auth_uri"},{"line_number":59,"context_line":"    action :upload"},{"line_number":60,"context_line":"    not_if { type \u003d\u003d \u0027docker\u0027 \u0026\u0026 !node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027container_formats\u0027].include?(\u0027docker\u0027) }"},{"line_number":61,"context_line":"  end"},{"line_number":62,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a890539_2002626f","line":60,"updated":"2014-11-21 10:17:04.000000000","message":"This seems also unexpected to me, if someone wants a docker image to be uploaded and forgets to enable the appropriate image type, I would rather want to see it fail than having the upload silently skipped. \n\nOr is there a specific reason to treat docker here different than any other format?","commit_id":"75012550a5506e14f0ab9d7a1efc9968b093f7bc"}],"spec/spec_helper.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b5c0fdf7e146d0bd99b2855afa0d6a967d180a24","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    allow(Chef::Application).to receive(:fatal!)"},{"line_number":62,"context_line":"    stub_command(\u0027glance --insecure --os-username glance --os-password glance-pass --os-tenant-name service --os-image-url http://127.0.0.1:9292 --os-auth-url http://127.0.0.1:5000/v2.0 image-list | grep cirros\u0027).and_return(\u0027\u0027)"},{"line_number":63,"context_line":"    stub_command(\u0027glance --insecure --os-username glance --os-password glance-pass --os-tenant-name service --os-image-url http://127.0.0.1:9292 --os-auth-url http://127.0.0.1:5000/v2.0 image-show busybox\u0027).and_return(false)"},{"line_number":64,"context_line":"  end"},{"line_number":65,"context_line":"end"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a890539_009ac662","line":63,"updated":"2014-11-21 10:17:04.000000000","message":"All the other special case stubs are in spec/image_upload_spec.rb, only being applied for their single test case. I\u0027d go for consistency and have this one be moved there, too.","commit_id":"75012550a5506e14f0ab9d7a1efc9968b093f7bc"}]}