)]}'
{"Berksfile":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"72e553c988c5e76ae0ddef2bf9cc24c745f15fd7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"cookbook \"openstack-common\","},{"line_number":8,"context_line":"  github: \"stackforge/cookbook-openstack-common\""},{"line_number":9,"context_line":"cookbook \"ceph\","},{"line_number":10,"context_line":"  github: \"ceph/ceph-cookbook\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1a930d6b_255de615","line":10,"updated":"2015-01-26 10:07:55.000000000","message":"should not stackforge/ceph-cookbook ?","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"f5cb6f3b600e9d3a67ccfa53a07c59996285c18e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"cookbook \"openstack-common\","},{"line_number":8,"context_line":"  github: \"stackforge/cookbook-openstack-common\""},{"line_number":9,"context_line":"cookbook \"ceph\","},{"line_number":10,"context_line":"  github: \"ceph/ceph-cookbook\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1a930d6b_a8c5268f","line":10,"in_reply_to":"1a930d6b_255de615","updated":"2015-01-26 12:55:57.000000000","message":"No, https://review.openstack.org/#/c/142837/\n\nThat cookbook is being removed from stackforge in favor of the cookbook ceph provides.","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"}],"CHANGELOG.md":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"72e553c988c5e76ae0ddef2bf9cc24c745f15fd7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"This file is used to list changes made in each version of cookbook-openstack-image."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"## 10.1.0"},{"line_number":6,"context_line":"* Add dependency on upstream ceph cookbook for better key management"},{"line_number":7,"context_line":"### Blue print"},{"line_number":8,"context_line":"* Make container_formats and disk_formats configurable"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":5,"id":"1a930d6b_c5b0a245","line":6,"updated":"2015-01-26 10:07:55.000000000","message":"a blank line looks better","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3ed7d7c136e065180cac22fedb74e4347d848448","unresolved":false,"context_lines":[{"line_number":3,"context_line":"This file is used to list changes made in each version of cookbook-openstack-image."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"## 10.1.0"},{"line_number":6,"context_line":"* Add dependency on upstream ceph cookbook for better key management"},{"line_number":7,"context_line":"### Blue print"},{"line_number":8,"context_line":"* Make container_formats and disk_formats configurable"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":5,"id":"1a930d6b_207b0229","line":6,"in_reply_to":"1a930d6b_c5b0a245","updated":"2015-01-26 17:05:17.000000000","message":"yup, agree.    It\u0027s going to be nice in Kilo when we blast all these changelog files.","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"}],"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"016649b52242b4a5db4a1e4f345673c5cf5155fa","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"depends           \u0027openstack-common\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":19,"context_line":"depends           \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":20,"context_line":"depends           \u0027ceph\u0027, \u0027~\u003e 0.2.1\u0027"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3a961159_0d8558ac","line":20,"updated":"2015-01-15 19:47:42.000000000","message":"Maybe use\ndepends           \u0027ceph\u0027, \u0027~\u003e 0.2\u0027   if we think just fixes to this cookbook level are only what we want.\nor use\ndepends           \u0027ceph\u0027, \u0027\u003d\u003e 0.2.1\u0027 \nif we really don\u0027t care and have trust in ceph folks to keep compatibility going forward.","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3ed7d7c136e065180cac22fedb74e4347d848448","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"depends           \u0027openstack-common\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":19,"context_line":"depends           \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":20,"context_line":"depends           \u0027ceph\u0027, \u0027~\u003e 0.2.1\u0027"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1a930d6b_e0857a07","line":20,"in_reply_to":"3a961159_0d8558ac","updated":"2015-01-26 17:05:17.000000000","message":"After the discussion today about dependencies, probably need to go with a gating approach like:\n\ndepends           \u0027ceph\u0027, \u0027\u003d\u003e 0.2.1\u0027\ndepends           \u0027ceph\u0027, \u0027\u003c 3.0.0\u0027","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"72e553c988c5e76ae0ddef2bf9cc24c745f15fd7","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"depends           \u0027openstack-common\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":19,"context_line":"depends           \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":20,"context_line":"depends           \u0027ceph\u0027, \u0027~\u003e 0.2.1\u0027"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1a930d6b_857a1a75","line":20,"in_reply_to":"3a961159_0d8558ac","updated":"2015-01-26 10:07:55.000000000","message":"agreed","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"}],"recipes/api.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"016649b52242b4a5db4a1e4f345673c5cf5155fa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"elsif node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027default_store\u0027] \u003d\u003d \u0027rbd\u0027"},{"line_number":63,"context_line":"  include_recipe \u0027ceph::_common\u0027"},{"line_number":64,"context_line":"  include_recipe \u0027ceph::install\u0027"},{"line_number":65,"context_line":"  include_recipe \u0027ceph::conf\u0027"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3a961159_8d678824","line":63,"updated":"2015-01-15 19:47:42.000000000","message":"This seems odd, why is this needed.   Looks like an issue is needed against this cookbook and note that here.   This might also be a reason for locking down the version of this cookbook to just a \u003d 0.2.1 to make sure this never breaks us.","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"72e553c988c5e76ae0ddef2bf9cc24c745f15fd7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"elsif node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027default_store\u0027] \u003d\u003d \u0027rbd\u0027"},{"line_number":63,"context_line":"  include_recipe \u0027ceph::_common\u0027"},{"line_number":64,"context_line":"  include_recipe \u0027ceph::install\u0027"},{"line_number":65,"context_line":"  include_recipe \u0027ceph::conf\u0027"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1a930d6b_255086d3","line":63,"updated":"2015-01-26 10:07:55.000000000","message":"where is this recipe ?","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"f5cb6f3b600e9d3a67ccfa53a07c59996285c18e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"elsif node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027default_store\u0027] \u003d\u003d \u0027rbd\u0027"},{"line_number":63,"context_line":"  include_recipe \u0027ceph::_common\u0027"},{"line_number":64,"context_line":"  include_recipe \u0027ceph::install\u0027"},{"line_number":65,"context_line":"  include_recipe \u0027ceph::conf\u0027"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1a930d6b_08fe3aae","line":63,"in_reply_to":"1a930d6b_255086d3","updated":"2015-01-26 12:55:57.000000000","message":"https://github.com/ceph/ceph-cookbook/blob/master/recipes/_common.rb","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3ed7d7c136e065180cac22fedb74e4347d848448","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"elsif node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027default_store\u0027] \u003d\u003d \u0027rbd\u0027"},{"line_number":63,"context_line":"  include_recipe \u0027ceph::_common\u0027"},{"line_number":64,"context_line":"  include_recipe \u0027ceph::install\u0027"},{"line_number":65,"context_line":"  include_recipe \u0027ceph::conf\u0027"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1a930d6b_a096123d","line":63,"in_reply_to":"1a930d6b_68a97e8f","updated":"2015-01-26 17:05:17.000000000","message":"ok, i will try to help with that.","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":12588,"name":"Elliott Davis","email":"elliott@excellent.io","username":"elliott-davis"},"change_message_id":"f5cb6f3b600e9d3a67ccfa53a07c59996285c18e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"elsif node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027default_store\u0027] \u003d\u003d \u0027rbd\u0027"},{"line_number":63,"context_line":"  include_recipe \u0027ceph::_common\u0027"},{"line_number":64,"context_line":"  include_recipe \u0027ceph::install\u0027"},{"line_number":65,"context_line":"  include_recipe \u0027ceph::conf\u0027"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1a930d6b_68a97e8f","line":63,"in_reply_to":"3a961159_8d678824","updated":"2015-01-26 12:55:57.000000000","message":"I would like to wait until https://github.com/ceph/ceph-cookbook/pull/186 is settled before merging this.","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"}],"spec/api_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"016649b52242b4a5db4a1e4f345673c5cf5155fa","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        node.set[\u0027ceph\u0027][\u0027config\u0027][\u0027fsid\u0027] \u003d \u002700000000-0000-0000-0000-000000000000\u0027"},{"line_number":65,"context_line":"      end"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"      it \u0027includes the ceph::_common package\u0027 do"},{"line_number":68,"context_line":"        expect(chef_run).to include_recipe(\u0027ceph::_common\u0027)"},{"line_number":69,"context_line":"      end"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3a961159_0d7398e7","line":67,"updated":"2015-01-15 19:47:42.000000000","message":"recipe instead of package?","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"016649b52242b4a5db4a1e4f345673c5cf5155fa","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        expect(chef_run).to include_recipe(\u0027ceph::_common\u0027)"},{"line_number":69,"context_line":"      end"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"      it \u0027includes the ceph::install package\u0027 do"},{"line_number":72,"context_line":"        expect(chef_run).to include_recipe(\u0027ceph::install\u0027)"},{"line_number":73,"context_line":"      end"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3a961159_6d497c8d","line":71,"updated":"2015-01-15 19:47:42.000000000","message":"recipe instead of package?","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"016649b52242b4a5db4a1e4f345673c5cf5155fa","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        expect(chef_run).to include_recipe(\u0027ceph::install\u0027)"},{"line_number":73,"context_line":"      end"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      it \u0027includes the ceph::conf package\u0027 do"},{"line_number":76,"context_line":"        expect(chef_run).to include_recipe(\u0027ceph::conf\u0027)"},{"line_number":77,"context_line":"      end"},{"line_number":78,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3a961159_ad3fe4dd","line":75,"updated":"2015-01-15 19:47:42.000000000","message":"recipe instead of package?","commit_id":"9cd82520830d97a1c13520fc919d60a929cd2572"}]}