)]}'
{"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"31b9492eeea629771f86d23d56982e8081b9c613","unresolved":false,"context_lines":[{"line_number":16,"context_line":"end"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"depends           \u0027openstack-common\u0027, \u0027\u003e\u003d 10.2\u0027"},{"line_number":19,"context_line":"depends           \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":20,"context_line":"depends           \u0027ceph\u0027, \u0027\u003e\u003d 0.2.1\u0027"},{"line_number":21,"context_line":"depends           \u0027ceph\u0027, \u0027\u003c 3.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"da86d52c_2520eef6","line":19,"updated":"2015-02-09 18:43:16.000000000","message":"I also changed these to \u0027\u003e\u003d 10.0.0\u0027   to remove that optimistic range as it was causing problems for folks.\n\nI can fix that with a followup patch to like my others to not pollute this one.","commit_id":"be74e39244e0ef011c6193e0126701a4f14a835e"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"ba3ad3496fe23df6d3e009c336513a09427db3d3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"end"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"depends           \u0027openstack-common\u0027, \u0027\u003e\u003d 10.2\u0027"},{"line_number":19,"context_line":"depends           \u0027openstack-identity\u0027, \u0027~\u003e 10.0\u0027"},{"line_number":20,"context_line":"depends           \u0027ceph\u0027, \u0027\u003e\u003d 0.2.1\u0027"},{"line_number":21,"context_line":"depends           \u0027ceph\u0027, \u0027\u003c 3.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"da86d52c_46e08896","line":19,"in_reply_to":"da86d52c_2520eef6","updated":"2015-02-09 19:47:09.000000000","message":"Thx! Yup, it was when I was reviewing your patches that I realized that I missed that.","commit_id":"be74e39244e0ef011c6193e0126701a4f14a835e"}],"recipes/api.rb":[{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"a1d55d9d08b42a5e4563b94c5b8883ea886dcd73","unresolved":false,"context_lines":[{"line_number":107,"context_line":"glance \u003d node[\u0027openstack\u0027][\u0027image\u0027]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"identity_endpoint \u003d internal_endpoint \u0027identity-api\u0027"},{"line_number":110,"context_line":"identity_admin_endpoint \u003d admin_endpoint \u0027identity-admin\u0027"},{"line_number":111,"context_line":"service_pass \u003d get_password \u0027service\u0027, \u0027openstack-image\u0027"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"auth_uri \u003d auth_uri_transform identity_endpoint.to_s, node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027version\u0027]"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa81d914_13829652","line":110,"updated":"2015-01-27 19:43:07.000000000","message":"Does this makes sense? Using internal_endpoint for identity-api and admin_endpoint for identity-admin? I\u0027m wondering if identity-admin should become the admin_endpoint for \u0027identity-api\u0027? One the one hand it would be cleaner, but on the other, it could be confusing and more disruptive than I\u0027d like to see.","commit_id":"75aa2bc81f8f8aa51df32d4aad721ce8c0bdbfa7"}],"recipes/identity_registration.rb":[{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"a1d55d9d08b42a5e4563b94c5b8883ea886dcd73","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  include ::Openstack"},{"line_number":27,"context_line":"end"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"identity_admin_endpoint \u003d admin_endpoint \u0027identity-admin\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"token \u003d get_secret \u0027openstack_identity_bootstrap_token\u0027"},{"line_number":32,"context_line":"auth_url \u003d ::URI.decode identity_admin_endpoint.to_s"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa81d914_d3e63e44","line":29,"updated":"2015-01-27 19:43:07.000000000","message":"Same comment as before. Should identity-admin be refactored?","commit_id":"75aa2bc81f8f8aa51df32d4aad721ce8c0bdbfa7"}],"recipes/registry.rb":[{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"a1d55d9d08b42a5e4563b94c5b8883ea886dcd73","unresolved":false,"context_lines":[{"line_number":49,"context_line":"end"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"identity_endpoint \u003d internal_endpoint \u0027identity-api\u0027"},{"line_number":52,"context_line":"identity_admin_endpoint \u003d admin_endpoint \u0027identity-admin\u0027"},{"line_number":53,"context_line":"registry_bind \u003d internal_endpoint \u0027image-registry-bind\u0027"},{"line_number":54,"context_line":"service_pass \u003d get_password \u0027service\u0027, \u0027openstack-image\u0027"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa81d914_934a0626","line":52,"updated":"2015-01-27 19:43:07.000000000","message":"Again, should we refactor identity-admin to be the admin_endpoint for identity-api?","commit_id":"75aa2bc81f8f8aa51df32d4aad721ce8c0bdbfa7"}],"spec/identity_registration_spec.rb":[{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"a1d55d9d08b42a5e4563b94c5b8883ea886dcd73","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      )"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    it \u0027with different admin url\u0027 do"},{"line_number":82,"context_line":"      admin_url \u003d \u0027http://admin.host:456/admin_path\u0027"},{"line_number":83,"context_line":"      node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027admin\u0027][\u0027image-api\u0027][\u0027uri\u0027] \u003d admin_url"},{"line_number":84,"context_line":"      node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027identity-admin\u0027][\u0027uri\u0027] \u003d \u0027http://127.0.0.1:35357/v2.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa81d914_93f846c6","line":81,"updated":"2015-01-27 19:43:07.000000000","message":"Note that this test currently fails because of a bug in the common library. A fix has been proposed:\nhttps://review.openstack.org/#/c/150544/","commit_id":"75aa2bc81f8f8aa51df32d4aad721ce8c0bdbfa7"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"a1d55d9d08b42a5e4563b94c5b8883ea886dcd73","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    it \u0027with different admin,internal,public urls\u0027 do"},{"line_number":123,"context_line":"      internal_url \u003d \u0027http://internal.host:789/internal_path\u0027"},{"line_number":124,"context_line":"      admin_url \u003d \u0027http://admin.host:456/admin_path\u0027"},{"line_number":125,"context_line":"      public_url \u003d \u0027https://public.host:123/public_path\u0027"},{"line_number":126,"context_line":"      node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027internal\u0027][\u0027image-api\u0027][\u0027uri\u0027] \u003d internal_url"},{"line_number":127,"context_line":"      node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027admin\u0027][\u0027image-api\u0027][\u0027uri\u0027] \u003d admin_url"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa81d914_7314b2f5","line":124,"updated":"2015-01-27 19:43:07.000000000","message":"Note that this test currently fails because of a bug in the common library. A fix has been proposed:\nhttps://review.openstack.org/#/c/150544/","commit_id":"75aa2bc81f8f8aa51df32d4aad721ce8c0bdbfa7"}]}