)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14888,"name":"Kasey Alusi","email":"kasey.alusi@gmail.com","username":"kasey.alusi"},"change_message_id":"84473f4dda5e78aaaec2be83394a8029a97f4b03","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make SSL settings configurable for Glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit makes allows enabling SSL for glance-api and registry"},{"line_number":10,"context_line":"endpoints by adding few new node attributes. Glance API and registry"},{"line_number":11,"context_line":"configuration files are also modified to use these node attributes."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fabf19d9_e99fc1b2","line":9,"updated":"2015-04-18 14:58:18.000000000","message":"remove makes? :)","commit_id":"4262d4af7bf9392c57f8e5bb2502c9f0372cdfd9"}],"spec/api_spec.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"3f6c7b19e59dd51a080bbdb7898c2b267a819816","unresolved":false,"context_lines":[{"line_number":153,"context_line":"          context \u0027glance-registry with certificate validation enabled\u0027 do"},{"line_number":154,"context_line":"            it \u0027enables SSL in insecure mode\u0027 do"},{"line_number":155,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":156,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] \u003dfalse"},{"line_number":157,"context_line":"              r \u003d line_regexp(\u0027registry_client_insecure \u003d True\u0027)"},{"line_number":158,"context_line":"              expect(chef_run).not_to render_file(file.name).with_content(r)"},{"line_number":159,"context_line":"            end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9abe1de1_9de1a301","line":156,"updated":"2015-04-27 09:19:03.000000000","message":"add a space after \u003d","commit_id":"5465a768fd7f08c6bd793c079e1a224c9016dfe1"},{"author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"change_message_id":"c8d2aecb4fe972ee9d46fe92a4252555f5574e7e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"          context \u0027glance-registry with certificate validation enabled\u0027 do"},{"line_number":154,"context_line":"            it \u0027enables SSL in insecure mode\u0027 do"},{"line_number":155,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":156,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] \u003dfalse"},{"line_number":157,"context_line":"              r \u003d line_regexp(\u0027registry_client_insecure \u003d True\u0027)"},{"line_number":158,"context_line":"              expect(chef_run).not_to render_file(file.name).with_content(r)"},{"line_number":159,"context_line":"            end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7ad32947_dd6ddccd","line":156,"in_reply_to":"9abe1de1_9de1a301","updated":"2015-04-27 16:18:36.000000000","message":"Done","commit_id":"5465a768fd7f08c6bd793c079e1a224c9016dfe1"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"3f6c7b19e59dd51a080bbdb7898c2b267a819816","unresolved":false,"context_lines":[{"line_number":162,"context_line":"          context \u0027glance-registry with certificate validation disabled\u0027 do"},{"line_number":163,"context_line":"            it \u0027enables SSL in secure mode\u0027 do"},{"line_number":164,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":165,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] \u003dtrue"},{"line_number":166,"context_line":"              r \u003d line_regexp(\u0027registry_client_insecure \u003d True\u0027)"},{"line_number":167,"context_line":"              expect(chef_run).to render_file(file.name).with_content(r)"},{"line_number":168,"context_line":"            end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9abe1de1_fdd2df33","line":165,"updated":"2015-04-27 09:19:03.000000000","message":"add a space after \u003d","commit_id":"5465a768fd7f08c6bd793c079e1a224c9016dfe1"},{"author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"change_message_id":"c8d2aecb4fe972ee9d46fe92a4252555f5574e7e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"          context \u0027glance-registry with certificate validation disabled\u0027 do"},{"line_number":163,"context_line":"            it \u0027enables SSL in secure mode\u0027 do"},{"line_number":164,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":165,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] \u003dtrue"},{"line_number":166,"context_line":"              r \u003d line_regexp(\u0027registry_client_insecure \u003d True\u0027)"},{"line_number":167,"context_line":"              expect(chef_run).to render_file(file.name).with_content(r)"},{"line_number":168,"context_line":"            end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7ad32947_bd7220ac","line":165,"in_reply_to":"9abe1de1_fdd2df33","updated":"2015-04-27 16:18:36.000000000","message":"Done","commit_id":"5465a768fd7f08c6bd793c079e1a224c9016dfe1"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e3817b47632d9cd4480b60019bd1314d2b3fec6b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":105,"context_line":"            default_opts.each do |key, val|"},{"line_number":106,"context_line":"              r \u003d line_regexp(\"#{key} \u003d #{val}\")"},{"line_number":107,"context_line":"              expect(chef_run).to render_file(file.name).with_content(r)"},{"line_number":108,"context_line":"            end"},{"line_number":109,"context_line":"          end"},{"line_number":110,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7ad32947_2ca13caa","line":107,"updated":"2015-04-27 18:06:37.000000000","message":"would like to see all new spec content checks use the new Common matcher with section specific support.","commit_id":"8e9504f227ad131c48bf422016bfa96c01bbf9b9"},{"author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"change_message_id":"d2debc999d76f9fcc74c4eb596e5d8a8b4270ef6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":105,"context_line":"            default_opts.each do |key, val|"},{"line_number":106,"context_line":"              r \u003d line_regexp(\"#{key} \u003d #{val}\")"},{"line_number":107,"context_line":"              expect(chef_run).to render_file(file.name).with_content(r)"},{"line_number":108,"context_line":"            end"},{"line_number":109,"context_line":"          end"},{"line_number":110,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5ad0253b_17044f7c","line":107,"in_reply_to":"5ad0253b_b5afe07c","updated":"2015-04-28 19:58:47.000000000","message":"Done","commit_id":"8e9504f227ad131c48bf422016bfa96c01bbf9b9"},{"author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"change_message_id":"09d911b32486395d8bec8e52ac27d02abb2a3835","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":105,"context_line":"            default_opts.each do |key, val|"},{"line_number":106,"context_line":"              r \u003d line_regexp(\"#{key} \u003d #{val}\")"},{"line_number":107,"context_line":"              expect(chef_run).to render_file(file.name).with_content(r)"},{"line_number":108,"context_line":"            end"},{"line_number":109,"context_line":"          end"},{"line_number":110,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7ad32947_b877c3d3","line":107,"in_reply_to":"7ad32947_2ca13caa","updated":"2015-04-27 22:13:08.000000000","message":"According to https://github.com/openstack/glance/blob/master/etc/glance-api.conf/#L124, there are no section headers for SSL. I don\u0027t see the value add for putting match under [DEFAULT] section.","commit_id":"8e9504f227ad131c48bf422016bfa96c01bbf9b9"},{"author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"change_message_id":"d2debc999d76f9fcc74c4eb596e5d8a8b4270ef6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":105,"context_line":"            default_opts.each do |key, val|"},{"line_number":106,"context_line":"              r \u003d line_regexp(\"#{key} \u003d #{val}\")"},{"line_number":107,"context_line":"              expect(chef_run).to render_file(file.name).with_content(r)"},{"line_number":108,"context_line":"            end"},{"line_number":109,"context_line":"          end"},{"line_number":110,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5ad0253b_97f85f7e","line":107,"in_reply_to":"7ad32947_7d090f95","updated":"2015-04-28 19:58:47.000000000","message":"Done","commit_id":"8e9504f227ad131c48bf422016bfa96c01bbf9b9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d9ff01a6eedccc6f7d0703c1eb0310899ed1516d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":105,"context_line":"            default_opts.each do |key, val|"},{"line_number":106,"context_line":"              r \u003d line_regexp(\"#{key} \u003d #{val}\")"},{"line_number":107,"context_line":"              expect(chef_run).to render_file(file.name).with_content(r)"},{"line_number":108,"context_line":"            end"},{"line_number":109,"context_line":"          end"},{"line_number":110,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5ad0253b_b5afe07c","line":107,"in_reply_to":"7ad32947_7d090f95","updated":"2015-04-28 15:45:32.000000000","message":"It\u0027s even more important when the values are just sitting together in the \"will one day be deprecated\" Default section.","commit_id":"8e9504f227ad131c48bf422016bfa96c01bbf9b9"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"6d7b1537ccf785217304147f6954aa486dbfe4b5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":105,"context_line":"            default_opts.each do |key, val|"},{"line_number":106,"context_line":"              r \u003d line_regexp(\"#{key} \u003d #{val}\")"},{"line_number":107,"context_line":"              expect(chef_run).to render_file(file.name).with_content(r)"},{"line_number":108,"context_line":"            end"},{"line_number":109,"context_line":"          end"},{"line_number":110,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7ad32947_7d090f95","line":107,"in_reply_to":"7ad32947_b877c3d3","updated":"2015-04-28 09:19:01.000000000","message":"i aggree with Mark here, since we are probably going to move to a new way of rendering templates it would be good to always match the section","commit_id":"8e9504f227ad131c48bf422016bfa96c01bbf9b9"}],"spec/registry_spec.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"3f6c7b19e59dd51a080bbdb7898c2b267a819816","unresolved":false,"context_lines":[{"line_number":236,"context_line":"          end"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"          context \u0027with cert not required\u0027 do"},{"line_number":239,"context_line":"            #cert \u003d { \u0027ca_file\u0027 \u003d\u003e \u0027/etc/glance/ssl/certs/sslca.pem\u0027 }"},{"line_number":240,"context_line":"            it \u0027configures CA cert \u0027 do"},{"line_number":241,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":242,"context_line":"              node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] \u003d false"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9abe1de1_fd041fc7","line":239,"updated":"2015-04-27 09:19:03.000000000","message":"add a space after #","commit_id":"5465a768fd7f08c6bd793c079e1a224c9016dfe1"}],"templates/default/glance-api.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"379498bb008530364a74f470c3f2aebe9b4b9706","unresolved":false,"context_lines":[{"line_number":181,"context_line":"registry_client_ca_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027cafile\u0027] %\u003e"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  \u003c% end %\u003e"},{"line_number":184,"context_line":"  \u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] %\u003e"},{"line_number":185,"context_line":"# When using SSL in connections to the registry server, do not require"},{"line_number":186,"context_line":"# validation via a certifying authority. This is the registry\u0027s equivalent of"},{"line_number":187,"context_line":"# specifying --insecure on the command line using glanceclient for the API"}],"source_content_type":"application/x-erb","patch_set":6,"id":"5ad0253b_8df60cd6","line":184,"updated":"2015-04-28 20:30:38.000000000","message":"why the need for the if logic here, why not just use the node attr directly as the value for this?","commit_id":"48c571d67b9427279d2bd1b7f08c3813b580e978"},{"author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"change_message_id":"6ddd5183e338ff96f59c7c65e4e06215641d4f1d","unresolved":false,"context_lines":[{"line_number":181,"context_line":"registry_client_ca_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027cafile\u0027] %\u003e"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  \u003c% end %\u003e"},{"line_number":184,"context_line":"  \u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] %\u003e"},{"line_number":185,"context_line":"# When using SSL in connections to the registry server, do not require"},{"line_number":186,"context_line":"# validation via a certifying authority. This is the registry\u0027s equivalent of"},{"line_number":187,"context_line":"# specifying --insecure on the command line using glanceclient for the API"}],"source_content_type":"application/x-erb","patch_set":6,"id":"5ad0253b_e6b8fee7","line":184,"in_reply_to":"5ad0253b_8df60cd6","updated":"2015-04-28 22:08:23.000000000","message":"Done","commit_id":"48c571d67b9427279d2bd1b7f08c3813b580e978"}],"templates/default/glance-registry.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"379498bb008530364a74f470c3f2aebe9b4b9706","unresolved":false,"context_lines":[{"line_number":238,"context_line":"admin_user \u003d \u003c%\u003d node[\"openstack\"][\"image\"][\"service_user\"] %\u003e"},{"line_number":239,"context_line":"admin_password \u003d \u003c%\u003d @service_pass %\u003e"},{"line_number":240,"context_line":"signing_dir \u003d \u003c%\u003d node[\"openstack\"][\"image\"][\"registry\"][\"auth\"][\"cache_dir\"] %\u003e"},{"line_number":241,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027registry\u0027][\u0027auth\u0027][\u0027insecure\u0027] %\u003e"},{"line_number":242,"context_line":"insecure \u003d true"},{"line_number":243,"context_line":"\u003c% end %\u003e"},{"line_number":244,"context_line":""}],"source_content_type":"application/x-erb","patch_set":6,"id":"5ad0253b_2d2c9849","line":241,"updated":"2015-04-28 20:30:38.000000000","message":"why the need for the if logic here, why not just use the node attr directly as the value for this?","commit_id":"48c571d67b9427279d2bd1b7f08c3813b580e978"}]}