)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"b3e3c24ac5db3621b0448d58d6199b76a1f3fc49","unresolved":false,"context_lines":[{"line_number":14,"context_line":"task."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ieed28ad891192d81356c0d40ba48d70517087950"},{"line_number":17,"context_line":"Closes-Bug: #1459169"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_5603f20f","line":17,"updated":"2015-06-05 06:51:41.000000000","message":"I do not think it is related to the bug 1459169.","commit_id":"78f017cf665b54a930f9e3f0c6ce534b25c3f29e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"2610fb46d849b473d15ff7aa43dd23e2df12ad0c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"task."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ieed28ad891192d81356c0d40ba48d70517087950"},{"line_number":17,"context_line":"Closes-Bug: #1459169"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_2baa41d5","line":17,"in_reply_to":"3afb71cf_5603f20f","updated":"2015-06-05 14:58:46.000000000","message":"Yup, created new bug for this.","commit_id":"78f017cf665b54a930f9e3f0c6ce534b25c3f29e"}],"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"d61b31ab460b0842b0dc5a7805b00eac0ebed7da","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# SSL Options"},{"line_number":31,"context_line":"# Enable SSL for glance-api bind endpoint. NOTE: Once enabled, Glance service endpoint"},{"line_number":32,"context_line":"# must be set to https on Keystone"},{"line_number":33,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d false"},{"line_number":34,"context_line":"# Base directory for SSL certficate and key"},{"line_number":35,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027] \u003d \u0027/etc/glance/ssl\u0027"},{"line_number":36,"context_line":"# Path of the cert file for SSL."}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_76626eda","line":33,"updated":"2015-06-05 05:11:50.000000000","message":"a question how to makes sure that setting this attribute to true sync with the registry_scheme ?","commit_id":"78f017cf665b54a930f9e3f0c6ce534b25c3f29e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"2610fb46d849b473d15ff7aa43dd23e2df12ad0c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# SSL Options"},{"line_number":31,"context_line":"# Enable SSL for glance-api bind endpoint. NOTE: Once enabled, Glance service endpoint"},{"line_number":32,"context_line":"# must be set to https on Keystone"},{"line_number":33,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d false"},{"line_number":34,"context_line":"# Base directory for SSL certficate and key"},{"line_number":35,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027] \u003d \u0027/etc/glance/ssl\u0027"},{"line_number":36,"context_line":"# Path of the cert file for SSL."}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_cb772d01","line":33,"in_reply_to":"3afb71cf_76626eda","updated":"2015-06-05 14:58:46.000000000","message":"Ma Wen Cheng, Yeah, don\u0027t have a good answer for that, I can add a line to the ReadMe, but I suspect this is not covered very well for the other components either.\n\nYang Lei, yup, I see your point.  For the endpoints this should be separately controllable for api and registry.  I\u0027ll update patch to allow for that.","commit_id":"78f017cf665b54a930f9e3f0c6ce534b25c3f29e"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"b3e3c24ac5db3621b0448d58d6199b76a1f3fc49","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# SSL Options"},{"line_number":31,"context_line":"# Enable SSL for glance-api bind endpoint. NOTE: Once enabled, Glance service endpoint"},{"line_number":32,"context_line":"# must be set to https on Keystone"},{"line_number":33,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] \u003d false"},{"line_number":34,"context_line":"# Base directory for SSL certficate and key"},{"line_number":35,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027] \u003d \u0027/etc/glance/ssl\u0027"},{"line_number":36,"context_line":"# Path of the cert file for SSL."}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3afb71cf_39606935","line":33,"in_reply_to":"3afb71cf_76626eda","updated":"2015-06-05 06:51:41.000000000","message":"Yes, same question.\n\nglance-registry.conf.erb set cert_file/key_file/ca_file according to node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027] ,\nbut \nglance-api.conf.erb set registry_client_key_file/registry_client_cert_file/registry_client_ca_file according to registry_scheme .\n(node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027scheme\u0027])","commit_id":"78f017cf665b54a930f9e3f0c6ce534b25c3f29e"},{"author":{"_account_id":9492,"name":"Yi Ming Yin","email":"yinym@cn.ibm.com","username":"yym"},"change_message_id":"8fbcc3eb817a5ccbf8bc30e0e3c8aa6491509b5b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# Base directory for SSL certficate and key"},{"line_number":38,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027] \u003d \u0027/etc/glance/ssl\u0027"},{"line_number":39,"context_line":"# Path of the cert file for SSL."},{"line_number":40,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/certs/sslcert.pem\""},{"line_number":41,"context_line":"# Path of the keyfile for SSL."},{"line_number":42,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/private/sslkey.pem\""},{"line_number":43,"context_line":"# Specify server whether SSL certificate is required"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa32b979_7e1255b6","line":40,"updated":"2015-06-15 06:13:23.000000000","message":"We\u0027ve set the default value here. It seems that \"nil\" value in environment override_attributes cannot really \"override\" the value to nil. After chef run, it will be still the default value, unless we set this value as empty string \"\" in environment override attribute.\n\nMaybe we need to consider to set the default value as nil here. Or we need to change the template logic as to check if this value is empty. This is because once we set this value in default, it will not be overriden to nil anymore, unless we specifically set or delete this attribute in recipes.","commit_id":"248c5ed1bd0ca9deb57a89162ac005170e03ccf8"},{"author":{"_account_id":9492,"name":"Yi Ming Yin","email":"yinym@cn.ibm.com","username":"yym"},"change_message_id":"8fbcc3eb817a5ccbf8bc30e0e3c8aa6491509b5b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# Path of the cert file for SSL."},{"line_number":40,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/certs/sslcert.pem\""},{"line_number":41,"context_line":"# Path of the keyfile for SSL."},{"line_number":42,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/private/sslkey.pem\""},{"line_number":43,"context_line":"# Specify server whether SSL certificate is required"},{"line_number":44,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] \u003d false"},{"line_number":45,"context_line":"# Path of the CA cert file for SSL. Only use if client certificate is required"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa32b979_9e1719a3","line":42,"updated":"2015-06-15 06:13:23.000000000","message":"Same as above.","commit_id":"248c5ed1bd0ca9deb57a89162ac005170e03ccf8"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"71cdc06a28edf8c57b957f3f9ddc2d1c81e9d297","unresolved":false,"context_lines":[{"line_number":36,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027registry\u0027][\u0027enabled\u0027] \u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027]"},{"line_number":37,"context_line":"# Base directory for SSL certficate and key"},{"line_number":38,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027] \u003d \u0027/etc/glance/ssl\u0027"},{"line_number":39,"context_line":"# Path of the cert file for SSL. An empty string value will remove the key."},{"line_number":40,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/certs/sslcert.pem\""},{"line_number":41,"context_line":"# Path of the keyfile for SSL. An empty string value will remove the key."},{"line_number":42,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/private/sslkey.pem\""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa32b979_4599dfc2","line":39,"updated":"2015-06-19 06:40:47.000000000","message":"is this needed? enabling or disabling ssl will remove the key anyway right?","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"99541a4036a69fa8c4a669feda22a338bfa673a3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027registry\u0027][\u0027enabled\u0027] \u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027enabled\u0027]"},{"line_number":37,"context_line":"# Base directory for SSL certficate and key"},{"line_number":38,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027] \u003d \u0027/etc/glance/ssl\u0027"},{"line_number":39,"context_line":"# Path of the cert file for SSL. An empty string value will remove the key."},{"line_number":40,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/certs/sslcert.pem\""},{"line_number":41,"context_line":"# Path of the keyfile for SSL. An empty string value will remove the key."},{"line_number":42,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/private/sslkey.pem\""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa32b979_4e757030","line":39,"in_reply_to":"fa32b979_4599dfc2","updated":"2015-06-19 13:54:11.000000000","message":"Please take a look at Yi Mings comments.  Basically you can enable ssl, and NOT have a cert/key specified and just use the ca cert file is enough to connect to the registry service.  If the glance code there checks for this case so I was trying to allow for it.","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"92119bab695e5b65e65f3234759ab588f0963b7c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Path of the keyfile for SSL."},{"line_number":42,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/private/sslkey.pem\""},{"line_number":43,"context_line":"# Specify server whether SSL certificate is required"},{"line_number":44,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] \u003d false"},{"line_number":45,"context_line":"# Path of the CA cert file for SSL. Only use if client certificate is required"},{"line_number":46,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/certs/sslca.pem\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa32b979_98611bab","line":44,"updated":"2015-06-23 08:49:13.000000000","message":"maybe rename this to cacert_required? (comments also in the *.conf.erb)","commit_id":"3ede834e41dfe3ca70171cd58a5d58a5d7c3398a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e150320d7687216ec2e24b8857ed69f7c210877d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Path of the keyfile for SSL."},{"line_number":42,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/private/sslkey.pem\""},{"line_number":43,"context_line":"# Specify server whether SSL certificate is required"},{"line_number":44,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] \u003d false"},{"line_number":45,"context_line":"# Path of the CA cert file for SSL. Only use if client certificate is required"},{"line_number":46,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] \u003d \"#{node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027basedir\u0027]}/certs/sslca.pem\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa32b979_41594c34","line":44,"in_reply_to":"fa32b979_98611bab","updated":"2015-06-23 13:58:32.000000000","message":"That\u0027s a good comment, I\u0027ll open a bug for it and put it in the backlog.\n\nhttps://bugs.launchpad.net/openstack-chef/+bug/1467951","commit_id":"3ede834e41dfe3ca70171cd58a5d58a5d7c3398a"}],"templates/default/glance-api.conf.erb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"d61b31ab460b0842b0dc5a7805b00eac0ebed7da","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# What protocol to use when connecting to the registry server?"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# Set to https for secure HTTP communication"},{"line_number":165,"context_line":"registry_client_protocol \u003d \u003c%\u003d @registry_scheme %\u003e"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"\u003c% if @registry_scheme \u003d\u003d \u0027https\u0027 -%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"3afb71cf_761dce65","line":164,"updated":"2015-06-05 05:11:50.000000000","message":"the comment needs to be updated according to the new setting.","commit_id":"78f017cf665b54a930f9e3f0c6ce534b25c3f29e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"2610fb46d849b473d15ff7aa43dd23e2df12ad0c","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# What protocol to use when connecting to the registry server?"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# Set to https for secure HTTP communication"},{"line_number":165,"context_line":"registry_client_protocol \u003d \u003c%\u003d @registry_scheme %\u003e"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"\u003c% if @registry_scheme \u003d\u003d \u0027https\u0027 -%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"3afb71cf_6bccb935","line":164,"in_reply_to":"3afb71cf_761dce65","updated":"2015-06-05 14:58:46.000000000","message":"Done","commit_id":"78f017cf665b54a930f9e3f0c6ce534b25c3f29e"},{"author":{"_account_id":9492,"name":"Yi Ming Yin","email":"yinym@cn.ibm.com","username":"yym"},"change_message_id":"53278dcdea20fc34bf3d48bb7c7a25065f367618","unresolved":false,"context_lines":[{"line_number":166,"context_line":"# The path to the key file to use in SSL connections to the"},{"line_number":167,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":168,"context_line":"# GLANCE_CLIENT_KEY_FILE environ variable to a filepath of the key file"},{"line_number":169,"context_line":"registry_client_key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# The path to the cert file to use in SSL connections to the"},{"line_number":172,"context_line":"# registry server, if any. Alternately, you may set the"}],"source_content_type":"application/x-erb","patch_set":2,"id":"1af86dd1_1579f293","line":169,"updated":"2015-06-12 08:09:56.000000000","message":"This key should be removed if we do not have a valid key_file here. Leave the key as empty or invalid key_file path will cause the glance_api failed to connect to registry with https.\n\nThis is caused by glance client code https://github.com/openstack/glance/blob/master/glance/common/client.py#L236. It is using \"not None\" to check these attributes. So we need to make sure the option is not in conf file to give it a \"None\" option.\n\nActually, if we don\u0027t need to validate client (in most cases), the registry_client_ca_file is enough for us to connect to https APIs.","commit_id":"28981d91fd965fecb1afbe659df7d4c62d9576b1"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"71942fc79c200f2c834916be090bb4a76a10edd6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"# The path to the key file to use in SSL connections to the"},{"line_number":167,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":168,"context_line":"# GLANCE_CLIENT_KEY_FILE environ variable to a filepath of the key file"},{"line_number":169,"context_line":"registry_client_key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# The path to the cert file to use in SSL connections to the"},{"line_number":172,"context_line":"# registry server, if any. Alternately, you may set the"}],"source_content_type":"application/x-erb","patch_set":2,"id":"1af86dd1_c8a3b49d","line":169,"in_reply_to":"1af86dd1_1579f293","updated":"2015-06-12 14:45:14.000000000","message":"Yeah, I can add in the nil check for these two.   But I also see that we are using the same attributes (key_file, cert_file) for all 3 cases (API service, API use of registry client, Registry service), I think at some point these should all be separate attributes, but I\u0027ll leave that for another patch.","commit_id":"28981d91fd965fecb1afbe659df7d4c62d9576b1"},{"author":{"_account_id":9492,"name":"Yi Ming Yin","email":"yinym@cn.ibm.com","username":"yym"},"change_message_id":"53278dcdea20fc34bf3d48bb7c7a25065f367618","unresolved":false,"context_lines":[{"line_number":171,"context_line":"# The path to the cert file to use in SSL connections to the"},{"line_number":172,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":173,"context_line":"# GLANCE_CLIENT_CERT_FILE environ variable to a filepath of the cert file"},{"line_number":174,"context_line":"registry_client_cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":175,"context_line":"  \u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] %\u003e"},{"line_number":176,"context_line":"# The path to the certifying authority cert file to use in SSL connections"},{"line_number":177,"context_line":"# to the registry server, if any. Alternately, you may set the"}],"source_content_type":"application/x-erb","patch_set":2,"id":"1af86dd1_9565e2e2","line":174,"updated":"2015-06-12 08:09:56.000000000","message":"Same issue as above","commit_id":"28981d91fd965fecb1afbe659df7d4c62d9576b1"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"71942fc79c200f2c834916be090bb4a76a10edd6","unresolved":false,"context_lines":[{"line_number":171,"context_line":"# The path to the cert file to use in SSL connections to the"},{"line_number":172,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":173,"context_line":"# GLANCE_CLIENT_CERT_FILE environ variable to a filepath of the cert file"},{"line_number":174,"context_line":"registry_client_cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":175,"context_line":"  \u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] %\u003e"},{"line_number":176,"context_line":"# The path to the certifying authority cert file to use in SSL connections"},{"line_number":177,"context_line":"# to the registry server, if any. Alternately, you may set the"}],"source_content_type":"application/x-erb","patch_set":2,"id":"1af86dd1_a8a07891","line":174,"in_reply_to":"1af86dd1_9565e2e2","updated":"2015-06-12 14:45:14.000000000","message":"Done","commit_id":"28981d91fd965fecb1afbe659df7d4c62d9576b1"},{"author":{"_account_id":9492,"name":"Yi Ming Yin","email":"yinym@cn.ibm.com","username":"yym"},"change_message_id":"8fbcc3eb817a5ccbf8bc30e0e3c8aa6491509b5b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"# The path to the key file to use in SSL connections to the"},{"line_number":167,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":168,"context_line":"# GLANCE_CLIENT_KEY_FILE environ variable to a filepath of the key file"},{"line_number":169,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027key_file\u0027].nil? %\u003e"},{"line_number":170,"context_line":"registry_client_key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":171,"context_line":"  \u003c% end %\u003e"},{"line_number":172,"context_line":""}],"source_content_type":"application/x-erb","patch_set":4,"id":"fa32b979_be81bd91","line":169,"updated":"2015-06-15 06:13:23.000000000","message":"Maybe we need to check the empty value as well. Otherwise, users cannot simply override the default value back to \u0027nil\u0027 due to the reason I posted in default/attribute.rb","commit_id":"248c5ed1bd0ca9deb57a89162ac005170e03ccf8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"10b942ba4fcee956bb8694075656176fd3ad80f2","unresolved":false,"context_lines":[{"line_number":166,"context_line":"# The path to the key file to use in SSL connections to the"},{"line_number":167,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":168,"context_line":"# GLANCE_CLIENT_KEY_FILE environ variable to a filepath of the key file"},{"line_number":169,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027key_file\u0027].nil? %\u003e"},{"line_number":170,"context_line":"registry_client_key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":171,"context_line":"  \u003c% end %\u003e"},{"line_number":172,"context_line":""}],"source_content_type":"application/x-erb","patch_set":4,"id":"fa32b979_c03d9abc","line":169,"in_reply_to":"fa32b979_be81bd91","updated":"2015-06-15 18:39:27.000000000","message":"agreed.  I\u0027ll use the .to_s.empty? trick, it handles both nil and empty string.","commit_id":"248c5ed1bd0ca9deb57a89162ac005170e03ccf8"},{"author":{"_account_id":9492,"name":"Yi Ming Yin","email":"yinym@cn.ibm.com","username":"yym"},"change_message_id":"8fbcc3eb817a5ccbf8bc30e0e3c8aa6491509b5b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"# The path to the cert file to use in SSL connections to the"},{"line_number":174,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":175,"context_line":"# GLANCE_CLIENT_CERT_FILE environ variable to a filepath of the cert file"},{"line_number":176,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027cert_file\u0027].nil? %\u003e"},{"line_number":177,"context_line":"registry_client_cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":178,"context_line":"  \u003c% end %\u003e"},{"line_number":179,"context_line":"  \u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] %\u003e"}],"source_content_type":"application/x-erb","patch_set":4,"id":"fa32b979_7e4a5585","line":176,"updated":"2015-06-15 06:13:23.000000000","message":"Same as above","commit_id":"248c5ed1bd0ca9deb57a89162ac005170e03ccf8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"10b942ba4fcee956bb8694075656176fd3ad80f2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"# The path to the cert file to use in SSL connections to the"},{"line_number":174,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":175,"context_line":"# GLANCE_CLIENT_CERT_FILE environ variable to a filepath of the cert file"},{"line_number":176,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027cert_file\u0027].nil? %\u003e"},{"line_number":177,"context_line":"registry_client_cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":178,"context_line":"  \u003c% end %\u003e"},{"line_number":179,"context_line":"  \u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] %\u003e"}],"source_content_type":"application/x-erb","patch_set":4,"id":"fa32b979_604cce70","line":176,"in_reply_to":"fa32b979_7e4a5585","updated":"2015-06-15 18:39:27.000000000","message":"Done","commit_id":"248c5ed1bd0ca9deb57a89162ac005170e03ccf8"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"71cdc06a28edf8c57b957f3f9ddc2d1c81e9d297","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# Certificate file to use when starting API server securely"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027api\u0027][\u0027enabled\u0027] -%\u003e"},{"line_number":135,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027cert_file\u0027].to_s.empty? -%\u003e"},{"line_number":136,"context_line":"cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":137,"context_line":"  \u003c% end -%\u003e"},{"line_number":138,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_653f43b4","line":135,"updated":"2015-06-19 06:40:47.000000000","message":"is this check needed here? i think if you enable ssl, you have to add the path to a cert and key file, right? (same goes ofc for the changes below and the registry one)","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"b89e9d4ce1def851ed931b2ec0849118e0646fc2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# Certificate file to use when starting API server securely"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027api\u0027][\u0027enabled\u0027] -%\u003e"},{"line_number":135,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027cert_file\u0027].to_s.empty? -%\u003e"},{"line_number":136,"context_line":"cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":137,"context_line":"  \u003c% end -%\u003e"},{"line_number":138,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_1c62ffd8","line":135,"in_reply_to":"fa32b979_0eb528cf","updated":"2015-06-22 16:04:57.000000000","message":"as discussed in the chat, the unless checks are not needed here, since cert and key file are needed if ssl is enabled in this context","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1afc56a7642deef21f565af4a98f9a73bd2d470a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# Certificate file to use when starting API server securely"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027api\u0027][\u0027enabled\u0027] -%\u003e"},{"line_number":135,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027cert_file\u0027].to_s.empty? -%\u003e"},{"line_number":136,"context_line":"cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":137,"context_line":"  \u003c% end -%\u003e"},{"line_number":138,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_e311af05","line":135,"in_reply_to":"fa32b979_1c62ffd8","updated":"2015-06-22 19:13:19.000000000","message":"Done","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"99541a4036a69fa8c4a669feda22a338bfa673a3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# Certificate file to use when starting API server securely"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027api\u0027][\u0027enabled\u0027] -%\u003e"},{"line_number":135,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027cert_file\u0027].to_s.empty? -%\u003e"},{"line_number":136,"context_line":"cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":137,"context_line":"  \u003c% end -%\u003e"},{"line_number":138,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_0eb528cf","line":135,"in_reply_to":"fa32b979_653f43b4","updated":"2015-06-19 13:54:11.000000000","message":"See attribute reply.","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"b89e9d4ce1def851ed931b2ec0849118e0646fc2","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  \u003c% end -%\u003e"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# Private key file to use when starting API server securely"},{"line_number":140,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027key_file\u0027].to_s.empty? -%\u003e"},{"line_number":141,"context_line":"key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":142,"context_line":"  \u003c% end -%\u003e"},{"line_number":143,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_7caa2bd4","line":140,"updated":"2015-06-22 16:04:57.000000000","message":"unless not needed here","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1afc56a7642deef21f565af4a98f9a73bd2d470a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  \u003c% end -%\u003e"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# Private key file to use when starting API server securely"},{"line_number":140,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027key_file\u0027].to_s.empty? -%\u003e"},{"line_number":141,"context_line":"key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":142,"context_line":"  \u003c% end -%\u003e"},{"line_number":143,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_83f9c3ca","line":140,"in_reply_to":"fa32b979_7caa2bd4","updated":"2015-06-22 19:13:19.000000000","message":"Done","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"b89e9d4ce1def851ed931b2ec0849118e0646fc2","unresolved":false,"context_lines":[{"line_number":170,"context_line":"# The path to the key file to use in SSL connections to the"},{"line_number":171,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":172,"context_line":"# GLANCE_CLIENT_KEY_FILE environ variable to a filepath of the key file"},{"line_number":173,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027key_file\u0027].to_s.empty? -%\u003e"},{"line_number":174,"context_line":"registry_client_key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":175,"context_line":"  \u003c% end -%\u003e"},{"line_number":176,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_fceb9b10","line":173,"updated":"2015-06-22 16:04:57.000000000","message":"unless is actually needed here and for the one below","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1afc56a7642deef21f565af4a98f9a73bd2d470a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"# The path to the key file to use in SSL connections to the"},{"line_number":171,"context_line":"# registry server, if any. Alternately, you may set the"},{"line_number":172,"context_line":"# GLANCE_CLIENT_KEY_FILE environ variable to a filepath of the key file"},{"line_number":173,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027key_file\u0027].to_s.empty? -%\u003e"},{"line_number":174,"context_line":"registry_client_key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":175,"context_line":"  \u003c% end -%\u003e"},{"line_number":176,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_4303bbb8","line":173,"in_reply_to":"fa32b979_fceb9b10","updated":"2015-06-22 19:13:19.000000000","message":"Done","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"92119bab695e5b65e65f3234759ab588f0963b7c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"registry_client_cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":177,"context_line":"  \u003c% end -%\u003e"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"  \u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] -%\u003e"},{"line_number":180,"context_line":"# The path to the certifying authority cert file to use in SSL connections"},{"line_number":181,"context_line":"# to the registry server, if any. Alternately, you may set the"},{"line_number":182,"context_line":"# GLANCE_CLIENT_CA_FILE environ variable to a filepath of the CA cert file"}],"source_content_type":"application/x-erb","patch_set":6,"id":"fa32b979_b8b97f30","line":179,"updated":"2015-06-23 08:49:13.000000000","message":"not sure if renaming is a good idea in this context, but maybe its easier to understand if its called \u0027cacert_required\u0027 instead of \u0027cert_required\u0027?","commit_id":"3ede834e41dfe3ca70171cd58a5d58a5d7c3398a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e150320d7687216ec2e24b8857ed69f7c210877d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"registry_client_cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":177,"context_line":"  \u003c% end -%\u003e"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"  \u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] -%\u003e"},{"line_number":180,"context_line":"# The path to the certifying authority cert file to use in SSL connections"},{"line_number":181,"context_line":"# to the registry server, if any. Alternately, you may set the"},{"line_number":182,"context_line":"# GLANCE_CLIENT_CA_FILE environ variable to a filepath of the CA cert file"}],"source_content_type":"application/x-erb","patch_set":6,"id":"fa32b979_21f0c8fc","line":179,"in_reply_to":"fa32b979_b8b97f30","updated":"2015-06-23 13:58:32.000000000","message":"opened a bug to look into renaming this later.","commit_id":"3ede834e41dfe3ca70171cd58a5d58a5d7c3398a"}],"templates/default/glance-registry.conf.erb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"b89e9d4ce1def851ed931b2ec0849118e0646fc2","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027registry\u0027][\u0027enabled\u0027] -%\u003e"},{"line_number":89,"context_line":"# Certificate file to use when starting registry server securely"},{"line_number":90,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027cert_file\u0027].to_s.empty? -%\u003e"},{"line_number":91,"context_line":"cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":92,"context_line":"  \u003c% end -%\u003e"},{"line_number":93,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_fc395ba4","line":90,"updated":"2015-06-22 16:04:57.000000000","message":"unless check not needed here","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1afc56a7642deef21f565af4a98f9a73bd2d470a","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027registry\u0027][\u0027enabled\u0027] -%\u003e"},{"line_number":89,"context_line":"# Certificate file to use when starting registry server securely"},{"line_number":90,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027cert_file\u0027].to_s.empty? -%\u003e"},{"line_number":91,"context_line":"cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":92,"context_line":"  \u003c% end -%\u003e"},{"line_number":93,"context_line":""}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_431adb18","line":90,"in_reply_to":"fa32b979_fc395ba4","updated":"2015-06-22 19:13:19.000000000","message":"Done","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"b89e9d4ce1def851ed931b2ec0849118e0646fc2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":92,"context_line":"  \u003c% end -%\u003e"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027key_file\u0027].to_s.empty? -%\u003e"},{"line_number":95,"context_line":"# Private key file to use when starting registry server securely"},{"line_number":96,"context_line":"key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":97,"context_line":"  \u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_7c46ab22","line":94,"updated":"2015-06-22 16:04:57.000000000","message":"unless check not needed here","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1afc56a7642deef21f565af4a98f9a73bd2d470a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"cert_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_file\u0027] %\u003e"},{"line_number":92,"context_line":"  \u003c% end -%\u003e"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  \u003c% unless node[\"openstack\"][\"image\"][\u0027ssl\u0027][\u0027key_file\u0027].to_s.empty? -%\u003e"},{"line_number":95,"context_line":"# Private key file to use when starting registry server securely"},{"line_number":96,"context_line":"key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":97,"context_line":"  \u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":5,"id":"fa32b979_63159fe3","line":94,"in_reply_to":"fa32b979_7c46ab22","updated":"2015-06-22 19:13:19.000000000","message":"Done","commit_id":"d52cae771355bf890643c7f17854f1fefbe2a669"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"92119bab695e5b65e65f3234759ab588f0963b7c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# Private key file to use when starting registry server securely"},{"line_number":94,"context_line":"key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] -%\u003e"},{"line_number":97,"context_line":"# CA certificate file to use to verify connecting clients"},{"line_number":98,"context_line":"ca_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] %\u003e"},{"line_number":99,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":6,"id":"fa32b979_98ecbb2a","line":96,"updated":"2015-06-23 08:49:13.000000000","message":"same as for glance-api.conf.erb","commit_id":"3ede834e41dfe3ca70171cd58a5d58a5d7c3398a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e150320d7687216ec2e24b8857ed69f7c210877d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# Private key file to use when starting registry server securely"},{"line_number":94,"context_line":"key_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027key_file\u0027] %\u003e"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027cert_required\u0027] -%\u003e"},{"line_number":97,"context_line":"# CA certificate file to use to verify connecting clients"},{"line_number":98,"context_line":"ca_file \u003d \u003c%\u003d node[\u0027openstack\u0027][\u0027image\u0027][\u0027ssl\u0027][\u0027ca_file\u0027] %\u003e"},{"line_number":99,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":6,"id":"fa32b979_a1e4d83b","line":96,"in_reply_to":"fa32b979_98ecbb2a","updated":"2015-06-23 13:58:32.000000000","message":"bug opened for later.","commit_id":"3ede834e41dfe3ca70171cd58a5d58a5d7c3398a"}]}