)]}'
{"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0bdb03b17f629d2a0a0c3400b43d9ec7893f683d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_datadir\u0027] \u003d \u0027/var/lib/glance/images\u0027"},{"line_number":138,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_file\u0027] \u003d nil"},{"line_number":139,"context_line":"# These two attributes are only available when filesystem_store_metadata_file is specified but not exist"},{"line_number":140,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_id\u0027] \u003d nil"},{"line_number":141,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_mountpoint\u0027] \u003d nil"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027swift\u0027][\u0027container\u0027] \u003d \u0027glance\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a41bdd9_8030ef02","line":140,"updated":"2015-07-13 14:31:50.000000000","message":"What is the value of the ID?  maybe give example or where it comes from?","commit_id":"c49a1ed5aac9bd48efe5edde7c0ddae5122422f6"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"2d05fdbf13f9366a4bedf155c73f48554fb4c3e8","unresolved":false,"context_lines":[{"line_number":137,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_datadir\u0027] \u003d \u0027/var/lib/glance/images\u0027"},{"line_number":138,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_file\u0027] \u003d nil"},{"line_number":139,"context_line":"# These two attributes are only available when filesystem_store_metadata_file is specified but not exist"},{"line_number":140,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_id\u0027] \u003d nil"},{"line_number":141,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_mountpoint\u0027] \u003d nil"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027swift\u0027][\u0027container\u0027] \u003d \u0027glance\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a41bdd9_14365d52","line":140,"in_reply_to":"9a41bdd9_8030ef02","updated":"2015-07-13 15:31:15.000000000","message":"Done","commit_id":"c49a1ed5aac9bd48efe5edde7c0ddae5122422f6"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0bdb03b17f629d2a0a0c3400b43d9ec7893f683d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_file\u0027] \u003d nil"},{"line_number":139,"context_line":"# These two attributes are only available when filesystem_store_metadata_file is specified but not exist"},{"line_number":140,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_id\u0027] \u003d nil"},{"line_number":141,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_mountpoint\u0027] \u003d nil"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027swift\u0027][\u0027container\u0027] \u003d \u0027glance\u0027"},{"line_number":144,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027swift\u0027][\u0027large_object_size\u0027] \u003d \u0027200\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a41bdd9_a0541321","line":141,"updated":"2015-07-13 14:31:50.000000000","message":"Would like to see a separate line comment for each attribute.  Maybe give an example?","commit_id":"c49a1ed5aac9bd48efe5edde7c0ddae5122422f6"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"2d05fdbf13f9366a4bedf155c73f48554fb4c3e8","unresolved":false,"context_lines":[{"line_number":138,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_file\u0027] \u003d nil"},{"line_number":139,"context_line":"# These two attributes are only available when filesystem_store_metadata_file is specified but not exist"},{"line_number":140,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_id\u0027] \u003d nil"},{"line_number":141,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_mountpoint\u0027] \u003d nil"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027swift\u0027][\u0027container\u0027] \u003d \u0027glance\u0027"},{"line_number":144,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027swift\u0027][\u0027large_object_size\u0027] \u003d \u0027200\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a41bdd9_34392142","line":141,"in_reply_to":"9a41bdd9_a0541321","updated":"2015-07-13 15:31:15.000000000","message":"Done","commit_id":"c49a1ed5aac9bd48efe5edde7c0ddae5122422f6"}],"recipes/api.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fcadcfbd324ac85d923a53c187ad6ef73a6cdd0f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  vmware_server_password \u003d get_password \u0027token\u0027, node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027vmware\u0027][\u0027secret_name\u0027]"},{"line_number":160,"context_line":"end"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"if glance[\u0027filesystem_store_metadata_file\u0027]"},{"line_number":163,"context_line":"  unless ::File.exist?(glance[\u0027filesystem_store_metadata_file\u0027])"},{"line_number":164,"context_line":"    template glance[\u0027filesystem_store_metadata_file\u0027] do"},{"line_number":165,"context_line":"      source \u0027glance-metadata.json.erb\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_baf9bc4f","line":162,"updated":"2015-07-13 03:29:06.000000000","message":"I think it is better to use a \"only_if\" instead .","commit_id":"85df04f7e5625ec0820990d37cda4d7168eecd19"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"edc1b7efd36e03bc1630f1e1769de6c597b1b265","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  vmware_server_password \u003d get_password \u0027token\u0027, node[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027vmware\u0027][\u0027secret_name\u0027]"},{"line_number":160,"context_line":"end"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"if glance[\u0027filesystem_store_metadata_file\u0027]"},{"line_number":163,"context_line":"  unless ::File.exist?(glance[\u0027filesystem_store_metadata_file\u0027])"},{"line_number":164,"context_line":"    template glance[\u0027filesystem_store_metadata_file\u0027] do"},{"line_number":165,"context_line":"      source \u0027glance-metadata.json.erb\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_782b3cec","line":162,"in_reply_to":"9a41bdd9_baf9bc4f","updated":"2015-07-13 05:24:00.000000000","message":"We can\u0027t change this line to use \"only_if\" here , because if we do it , the line 164 will use \"glance[filesystem_store_metadata_file]\" firstly, and this value is \"nil\" by default , so ArgumentError should be occurred: \n\nArgumentError\n-------------\nYou must supply a name when declaring a template resource\n\n\n\nBut, I think  we can change line 163 to :\n\nnot if { ::File.exist?(glance[\u0027filesystem_store_metadata_file\u0027]) }\n\n\nWill do it in the next patch.","commit_id":"85df04f7e5625ec0820990d37cda4d7168eecd19"}],"spec/api_spec.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"e851082d27d6c8d91a662afd4d64c22f919676ba","unresolved":false,"context_lines":[{"line_number":627,"context_line":""},{"line_number":628,"context_line":"      context \u0027template contents\u0027 do"},{"line_number":629,"context_line":"        before do"},{"line_number":630,"context_line":"          node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_file\u0027] \u003d \u0027/etc/glance/glance-metadata.json\u0027"},{"line_number":631,"context_line":"        end"},{"line_number":632,"context_line":"        it \u0027configure id for image filesystem metadata\u0027 do"},{"line_number":633,"context_line":"          node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_id\u0027] \u003d \u002755acb157-d9de-4422-80b0-120b95dd4cd6\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba3cc151_ba0fa138","line":630,"updated":"2015-07-10 03:31:50.000000000","message":"there is a repeated node.set with  line#620, I think we can merge them to one.","commit_id":"ba81f0d1c32c65c0ea419517ee5311cb91a3ff1f"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"3b59e94751aa142c3f318b0ea83b9bf6a4703538","unresolved":false,"context_lines":[{"line_number":627,"context_line":""},{"line_number":628,"context_line":"      context \u0027template contents\u0027 do"},{"line_number":629,"context_line":"        before do"},{"line_number":630,"context_line":"          node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_file\u0027] \u003d \u0027/etc/glance/glance-metadata.json\u0027"},{"line_number":631,"context_line":"        end"},{"line_number":632,"context_line":"        it \u0027configure id for image filesystem metadata\u0027 do"},{"line_number":633,"context_line":"          node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_id\u0027] \u003d \u002755acb157-d9de-4422-80b0-120b95dd4cd6\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba3cc151_75ccca8a","line":630,"in_reply_to":"ba3cc151_ba0fa138","updated":"2015-07-10 03:46:26.000000000","message":"Done","commit_id":"ba81f0d1c32c65c0ea419517ee5311cb91a3ff1f"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"e851082d27d6c8d91a662afd4d64c22f919676ba","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        it \u0027configure id for image filesystem metadata\u0027 do"},{"line_number":633,"context_line":"          node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_id\u0027] \u003d \u002755acb157-d9de-4422-80b0-120b95dd4cd6\u0027"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"          line \u003d \u0027\"id\": \"55acb157-d9de-4422-80b0-120b95dd4cd6\"\u0027"},{"line_number":636,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/#{line}/)"},{"line_number":637,"context_line":"        end"},{"line_number":638,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba3cc151_351ba275","line":635,"updated":"2015-07-10 03:31:50.000000000","message":"for line635 and 641,  you can use a \"each\" method to be simple","commit_id":"ba81f0d1c32c65c0ea419517ee5311cb91a3ff1f"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"3b59e94751aa142c3f318b0ea83b9bf6a4703538","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        it \u0027configure id for image filesystem metadata\u0027 do"},{"line_number":633,"context_line":"          node.set[\u0027openstack\u0027][\u0027image\u0027][\u0027filesystem_store_metadata_id\u0027] \u003d \u002755acb157-d9de-4422-80b0-120b95dd4cd6\u0027"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"          line \u003d \u0027\"id\": \"55acb157-d9de-4422-80b0-120b95dd4cd6\"\u0027"},{"line_number":636,"context_line":"          expect(chef_run).to render_file(file.name).with_content(/#{line}/)"},{"line_number":637,"context_line":"        end"},{"line_number":638,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba3cc151_95c94e7c","line":635,"in_reply_to":"ba3cc151_351ba275","updated":"2015-07-10 03:46:26.000000000","message":"Done","commit_id":"ba81f0d1c32c65c0ea419517ee5311cb91a3ff1f"}]}