)]}'
{"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d555645d1972b5b95c7f612c0a1b0ee2cb7fc822","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# RPC attributes"},{"line_number":58,"context_line":"# The AMQP exchange to connect to if using RabbitMQ or Qpid"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"case node[\u0027openstack\u0027][\u0027mq\u0027][\u0027service_type\u0027]"},{"line_number":61,"context_line":"when \u0027rabbitmq\u0027"},{"line_number":62,"context_line":"  default[\u0027openstack\u0027][\u0027image\u0027][\u0027rpc_backend\u0027] \u003d \u0027rabbit\u0027"},{"line_number":63,"context_line":"when \u0027qpid\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"fa69d971_d6ff5aa8","line":60,"updated":"2016-01-04 19:13:05.000000000","message":"Seems like this logic is \"common\" and should be moved into the common attributes or into a common template for mq stuff.  something for todo list.","commit_id":"61336be934d561fa953c3cffd054602bafa1af28"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"dddb2a259a574b40829eecafa9939e109a0fba14","unresolved":false,"context_lines":[{"line_number":52,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027rabbit_server_chef_role\u0027] \u003d \u0027os-ops-messaging\u0027"},{"line_number":53,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027service_tenant_name\u0027] \u003d \u0027service\u0027"},{"line_number":54,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027service_user\u0027] \u003d \u0027glance\u0027"},{"line_number":55,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027service_role\u0027] \u003d \u0027admin\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Supported values for the \u0027container_format\u0027 image attribute"},{"line_number":58,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027container_formats\u0027] \u003d %w(ami ari aki bare ovf ova docker dockerref)"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"5a5ae5dd_488e3b7a","line":55,"updated":"2016-02-05 17:25:36.000000000","message":"humm, why did this change?   has a matching change in identity recipe then?   or in a policy file somewhere?","commit_id":"d8252e3b566dd3471b98733ad33e0f4900c85b1b"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"f7839203d24a2da99e9b848aa02fc2f5253762f3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027rabbit_server_chef_role\u0027] \u003d \u0027os-ops-messaging\u0027"},{"line_number":53,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027service_tenant_name\u0027] \u003d \u0027service\u0027"},{"line_number":54,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027service_user\u0027] \u003d \u0027glance\u0027"},{"line_number":55,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027service_role\u0027] \u003d \u0027admin\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Supported values for the \u0027container_format\u0027 image attribute"},{"line_number":58,"context_line":"default[\u0027openstack\u0027][\u0027image\u0027][\u0027api\u0027][\u0027container_formats\u0027] \u003d %w(ami ari aki bare ovf ova docker dockerref)"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"5a5ae5dd_70a162f7","line":55,"in_reply_to":"5a5ae5dd_488e3b7a","updated":"2016-02-08 14:11:38.000000000","message":"Not sure why it was \u0027service\u0027 before, while it was \u0027admin\u0027 for some other services. I think we should set all the openstack services roles to service, but i am not sure if this would work out of the box without changes to the policy files. For now i would like to stick with admin, since this should work for all services.","commit_id":"d8252e3b566dd3471b98733ad33e0f4900c85b1b"}],"attributes/glance_api_conf.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d555645d1972b5b95c7f612c0a1b0ee2cb7fc822","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  # [oslo_messaging_rabbit] section # needs further discussion"},{"line_number":55,"context_line":"  if node[\u0027openstack\u0027][\u0027image\u0027][\u0027notification_driver\u0027] \u003d\u003d \u0027messaging\u0027 \u0026\u0026"},{"line_number":56,"context_line":"     (node[\u0027openstack\u0027][\u0027mq\u0027][\u0027image\u0027][\u0027service_type\u0027] \u003d\u003d \u0027rabbitmq\u0027 ||"},{"line_number":57,"context_line":"       node[\u0027openstack\u0027][\u0027mq\u0027][\u0027image\u0027][\u0027service_type\u0027] \u003d\u003d \u0027rabbit\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    conf[\u0027oslo_messaging_rabbit\u0027][\u0027heartbeat_timeout_threshold\u0027] \u003d node[\u0027openstack\u0027][\u0027mq\u0027][\u0027image\u0027][\u0027rabbit\u0027][\u0027heartbeat_timeout_threshold\u0027]"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"fa69d971_f6961e4b","line":56,"updated":"2016-01-04 19:13:05.000000000","message":"yup needs further discussion, this is ugly check. should be able to refactor this into a mq helper template, just pass in the cookbook name.","commit_id":"61336be934d561fa953c3cffd054602bafa1af28"}],"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"dddb2a259a574b40829eecafa9939e109a0fba14","unresolved":false,"context_lines":[{"line_number":11,"context_line":"recipe \u0027openstack-image::identity_registration\u0027, \u0027Registers Glance endpoints and service with Keystone\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-image::image_upload\u0027, \u0027Upload image using glance image-create command\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"%w(ubuntu fedora redhat centos).each do |os|"},{"line_number":15,"context_line":"  supports os"},{"line_number":16,"context_line":"end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":14,"id":"5a5ae5dd_a8dc8f73","line":14,"updated":"2016-02-05 17:25:36.000000000","message":"make consistent with Common, remove fedora","commit_id":"d8252e3b566dd3471b98733ad33e0f4900c85b1b"},{"author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"change_message_id":"975682410af4dc6ee89e510442cf0444b521b25c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"recipe \u0027openstack-image::identity_registration\u0027, \u0027Registers Glance endpoints and service with Keystone\u0027"},{"line_number":12,"context_line":"recipe \u0027openstack-image::image_upload\u0027, \u0027Upload image using glance image-create command\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"%w(ubuntu fedora redhat centos).each do |os|"},{"line_number":15,"context_line":"  supports os"},{"line_number":16,"context_line":"end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":14,"id":"5a5ae5dd_4d6db6ca","line":14,"in_reply_to":"5a5ae5dd_a8dc8f73","updated":"2016-02-08 14:07:13.000000000","message":"Done","commit_id":"d8252e3b566dd3471b98733ad33e0f4900c85b1b"}],"recipes/api.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d555645d1972b5b95c7f612c0a1b0ee2cb7fc822","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":22,"context_line":"# limitations under the License."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"chef_gem \u0027activesupport\u0027 do"},{"line_number":25,"context_line":"  action :upgrade"},{"line_number":26,"context_line":"  version \u00274.2.4\u0027"},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"fa69d971_5687ead6","line":24,"updated":"2016-01-04 19:13:05.000000000","message":"This seems dangerous to include in invdividual recipes, should be pushed up into common somehow, and also that way the version can be handled more cleanly for when it needs to change.","commit_id":"61336be934d561fa953c3cffd054602bafa1af28"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"c87d1061c3e0efe1f94f99a31a0dc724988318d6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":22,"context_line":"# limitations under the License."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"chef_gem \u0027activesupport\u0027 do"},{"line_number":25,"context_line":"  action :upgrade"},{"line_number":26,"context_line":"  version \u00274.2.4\u0027"},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa69d971_49fe7639","line":24,"updated":"2016-01-08 16:21:45.000000000","message":"This should really be treated as a bug, and will be fixed when Chef gets to that version.   Please open a bug to track and doc that here.  I still think this type of workaround should be pushed up into Common Openstack library which is included below.","commit_id":"a89c7297e8553e40cbc2ab3edb8443b8ddde3e5b"}],"templates/default/glance-api.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d555645d1972b5b95c7f612c0a1b0ee2cb7fc822","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003c%\u003d \"# #{value[\u0027comment\u0027]}\" -%\u003e"},{"line_number":7,"context_line":"\u003c%\u003d key %\u003e \u003d \u003c%\u003d value[\u0027set_to\u0027] %\u003e"},{"line_number":8,"context_line":"  \u003c% else -%\u003e"},{"line_number":9,"context_line":"\u003c%\u003d key %\u003e \u003d \u003c%\u003d value %\u003e"},{"line_number":10,"context_line":"  \u003c% end -%\u003e"},{"line_number":11,"context_line":"\u003c% end -%\u003e"},{"line_number":12,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"fa69d971_a6ae3183","line":9,"updated":"2016-01-04 19:13:05.000000000","message":"missing 3 ends here","commit_id":"61336be934d561fa953c3cffd054602bafa1af28"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"82e8cbb0e736a9a3a3bd7110bec6f484fdd9e74d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003c%\u003d \"# #{value[\u0027comment\u0027]}\" -%\u003e"},{"line_number":7,"context_line":"\u003c%\u003d key %\u003e \u003d \u003c%\u003d value[\u0027set_to\u0027] %\u003e"},{"line_number":8,"context_line":"  \u003c% else -%\u003e"},{"line_number":9,"context_line":"\u003c%\u003d key %\u003e \u003d \u003c%\u003d value %\u003e"},{"line_number":10,"context_line":"  \u003c% end -%\u003e"},{"line_number":11,"context_line":"\u003c% end -%\u003e"},{"line_number":12,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"fa69d971_2d453c16","line":9,"in_reply_to":"fa69d971_a6ae3183","updated":"2016-01-04 20:51:49.000000000","message":"Done","commit_id":"61336be934d561fa953c3cffd054602bafa1af28"}],"templates/default/glance-registry.conf.erb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d555645d1972b5b95c7f612c0a1b0ee2cb7fc822","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u003c%\u003d key %\u003e \u003d \u003c%\u003d value[\u0027set_to\u0027] %\u003e"},{"line_number":8,"context_line":"  \u003c% else -%\u003e"},{"line_number":9,"context_line":"\u003c%\u003d key %\u003e \u003d \u003c%\u003d value %\u003e"},{"line_number":10,"context_line":"  \u003c% end -%\u003e"},{"line_number":11,"context_line":"\u003c% end -%\u003e"},{"line_number":12,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"fa69d971_66b7d9d8","line":10,"updated":"2016-01-04 19:13:05.000000000","message":"missing 2 ends ?","commit_id":"61336be934d561fa953c3cffd054602bafa1af28"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"82e8cbb0e736a9a3a3bd7110bec6f484fdd9e74d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u003c%\u003d key %\u003e \u003d \u003c%\u003d value[\u0027set_to\u0027] %\u003e"},{"line_number":8,"context_line":"  \u003c% else -%\u003e"},{"line_number":9,"context_line":"\u003c%\u003d key %\u003e \u003d \u003c%\u003d value %\u003e"},{"line_number":10,"context_line":"  \u003c% end -%\u003e"},{"line_number":11,"context_line":"\u003c% end -%\u003e"},{"line_number":12,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":7,"id":"fa69d971_8d56a8d0","line":10,"in_reply_to":"fa69d971_66b7d9d8","updated":"2016-01-04 20:51:49.000000000","message":"Done","commit_id":"61336be934d561fa953c3cffd054602bafa1af28"}]}