)]}'
{"id":"openstack%2Fcookbook-openstack-image~659263","triplet_id":"openstack%2Fcookbook-openstack-image~master~Ie9d3a5eca7868d1cb79767fa3295af6d4c11fa84","project":"openstack/cookbook-openstack-image","branch":"master","topic":"fix-service-user-usage","hashtags":[],"change_id":"Ie9d3a5eca7868d1cb79767fa3295af6d4c11fa84","subject":"Fix user used to upload images","status":"ABANDONED","created":"2019-05-15 10:26:59.000000000","updated":"2020-09-22 17:44:43.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b2e4938abf3da10bac95b2796a77ec07a013320a","_number":659263,"virtual_id_number":659263,"owner":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-05-15 17:24:16.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-16 13:49:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"value":-1,"date":"2019-05-16 10:15:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"value":-1,"date":"2019-05-16 10:15:39.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-15 17:24:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-16 13:49:52.000000000","updated_by":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"reviewer":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"state":"REVIEWER"}],"messages":[{"id":"5691f65f14ca7297632b69a67f866e2cafd18628","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-05-15 10:26:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"70dae7a32949c0c4053a1b45b61b1548b6006a96","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 11:15:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-chef-delivery http://logs.openstack.org/63/659263/1/check/openstack-chef-delivery/b3be330/ : FAILURE in 3m 27s\n- openstack-chef-integration http://logs.openstack.org/63/659263/1/check/openstack-chef-integration/252b0d9/ : SUCCESS in 47m 45s","accounts_in_message":[],"_revision_number":1},{"id":"76e38d9bdbd73a9ecf7008e7606c0bad5467efcc","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-05-15 16:39:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"35a52e52255ee747771cd8e313a4153a0dddc723","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 17:24:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery http://logs.openstack.org/63/659263/2/check/openstack-chef-delivery/2d0b3ca/ : SUCCESS in 3m 19s\n- openstack-chef-integration http://logs.openstack.org/63/659263/2/check/openstack-chef-integration/2780f01/ : SUCCESS in 42m 55s","accounts_in_message":[],"_revision_number":2},{"id":"5dd3d016c7c00c87f248c7cac46b2378addca24f","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-05-15 20:57:44.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f93ce3bb1b63b681e95e8aedf71bdc03e16a393f","author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"date":"2019-05-16 08:32:45.000000000","message":"Patch Set 2: Code-Review-2\n\nI think we should not upload any images with the glance service user (this user should not own anything, expect stuff directly related to the service). I agree that uploading as the admin user might not be idea here, maybe we can change the user to be configurable.","accounts_in_message":[],"_revision_number":2},{"id":"d3a1659f99671d5a6879b874372078e7834fc689","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-05-16 10:15:39.000000000","message":"Patch Set 2: Code-Review-1 Workflow-1\n\n\u003e I think we should not upload any images with the glance service\n \u003e user (this user should not own anything, expect stuff directly\n \u003e related to the service). I agree that uploading as the admin user\n \u003e might not be idea here, maybe we can change the user to be\n \u003e configurable.\n\nNow I get the idea behind the admin user choice, sure that seems reasonable. However, using `node[\u0027openstack\u0027][\u0027image_api\u0027][\u0027conf\u0027][\u0027keystone_authtoken\u0027]` namespace to get:\n\n  - project_name\n  - project_domain_name\n  - user_domain_name\n\nis misleading, as we are mixing up admin user properties with glance service user properties.\n\nI\u0027ll submit a patch with suggestions to tackle this.","accounts_in_message":[],"_revision_number":2},{"id":"216331c63eae5ecd3e7ac211ef23aee76f7fd997","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-05-16 10:49:15.000000000","message":"Patch Set 2:\n\n\u003e \u003e I think we should not upload any images with the glance service\n \u003e \u003e user (this user should not own anything, expect stuff directly\n \u003e \u003e related to the service). I agree that uploading as the admin user\n \u003e \u003e might not be idea here, maybe we can change the user to be\n \u003e \u003e configurable.\n \u003e \n \u003e Now I get the idea behind the admin user choice, sure that seems\n \u003e reasonable. However, using `node[\u0027openstack\u0027][\u0027image_api\u0027][\u0027conf\u0027][\u0027keystone_authtoken\u0027]`\n \u003e namespace to get:\n \u003e \n \u003e - project_name\n \u003e - project_domain_name\n \u003e - user_domain_name\n \u003e \n \u003e is misleading, as we are mixing up admin user properties with\n \u003e glance service user properties.\n \u003e \n \u003e I\u0027ll submit a patch with suggestions to tackle this.\n\nBtw, I\u0027ve dug through the cookbooks for the other services and noticed that glance is the only service which in its `keystone_authtoken` configuration section the project_name is `admin`.\n\nDoes this make sense? Shouldn\u0027t it be `service`?","accounts_in_message":[],"_revision_number":2},{"id":"60bf3a05f6dd226577909e926635c620886e7a4c","author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"date":"2019-05-16 11:39:12.000000000","message":"Patch Set 2: -Code-Review\n\nI am not 100% sure why we kept the admin auth here when we changed it in the other cookbooks, but iirc there was some reason and it was not just forgotten. I guess the easiest way to find out is to align it with the other cookbooks and see if everything still works :)","accounts_in_message":[],"_revision_number":2},{"id":"4e7ece126c0bb2ebba9ffff6fd78cd59ff66df12","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-05-16 13:01:30.000000000","message":"Patch Set 2:\n\n\u003e I am not 100% sure why we kept the admin auth here when we changed\n \u003e it in the other cookbooks, but iirc there was some reason and it\n \u003e was not just forgotten. I guess the easiest way to find out is to\n \u003e align it with the other cookbooks and see if everything still works\n \u003e :)\n\nGood point eheh\n\nFrom what I can see, from one of our Openstack deployments, there is no problem with the glance_api service using `service` as its `project_name`. I just want to be sure that conceptually this makes sense.\n\nIf it does, would you rather have me abandon this patch and make a suggestion for the user be configurable in a new one?","accounts_in_message":[],"_revision_number":2},{"id":"6055456faaeeaeaeb5a575b8223f1204d6958e8f","author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"date":"2019-05-16 13:49:52.000000000","message":"Patch Set 2:\n\nI think having a configurable user for uploading images would be useful. I am not sure thou if we actually want to implement the needed logic in this cookbook or rather have people add the needed resources/logic to their own wrapper cookbooks. I think a good first step for making image upload easier (and configurable), would be to add a lwrp for this task here https://github.com/openstack/cookbook-openstackclient.","accounts_in_message":[],"_revision_number":2},{"id":"d2d25f1538c614d8559106395efb5fc9234057c0","author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"date":"2020-09-22 17:44:43.000000000","message":"Abandoned\n\nNo update in 1.5+ years.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e97f93fa184d6c18a2b5b1e205c92b71f7f3b0c0","revisions":{"1eddba4e7a33fa104ec2b6a79092616285a621cc":{"kind":"REWORK","_number":1,"created":"2019-05-15 10:26:59.000000000","uploader":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"ref":"refs/changes/63/659263/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-image","ref":"refs/changes/63/659263/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-image refs/changes/63/659263/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-image refs/changes/63/659263/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-image refs/changes/63/659263/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-image refs/changes/63/659263/1"}}},"commit":{"parents":[{"commit":"b5e593d9b1902b7356eae50d14eaf0234e36d05d","subject":"Merge \"Drop admin endpoints and cache dirs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-image/commit/b5e593d9b1902b7356eae50d14eaf0234e36d05d"}]}],"author":{"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","date":"2019-05-15 10:19:24.000000000","tz":60},"committer":{"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","date":"2019-05-15 10:19:24.000000000","tz":60},"subject":"Fix user used to upload images","message":"Fix user used to upload images\n\nChange-Id: Ie9d3a5eca7868d1cb79767fa3295af6d4c11fa84\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-image/commit/1eddba4e7a33fa104ec2b6a79092616285a621cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-image/commit/1eddba4e7a33fa104ec2b6a79092616285a621cc"}]},"branch":"refs/heads/master"},"e97f93fa184d6c18a2b5b1e205c92b71f7f3b0c0":{"kind":"REWORK","_number":2,"created":"2019-05-15 16:39:55.000000000","uploader":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"ref":"refs/changes/63/659263/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-image","ref":"refs/changes/63/659263/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-image refs/changes/63/659263/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-image refs/changes/63/659263/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-image refs/changes/63/659263/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-image refs/changes/63/659263/2"}}},"commit":{"parents":[{"commit":"b5e593d9b1902b7356eae50d14eaf0234e36d05d","subject":"Merge \"Drop admin endpoints and cache dirs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-image/commit/b5e593d9b1902b7356eae50d14eaf0234e36d05d"}]}],"author":{"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","date":"2019-05-15 10:19:24.000000000","tz":60},"committer":{"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","date":"2019-05-15 16:39:42.000000000","tz":60},"subject":"Fix user used to upload images","message":"Fix user used to upload images\n\nChange-Id: Ie9d3a5eca7868d1cb79767fa3295af6d4c11fa84\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-image/commit/e97f93fa184d6c18a2b5b1e205c92b71f7f3b0c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-image/commit/e97f93fa184d6c18a2b5b1e205c92b71f7f3b0c0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}