)]}'
{"id":"openstack%2Fcookbook-openstack-integration-test~519372","triplet_id":"openstack%2Fcookbook-openstack-integration-test~master~I92b47cd0156e4146a40ca7be89c102a625b5bdf6","project":"openstack/cookbook-openstack-integration-test","branch":"master","topic":"fix_domain_handling_02","hashtags":[],"change_id":"I92b47cd0156e4146a40ca7be89c102a625b5bdf6","subject":"Remove superfluous role_name arguments","status":"MERGED","created":"2017-11-13 14:51:35.000000000","updated":"2017-11-17 20:11:00.000000000","submitted":"2017-11-17 20:11:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"519372-1510949460241-271f2d14","meta_rev_id":"be8dc98458824fd64a6c1136abb3329b4cfad3fc","_number":519372,"virtual_id_number":519372,"owner":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2017-11-17 20:11:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2017-11-17 09:30:23.000000000","_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":2,"date":"2017-11-17 19:41:21.000000000","_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":1,"date":"2017-11-17 19:41:21.000000000","_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-17 09:30:23.000000000","updated_by":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"reviewer":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"state":"REVIEWER"},{"updated":"2017-11-17 19:41:21.000000000","updated_by":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"reviewer":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"state":"REVIEWER"},{"updated":"2017-11-17 20:11:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9098e1bfe8c27b9989d20c44241f1363f6ea035e","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2017-11-13 14:51:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"18f0d6d1ea97096532fe0dd83e8b4e2ad06a6667","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-13 15:26:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-repo-rake http://logs.openstack.org/72/519372/1/check/openstack-chef-repo-rake/9ce1354/ : SUCCESS in 4m 24s\n- openstack-chef-repo-integration http://logs.openstack.org/72/519372/1/check/openstack-chef-repo-integration/91d9462/ : SUCCESS in 32m 05s","accounts_in_message":[],"_revision_number":1},{"id":"6be81e0b3d29444cba046c4811d4891b6210482a","author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"date":"2017-11-17 09:30:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ffdde44afee6a90aa9733ed662ad52cf865ff973","author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"date":"2017-11-17 19:41:21.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3002762e3ede2bc5f1ce1dd07b3302eef14526da","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-17 19:41:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"aef745ea92e1e5b35a6253efbca49e8bfe9c4671","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-17 20:11:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"8c89e5076f0d89369f7259286f8d54ca44cc8d22","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-17 20:11:00.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-repo-rake http://logs.openstack.org/72/519372/1/gate/openstack-chef-repo-rake/cffd8fd/ : SUCCESS in 5m 07s\n- openstack-chef-repo-integration http://logs.openstack.org/72/519372/1/gate/openstack-chef-repo-integration/af3d145/ : SUCCESS in 28m 01s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9bd4339b3b59b29dd532ef98830178320ecd6742","revisions":{"9bd4339b3b59b29dd532ef98830178320ecd6742":{"kind":"REWORK","_number":1,"created":"2017-11-13 14:51:35.000000000","uploader":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"ref":"refs/changes/72/519372/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-integration-test","ref":"refs/changes/72/519372/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-integration-test refs/changes/72/519372/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-integration-test refs/changes/72/519372/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-integration-test refs/changes/72/519372/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-integration-test refs/changes/72/519372/1"}}},"commit":{"parents":[{"commit":"4cf5c849b25018431a70d1a970037d44c63ec2f2","subject":"Add native zuul v3 jobs defined in openstack-chef-repo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-integration-test/commit/4cf5c849b25018431a70d1a970037d44c63ec2f2"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2017-11-13 09:39:19.000000000","tz":60},"committer":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2017-11-13 09:39:19.000000000","tz":60},"subject":"Remove superfluous role_name arguments","message":"Remove superfluous role_name arguments\n\nThis patch removes the role_name when using openstack_user\u0027s :create\naction (it gets ignored by the target method).\n\nNote that the spec test would still pass if only the line in\nidentity_registration.rb (but not the test) were changed, because the\ncode that actually does grant the role to the resource is executed right\nafter user creation and before any tests check the resource for the\nexistence of the role_name attribute. In other words: if the argument\nwere required in a call but only supplied in another call, the spec\ntests would not catch it. Something to watch out for.\n\nChange-Id: I92b47cd0156e4146a40ca7be89c102a625b5bdf6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-integration-test/commit/9bd4339b3b59b29dd532ef98830178320ecd6742"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-integration-test/commit/9bd4339b3b59b29dd532ef98830178320ecd6742"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4cf5c849b25018431a70d1a970037d44c63ec2f2","is_merged_in_target_branch":true,"change_id":"I320a65d20dbae5db701f164188871fa3dae93a5f","change_number":517253,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}